57179 2011-03-27 06:55:35 -0700 [Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED www.blognone.com P2 Normal --- 56130 1 robert robert ademar commit-queue kling oldest_to_newest 374118 0 robert 2011-03-27 06:55:35 -0700 [Qt] Invalidate relative and absolute co-ords in PluginView 374613 1 robert 2011-03-28 11:00:28 -0700 http://trac.webkit.org/changeset/79397 374622 2 robert 2011-03-28 11:10:06 -0700 http://trac.webkit.org/changeset/79397 uses frameView->invalidateRect(m_windowRect); to dirty the appropriate region on the screen, so that QWebFrame::renderRelativeCoords() will repaint the correct location of the plugin. This works well except when the plugin is contained in an iframe, such as at www.blognone.com. In that situation, invalidating the location of the plugin has no effect - putting some debug statements in renderRelativeCoords() shows that the plugin's rect does not even show up in the list of dirty rects in 'clip'. The result is that the plugin does not move when you scroll the page, except when the area it is contained in is about to get clipped by the viewport. The simple solution is to just reinstate invalidate() so that we call that in addition to frameView->invalidateRect(m_windowRect);. 374666 3 87178 robert 2011-03-28 12:15:11 -0700 Created attachment 87178 Patch 374672 4 robert 2011-03-28 12:24:43 -0700 The iframe plugin in blognone.com is: <iframe id='a400cc05' name='a400cc05' src='http://solid.lightdynamic.com/www/delivery/afr.php?zoneid=16&amp;cb=INSERT_RANDOM_NUMBER_HERE' frameborder='0' scrolling='no' width='300' height='250'><a href='http://solid.lightdynamic.com/www/delivery/ck.phpn=af511631&amp;cb=INSERT_RANDOM_NUMBER_HERE' target='_blank'><img src='http://solid.lightdynamic.com/www/delivery/avw.php?zoneid=16&amp;cb=INSERT_RANDOM_NUMBER_HERE&amp;n=af511631' border='0' alt='' /></a></iframe> 374684 5 87181 robert 2011-03-28 12:41:26 -0700 Created attachment 87181 Patch 375679 6 87397 robert 2011-03-29 12:51:59 -0700 Created attachment 87397 Patch 375681 7 robert 2011-03-29 12:53:47 -0700 OK, all my analysis up to now was wrong: the issue r79397 was trying to solve is properly solved by the new patch. PluginViewQt was getting the plugin widget repainted before it had updated the widget's knowledge of its position on the page. As a result, QWebView got a paint event from the widget with the wrong rects for painting. 382381 8 87397 kling 2011-04-08 10:54:31 -0700 Comment on attachment 87397 Patch This might be the most sane-looking Qt plugin patch I've seen. r=me :) 385014 9 ademar 2011-04-13 11:05:05 -0700 Blocking 2.2 (bug 56130, which fixes the problem on symbian has been added to 2.1.x, so it makes sense to fix the problem on all platforms on 2.2). 387891 10 87397 commit-queue 2011-04-18 11:29:25 -0700 Comment on attachment 87397 Patch Rejecting attachment 87397 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8469040 388060 11 87397 commit-queue 2011-04-18 14:48:59 -0700 Comment on attachment 87397 Patch Clearing flags on attachment: 87397 Committed r84187: <http://trac.webkit.org/changeset/84187> 388061 12 commit-queue 2011-04-18 14:49:05 -0700 All reviewed patches have been landed. Closing bug. 87178 2011-03-28 12:15:11 -0700 2011-03-28 12:41:21 -0700 Patch bug-57179-20110328201508.patch text/plain 3168 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODIwNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYjZmZWYzZWYzMzg3NTIz MzE1YWMxNDU3NWNiNGU4NjM2ZTJhNmY3Li4yZjEyNDk2MmJlMWYwOTU2MjVmNGI4M2RlN2VjMTBi Y2I1ZmVhNmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDMtMjggIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gcjc5Mzk3IGJyZWFrcyByZW5kZXJpbmcgb2Ygd2lu ZG93ZWQgcGx1Z2lucyBpbiBpZnJhbWVzCisKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvNzkzOTcgdXNlcyBmcmFtZVZpZXctPmludmFsaWRhdGVSZWN0KG1fd2luZG93 UmVjdCkgCisgICAgICAgIHRvIGRpcnR5IHRoZSBhcHByb3ByaWF0ZSByZWdpb24gb24gdGhlIHNj cmVlbiwgc28gdGhhdCBRV2ViRnJhbWU6OnJlbmRlclJlbGF0aXZlQ29vcmRzKCkgCisgICAgICAg IHdpbGwgcmVwYWludCB0aGUgY29ycmVjdCBsb2NhdGlvbiBvZiB0aGUgcGx1Z2luLgorCisgICAg ICAgIFRoaXMgd29ya3Mgd2VsbCBleGNlcHQgd2hlbiB0aGUgcGx1Z2luIGlzIGNvbnRhaW5lZCBp biBhbiBpZnJhbWUsIHN1Y2ggYXMgYXQgd3d3LmJsb2dub25lLmNvbS4gCisgICAgICAgIEluIHRo YXQgc2l0dWF0aW9uLCBpbnZhbGlkYXRpbmcgdGhlIGxvY2F0aW9uIG9mIHRoZSBwbHVnaW4gaGFz IG5vIGVmZmVjdCAtIHB1dHRpbmcgc29tZSBkZWJ1ZyAKKyAgICAgICAgc3RhdGVtZW50cyBpbiBy ZW5kZXJSZWxhdGl2ZUNvb3JkcygpIHNob3dzIHRoYXQgdGhlIHBsdWdpbidzIHJlY3QgZG9lcyBu b3QgZXZlbiBzaG93IHVwIGluIAorICAgICAgICB0aGUgbGlzdCBvZiBkaXJ0eSByZWN0cyBpbiAn Y2xpcCcuIFRoZSByZXN1bHQgaXMgdGhhdCB0aGUgcGx1Z2luIGRvZXMgbm90IG1vdmUgd2hlbiB5 b3Ugc2Nyb2xsIAorICAgICAgICB0aGUgcGFnZSwgZXhjZXB0IHdoZW4gdGhlIGFyZWEgaXQgaXMg Y29udGFpbmVkIGluIGlzIGFib3V0IHRvIGdldCBjbGlwcGVkIGJ5IHRoZSB2aWV3cG9ydC4KKwor ICAgICAgICBUaGUgc2ltcGxlIHNvbHV0aW9uIGlzIHRvIGp1c3QgcmVpbnN0YXRlIGludmFsaWRh dGUoKSBzbyB0aGF0IHdlIGNhbGwgdGhhdCBpbiBhZGRpdGlvbiAKKyAgICAgICAgdG8gZnJhbWVW aWV3LT5pbnZhbGlkYXRlUmVjdChtX3dpbmRvd1JlY3QpOy4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxNzkKKworICAgICAgICAqIHBsdWdpbnMv cXQvUGx1Z2luVmlld1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnVwZGF0 ZVBsdWdpbldpZGdldCk6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjppbnZhbGlkYXRl UmVjdCk6CisKIDIwMTEtMDMtMjcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4IDYyYzk4NTU5OTNlMTdlOWJmZDYwNTllNzUz NTk0YzZmZGI4YmRjMmQuLjYwOWExMjIxZTczOWJlZGJhNGY5Yjk3NjRhZmYxOGMzYzliMGM1ZWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKQEAgLTE3OSwx MSArMTc5LDcgQEAgdm9pZCBQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQoKQogICAgIGlm ICghbV9wbGF0Zm9ybUxheWVyKSB7CiAgICAgICAgIC8vIE1ha2Ugc3VyZSB3ZSBnZXQgcmVwYWlu dGVkIGFmdGVyd2FyZHMuIFRoaXMgaXMgbmVjZXNzYXJ5IGZvciBkb3dud2FyZAogICAgICAgICAv LyBzY3JvbGxpbmcgdG8gbW92ZSB0aGUgcGx1Z2luIHdpZGdldCBwcm9wZXJseS4KLSAgICAgICAg Ly8gTm90ZSB0aGF0IHdlIGRvbid0IGludmFsaWRhdGUgdGhlIGZyYW1lUmVjdCgpIGhlcmUuIFRo aXMgaXMgYmVjYXVzZSBRV2ViRnJhbWU6OnJlbmRlclJlbGF0aXZlQ29vcmRzKCkKLSAgICAgICAg Ly8gaW1pdGF0ZXMgU2Nyb2xsVmlldyBhbmQgYWRkcyB0aGUgc2Nyb2xsIG9mZnNldCBiYWNrIG9u IHRvIHRoZSByZWN0IHdlIGRhbWFnZSBoZXJlIChtYWtpbmcgdGhlIGNvLW9yZGluYXRlcyBhYnNv bHV0ZQotICAgICAgICAvLyB0byB0aGUgZnJhbWUgYWdhaW4pIGJlZm9yZSBwYXNzaW5nIGl0IHRv IEZyYW1lVmlldy4KICAgICAgICAgaW52YWxpZGF0ZSgpOwotICAgICAgICBmcmFtZVZpZXctPmlu dmFsaWRhdGVSZWN0KG1fd2luZG93UmVjdCk7CiAgICAgfQogfQogCkBAIC04MTMsNiArODA5LDEz IEBAIHZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkK ICNlbmRpZgogCiAgICAgaWYgKG1faXNXaW5kb3dlZCkgeworICAgICAgICAvLyBJbnZhbGlkYXRl IHRoZSBwb3NpdGlvbiBvZiB0aGUgcGx1Z2luIHdpdGhpbiB0aGUgZnJhbWV2aWV3CisgICAgICAg IC8vIHNvIHRoYXQgUVdlYkZyYW1lOjpyZW5kZXJSZWxhdGl2ZUNvb3JkcyB3aWxsIHJlY29nbml6 ZQorICAgICAgICAvLyB0aGUgcGx1Z2luJ3MgYXJlYSB3aXRoaW4gdGhlIGZyYW1lIGFzIGRpcnR5 CisgICAgICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4o cGFyZW50KCkpOworICAgICAgICBmcmFtZVZpZXctPmludmFsaWRhdGVSZWN0KG1fd2luZG93UmVj dCk7CisgICAgICAgIC8vIFdlIGFsc28gbmVlZCB0aGUgcGx1Z2luIHRvIGludmFsaWRhdGUgaXRz ZWxmIGluIGNhc2UgaXQgaXMKKyAgICAgICAgLy8gY29udGFpbmVkIGluIGFuIGlmcmFtZS4KICAg ICAgICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkpCiAgICAgICAgICAgICBwbGF0Zm9ybVdpZGdldCgp LT51cGRhdGUocmVjdCk7CiAgICAgICAgIHJldHVybjsK 87181 2011-03-28 12:41:26 -0700 2011-03-29 12:51:54 -0700 Patch bug-57179-20110328204123.patch text/plain 3373 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODIwNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYjZmZWYzZWYzMzg3NTIz MzE1YWMxNDU3NWNiNGU4NjM2ZTJhNmY3Li41M2I3MDRlNGEwZjllOWM4MmMzZjBmYWExODY3YWNj ZTVhOGE2YjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDMtMjggIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gcjc5Mzk3IGJyZWFrcyByZW5kZXJpbmcgb2Ygd2lu ZG93ZWQgcGx1Z2lucyBpbiBpZnJhbWVzCisKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvNzkzOTcgdXNlcyBmcmFtZVZpZXctPmludmFsaWRhdGVSZWN0KG1fd2luZG93 UmVjdCkgCisgICAgICAgIHRvIGRpcnR5IHRoZSBhcHByb3ByaWF0ZSByZWdpb24gb24gdGhlIHNj cmVlbiwgc28gdGhhdCBRV2ViRnJhbWU6OnJlbmRlclJlbGF0aXZlQ29vcmRzKCkgCisgICAgICAg IHdpbGwgcmVwYWludCB0aGUgY29ycmVjdCBsb2NhdGlvbiBvZiB0aGUgcGx1Z2luLgorCisgICAg ICAgIFRoaXMgd29ya3Mgd2VsbCBleGNlcHQgd2hlbiB0aGUgcGx1Z2luIGlzIGNvbnRhaW5lZCBp biBhbiBpZnJhbWUsIHN1Y2ggYXMgYXQgd3d3LmJsb2dub25lLmNvbS4gCisgICAgICAgIEluIHRo YXQgc2l0dWF0aW9uLCBpbnZhbGlkYXRpbmcgdGhlIGxvY2F0aW9uIG9mIHRoZSBwbHVnaW4gaGFz IG5vIGVmZmVjdCAtIHB1dHRpbmcgc29tZSBkZWJ1ZyAKKyAgICAgICAgc3RhdGVtZW50cyBpbiBy ZW5kZXJSZWxhdGl2ZUNvb3JkcygpIHNob3dzIHRoYXQgdGhlIHBsdWdpbidzIHJlY3QgZG9lcyBu b3QgZXZlbiBzaG93IHVwIGluIAorICAgICAgICB0aGUgbGlzdCBvZiBkaXJ0eSByZWN0cyBpbiAn Y2xpcCcuIFRoZSByZXN1bHQgaXMgdGhhdCB0aGUgcGx1Z2luIGRvZXMgbm90IG1vdmUgd2hlbiB5 b3Ugc2Nyb2xsIAorICAgICAgICB0aGUgcGFnZSwgZXhjZXB0IHdoZW4gdGhlIGFyZWEgaXQgaXMg Y29udGFpbmVkIGluIGlzIGFib3V0IHRvIGdldCBjbGlwcGVkIGJ5IHRoZSB2aWV3cG9ydC4KKwor ICAgICAgICBUaGUgc2ltcGxlIHNvbHV0aW9uIGlzIHRvIGludmFsaWRhdGUoKSB0aGUgcGx1Z2lu IHdoZW4gaXQgaXMgY29udGFpbmVkIGluIGFuIGlmcmFtZS4gCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MTc5CisKKyAgICAgICAgKiBwbHVnaW5z L3F0L1BsdWdpblZpZXdRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojp1cGRh dGVQbHVnaW5XaWRnZXQpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aW52YWxpZGF0 ZVJlY3QpOgorCiAyMDExLTAzLTI3ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCA2MmM5ODU1OTkzZTE3ZTliZmQ2MDU5ZTc1 MzU5NGM2ZmRiOGJkYzJkLi5jM2U2Mzc1MWQ3ZTQ1MWE0YWU2YTIzNzI3MzU3MzhjNzdjMWIwMDFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC0xNzks MTEgKzE3OSw3IEBAIHZvaWQgUGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0KCkKICAgICBp ZiAoIW1fcGxhdGZvcm1MYXllcikgewogICAgICAgICAvLyBNYWtlIHN1cmUgd2UgZ2V0IHJlcGFp bnRlZCBhZnRlcndhcmRzLiBUaGlzIGlzIG5lY2Vzc2FyeSBmb3IgZG93bndhcmQKICAgICAgICAg Ly8gc2Nyb2xsaW5nIHRvIG1vdmUgdGhlIHBsdWdpbiB3aWRnZXQgcHJvcGVybHkuCi0gICAgICAg IC8vIE5vdGUgdGhhdCB3ZSBkb24ndCBpbnZhbGlkYXRlIHRoZSBmcmFtZVJlY3QoKSBoZXJlLiBU aGlzIGlzIGJlY2F1c2UgUVdlYkZyYW1lOjpyZW5kZXJSZWxhdGl2ZUNvb3JkcygpCi0gICAgICAg IC8vIGltaXRhdGVzIFNjcm9sbFZpZXcgYW5kIGFkZHMgdGhlIHNjcm9sbCBvZmZzZXQgYmFjayBv biB0byB0aGUgcmVjdCB3ZSBkYW1hZ2UgaGVyZSAobWFraW5nIHRoZSBjby1vcmRpbmF0ZXMgYWJz b2x1dGUKLSAgICAgICAgLy8gdG8gdGhlIGZyYW1lIGFnYWluKSBiZWZvcmUgcGFzc2luZyBpdCB0 byBGcmFtZVZpZXcuCiAgICAgICAgIGludmFsaWRhdGUoKTsKLSAgICAgICAgZnJhbWVWaWV3LT5p bnZhbGlkYXRlUmVjdChtX3dpbmRvd1JlY3QpOwogICAgIH0KIH0KIApAQCAtODEzLDcgKzgwOSwx NiBAQCB2b2lkIFBsdWdpblZpZXc6OmludmFsaWRhdGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3Qp CiAjZW5kaWYKIAogICAgIGlmIChtX2lzV2luZG93ZWQpIHsKLSAgICAgICAgaWYgKHBsYXRmb3Jt V2lkZ2V0KCkpCisgICAgICAgIC8vIEludmFsaWRhdGUgdGhlIHBvc2l0aW9uIG9mIHRoZSBwbHVn aW4gd2l0aGluIHRoZSBmcmFtZXZpZXcKKyAgICAgICAgLy8gc28gdGhhdCBRV2ViRnJhbWU6OnJl bmRlclJlbGF0aXZlQ29vcmRzIHdpbGwgcmVjb2duaXplCisgICAgICAgIC8vIHRoZSBwbHVnaW4n cyBhcmVhIHdpdGhpbiB0aGUgZnJhbWUgYXMgZGlydHkuCisgICAgICAgIEZyYW1lVmlldyogZnJh bWVWaWV3ID0gc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4ocGFyZW50KCkpOworICAgICAgICBmcmFt ZVZpZXctPmludmFsaWRhdGVSZWN0KG1fd2luZG93UmVjdCk7CisgICAgICAgIC8vIFdlIGFsc28g bmVlZCB0aGUgcGx1Z2luIHRvIGludmFsaWRhdGUgaXRzZWxmIGlmIGl0IGlzCisgICAgICAgIC8v IGNvbnRhaW5lZCBpbiBhbiBpZnJhbWUgKG90aGVyd2lzZSB0aGUgcGFyZW50IGZyYW1lVmlldwor ICAgICAgICAvLyB3b24ndCBrbm93IGl0J3MgZGlydHkpLgorICAgICAgICBFbGVtZW50KiBvd25l ckVsZW1lbnQgPSBmcmFtZVZpZXctPmZyYW1lKCkgPyBmcmFtZVZpZXctPmZyYW1lKCktPm93bmVy RWxlbWVudCgpIDogMDsKKyAgICAgICAgaWYgKG93bmVyRWxlbWVudCAmJiBvd25lckVsZW1lbnQt Pmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppZnJhbWVUYWcpICYmIHBsYXRmb3JtV2lkZ2V0KCkpCiAg ICAgICAgICAgICBwbGF0Zm9ybVdpZGdldCgpLT51cGRhdGUocmVjdCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9Cg== 87397 2011-03-29 12:51:59 -0700 2011-04-18 14:48:59 -0700 Patch bug-57179-20110329205157.patch text/plain 7465 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODIwNjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NDhhOTJjNDQwMDEzODlk NjY2MzU4ZmUyNmIyMTFiNGM5MTA3ZmZmLi4zNThkMDYzODc2NjRkYzdlNTgzNjdmZWRlMThkNGJm OGRhNGZjOWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMjkgIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUGx1Z2luVmlld1F0IG5lZWRzIHRvIHVwZGF0ZSBn ZW9tZXRyeSBvZiBwbHVnaW4gd2lkZ2V0IGJlZm9yZSBzY2hlZHVsaW5nIGEgcmVwYWludAorCisg ICAgICAgIFdoZW4gc2NoZWR1bGluZyBhIHJlcGFpbnQgZm9yIHRoZSBwbHVnaW4ncyB3aWRnZXQs IFBsdWdpblZpZXdRdAorICAgICAgICBuZWVkcyB0byBtYWtlIHN1cmUgdGhlIHdpZGdldCdzIGdl b21ldHJ5IGlzIHVwIHRvIGRhdGUuIE90aGVyd2lzZQorICAgICAgICB0aGUgcGFpbnQgZXZlbnQg aGFwcGVucyBvbiB0aGUgd2lkZ2V0J3Mgb2xkIGxvY2F0aW9uLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzE3OQorCisgICAgICAgIEFkZGVkIGEg bWFudWFsIHRlc3QuIAorCisgICAgICAgICogbWFudWFsLXRlc3RzL3F0L3BsdWdpbi1wYWludGlu Zy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQpOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QpOgorCiAyMDExLTAzLTI3ICBS b2IgQnVpcyAgPHJ3bGJ1aXNAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29s YXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9x dC9wbHVnaW4tcGFpbnRpbmcuaHRtbCBiL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9xdC9w bHVnaW4tcGFpbnRpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYWE4N2JjNmIwNWViZmFlMWYyOTQ0NDA0 OGY4NGM3MmMyNjU2MDU0Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvbWFudWFs LXRlc3RzL3F0L3BsdWdpbi1wYWludGluZy5odG1sCkBAIC0wLDAgKzEsNjAgQEAKKzxodG1sIHht bG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKworPGhlYWQ+Cis8bWV0YSBodHRw LWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCIg Lz4KKzx0aXRsZT5GbGFzaCBJbiBJRnJhbWUgVGVzdCBGaWxlPC90aXRsZT4KKzwvaGVhZD4KKwor PGJvZHk+CisKKyAgICA8Yj4gVGhpcyBtYW51YWwgdGVzdHMgdmVyaWZpZXMgcGFnaW5nIGFuZCBh cnJvdy1uYXZpZ2F0aW5nIHVwIGFuZCBkb3duIGEgcGFnZSBvZiBwbHVnaW5zIGRvZXNuJ3QgcmVz dWx0CisgICAgICAgIGluIHRoZW0gYXBwZWFyaW5nIHRvIGdldCBmdXNlZCB0b2dldGhlci4gUXRX ZWJLaXQgd2Fzbid0IHVwZGF0aW5nIHRoZSBwb3NpdGlvbiBvZiB0aGUgcGx1Z2lucworICAgICAg ICB3aXRoaW4gdGhlIHBhZ2UgYmVmb3JlIHNjaGVkdWxpbmcgdGhlbSBmb3IgYSByZXBhaW50LCB3 aXRoIHRoZSByZXN1bHQgdGhhdCBwYXJ0cyBvZiB0aGUgcGx1Z2luCisgICAgICAgIHdlcmUgYXBw ZWFyaW5nIGluIHRoZWlyIG9sZCBwb3NpdGlvbiBhZnRlciBhIHBhZ2Ugc2Nyb2xsLiBUaGlzIHdh cyBhIHByb2JsZW0gZm9yCisgICAgICAgIFF0IGluIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzE3OSI+YnVnIDU3MTc5PC9hPjwvYj4gPGJyLz48YnIv PgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gt c2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgor PGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hv Y2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlm cmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3 YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFt ZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZl LWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBz cmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZs YXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9 Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNo IiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4u L3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBz dHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3Bs dWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHls ZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdp bnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0i cG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMv dGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9z aXRpb246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVz dC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRp b246IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5z d2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246 IHJlbGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2Yi IHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJl bGF0aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5 cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0 aXZlOyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9 ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZl OyAiPjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFw cGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAi PjwvaWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxp Y2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwv aWZyYW1lPgorPGlmcmFtZSBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0 aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvaWZy YW1lPgorPGVtYmVkIHNyYz0iLi4vcGx1Z2lucy90ZXN0LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24v eC1zaG9ja3dhdmUtZmxhc2giIHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7ICI+PC9lbWJlZD4K KzxlbWJlZCBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hv Y2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvZW1iZWQ+Cis8ZW1i ZWQgc3JjPSIuLi9wbHVnaW5zL3Rlc3Quc3dmIiB0eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2 ZS1mbGFzaCIgc3R5bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgIj48L2VtYmVkPgorPGVtYmVkIHNy Yz0iLi4vcGx1Z2lucy90ZXN0LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxh c2giIHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7ICI+PC9lbWJlZD4KKzxlbWJlZCBzcmM9Ii4u L3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBz dHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvZW1iZWQ+Cis8ZW1iZWQgc3JjPSIuLi9wbHVn aW5zL3Rlc3Quc3dmIiB0eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1mbGFzaCIgc3R5bGU9 InBvc2l0aW9uOiByZWxhdGl2ZTsgIj48L2VtYmVkPgorPGVtYmVkIHNyYz0iLi4vcGx1Z2lucy90 ZXN0LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxhc2giIHN0eWxlPSJwb3Np dGlvbjogcmVsYXRpdmU7ICI+PC9lbWJlZD4KKzxlbWJlZCBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5z d2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246 IHJlbGF0aXZlOyAiPjwvZW1iZWQ+Cis8ZW1iZWQgc3JjPSIuLi9wbHVnaW5zL3Rlc3Quc3dmIiB0 eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1mbGFzaCIgc3R5bGU9InBvc2l0aW9uOiByZWxh dGl2ZTsgIj48L2VtYmVkPgorPGVtYmVkIHNyYz0iLi4vcGx1Z2lucy90ZXN0LnN3ZiIgdHlwZT0i YXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxhc2giIHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7 ICI+PC9lbWJlZD4KKzxlbWJlZCBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxp Y2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwv ZW1iZWQ+Cis8ZW1iZWQgc3JjPSIuLi9wbHVnaW5zL3Rlc3Quc3dmIiB0eXBlPSJhcHBsaWNhdGlv bi94LXNob2Nrd2F2ZS1mbGFzaCIgc3R5bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgIj48L2VtYmVk PgorPGVtYmVkIHNyYz0iLi4vcGx1Z2lucy90ZXN0LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24veC1z aG9ja3dhdmUtZmxhc2giIHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7ICI+PC9lbWJlZD4KKzxl bWJlZCBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3 YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvZW1iZWQ+Cis8ZW1iZWQg c3JjPSIuLi9wbHVnaW5zL3Rlc3Quc3dmIiB0eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1m bGFzaCIgc3R5bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgIj48L2VtYmVkPgorPGVtYmVkIHNyYz0i Li4vcGx1Z2lucy90ZXN0LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxhc2gi IHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7ICI+PC9lbWJlZD4KKzxlbWJlZCBzcmM9Ii4uL3Bs dWdpbnMvdGVzdC5zd2YiIHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHls ZT0icG9zaXRpb246IHJlbGF0aXZlOyAiPjwvZW1iZWQ+Cis8ZW1iZWQgc3JjPSIuLi9wbHVnaW5z L3Rlc3Quc3dmIiB0eXBlPSJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1mbGFzaCIgc3R5bGU9InBv c2l0aW9uOiByZWxhdGl2ZTsgIj48L2VtYmVkPgorPGVtYmVkIHNyYz0iLi4vcGx1Z2lucy90ZXN0 LnN3ZiIgdHlwZT0iYXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxhc2giIHN0eWxlPSJwb3NpdGlv bjogcmVsYXRpdmU7ICI+PC9lbWJlZD4KKzxlbWJlZCBzcmM9Ii4uL3BsdWdpbnMvdGVzdC5zd2Yi IHR5cGU9ImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIiBzdHlsZT0icG9zaXRpb246IHJl bGF0aXZlOyAiPjwvZW1iZWQ+CisKKzwvYm9keT4KKworPC9odG1sPgorCisKKworCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKaW5kZXggZGNiODA1YWExMjU3YzFi MzM0N2Y1YzllNmJjOTM2OTA3Mzc5YjkxZC4uZjM5ZGE4NTE3OWY1NmI3MzFiOTk3NDU2YzMwZDVj MGQzOGE0MDVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5W aWV3UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNw cApAQCAtMTgyLDcgKzE4Miw3IEBAIHZvaWQgUGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0 KCkKICAgICAgICAgLy8gTm90ZSB0aGF0IHdlIGRvbid0IGludmFsaWRhdGUgdGhlIGZyYW1lUmVj dCgpIGhlcmUuIFRoaXMgaXMgYmVjYXVzZSBRV2ViRnJhbWU6OnJlbmRlclJlbGF0aXZlQ29vcmRz KCkKICAgICAgICAgLy8gaW1pdGF0ZXMgU2Nyb2xsVmlldyBhbmQgYWRkcyB0aGUgc2Nyb2xsIG9m ZnNldCBiYWNrIG9uIHRvIHRoZSByZWN0IHdlIGRhbWFnZSBoZXJlIChtYWtpbmcgdGhlIGNvLW9y ZGluYXRlcyBhYnNvbHV0ZQogICAgICAgICAvLyB0byB0aGUgZnJhbWUgYWdhaW4pIGJlZm9yZSBw YXNzaW5nIGl0IHRvIEZyYW1lVmlldy4KLSAgICAgICAgZnJhbWVWaWV3LT5pbnZhbGlkYXRlUmVj dChtX3dpbmRvd1JlY3QpOworICAgICAgICBpbnZhbGlkYXRlKCk7CiAgICAgfQogfQogCkBAIC04 MTIsOCArODEyLDEyIEBAIHZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QoY29uc3QgSW50 UmVjdCYgcmVjdCkKICNlbmRpZgogCiAgICAgaWYgKG1faXNXaW5kb3dlZCkgewotICAgICAgICBp ZiAocGxhdGZvcm1XaWRnZXQoKSkKKyAgICAgICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkpIHsKKyAg ICAgICAgICAgIC8vIHVwZGF0ZSgpIHdpbGwgc2NoZWR1bGUgYSByZXBhaW50IG9mIHRoZSB3aWRn ZXQgc28gZW5zdXJlCisgICAgICAgICAgICAvLyBpdHMga25vd2xlZGdlIG9mIGl0cyBwb3NpdGlv biBvbiB0aGUgcGFnZSBpcyB1cCB0byBkYXRlLgorICAgICAgICAgICAgcGxhdGZvcm1XaWRnZXQo KS0+c2V0R2VvbWV0cnkobV93aW5kb3dSZWN0KTsKICAgICAgICAgICAgIHBsYXRmb3JtV2lkZ2V0 KCktPnVwZGF0ZShyZWN0KTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm47CiAgICAgfQogCg==