57178 2011-03-27 04:03:33 -0700 InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed 2023-06-03 06:09:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 eric webkit-unassigned ahmad.saleem792 commit-queue hyatt mitz rniwa simon.fraser xji yael zalan oldest_to_newest 374103 0 eric 2011-03-27 04:03:33 -0700 InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed prevOnline() just returns m_prev and is probably named with "onLine" to indicate that it's on the same line (and not a prev/next in the sense of a RenderLineBoxList). prevOnlineExists() answers the question of if there is a previous line box on the same line, not necessarily within the current InlineFlowBox container. For example, the following code is wrong: prevOnlineExists() && prevOnline()->foo() One of these should be renamed to prevent confusion. 374105 1 eric 2011-03-27 04:21:23 -0700 This came up when Yael and I were looking at fixing bug 9272. 383389 2 yael 2011-04-11 12:45:24 -0700 After http://trac.webkit.org/changeset/82419, prevOnLineExists() and nextOnLineExists() are no longer used. I am preparing a patch to remove them, and all the flags associated with them. 383417 3 89063 yael 2011-04-11 13:13:08 -0700 Created attachment 89063 Patch. Remove nextOnLineExists() and prevOnLineExists(), as they are not used anymore. 383423 4 89063 eric 2011-04-11 13:19:27 -0700 Comment on attachment 89063 Patch. OK. Sounds great. Thanks! 383586 5 89063 commit-queue 2011-04-11 15:18:21 -0700 Comment on attachment 89063 Patch. Clearing flags on attachment: 89063 Committed r83515: <http://trac.webkit.org/changeset/83515> 383587 6 commit-queue 2011-04-11 15:18:26 -0700 All reviewed patches have been landed. Closing bug. 383682 7 rniwa 2011-04-11 16:55:53 -0700 This broke GTK builds. They were apparently used in AccessibilityObjectWrapperAtk.cpp: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/21347/steps/compile-webkit/logs/stdio 383698 8 eric 2011-04-11 17:12:56 -0700 Wow, that's so wrong it hurts. 383701 9 rniwa 2011-04-11 17:16:14 -0700 Committed r83540: <http://trac.webkit.org/changeset/83540> 383702 10 rniwa 2011-04-11 17:18:49 -0700 Sorry, I had to roll out the patch in http://trac.webkit.org/changeset/83540 because there wasn't obvious alternatives to call. 383718 11 yael 2011-04-11 17:42:46 -0700 (In reply to comment #10) > Sorry, I had to roll out the patch in http://trac.webkit.org/changeset/83540 because there wasn't obvious alternatives to call. Thank you for rolling out. Sorry I was not online to see that it broke the build. 1959685 12 ahmad.saleem792 2023-06-03 05:31:03 -0700 Do we need to track this? This is in Legacy Line Layout. Only following references exists in our code besides in 'LegacyInlineBox.cpp/h': In RenderLineBreak: isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists(); isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists(); In RenderText: isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists(); isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists(); 1959693 13 zalan 2023-06-03 06:09:00 -0700 (In reply to Ahmad Saleem from comment #12) > Do we need to track this? Certainly not. This code is soon to be completely removed. 89063 2011-04-11 13:13:08 -0700 2011-04-11 15:18:21 -0700 Patch. 57178.patch text/plain 3733 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDg0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElubGluZUJveDo6cHJldk9ubGluZSBhbmQgSW5saW5lQm94 OjpwcmV2T25saW5lRXhpc3RzKCkgYXJlIGNvbmZ1c2luZyBhbmQgc2hvdWxkIGJlIHJlbmFtZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MTc4CisK KyAgICAgICAgUmVtb3ZlIHByZXZPbkxpbmVFeGlzdHMoKSBhbmQgbmV4dE9uTGluZUV4aXN0cygp IGFzIHRoZXkgYXJlIG5vdCB1c2VkIGFueW1vcmUuCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVk ZWQgYmVjYXVzZSB0aGlzIGlzIGNsZWFudXAgb25seS4KKworICAgICAgICAqIHJlbmRlcmluZy9J bmxpbmVCb3guY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVCb3guaDoKKyAgICAgICAg KFdlYkNvcmU6OklubGluZUJveDo6SW5saW5lQm94KToKKyAgICAgICAgKFdlYkNvcmU6OklubGlu ZUJveDo6c2V0UHJldk9uTGluZSk6CisKIDIwMTEtMDQtMDYgIFhpYW9tZWkgSmkgIDx4amlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCShyZXZpc2lvbiA4MzQzNSkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MTEsMzYgKzIxMSw2IEBAIFJvb3RJbmxpbmVCb3gqIElubGluZUJveDo6cm9vdCgpCiAgICAgcmV0 dXJuIHN0YXRpY19jYXN0PFJvb3RJbmxpbmVCb3gqPih0aGlzKTsKIH0KIAotYm9vbCBJbmxpbmVC b3g6Om5leHRPbkxpbmVFeGlzdHMoKSBjb25zdAotewotICAgIGlmICghbV9kZXRlcm1pbmVkSWZO ZXh0T25MaW5lRXhpc3RzKSB7Ci0gICAgICAgIG1fZGV0ZXJtaW5lZElmTmV4dE9uTGluZUV4aXN0 cyA9IHRydWU7Ci0KLSAgICAgICAgaWYgKCFwYXJlbnQoKSkKLSAgICAgICAgICAgIG1fbmV4dE9u TGluZUV4aXN0cyA9IGZhbHNlOwotICAgICAgICBlbHNlIGlmIChuZXh0T25MaW5lKCkpCi0gICAg ICAgICAgICBtX25leHRPbkxpbmVFeGlzdHMgPSB0cnVlOwotICAgICAgICBlbHNlCi0gICAgICAg ICAgICBtX25leHRPbkxpbmVFeGlzdHMgPSBwYXJlbnQoKS0+bmV4dE9uTGluZUV4aXN0cygpOwot ICAgIH0KLSAgICByZXR1cm4gbV9uZXh0T25MaW5lRXhpc3RzOwotfQotCi1ib29sIElubGluZUJv eDo6cHJldk9uTGluZUV4aXN0cygpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2RldGVybWluZWRJZlBy ZXZPbkxpbmVFeGlzdHMpIHsKLSAgICAgICAgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhpc3Rz ID0gdHJ1ZTsKLSAgICAgICAgCi0gICAgICAgIGlmICghcGFyZW50KCkpCi0gICAgICAgICAgICBt X3ByZXZPbkxpbmVFeGlzdHMgPSBmYWxzZTsKLSAgICAgICAgZWxzZSBpZiAocHJldk9uTGluZSgp KQotICAgICAgICAgICAgbV9wcmV2T25MaW5lRXhpc3RzID0gdHJ1ZTsKLSAgICAgICAgZWxzZQot ICAgICAgICAgICAgbV9wcmV2T25MaW5lRXhpc3RzID0gcGFyZW50KCktPnByZXZPbkxpbmVFeGlz dHMoKTsKLSAgICB9Ci0gICAgcmV0dXJuIG1fcHJldk9uTGluZUV4aXN0czsKLX0KLQogSW5saW5l Qm94KiBJbmxpbmVCb3g6Om5leHRMZWFmQ2hpbGQoKSBjb25zdAogewogICAgIElubGluZUJveCog bGVhZiA9IDA7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oCShyZXZpc2lv biA4MzQzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaAkod29ya2lu ZyBjb3B5KQpAQCAtNTgsMTAgKzU4LDYgQEAgcHVibGljOgogICAgICAgICAsIG1faGFzRWxsaXBz aXNCb3hPckh5cGhlbihmYWxzZSkKICAgICAgICAgLCBtX2Rpck92ZXJyaWRlKGZhbHNlKQogICAg ICAgICAsIG1faXNUZXh0KGZhbHNlKQotICAgICAgICAsIG1fZGV0ZXJtaW5lZElmTmV4dE9uTGlu ZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMo ZmFsc2UpCi0gICAgICAgICwgbV9uZXh0T25MaW5lRXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1f cHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAgICAgLCBtX2V4cGFuc2lvbigwKQogI2lmbmRl ZiBOREVCVUcKICAgICAgICAgLCBtX2hhc0JhZFBhcmVudChmYWxzZSkKQEAgLTkzLDEwICs4OSw2 IEBAIHB1YmxpYzoKICAgICAgICAgLCBtX2hhc0VsbGlwc2lzQm94T3JIeXBoZW4oZmFsc2UpCiAg ICAgICAgICwgbV9kaXJPdmVycmlkZShmYWxzZSkKICAgICAgICAgLCBtX2lzVGV4dChmYWxzZSkK LSAgICAgICAgLCBtX2RldGVybWluZWRJZk5leHRPbkxpbmVFeGlzdHMoZmFsc2UpCi0gICAgICAg ICwgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fbmV4 dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX3ByZXZPbkxpbmVFeGlzdHMoZmFsc2Up CiAgICAgICAgICwgbV9leHBhbnNpb24oMCkKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgICwgbV9o YXNCYWRQYXJlbnQoZmFsc2UpCkBAIC0yMDEsOCArMTkzLDYgQEAgcHVibGljOgogICAgICAgICBB U1NFUlQobV9wYXJlbnQgfHwgIXByZXYpOwogICAgICAgICBtX3ByZXYgPSBwcmV2OwogICAgIH0K LSAgICBib29sIG5leHRPbkxpbmVFeGlzdHMoKSBjb25zdDsKLSAgICBib29sIHByZXZPbkxpbmVF eGlzdHMoKSBjb25zdDsKIAogICAgIHZpcnR1YWwgYm9vbCBpc0xlYWYoKSBjb25zdCB7IHJldHVy biB0cnVlOyB9CiAgICAgCkBAIC0zNTcsMTAgKzM0Nyw2IEBAIHB1YmxpYzoKICAgICBib29sIG1f ZGlyT3ZlcnJpZGUgOiAxOwogICAgIGJvb2wgbV9pc1RleHQgOiAxOyAvLyBXaGV0aGVyIG9yIG5v dCB0aGlzIG9iamVjdCByZXByZXNlbnRzIHRleHQgd2l0aCBhIG5vbi16ZXJvIGhlaWdodC4gSW5j bHVkZXMgbm9uLWltYWdlIGxpc3QgbWFya2VycywgdGV4dCBib3hlcy4KIHByb3RlY3RlZDoKLSAg ICBtdXRhYmxlIGJvb2wgbV9kZXRlcm1pbmVkSWZOZXh0T25MaW5lRXhpc3RzIDogMTsKLSAgICBt dXRhYmxlIGJvb2wgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhpc3RzIDogMTsKLSAgICBtdXRh YmxlIGJvb2wgbV9uZXh0T25MaW5lRXhpc3RzIDogMTsKLSAgICBtdXRhYmxlIGJvb2wgbV9wcmV2 T25MaW5lRXhpc3RzIDogMTsKICAgICBpbnQgbV9leHBhbnNpb24gOiAxMTsgLy8gZm9yIGp1c3Rp ZmllZCB0ZXh0CiAKICNpZm5kZWYgTkRFQlVHCg==