57171 2011-03-26 19:32:14 -0700 check-webkit-style errors on trailing comma replaced by space when comments follow 2011-04-10 08:16:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Other RESOLVED INVALID P2 Normal --- 0 bentaylor.solx86 webkit-unassigned levin oldest_to_newest 374027 0 bentaylor.solx86 2011-03-26 19:32:14 -0700 The example patch failed the check-webkit-style, and I believe this to be a false positive: The , that is replaced should be acceptable to be replaced by a space " " so that trailing comments maintain their 'style" Index: Source/WebCore/platform/network/ResourceRequestBase.h =================================================================== --- Source/WebCore/platform/network/ResourceRequestBase.h (revision 82026) +++ Source/WebCore/platform/network/ResourceRequestBase.h (working copy) @@ -41,7 +41,7 @@ namespace WebCore { UseProtocolCachePolicy, // normal load ReloadIgnoringCacheData, // reload ReturnCacheDataElseLoad, // back/forward or encoding change - allow stale data - ReturnCacheDataDontLoad, // results of a post - allow stale data and only use cache + ReturnCacheDataDontLoad // results of a post - allow stale data and only use cache }; class ResourceRequest; 382882 1 levin 2011-04-10 08:16:37 -0700 Somehow I missed this in my previous search. Regardless this has been discussed before, and it is not desirable in this project: https://lists.webkit.org/pipermail/webkit-dev/2009-September/009814.html