5717 2005-11-12 07:39:24 -0800 REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes 2005-11-21 11:04:52 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 VERIFIED FIXED P1 Major --- 5230 1 ap justin.garcia oldest_to_newest 23949 0 ap 2005-11-12 07:39:24 -0800 _visiblePositionForPoint lacks a check for the case when renderer->layer()->hitTest() doesn't find any node. This causes a crash in "run-webkit-tests editing/input/text-input-controller.html" with a fix to bug 5230 being applied. Used to work fine before - apparently, some recent checkin has changed the behavior of hitTest(). 23950 1 4674 ap 2005-11-12 07:41:25 -0800 Created attachment 4674 naive fix I couldn't find the reason why the behavior has changed - but the check for nil seems necessary here nonetheless. 24033 2 4674 justin.garcia 2005-11-14 14:19:51 -0800 Comment on attachment 4674 naive fix As long as it's correct for hitTest to not find a node in this case, r=me. 24117 3 justin.garcia 2005-11-15 11:14:57 -0800 Landed 4674 2005-11-12 07:41:25 -0800 2005-11-14 14:19:51 -0800 naive fix CheckNodePatch.txt text/plain 738 ap SW5kZXg6IGt3cS9XZWJDb3JlQnJpZGdlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9v dC9XZWJDb3JlL2t3cS9XZWJDb3JlQnJpZGdlLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQy NgpkaWZmIC1wIC11IC1yMS40MjYga3dxL1dlYkNvcmVCcmlkZ2UubW0KLS0tIGt3cS9XZWJDb3Jl QnJpZGdlLm1tCTkgTm92IDIwMDUgMDI6NDY6MjkgLTAwMDAJMS40MjYKKysrIGt3cS9XZWJDb3Jl QnJpZGdlLm1tCTEyIE5vdiAyMDA1IDE1OjM5OjQxIC0wMDAwCkBAIC0xOTMxLDcgKzE5NDEsNyBA QCBzdGF0aWMgSFRNTEZvcm1FbGVtZW50SW1wbCAqZm9ybUVsZW1lbnRGCiAgICAgUmVuZGVyT2Jq ZWN0OjpOb2RlSW5mbyBub2RlSW5mbyh0cnVlLCB0cnVlKTsKICAgICByZW5kZXJlci0+bGF5ZXIo KS0+aGl0VGVzdChub2RlSW5mbywgKGludClwb2ludC54LCAoaW50KXBvaW50LnkpOwogICAgIE5v ZGVJbXBsICpub2RlID0gbm9kZUluZm8uaW5uZXJOb2RlKCk7Ci0gICAgaWYgKCFub2RlLT5yZW5k ZXJlcigpKQorICAgIGlmICghbm9kZSB8fCAhbm9kZS0+cmVuZGVyZXIoKSkKICAgICAgICAgcmV0 dXJuIFZpc2libGVQb3NpdGlvbigpOwogICAgIAogICAgIHJldHVybiBub2RlLT5yZW5kZXJlcigp LT5wb3NpdGlvbkZvckNvb3JkaW5hdGVzKChpbnQpcG9pbnQueCwgKGludClwb2ludC55KTsK