57159 2011-03-26 12:30:23 -0700 WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate 2011-03-26 13:18:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam abarth eric webkit.review.bot oldest_to_newest 373943 0 sam 2011-03-26 12:30:23 -0700 WebKit2: Assert in CoreIPC::typeFromCFTypeRef() when loading a site with an invalid certificate 373947 1 87039 sam 2011-03-26 12:32:32 -0700 Created attachment 87039 Patch 373951 2 87039 andersca 2011-03-26 12:34:05 -0700 Comment on attachment 87039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87039&action=review > Source/WebKit2/ChangeLog:20 > + an array of SecCertificateRefs. s/an array of// 373953 3 sam 2011-03-26 12:37:15 -0700 Committed r82036: <http://trac.webkit.org/changeset/82036> 373965 4 webkit.review.bot 2011-03-26 13:18:44 -0700 http://trac.webkit.org/changeset/82036 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/forms/input-appearance-preventDefault.html 87039 2011-03-26 12:32:32 -0700 2011-03-26 12:34:05 -0700 Patch bug-57159-20110326123231.patch text/plain 6479 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMDM0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMjYgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXQyOiBBc3NlcnQgaW4gQ29yZUlQQzo6dHlwZUZyb21DRlR5cGVS ZWYoKSB3aGVuIGxvYWRpbmcgYSBzaXRlIHdpdGggYW4gaW52YWxpZCBjZXJ0aWZpY2F0ZQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vOTE4ODA0MT4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MTU5CisKKyAgICAgICAgKiBTaGFyZWQvY2YvQXJndW1l bnRDb2RlcnNDRi5jcHA6CisgICAgICAgIChDb3JlSVBDOjp0eXBlRnJvbUNGVHlwZVJlZik6Cisg ICAgICAgIChDb3JlSVBDOjplbmNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6ZGVjb2RlKToKKyAg ICAgICAgKiBTaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5oOgorICAgICAgICBBZGQgZW5jb2Rp bmcvZGVjb2RpbmcgZm9yIFNlY0NlcnRpZmljYXRlUmVmIHR5cGUuCisKKyAgICAgICAgKiBTaGFy ZWQvbWFjL1BsYXRmb3JtQ2VydGlmaWNhdGVJbmZvLm1tOgorICAgICAgICAoV2ViS2l0OjpQbGF0 Zm9ybUNlcnRpZmljYXRlSW5mbzo6ZW5jb2RlKToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1D ZXJ0aWZpY2F0ZUluZm86OmRlY29kZSk6CisgICAgICAgIFVzZSBBcmd1bWVudENvZGVyc0NGIG5v dyB0aGF0IGl0IGtub3dzIGhvdyB0byBlbmNvZGUvZGVjb2RlCisgICAgICAgIGFuIGFycmF5IG9m IFNlY0NlcnRpZmljYXRlUmVmcy4KKwogMjAxMS0wMy0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50Q29kZXJzQ0YuY3BwCShyZXZp c2lvbiA4MjAzMCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NG LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgsNiArNDgsOSBAQCBlbnVtIENGVHlwZSB7CiAgICAg Q0ZOdW1iZXIsCiAgICAgQ0ZTdHJpbmcsCiAgICAgQ0ZVUkwsCisjaWYgUExBVEZPUk0oTUFDKQor ICAgIFNlY0NlcnRpZmljYXRlLAorI2VuZGlmCiAgICAgTnVsbCwKICAgICBVbmtub3duLAogfTsK QEAgLTc2LDYgKzc5LDEwIEBAIHN0YXRpYyBDRlR5cGUgdHlwZUZyb21DRlR5cGVSZWYoQ0ZUeXBl UmUKICAgICAgICAgcmV0dXJuIENGU3RyaW5nOwogICAgIGlmICh0eXBlSUQgPT0gQ0ZVUkxHZXRU eXBlSUQoKSkKICAgICAgICAgcmV0dXJuIENGVVJMOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBp ZiAodHlwZUlEID09IFNlY0NlcnRpZmljYXRlR2V0VHlwZUlEKCkpCisgICAgICAgIHJldHVybiBT ZWNDZXJ0aWZpY2F0ZTsKKyNlbmRpZgogCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAg cmV0dXJuIFVua25vd247CkBAIC0xMTAsNiArMTE3LDExIEBAIHN0YXRpYyB2b2lkIGVuY29kZShB cmd1bWVudEVuY29kZXIqIGVuY28KICAgICBjYXNlIENGVVJMOgogICAgICAgICBlbmNvZGUoZW5j b2Rlciwgc3RhdGljX2Nhc3Q8Q0ZVUkxSZWY+KHR5cGVSZWYpKTsKICAgICAgICAgcmV0dXJuOwor I2lmIFBMQVRGT1JNKE1BQykKKyAgICBjYXNlIFNlY0NlcnRpZmljYXRlOgorICAgICAgICBlbmNv ZGUoZW5jb2RlciwgKFNlY0NlcnRpZmljYXRlUmVmKXR5cGVSZWYpOworICAgICAgICByZXR1cm47 CisjZW5kaWYKICAgICBjYXNlIE51bGw6CiAgICAgICAgIHJldHVybjsKICAgICBjYXNlIFVua25v d246CkBAIC0xNzgsNiArMTkwLDE1IEBAIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29k ZXIqIGRlY28KICAgICAgICAgcmVzdWx0LmFkb3B0Q0YodXJsLmxlYWtSZWYoKSk7CiAgICAgICAg IHJldHVybiB0cnVlOwogICAgIH0KKyNpZiBQTEFURk9STShNQUMpCisgICAgY2FzZSBTZWNDZXJ0 aWZpY2F0ZTogeworICAgICAgICBSZXRhaW5QdHI8U2VjQ2VydGlmaWNhdGVSZWY+IGNlcnRpZmlj YXRlOworICAgICAgICBpZiAoIWRlY29kZShkZWNvZGVyLCBjZXJ0aWZpY2F0ZSkpCisgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJlc3VsdC5hZG9wdENGKGNlcnRpZmljYXRlLmxl YWtSZWYoKSk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyNlbmRpZgogICAgIGNhc2Ug TnVsbDoKICAgICAgICAgcmVzdWx0ID0gdG9rZW5OdWxsVHlwZVJlZigpOwogICAgICAgICByZXR1 cm4gdHJ1ZTsKQEAgLTQ1OSw1ICs0ODAsMjIgQEAgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVy KiBkZWNvZGVyLCBSZQogICAgIHJldHVybiB0cnVlOwogfQogCi19IC8vIG5hbWVzcGFjZSBDb3Jl SVBDCisjaWYgUExBVEZPUk0oTUFDKQordm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyKiBlbmNv ZGVyLCBTZWNDZXJ0aWZpY2F0ZVJlZiBjZXJ0aWZpY2F0ZSkKK3sKKyAgICBSZXRhaW5QdHI8Q0ZE YXRhUmVmPiBkYXRhKEFkb3B0Q0YsIFNlY0NlcnRpZmljYXRlQ29weURhdGEoY2VydGlmaWNhdGUp KTsKKyAgICBlbmNvZGUoZW5jb2RlciwgZGF0YS5nZXQoKSk7Cit9CiAKK2Jvb2wgZGVjb2RlKEFy Z3VtZW50RGVjb2RlciogZGVjb2RlciwgUmV0YWluUHRyPFNlY0NlcnRpZmljYXRlUmVmPiYgcmVz dWx0KQoreworICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IGRhdGE7CisgICAgaWYgKCFkZWNvZGUo ZGVjb2RlciwgZGF0YSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJlc3VsdC5hZG9w dENGKFNlY0NlcnRpZmljYXRlQ3JlYXRlV2l0aERhdGEoMCwgZGF0YS5nZXQoKSkpOworICAgIHJl dHVybiB0cnVlOworfQorI2VuZGlmCisKK30gLy8gbmFtZXNwYWNlIENvcmVJUEMKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50Q29kZXJzQ0YuaAkocmV2aXNpb24gODIw MzApCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCw2ICsyOCwxMCBAQAogCiAjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5o PgogCisjaWYgUExBVEZPUk0oTUFDKQorI2luY2x1ZGUgPFNlY3VyaXR5L1NlY0NlcnRpZmljYXRl Lmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIENvcmVJUEMgewogCiBjbGFzcyBBcmd1bWVudEVuY29k ZXI7CkBAIC02MSw2ICs2NSwxMiBAQCBib29sIGRlY29kZShBcmd1bWVudERlY29kZXIqLCBSZXRh aW5QdHI8CiB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXIqLCBDRlVSTFJlZik7CiBib29sIGRl Y29kZShBcmd1bWVudERlY29kZXIqLCBSZXRhaW5QdHI8Q0ZVUkxSZWY+JiByZXN1bHQpOwogCisj aWYgUExBVEZPUk0oTUFDKQorLy8gU2VjQ2VydGlmaWNhdGVSZWYKK3ZvaWQgZW5jb2RlKEFyZ3Vt ZW50RW5jb2RlciosIFNlY0NlcnRpZmljYXRlUmVmKTsKK2Jvb2wgZGVjb2RlKEFyZ3VtZW50RGVj b2RlciosIFJldGFpblB0cjxTZWNDZXJ0aWZpY2F0ZVJlZj4mIHJlc3VsdCk7CisjZW5kaWYKKwog Q0ZUeXBlUmVmIHRva2VuTnVsbFR5cGVSZWYoKTsKIAogfSAvLyBuYW1lc3BhY2UgQ29yZUlQQwpJ bmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9QbGF0Zm9ybUNlcnRpZmljYXRlSW5mby5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1BsYXRmb3JtQ2VydGlm aWNhdGVJbmZvLm1tCShyZXZpc2lvbiA4MjAzMCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9t YWMvUGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8ubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2LDEwICsy NiwxMCBAQAogI2ltcG9ydCAiY29uZmlnLmgiCiAjaW1wb3J0ICJQbGF0Zm9ybUNlcnRpZmljYXRl SW5mby5oIgogCisjaW1wb3J0ICJBcmd1bWVudENvZGVyc0NGLmgiCiAjaW1wb3J0ICJBcmd1bWVu dERlY29kZXIuaCIKICNpbXBvcnQgIkFyZ3VtZW50RW5jb2Rlci5oIgogI2ltcG9ydCA8V2ViS2l0 U3lzdGVtSW50ZXJmYWNlLmg+Ci0jaW1wb3J0IDxTZWN1cml0eS9TZWN1cml0eS5oPgogCiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtNTEsNDUgKzUxLDI3IEBAIFBsYXRmb3JtQ2VydGlm aWNhdGVJbmZvOjpQbGF0Zm9ybUNlcnRpZmkKIAogdm9pZCBQbGF0Zm9ybUNlcnRpZmljYXRlSW5m bzo6ZW5jb2RlKENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciogZW5jb2RlcikgY29uc3QKIHsKLSAg ICAvLyBTcGVjaWFsIGNhc2Ugbm8gY2VydGlmaWNhdGVzLCAKICAgICBpZiAoIW1fY2VydGlmaWNh dGVDaGFpbikgewotICAgICAgICBlbmNvZGVyLT5lbmNvZGVVSW50NjQoc3RkOjpudW1lcmljX2xp bWl0czx1aW50NjRfdD46Om1heCgpKTsKKyAgICAgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbChmYWxz ZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICB1aW50NjRfdCBsZW5ndGggPSBDRkFy cmF5R2V0Q291bnQobV9jZXJ0aWZpY2F0ZUNoYWluLmdldCgpKTsKLSAgICBlbmNvZGVyLT5lbmNv ZGVVSW50NjQobGVuZ3RoKTsKLQotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoOyAr K2kpIHsKLSAgICAgICAgUmV0YWluUHRyPENGRGF0YVJlZj4gZGF0YShBZG9wdENGLCBTZWNDZXJ0 aWZpY2F0ZUNvcHlEYXRhKChTZWNDZXJ0aWZpY2F0ZVJlZilDRkFycmF5R2V0VmFsdWVBdEluZGV4 KG1fY2VydGlmaWNhdGVDaGFpbi5nZXQoKSwgaSkpKTsKLSAgICAgICAgZW5jb2Rlci0+ZW5jb2Rl Qnl0ZXMoQ0ZEYXRhR2V0Qnl0ZVB0cihkYXRhLmdldCgpKSwgQ0ZEYXRhR2V0TGVuZ3RoKGRhdGEu Z2V0KCkpKTsKLSAgICB9CisgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbCh0cnVlKTsKKyAgICBDb3Jl SVBDOjplbmNvZGUoZW5jb2RlciwgbV9jZXJ0aWZpY2F0ZUNoYWluLmdldCgpKTsKIH0KIAogYm9v bCBQbGF0Zm9ybUNlcnRpZmljYXRlSW5mbzo6ZGVjb2RlKENvcmVJUEM6OkFyZ3VtZW50RGVjb2Rl ciogZGVjb2RlciwgUGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8mIGMpCiB7Ci0gICAgdWludDY0X3Qg bGVuZ3RoOwotICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGxlbmd0aCkpCisgICAgYm9vbCBoYXND ZXJ0aWZpY2F0ZUNoYWluOworICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGhhc0NlcnRpZmljYXRl Q2hhaW4pKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAobGVuZ3RoID09IHN0ZDo6 bnVtZXJpY19saW1pdHM8dWludDY0X3Q+OjptYXgoKSkgewotICAgICAgICAvLyBUaGlzIGlzIHRo ZSBubyBjZXJ0aWZpY2F0ZXMgY2FzZS4KKyAgICBpZiAoIWhhc0NlcnRpZmljYXRlQ2hhaW4pCiAg ICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KIAotICAgIFJldGFpblB0cjxDRk11dGFibGVBcnJh eVJlZj4gYXJyYXkoQWRvcHRDRiwgQ0ZBcnJheUNyZWF0ZU11dGFibGUoMCwgbGVuZ3RoLCAma0NG VHlwZUFycmF5Q2FsbEJhY2tzKSk7Ci0KLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxlbmd0 aDsgKytpKSB7Ci0gICAgICAgIFZlY3Rvcjx1aW50OF90PiBieXRlczsKLSAgICAgICAgaWYgKCFk ZWNvZGVyLT5kZWNvZGVCeXRlcyhieXRlcykpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0K LSAgICAgICAgUmV0YWluUHRyPENGRGF0YVJlZj4gZGF0YShBZG9wdENGLCBDRkRhdGFDcmVhdGVX aXRoQnl0ZXNOb0NvcHkoMCwgYnl0ZXMuZGF0YSgpLCBieXRlcy5zaXplKCksIGtDRkFsbG9jYXRv ck51bGwpKTsKLSAgICAgICAgUmV0YWluUHRyPFNlY0NlcnRpZmljYXRlUmVmPiBjZXJ0aWZpY2F0 ZShBZG9wdENGLCBTZWNDZXJ0aWZpY2F0ZUNyZWF0ZVdpdGhEYXRhKDAsIGRhdGEuZ2V0KCkpKTsK LSAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGFycmF5LmdldCgpLCBjZXJ0aWZpY2F0ZS5nZXQo KSk7Ci0gICAgfQorICAgIGlmICghQ29yZUlQQzo6ZGVjb2RlKGRlY29kZXIsIGMubV9jZXJ0aWZp Y2F0ZUNoYWluKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgYy5tX2NlcnRpZmljYXRl Q2hhaW4gPSBhcnJheTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=