57157 2011-03-26 11:43:21 -0700 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded 2011-03-26 12:30:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-unassigned benjamin webkit.review.bot oldest_to_newest 373927 0 kling 2011-03-26 11:43:21 -0700 If the page's icon is cached in the icon database, but has not been loaded from disk when WebCore asks for it, the QWebFrame::iconChanged() signal will not be emitted. In this case, the FrameLoader asks the FrameLoaderClient to wait for a notification from the IconDatabase that it's finished loading the icon. This mechanism is currently absent in WebKit/qt/ 373929 1 87033 kling 2011-03-26 11:49:20 -0700 Created attachment 87033 Proposed patch 373930 2 webkit.review.bot 2011-03-26 11:50:11 -0700 Attachment 87033 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebsettings.cpp', u'..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.h:31: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 373933 3 87033 kenneth 2011-03-26 11:58:15 -0700 Comment on attachment 87033 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=87033&action=review > Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp:61 > +void IconDatabaseClientQt::didRemoveAllIcons() > +{ > +} Why not add notImplemented() in these? 373934 4 kling 2011-03-26 12:00:22 -0700 (In reply to comment #3) > (From update of attachment 87033 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87033&action=review > > > Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp:61 > > +void IconDatabaseClientQt::didRemoveAllIcons() > > +{ > > +} > > Why not add notImplemented() in these? Because we don't want to do anything in these functions (for now, at least.) :) 373944 5 kling 2011-03-26 12:30:33 -0700 Landed in <http://trac.webkit.org/changeset/82034>. 87033 2011-03-26 11:49:20 -0700 2011-03-26 12:19:06 -0700 Proposed patch bug-57157.diff text/plain 10693 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCmluZGV4IGU0ZDdhMTUuLmY3NDRlODEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcApAQCAtMjgsNiArMjgsOSBAQAog I2luY2x1ZGUgIk1lbW9yeUNhY2hlLmgiCiAjaW5jbHVkZSAiQ3Jvc3NPcmlnaW5QcmVmbGlnaHRS ZXN1bHRDYWNoZS5oIgogI2luY2x1ZGUgIkZvbnRDYWNoZS5oIgorI2lmIEVOQUJMRShJQ09OREFU QUJBU0UpCisjaW5jbHVkZSAiSWNvbkRhdGFiYXNlQ2xpZW50UXQuaCIKKyNlbmRpZgogI2luY2x1 ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJQYWdlQ2FjaGUuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5o IgpAQCAtNjM2LDYgKzYzOSwxMSBAQCBRU3RyaW5nIFFXZWJTZXR0aW5nczo6ZGVmYXVsdFRleHRF bmNvZGluZygpIGNvbnN0CiAqLwogdm9pZCBRV2ViU2V0dGluZ3M6OnNldEljb25EYXRhYmFzZVBh dGgoY29uc3QgUVN0cmluZyYgcGF0aCkKIHsKKyNpZiBFTkFCTEUoSUNPTkRBVEFCQVNFKQorICAg IC8vIE1ha2Ugc3VyZSB0aGF0IEljb25EYXRhYmFzZUNsaWVudFF0IGlzIGluc3RhbnRpYXRlZC4K KyAgICBXZWJDb3JlOjpJY29uRGF0YWJhc2VDbGllbnRRdDo6aW5zdGFuY2UoKTsKKyNlbmRpZgor CiAgICAgV2ViQ29yZTo6SWNvbkRhdGFiYXNlOjpkZWxheURhdGFiYXNlQ2xlYW51cCgpOwogCiAg ICAgaWYgKCFwYXRoLmlzRW1wdHkoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAzNDBiMTIxLi5hNDhl N2M3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDExLTAzLTI2ICBBbmRyZWFz IEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIFFXZWJGcmFtZTo6aWNvbkNoYW5nZWQoKSBub3QgZW1p dHRlZCB3aGVuIGljb24gaXMgY2FjaGVkIGJ1dCBub3QgeWV0IGxvYWRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxNTcKKworICAgICAgICBBZGQg YW4gSWNvbkRhdGFiYXNlQ2xpZW50IGZvciB0aGUgUXQgcG9ydCB0byBlbnN1cmUgdGhhdCBRV2Vi RnJhbWU6Omljb25DaGFuZ2VkKCkKKyAgICAgICAgaXMgYWx3YXlzIGVtaXR0ZWQgd2hlbiBhcHBy b3ByaWF0ZS4KKworICAgICAgICAqIFF0V2ViS2l0LnBybzogQWRkIG5ldyBmaWxlcy4KKworICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNsaWVudFF0Lmg6IEFkZGVkLgorICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNsaWVudFF0LmNwcDogQWRkZWQuCisg ICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJhc2VDbGllbnRRdDo6aW5zdGFuY2UpOgorICAgICAg ICAoV2ViQ29yZTo6SWNvbkRhdGFiYXNlQ2xpZW50UXQ6Okljb25EYXRhYmFzZUNsaWVudFF0KToK KyAgICAgICAgKFdlYkNvcmU6Okljb25EYXRhYmFzZUNsaWVudFF0Ojp+SWNvbkRhdGFiYXNlQ2xp ZW50UXQpOgorICAgICAgICAoV2ViQ29yZTo6SWNvbkRhdGFiYXNlQ2xpZW50UXQ6OnBlcmZvcm1J bXBvcnQpOgorICAgICAgICAoV2ViQ29yZTo6SWNvbkRhdGFiYXNlQ2xpZW50UXQ6OmRpZFJlbW92 ZUFsbEljb25zKToKKyAgICAgICAgKFdlYkNvcmU6Okljb25EYXRhYmFzZUNsaWVudFF0OjpkaWRJ bXBvcnRJY29uVVJMRm9yUGFnZVVSTCk6CisgICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJhc2VD bGllbnRRdDo6ZGlkSW1wb3J0SWNvbkRhdGFGb3JQYWdlVVJMKToKKyAgICAgICAgKFdlYkNvcmU6 Okljb25EYXRhYmFzZUNsaWVudFF0OjpkaWRDaGFuZ2VJY29uRm9yUGFnZVVSTCk6CisgICAgICAg IChXZWJDb3JlOjpJY29uRGF0YWJhc2VDbGllbnRRdDo6ZGlkRmluaXNoVVJMSW1wb3J0KToKKwor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuaDoKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OnJlZ2lzdGVyRm9ySWNvbk5vdGlmaWNhdGlvbik6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0Ojpvbkljb25Mb2FkZWRGb3JQYWdl VVJMKTogTmV3IHNsb3QgY29ubmVjdGVkCisgICAgICAgIHRvIHRoZSBJY29uRGF0YWJhc2VDbGll bnRRdDo6aWNvbkxvYWRlZEZvclBhZ2VVUkwoKSBzaWduYWwuIFRoaXMgZW1pdHMgdGhlCisgICAg ICAgIFFXZWJGcmFtZTo6aWNvbkNoYW5nZWQoKSBzaWduYWwgd2hlbiB0aGUgSWNvbkRhdGFiYXNl cyBmaW5pc2hlcyBsb2FkaW5nCisgICAgICAgIGEgY2FjaGVkIGZhdmljb24gZm9yIHRoZSBmcmFt ZSdzIFVSTC4KKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdl YlNldHRpbmdzOjpzZXRJY29uRGF0YWJhc2VQYXRoKTogTWFrZSBzdXJlIHRoYXQgSWNvbkRhdGFi YXNlQ2xpZW50UXQgaXMKKyAgICAgICAgaW5zdGFudGlhdGVkLiBBbiBJY29uRGF0YWJhc2VDbGll bnQgaGFzIHRvIGJlIHJlZ2lzdGVyZWQgYmVmb3JlIHRoZSBJY29uRGF0YWJhc2UKKyAgICAgICAg c3Bhd25zIGl0cyByZWFkZXIgdGhyZWFkLgorCiAyMDExLTAzLTI1ICBBbmR5IEVzdGVzICA8YWVz dGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvUXRXZWJLaXQucHJvIGIvU291cmNlL1dlYktpdC9x dC9RdFdlYktpdC5wcm8KaW5kZXggMTY1MThlMC4uNTExMGJjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9RdFdlYktpdC5wcm8KKysrIGIvU291cmNlL1dlYktpdC9xdC9RdFdlYktpdC5w cm8KQEAgLTIxOCw2ICsyMTgsMTUgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1ZJREVPPTEp IHsKICAgICB9CiB9CiAKK2NvbnRhaW5zKERFRklORVMsIEVOQUJMRV9JQ09OREFUQUJBU0U9MSkg eworICAgIEhFQURFUlMgKz0gXAorICAgICAgICAkJFBXRC9XZWJDb3JlU3VwcG9ydC9JY29uRGF0 YWJhc2VDbGllbnQuaCBcCisgICAgICAgICQkUFdEL1dlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFz ZUNsaWVudFF0LmgKKworICAgIFNPVVJDRVMgKz0gXAorICAgICAgICAkJFBXRC9XZWJDb3JlU3Vw cG9ydC9JY29uRGF0YWJhc2VDbGllbnRRdC5jcHAKK30KKwogY29udGFpbnMoREVGSU5FUywgRU5B QkxFX0RFVklDRV9PUklFTlRBVElPTj0xKSB7CiAgICAgSEVBREVSUyArPSBcCiAgICAgICAgICQk UFdEL1dlYkNvcmVTdXBwb3J0L0RldmljZU1vdGlvbkNsaWVudFF0LmggXApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcCBi L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAK aW5kZXggNDhiMDk3ZC4uMWY4N2YwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCkBAIC00MCw2ICs0MCw5IEBA CiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRMb2FkZXIuaCIKICNp bmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCisjaWYgRU5BQkxFKElDT05EQVRBQkFTRSkKKyNpbmNs dWRlICJJY29uRGF0YWJhc2VDbGllbnRRdC5oIgorI2VuZGlmCiAjaWYgVVNFKEpTQykKICNpbmNs dWRlICJKU0RPTVdpbmRvd0Jhc2UuaCIKICNlbGlmIFVTRShWOCkKQEAgLTc3MSwxMSArNzc0LDI1 IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlkUGVyZm9ybUZpcnN0TmF2aWdhdGlvbigp IGNvbnN0CiAgICAgbV93ZWJGcmFtZS0+cGFnZSgpLT5kLT51cGRhdGVOYXZpZ2F0aW9uQWN0aW9u cygpOwogfQogCi12b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OnJlZ2lzdGVyRm9ySWNvbk5vdGlm aWNhdGlvbihib29sKQordm9pZCBGcmFtZUxvYWRlckNsaWVudFF0OjpyZWdpc3RlckZvckljb25O b3RpZmljYXRpb24oYm9vbCBzaG91bGRSZWdpc3RlcikKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgp OworI2lmIEVOQUJMRShJQ09OREFUQUJBU0UpCisgICAgaWYgKHNob3VsZFJlZ2lzdGVyKQorICAg ICAgICBjb25uZWN0KEljb25EYXRhYmFzZUNsaWVudFF0OjppbnN0YW5jZSgpLCBTSUdOQUwoaWNv bkxvYWRlZEZvclBhZ2VVUkwoUVN0cmluZykpLCB0aGlzLCBTTE9UKG9uSWNvbkxvYWRlZEZvclBh Z2VVUkwoUVN0cmluZykpLCBRdDo6VW5pcXVlQ29ubmVjdGlvbik7CisgICAgZWxzZQorICAgICAg ICBkaXNjb25uZWN0KEljb25EYXRhYmFzZUNsaWVudFF0OjppbnN0YW5jZSgpLCBTSUdOQUwoaWNv bkxvYWRlZEZvclBhZ2VVUkwoUVN0cmluZykpLCB0aGlzLCBTTE9UKG9uSWNvbkxvYWRlZEZvclBh Z2VVUkwoUVN0cmluZykpKTsKKyNlbmRpZgorfQorCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6 Om9uSWNvbkxvYWRlZEZvclBhZ2VVUkwoY29uc3QgUVN0cmluZyYgdXJsKQoreworI2lmIEVOQUJM RShJQ09OREFUQUJBU0UpCisgICAgaWYgKG1fd2ViRnJhbWUgJiYgbV93ZWJGcmFtZS0+dXJsKCkg PT0gdXJsKQorICAgICAgICBlbWl0IG1fd2ViRnJhbWUtPmljb25DaGFuZ2VkKCk7CisjZW5kaWYK IH0KIAorCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OnVwZGF0ZUdsb2JhbEhpc3RvcnkoKQog ewogICAgIFFXZWJIaXN0b3J5SW50ZXJmYWNlICpoaXN0b3J5ID0gUVdlYkhpc3RvcnlJbnRlcmZh Y2U6OmRlZmF1bHRJbnRlcmZhY2UoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5oIGIvU291cmNlL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmgKaW5kZXggZGI5NjRmYS4uM2VjNWYyMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudFF0LmgKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudFF0LmgKQEAgLTI1NSw2ICsyNTUsOSBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wg ZHVtcEhpc3RvcnlDYWxsYmFja3M7CiAgICAgc3RhdGljIFFNYXA8UVN0cmluZywgUVN0cmluZz4g VVJMc1RvUmVkaXJlY3Q7CiAKK3ByaXZhdGUgc2xvdHM6CisgICAgdm9pZCBvbkljb25Mb2FkZWRG b3JQYWdlVVJMKGNvbnN0IFFTdHJpbmcmKTsKKwogcHJpdmF0ZToKICAgICBGcmFtZSAqbV9mcmFt ZTsKICAgICBRV2ViRnJhbWUgKm1fd2ViRnJhbWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvSWNvbkRhdGFiYXNlQ2xpZW50UXQuY3BwCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmJhMDU1OWEKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3Vy Y2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNsaWVudFF0LmNwcApAQCAt MCwwICsxLDgyIEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDExIEFuZHJlYXMgS2xpbmcgPGts aW5nQHdlYmtpdC5vcmc+CisgKgorICogQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu CisgKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBh bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAq CisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIENPTVBVVEVSLCBJTkMuIGBg QVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVE SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1F UkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFS RSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgQ09NUFVURVIsIElOQy4gT1IK KyAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ REVOVEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMg KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhF T1JZCisgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5j bHVkZSAiSWNvbkRhdGFiYXNlQ2xpZW50UXQuaCIKKworI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xp ZW50UXQuaCIKKyNpbmNsdWRlICJJY29uRGF0YWJhc2VCYXNlLmgiCisjaW5jbHVkZSA8d3RmL3Rl eHQvQ1N0cmluZy5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK0ljb25EYXRhYmFzZUNsaWVu dFF0KiBJY29uRGF0YWJhc2VDbGllbnRRdDo6aW5zdGFuY2UoKQoreworICAgIHN0YXRpYyBJY29u RGF0YWJhc2VDbGllbnRRdCogY2xpZW50ID0gMDsKKyAgICBpZiAoIWNsaWVudCkgeworICAgICAg ICBjbGllbnQgPSBuZXcgSWNvbkRhdGFiYXNlQ2xpZW50UXQ7CisgICAgICAgIGljb25EYXRhYmFz ZSgpLnNldENsaWVudChjbGllbnQpOworICAgIH0KKyAgICByZXR1cm4gY2xpZW50OworfQorCitJ Y29uRGF0YWJhc2VDbGllbnRRdDo6SWNvbkRhdGFiYXNlQ2xpZW50UXQoKQoreworfQorCitJY29u RGF0YWJhc2VDbGllbnRRdDo6fkljb25EYXRhYmFzZUNsaWVudFF0KCkKK3sKK30KKworYm9vbCBJ Y29uRGF0YWJhc2VDbGllbnRRdDo6cGVyZm9ybUltcG9ydCgpCit7CisgICAgcmV0dXJuIHRydWU7 Cit9CisKK3ZvaWQgSWNvbkRhdGFiYXNlQ2xpZW50UXQ6OmRpZFJlbW92ZUFsbEljb25zKCkKK3sK K30KKwordm9pZCBJY29uRGF0YWJhc2VDbGllbnRRdDo6ZGlkSW1wb3J0SWNvblVSTEZvclBhZ2VV UkwoY29uc3QgU3RyaW5nJiB1cmwpCit7Cit9CisKK3ZvaWQgSWNvbkRhdGFiYXNlQ2xpZW50UXQ6 OmRpZEltcG9ydEljb25EYXRhRm9yUGFnZVVSTChjb25zdCBTdHJpbmcmIHVybCkKK3sKKyAgICBl bWl0IGljb25Mb2FkZWRGb3JQYWdlVVJMKHVybCk7Cit9CisKK3ZvaWQgSWNvbkRhdGFiYXNlQ2xp ZW50UXQ6OmRpZENoYW5nZUljb25Gb3JQYWdlVVJMKGNvbnN0IFN0cmluZyYgdXJsKQoreworfQor Cit2b2lkIEljb25EYXRhYmFzZUNsaWVudFF0OjpkaWRGaW5pc2hVUkxJbXBvcnQoKQoreworfQor Cit9CisKKyNpbmNsdWRlICJtb2NfSWNvbkRhdGFiYXNlQ2xpZW50UXQuY3BwIgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JY29uRGF0YWJhc2VDbGllbnRRdC5o IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JY29uRGF0YWJhc2VDbGllbnRRdC5o Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjM3ZGNkM2MKLS0tIC9kZXYvbnVs bAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNsaWVu dFF0LmgKQEAgLTAsMCArMSw1OSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMSBBbmRyZWFz IEtsaW5nIDxrbGluZ0B3ZWJraXQub3JnPgorICoKKyAqIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3Ry aWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAor ICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVw cm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNv bmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3Vt ZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmli dXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRF UiwgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFO VElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICog UFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVS LCBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJ UkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElB TCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5U IE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgor ICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQg T04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJ Q1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJX SVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisg Ki8KKworI2lmbmRlZiBJY29uRGF0YWJhc2VDbGllbnRRdF9oCisjZGVmaW5lIEljb25EYXRhYmFz ZUNsaWVudFF0X2gKKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkljb25EYXRhYmFz ZUNsaWVudC5oIgorI2luY2x1ZGUgPFF0Q29yZS9RT2JqZWN0PgorCituYW1lc3BhY2UgV2ViQ29y ZSB7CisKK2NsYXNzIEljb25EYXRhYmFzZUNsaWVudFF0IDogcHVibGljIFFPYmplY3QsIHB1Ymxp YyBJY29uRGF0YWJhc2VDbGllbnQgeworICAgIFFfT0JKRUNUCitwdWJsaWM6CisgICAgc3RhdGlj IEljb25EYXRhYmFzZUNsaWVudFF0KiBpbnN0YW5jZSgpOworCisgICAgdmlydHVhbCBib29sIHBl cmZvcm1JbXBvcnQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkUmVtb3ZlQWxsSWNvbnMoKTsKKyAg ICB2aXJ0dWFsIHZvaWQgZGlkSW1wb3J0SWNvblVSTEZvclBhZ2VVUkwoY29uc3QgU3RyaW5nJik7 CisgICAgdmlydHVhbCB2b2lkIGRpZEltcG9ydEljb25EYXRhRm9yUGFnZVVSTChjb25zdCBTdHJp bmcmKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlSWNvbkZvclBhZ2VVUkwoY29uc3QgU3Ry aW5nJik7CisgICAgdmlydHVhbCB2b2lkIGRpZEZpbmlzaFVSTEltcG9ydCgpOworCitzaWduYWxz OgorICAgIHZvaWQgaWNvbkxvYWRlZEZvclBhZ2VVUkwoY29uc3QgUVN0cmluZyYpOworCitwcml2 YXRlOgorICAgIEljb25EYXRhYmFzZUNsaWVudFF0KCk7CisgICAgdmlydHVhbCB+SWNvbkRhdGFi YXNlQ2xpZW50UXQoKTsKK307CisKK30KKworI2VuZGlmCg==