57151 2011-03-26 08:04:25 -0700 Fix compilation with Solaris 10/SunStudio 12 CC in Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp: ambiguity in ?: 2011-03-27 02:54:16 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 bentaylor.solx86 webkit-unassigned barraclough commit-queue eric oliver oldest_to_newest 373900 0 bentaylor.solx86 2011-03-26 08:04:25 -0700 in Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp on Solaris 10 with Sun Studio 12 CC, the compiler emits this error Error: Ambiguous "?:" expression, second operand of type "JSC::JSObject*" and third operand of type "JSC::JSValuePtr" can be converted to one another. This is from patch 14 of 17 by Thiago Macieria from bug https://bugs.webkit.org/show_bug.cgi?id=24932 373901 1 87025 bentaylor.solx86 2011-03-26 08:13:50 -0700 Created attachment 87025 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This is a update from patch 14 of 17 in bug https://bugs.webkit.org/show_bug.cgi?id=24932 done by Thiago Macieria. Compiles correctly on Solaris 10/Sun Studio 12 CC on qt-4.7.2 with webkit enabled. Patch is against webkit head. 374069 2 87025 oliver 2011-03-27 00:55:28 -0700 Comment on attachment 87025 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler r=me, i'm surprised this doesn't fail on other platforms as gcc, et all all seem finicky about ?: operator. Thanks for the patch. 374076 3 87025 eric 2011-03-27 01:06:04 -0700 Comment on attachment 87025 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler What's the ambiguity? 374077 4 eric 2011-03-27 01:06:21 -0700 I see. OK. 374091 5 87025 commit-queue 2011-03-27 02:54:12 -0700 Comment on attachment 87025 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 87025 Committed r82060: <http://trac.webkit.org/changeset/82060> 374092 6 commit-queue 2011-03-27 02:54:16 -0700 All reviewed patches have been landed. Closing bug. 87025 2011-03-26 08:13:50 -0700 2011-03-27 02:54:12 -0700 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-57151-bindings_js_JSJavaScriptCallFrameCustom.cpp.diff text/plain 1386 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyMDMwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMjYgIEJlbiBUYXls b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTcxNTEsIHBhdGNoIGRlcml2ZWQgZnJvbSBzZXQKKyAgICAgICAgY3JlYXRlZCBi eSBUaGlhZ28gTWFjaWVyaWEgaW4gYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNDkzMgorCisgICAgICAgIEZpeCBjb21waWxlIGlzc3VlIG9uIFNvbGFyaXMgMTAv U3VuIFN0dWRpbyAxMiByZWdhcmRpbmcgYW1iaWd1aXR5IG9uID86IGZ1bmN0aW9ucworCisgICAg ICAgICogYmluZGluZ3MvanMvSlNKYXZhU2NyaXB0Q2FsbEZyYW1lQ3VzdG9tLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkpTSmF2YVNjcmlwdENhbGxGcmFtZTo6dGhpc09iamVjdCk6CisKIDIwMTEt MDMtMjYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSmF2 YVNjcmlwdENhbGxGcmFtZUN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNKYXZhU2NyaXB0Q2FsbEZyYW1lQ3VzdG9tLmNwcAkocmV2aXNpb24gODE5 ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0phdmFTY3JpcHRDYWxsRnJhbWVD dXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw3ICs0OSw3IEBAIEpTVmFsdWUgSlNKYXZh U2NyaXB0Q2FsbEZyYW1lOjpldmFsdWF0ZSgKIAogSlNWYWx1ZSBKU0phdmFTY3JpcHRDYWxsRnJh bWU6OnRoaXNPYmplY3QoRXhlY1N0YXRlKikgY29uc3QKIHsKLSAgICByZXR1cm4gaW1wbCgpLT50 aGlzT2JqZWN0KCkgPyBpbXBsKCktPnRoaXNPYmplY3QoKSA6IGpzTnVsbCgpOworICAgIHJldHVy biBpbXBsKCktPnRoaXNPYmplY3QoKSA/IEpTVmFsdWUoaW1wbCgpLT50aGlzT2JqZWN0KCkpIDog anNOdWxsKCk7CiB9CiAKIEpTVmFsdWUgSlNKYXZhU2NyaXB0Q2FsbEZyYW1lOjp0eXBlKEV4ZWNT dGF0ZSogZXhlYykgY29uc3QK