57146 2011-03-26 02:02:51 -0700 We shouldn't bother running GYP if the generated files are newer than the GYP files 2011-03-26 07:39:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55018 1 abarth abarth commit-queue dglazkov eric oldest_to_newest 373881 0 abarth 2011-03-26 02:02:51 -0700 We shouldn't bother running GYP if the generated files are newer than the GYP files 373882 1 87022 abarth 2011-03-26 02:06:48 -0700 Created attachment 87022 Patch 373883 2 87022 eric 2011-03-26 02:29:19 -0700 Comment on attachment 87022 Patch Seems reasonable. 373898 3 87022 commit-queue 2011-03-26 07:39:04 -0700 Comment on attachment 87022 Patch Clearing flags on attachment: 87022 Committed r82030: <http://trac.webkit.org/changeset/82030> 373899 4 commit-queue 2011-03-26 07:39:08 -0700 All reviewed patches have been landed. Closing bug. 87022 2011-03-26 02:06:48 -0700 2011-03-26 07:39:04 -0700 Patch bug-57146-20110326020646.patch text/plain 4700 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogODIwMjUKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCA4NmQyMGUwYjE5ZjMzZDliZWNkNThlMDgyYTI4NDdjZTg3N2E4OWU2Li45MTU3 ZTE3Yjg3ZDc5MzA3MTVkYWVkMzZjZjFmNmJjNTQ5NjNhYjIwIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMjYgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBzaG91bGRuJ3QgYm90aGVyIHJ1bm5pbmcgR1lQIGlmIHRoZSBn ZW5lcmF0ZWQgZmlsZXMgYXJlIG5ld2VyIHRoYW4gdGhlIEdZUCBmaWxlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxNDYKKworICAgICAgICBJbiB0 aGUgY29tbW9uIGNhc2UsIHRoaXMgY2hlY2sgd2lsbCBhdm9pZCBhbnkgb3ZlcmhlYWQgZnJvbSBw cm9jZXNzaW5nCisgICAgICAgIHRoZSBHWVAgZmlsZXMuICBBbm90aGVyIGFwcHJvYWNoIHRvIGRv aW5nIHRoaXMgaXMgdG8gYWRkIHRoZSBmZWF0dXJlIHRvCisgICAgICAgIEdZUCBkaXJlY3RseSwg YnV0IEdZUCdzIGFwcHJvYWNoIHRvIHRoaXMgcHJvYmxlbSBpcyB0byBjb21wdXRlIHRoZQorICAg ICAgICBvdXRwdXQgaW4gaXRzIGVudGlyZXR5IGFuZCBjb21wYXJlIGl0IGJ5dGUtZm9yLWJ5dGUg YWdhaW5zdCB0aGUgb3V0cHV0CisgICAgICAgIGZpbGUuICBJbiB0aGUgZnV0dXJlLCBpdCBtaWdo dCBtYWtlIHNlbnNlIHRvIGFkZCB0aGlzIGFwcHJvYWNoIGFzIGFuCisgICAgICAgIGFsdGVybmF0 aXZlIGFwcHJvYWNoIGZvciBHWVAgaXRzZWxmLgorCisgICAgICAgIEkgYWxzbyByZW1vdmVkIEph dmFTY3JpcHRHbHVlIGZyb20gdGhlIHNjcmlwdCBiZWNhdXNlIHdlJ3JlIG5vdCByZWFsbHkKKyAg ICAgICAgZ29pbmcgdG8gY2hhbmdlIEphdmFTY3JpcHRHbHVlIG92ZXIgdG8gR1lQLiAgV2Ugd2Vy ZSB1c2luZworICAgICAgICBKYXZhU2NyaXB0R2x1ZSBhcyBhIGxlYXJuaW5nIGV4cGVyaWVuY2Uu CisKKyAgICAgICAgKiBTb3VyY2UvZ3lwL2NvbmZpZ3VyZToKKwogMjAxMS0wMy0yNSAgS2V2aW4g T2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIEJ1aWxk IGZpeCwgZG9uJ3QgdXNlIHRoZSBuZXcgRlBEIGltcGxlbWVudGF0aW9uIHlldCwgdW50aWwgd2Ug Y2FuIG1lcmdlIG91cnMgd2l0aCBpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9neXAvY29uZmlndXJl IGIvU291cmNlL2d5cC9jb25maWd1cmUKaW5kZXggODRhOTg1Y2M1MzNhYjI1YTI0OWI3OTNkM2Q2 ZmIzZWQ5ZjJjMDljMy4uMjhkNjY3NzA3NzMzMjA2ZWI3YmUxZGY1YmI5ZjJlNjc3OTI2ZWZkMyAx MDA3NTUKLS0tIGEvU291cmNlL2d5cC9jb25maWd1cmUKKysrIGIvU291cmNlL2d5cC9jb25maWd1 cmUKQEAgLTMxLDM1ICszMSw4NSBAQAogaW1wb3J0IG9zCiBpbXBvcnQgc3VicHJvY2VzcwogCitm cm9tIG9wdHBhcnNlIGltcG9ydCBPcHRpb25QYXJzZXIKIAotUFJPSkVDVFMgPSBbCi0gICAgIkph dmFTY3JpcHRHbHVlIiwKLSAgICAiSmF2YVNjcmlwdENvcmUiLAotICAgICJXZWJDb3JlIiwKLV0K K2RlZiBjaGRpcl90b19zb3VyY2UoKToKKyAgICBzb3VyY2VfZGlyZWN0b3J5ID0gb3MucGF0aC5h YnNwYXRoKG9zLnBhdGguam9pbihfX2ZpbGVfXywgJy4uJywgJy4uJykpCisgICAgb3MuY2hkaXIo c291cmNlX2RpcmVjdG9yeSkKKworZGVmIGd5cCgpOgorICAgIHJldHVybiBvcy5wYXRoLmpvaW4o J1RoaXJkUGFydHknLCAnZ3lwJywgJ2d5cCcpCiAKK2NsYXNzIFByb2plY3Q6CisgICAgZGVmIF9f aW5pdF9fKHNlbGYsIG5hbWUpOgorICAgICAgICBzZWxmLl9uYW1lID0gbmFtZQogCi1kZWYgY3Jl YXRlX3Byb2plY3QocHJvamVjdCk6Ci0gICAgc3VicHJvY2Vzcy5jYWxsKFsKLSAgICAgICAgb3Mu cGF0aC5qb2luKCdUaGlyZFBhcnR5JywgJ2d5cCcsICdneXAnKSwKLSAgICAgICAgb3MucGF0aC5q b2luKHByb2plY3QsICdneXAnLCBwcm9qZWN0ICsgJy5neXAnKSwKLSAgICAgICAgJy1HJywKLSAg ICAgICAgJ3hjb2RlX2xpc3RfZXhjbHVkZWRfZmlsZXM9MCcsCi0gICAgICAgICctLWRlcHRoPS4n LAotICAgIF0pCisgICAgZGVmIG5hbWUoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLl9uYW1l CiAKKyAgICBkZWYgaW5wdXRzKHNlbGYpOgorICAgICAgICByZXR1cm4gWworICAgICAgICAgICAg b3MucGF0aC5qb2luKHNlbGYuX25hbWUsICdneXAnLCBzZWxmLl9uYW1lICsgJy5neXAnKSwKKyAg ICAgICAgICAgIG9zLnBhdGguam9pbihzZWxmLl9uYW1lLCBzZWxmLl9uYW1lICsgJy5neXBpJyks CisgICAgICAgICAgICBvcy5wYXRoLmpvaW4oJ2d5cCcsICdjb21tb24uZ3lwaScpLAorICAgICAg ICBdCiAKLWRlZiBjcmVhdGVfYWxsX3Byb2plY3RzKCk6Ci0gICAgZm9yIHByb2plY3QgaW4gUFJP SkVDVFM6Ci0gICAgICAgIGNyZWF0ZV9wcm9qZWN0KHByb2plY3QpCisgICAgZGVmIG91dHB1dChz ZWxmKToKKyAgICAgICAgcmV0dXJuIG9zLnBhdGguam9pbihzZWxmLl9uYW1lLCAnZ3lwJywgc2Vs Zi5fbmFtZSArICcueGNvZGVwcm9qJywgJ3Byb2plY3QucGJ4cHJvaicpCiAKKyAgICBkZWYgc2hv dWxkX2dlbmVyYXRlKHNlbGYpOgorICAgICAgICBpZiBub3Qgb3MucGF0aC5leGlzdHMoc2VsZi5v dXRwdXQoKSk6CisgICAgICAgICAgICByZXR1cm4gVHJ1ZQorICAgICAgICByZXR1cm4gb3MucGF0 aC5nZXRtdGltZShzZWxmLm91dHB1dCgpKSA8IHNlbGYuX25ld2VzdChzZWxmLmlucHV0cygpKQor CisgICAgZGVmIGdlbmVyYXRlKHNlbGYpOgorICAgICAgICBzdWJwcm9jZXNzLmNhbGwoWworICAg ICAgICAgICAgZ3lwKCksCisgICAgICAgICAgICBzZWxmLmlucHV0cygpWzBdLAorICAgICAgICAg ICAgJy1HJywKKyAgICAgICAgICAgICd4Y29kZV9saXN0X2V4Y2x1ZGVkX2ZpbGVzPTAnLAorICAg ICAgICAgICAgJy0tZGVwdGg9LicsCisgICAgICAgIF0pCisgICAgICAgICMgR1lQIGRvZXNuJ3Qg YWx3YXlzIHRvdWNoIHRoZSBvdXRwdXQgZmlsZSwgYnV0IHdlIHdhbnQgdG8gdG91Y2ggdGhlCisg ICAgICAgICMgZmlsZSBzbyB0aGF0IHdlIGRvbid0IGtlZXAgdHJ5aW5nIHRvIHJlZ2VuZXJhdGUg aXQuCisgICAgICAgIG9zLnV0aW1lKHNlbGYub3V0cHV0KCksIE5vbmUpCisKKyAgICBAc3RhdGlj bWV0aG9kCisgICAgZGVmIF9uZXdlc3QocGF0aHMpOgorICAgICAgICByZXR1cm4gbWF4KFtvcy5w YXRoLmdldG10aW1lKHBhdGgpIGZvciBwYXRoIGluIHBhdGhzXSkKKworUFJPSkVDVFMgPSBbCisg ICAgUHJvamVjdCgiSmF2YVNjcmlwdENvcmUiKSwKKyAgICBQcm9qZWN0KCJXZWJDb3JlIiksCitd CisKK2RlZiBwcm9qZWN0c190b19nZW5lcmF0ZSgpOgorICAgIHNob3VsZF9nZW5lcmF0ZSA9IFtw cm9qZWN0IGZvciBwcm9qZWN0IGluIFBST0pFQ1RTIGlmIHByb2plY3Quc2hvdWxkX2dlbmVyYXRl KCldCisgICAgYWxyZWFkeV9nZW5lcmF0ZWQgPSBbcHJvamVjdC5uYW1lKCkgZm9yIHByb2plY3Qg aW4gc2V0KFBST0pFQ1RTKSAtIHNldChzaG91bGRfZ2VuZXJhdGUpXQorCisgICAgaWYgYWxyZWFk eV9nZW5lcmF0ZWQ6CisgICAgICAgIHByaW50ICJOb3QgZ2VuZXJhdGluZyAlcyBiZWNhdXNlIHRo ZSBnZW5lcmF0ZWQgZmlsZXMgZXhpc3QgYW5kIGFyZSBuZXdlciB0aGFuIHRoZSBHWVAgZmlsZXMu IiAlICcsICcuam9pbihhbHJlYWR5X2dlbmVyYXRlZCkKKyAgICAgICAgcHJpbnQgIlBhc3MgLS1y ZWdlbmVyYXRlLXByb2plY3RzIHRvIG92ZXJyaWRlLiIKKworICAgIHJldHVybiBzaG91bGRfZ2Vu ZXJhdGUKIAogZGVmIG1haW4oKToKLSAgICBzb3VyY2VfZGlyZWN0b3J5ID0gb3MucGF0aC5hYnNw YXRoKG9zLnBhdGguam9pbihfX2ZpbGVfXywgJy4uJywgJy4uJykpCi0gICAgb3MuY2hkaXIoc291 cmNlX2RpcmVjdG9yeSkKKyAgICBjaGRpcl90b19zb3VyY2UoKQorCisgICAgcGFyc2VyID0gT3B0 aW9uUGFyc2VyKCkKICAgICAjIEZJWE1FOiBUaGUgdXNlciBzaG91bGQgYmUgYWJsZSB0byBwYXNz IHdoaWNoIHBvcnQgb24gdGhlIGNvbW1hbmQgbGluZS4KLSAgICBjcmVhdGVfYWxsX3Byb2plY3Rz KCkKKyAgICBwYXJzZXIuYWRkX29wdGlvbigiLS1yZWdlbmVyYXRlLXByb2plY3RzIiwgZGVzdD0i cmVnZW5lcmF0ZV9wcm9qZWN0cyIsCisgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdD1GYWxz ZSwgYWN0aW9uPSJzdG9yZV90cnVlIiwKKyAgICAgICAgICAgICAgICAgICAgICBoZWxwPSJHZW5l cmF0ZSBhbGwgcHJvamVjdCBmaWxlcyBldmVuIGlmIHRoZXkgYXBwZWFyIHRvIGJlIHVwIHRvIGRh dGUuIikKKyAgICAob3B0aW9ucywgYXJncykgPSBwYXJzZXIucGFyc2VfYXJncygpCisKKyAgICBw cm9qZWN0cyA9IFBST0pFQ1RTCisgICAgaWYgbm90IG9wdGlvbnMucmVnZW5lcmF0ZV9wcm9qZWN0 czoKKyAgICAgICAgcHJvamVjdHMgPSBwcm9qZWN0c190b19nZW5lcmF0ZSgpCiAKKyAgICBmb3Ig cHJvamVjdCBpbiBwcm9qZWN0czoKKyAgICAgICAgcHJpbnQgIkdlbmVyYXRpbmcgJXMuIiAlIHBy b2plY3QubmFtZSgpCisgICAgICAgIHByb2plY3QuZ2VuZXJhdGUoKQogCiBpZiBfX25hbWVfXyA9 PSAiX19tYWluX18iOgogICAgIG1haW4oKQo=