<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>57128</bug_id>
          
          <creation_ts>2011-03-25 15:15:43 -0700</creation_ts>
          <short_desc>[CMake] Generate WebKitVersion.h</short_desc>
          <delta_ts>2011-03-27 10:25:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>57175</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Patrick R. Gansterer">paroga</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>pkasting</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>373750</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-03-25 15:15:43 -0700</bug_when>
    <thetext>see patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>373751</commentid>
    <comment_count>1</comment_count>
      <attachid>86986</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-03-25 15:22:46 -0700</bug_when>
    <thetext>Created attachment 86986
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>374151</commentid>
    <comment_count>2</comment_count>
      <attachid>86986</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-03-27 09:10:46 -0700</bug_when>
    <thetext>Comment on attachment 86986
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>374166</commentid>
    <comment_count>3</comment_count>
      <attachid>86986</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-03-27 10:25:06 -0700</bug_when>
    <thetext>Comment on attachment 86986
Patch

Clearing flags on attachment: 86986

Committed r82069: &lt;http://trac.webkit.org/changeset/82069&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>374167</commentid>
    <comment_count>4</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-03-27 10:25:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>86986</attachid>
            <date>2011-03-25 15:22:46 -0700</date>
            <delta_ts>2011-03-27 10:25:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-57128.patch</filename>
            <type>text/plain</type>
            <size>1493</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv
cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggYzc4YWZjNC4uYjRkMDQ1YyAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0
cy50eHQKQEAgLTIxMDYsNiArMjEwNiwxNiBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMg
JHtERVJJVkVEX1NPVVJDRVNfRElSfS9YTUxOU05hbWVzLmNwcCkKIEdFTkVSQVRFX0RPTV9OQU1F
UyhYTUwgJHtXRUJDT1JFX0RJUn0veG1sL3htbGF0dHJzLmluKQogTElTVChBUFBFTkQgV2ViQ29y
ZV9TT1VSQ0VTICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vWE1MTmFtZXMuY3BwKQogCisKK0FERF9D
VVNUT01fQ09NTUFORCgKKyAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9XZWJLaXRW
ZXJzaW9uLmgKKyAgICBNQUlOX0RFUEVOREVOQ1kgJHtXRUJLSVRfRElSfS9zY3JpcHRzL2dlbmVy
YXRlLXdlYmtpdHZlcnNpb24ucGwKKyAgICBERVBFTkRTICR7V0VCS0lUX0RJUn0vbWFjL0NvbmZp
Z3VyYXRpb25zL1ZlcnNpb24ueGNjb25maWcKKyAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxF
fSAke1dFQktJVF9ESVJ9L3NjcmlwdHMvZ2VuZXJhdGUtd2Via2l0dmVyc2lvbi5wbCAtLWNvbmZp
ZyAke1dFQktJVF9ESVJ9L21hYy9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnIC0tb3V0
cHV0RGlyICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0KKyAgICBWRVJCQVRJTSkKK0xJU1QoQVBQRU5E
IFdlYkNvcmVfU09VUkNFUyAke0RFUklWRURfU09VUkNFU19ESVJ9L1dlYktpdFZlcnNpb24uaCkK
KworCiBTRVQoV2ViQ29yZV9MSUJSQVJJRVMKICAgICAke0phdmFTY3JpcHRDb3JlX0xJQlJBUllf
TkFNRX0KICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X
ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NDQyNjU1Li45NDRhOTk0IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTQgQEAKKzIwMTEtMDMtMjUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp
dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W0NNYWtlXSBHZW5lcmF0ZSBXZWJLaXRWZXJzaW9uLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MTI4CisKKyAgICAgICAgVGhpcyBmaWxlIHdpbGwg
YmUgdXNlZCBmb3IgdGhlIHVzZXIgYWdlbnQgc3RyaW5nIGJ5IHRoZSBDTWFrZSBiYXNlZCBwb3J0
cy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDExLTAzLTI1ICBUb255IENoYW5n
ICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0aGUgY2hyb21pdW0g
bWFjIGJ1aWxkLgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>