57125 2011-03-25 14:53:47 -0700 Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms 2011-03-25 17:03:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm abarth eric webkit.review.bot oldest_to_newest 373736 0 jeffm 2011-03-25 14:53:47 -0700 Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific. 373740 1 86985 jeffm 2011-03-25 14:59:47 -0700 Created attachment 86985 Patch 373773 2 jeffm 2011-03-25 16:15:19 -0700 Committed r82002: <http://trac.webkit.org/changeset/82002> 373794 3 webkit.review.bot 2011-03-25 17:03:50 -0700 http://trac.webkit.org/changeset/82002 might have broken Leopard Intel Release (Tests) 86985 2011-03-25 14:59:47 -0700 2011-03-25 15:28:17 -0700 Patch bug-57125-20110325145944.patch text/plain 6180 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxOTkxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMjUgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBDb3JlSVBDOjplbmNvZGVSZXNvdXJjZUVycm9yKCkgYW5kIENv cmVJUEM6OmRlY29kZVJlc291cmNlRXJyb3IoKSBmb3IgYWxsIHBsYXRmb3JtcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxMjUKKyAgICAgICAgCisg ICAgICAgIEN1cnJlbnRseSwgdGhlc2UgYXJlIG9ubHkgaW1wbGVtZW50ZWQgb24gdGhlIE1hYywg YnV0IHdlJ3JlIGdvaW5nIHRvIG5lZWQgdGhlbSBmb3IgV2luZG93cyBhcyB3ZWxsLCBzbyB3ZSBt aWdodCBhcyB3ZWxsIG1ha2UgdGhlbSBhbHdheXMgcGxhdGZvcm0tc3BlY2lmaWMuCisgICAgICAg IEluIHRoaXMgcGF0Y2gsIGp1c3QgcmVwbGljYXRlIHRoZSBleGlzdGluZyBjb21tb24gbm9uLU1h YyBpbXBsZW1lbnRhdGlvbiBpbiBXZWJDb3JlQXJndW1lbnRDb2RlcnMuaCB0byBwbGF0Zm9ybS1z cGVjaWZpYyBmaWxlcy4KKworICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMu aDogTW92ZSBub24tTWFjIGltcGxlbWVudGF0aW9ucyBvZiBlbmNvZGVSZXNvdXJjZUVycm9yKCkg YW5kIGRlY29kZVJlc291cmNlRXJyb3IoKSB0byBjb21tb24gZmlsZXMuCisgICAgICAgICogU2hh cmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwOgorICAgICAgICAoQ29yZUlQQzo6 ZW5jb2RlUmVzb3VyY2VFcnJvcik6IEFkZGVkLgorICAgICAgICAoQ29yZUlQQzo6ZGVjb2RlUmVz b3VyY2VFcnJvcik6IEFkZGVkLgorICAgICAgICAqIFNoYXJlZC9xdC9XZWJDb3JlQXJndW1lbnRD b2RlcnNRdC5jcHA6CisgICAgICAgIChDb3JlSVBDOjplbmNvZGVSZXNvdXJjZUVycm9yKTogQWRk ZWQuCisgICAgICAgIChDb3JlSVBDOjpkZWNvZGVSZXNvdXJjZUVycm9yKTogQWRkZWQuCisgICAg ICAgICogU2hhcmVkL3dpbi9XZWJDb3JlQXJndW1lbnRDb2RlcnNXaW4uY3BwOgorICAgICAgICAo Q29yZUlQQzo6ZW5jb2RlUmVzb3VyY2VFcnJvcik6IEFkZGVkLgorICAgICAgICAoQ29yZUlQQzo6 ZGVjb2RlUmVzb3VyY2VFcnJvcik6IEFkZGVkLgorCiAyMDExLTAzLTI1ICBTdGV2ZSBGYWxrZW5i dXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJpYW4gV2Vp bnN0ZWluLgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVy cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRD b2RlcnMuaAkocmV2aXNpb24gODE5ODYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29y ZUFyZ3VtZW50Q29kZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI3NywzNiArMjc3LDE5IEBAIHRl bXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8V2ViQ29yZToKICAgICB9CiB9OwogCi0jaWYg UExBVEZPUk0oTUFDKQogLy8gVGhlc2UgdHdvIGZ1bmN0aW9ucyBhcmUgaW1wbGVtZW50ZWQgaW4g YSBwbGF0Zm9ybSBzcGVjaWZpYyBtYW5uZXIuCiB2b2lkIGVuY29kZVJlc291cmNlRXJyb3IoQXJn dW1lbnRFbmNvZGVyKiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpOwogYm9vbCBkZWNv ZGVSZXNvdXJjZUVycm9yKEFyZ3VtZW50RGVjb2RlciosIFdlYkNvcmU6OlJlc291cmNlRXJyb3Im KTsKLSNlbmRpZgogCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OlJl c291cmNlRXJyb3I+IHsKICAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyKiBl bmNvZGVyLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJiByZXNvdXJjZUVycm9yKQogICAg IHsKLSNpZiBQTEFURk9STShNQUMpCiAgICAgICAgIGVuY29kZVJlc291cmNlRXJyb3IoZW5jb2Rl ciwgcmVzb3VyY2VFcnJvcik7Ci0jZWxzZQotICAgICAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQ Qzo6SW4ocmVzb3VyY2VFcnJvci5kb21haW4oKSwgcmVzb3VyY2VFcnJvci5lcnJvckNvZGUoKSwg cmVzb3VyY2VFcnJvci5mYWlsaW5nVVJMKCksIHJlc291cmNlRXJyb3IubG9jYWxpemVkRGVzY3Jp cHRpb24oKSkpOwotI2VuZGlmCiAgICAgfQogICAgIAogICAgIHN0YXRpYyBib29sIGRlY29kZShB cmd1bWVudERlY29kZXIqIGRlY29kZXIsIFdlYkNvcmU6OlJlc291cmNlRXJyb3ImIHJlc291cmNl RXJyb3IpCiAgICAgewotI2lmIFBMQVRGT1JNKE1BQykKICAgICAgICAgcmV0dXJuIGRlY29kZVJl c291cmNlRXJyb3IoZGVjb2RlciwgcmVzb3VyY2VFcnJvcik7Ci0jZWxzZQotICAgICAgICBTdHJp bmcgZG9tYWluOwotICAgICAgICBpbnQgZXJyb3JDb2RlOwotICAgICAgICBTdHJpbmcgZmFpbGlu Z1VSTDsKLSAgICAgICAgU3RyaW5nIGxvY2FsaXplZERlc2NyaXB0aW9uOwotICAgICAgICBpZiAo IWRlY29kZXItPmRlY29kZShDb3JlSVBDOjpPdXQoZG9tYWluLCBlcnJvckNvZGUsIGZhaWxpbmdV UkwsIGxvY2FsaXplZERlc2NyaXB0aW9uKSkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgICAgIHJlc291cmNlRXJyb3IgPSBXZWJDb3JlOjpSZXNvdXJjZUVycm9yKGRvbWFpbiwgZXJy b3JDb2RlLCBmYWlsaW5nVVJMLCBsb2NhbGl6ZWREZXNjcmlwdGlvbik7Ci0gICAgICAgIHJldHVy biB0cnVlOwotI2VuZGlmCiAgICAgfQogfTsKIApJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVk L2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9ndGsvV2ViQ29yZUFyZ3VtZW50Q29kZXJzR3RrLmNwcAkocmV2aXNpb24g ODE5ODYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkNvcmVBcmd1bWVudENvZGVy c0d0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDQgKzYxLDIxIEBAIGJvb2wgZGVjb2RlUmVz b3VyY2VSZXNwb25zZShBcmd1bWVudERlY28KICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9pZCBl bmNvZGVSZXNvdXJjZUVycm9yKEFyZ3VtZW50RW5jb2RlciogZW5jb2RlciwgY29uc3QgV2ViQ29y ZTo6UmVzb3VyY2VFcnJvciYgcmVzb3VyY2VFcnJvcikKK3sKKyAgICBlbmNvZGVyLT5lbmNvZGUo Q29yZUlQQzo6SW4ocmVzb3VyY2VFcnJvci5kb21haW4oKSwgcmVzb3VyY2VFcnJvci5lcnJvckNv ZGUoKSwgcmVzb3VyY2VFcnJvci5mYWlsaW5nVVJMKCksIHJlc291cmNlRXJyb3IubG9jYWxpemVk RGVzY3JpcHRpb24oKSkpOworfQorCitib29sIGRlY29kZVJlc291cmNlRXJyb3IoQXJndW1lbnRE ZWNvZGVyKiBkZWNvZGVyLCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJiByZXNvdXJjZUVycm9yKQor eworICAgIFN0cmluZyBkb21haW47CisgICAgaW50IGVycm9yQ29kZTsKKyAgICBTdHJpbmcgZmFp bGluZ1VSTDsKKyAgICBTdHJpbmcgbG9jYWxpemVkRGVzY3JpcHRpb247CisgICAgaWYgKCFkZWNv ZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0KGRvbWFpbiwgZXJyb3JDb2RlLCBmYWlsaW5nVVJMLCBs b2NhbGl6ZWREZXNjcmlwdGlvbikpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmVzb3Vy Y2VFcnJvciA9IFdlYkNvcmU6OlJlc291cmNlRXJyb3IoZG9tYWluLCBlcnJvckNvZGUsIGZhaWxp bmdVUkwsIGxvY2FsaXplZERlc2NyaXB0aW9uKTsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogfQpJ bmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkNvcmVBcmd1bWVudENvZGVyc1F0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvV2ViQ29yZUFyZ3VtZW50 Q29kZXJzUXQuY3BwCShyZXZpc2lvbiA4MTk4NikKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9x dC9XZWJDb3JlQXJndW1lbnRDb2RlcnNRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDQgKzYw LDIxIEBAIGJvb2wgZGVjb2RlUmVzb3VyY2VSZXNwb25zZShBcmd1bWVudERlY28KICAgICByZXR1 cm4gdHJ1ZTsKIH0KIAordm9pZCBlbmNvZGVSZXNvdXJjZUVycm9yKEFyZ3VtZW50RW5jb2Rlciog ZW5jb2RlciwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYgcmVzb3VyY2VFcnJvcikKK3sK KyAgICBlbmNvZGVyLT5lbmNvZGUoQ29yZUlQQzo6SW4ocmVzb3VyY2VFcnJvci5kb21haW4oKSwg cmVzb3VyY2VFcnJvci5lcnJvckNvZGUoKSwgcmVzb3VyY2VFcnJvci5mYWlsaW5nVVJMKCksIHJl c291cmNlRXJyb3IubG9jYWxpemVkRGVzY3JpcHRpb24oKSkpOworfQorCitib29sIGRlY29kZVJl c291cmNlRXJyb3IoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVyLCBXZWJDb3JlOjpSZXNvdXJjZUVy cm9yJiByZXNvdXJjZUVycm9yKQoreworICAgIFN0cmluZyBkb21haW47CisgICAgaW50IGVycm9y Q29kZTsKKyAgICBTdHJpbmcgZmFpbGluZ1VSTDsKKyAgICBTdHJpbmcgbG9jYWxpemVkRGVzY3Jp cHRpb247CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoQ29yZUlQQzo6T3V0KGRvbWFpbiwgZXJy b3JDb2RlLCBmYWlsaW5nVVJMLCBsb2NhbGl6ZWREZXNjcmlwdGlvbikpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgcmVzb3VyY2VFcnJvciA9IFdlYkNvcmU6OlJlc291cmNlRXJyb3IoZG9t YWluLCBlcnJvckNvZGUsIGZhaWxpbmdVUkwsIGxvY2FsaXplZERlc2NyaXB0aW9uKTsKKyAgICBy ZXR1cm4gdHJ1ZTsKK30KKwogfSAvLyBuYW1lc3BhY2UgQ29yZUlQQwpJbmRleDogU291cmNlL1dl YktpdDIvU2hhcmVkL3dpbi9XZWJDb3JlQXJndW1lbnRDb2RlcnNXaW4uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC93aW4vV2ViQ29yZUFyZ3VtZW50Q29kZXJzV2luLmNw cAkocmV2aXNpb24gODE5ODYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvd2luL1dlYkNvcmVB cmd1bWVudENvZGVyc1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNyw0ICsxMTcsMjEgQEAg Ym9vbCBkZWNvZGVSZXNvdXJjZVJlc3BvbnNlKEFyZ3VtZW50RGVjbwogI2VuZGlmCiB9CiAKK3Zv aWQgZW5jb2RlUmVzb3VyY2VFcnJvcihBcmd1bWVudEVuY29kZXIqIGVuY29kZXIsIGNvbnN0IFdl YkNvcmU6OlJlc291cmNlRXJyb3ImIHJlc291cmNlRXJyb3IpCit7CisgICAgZW5jb2Rlci0+ZW5j b2RlKENvcmVJUEM6OkluKHJlc291cmNlRXJyb3IuZG9tYWluKCksIHJlc291cmNlRXJyb3IuZXJy b3JDb2RlKCksIHJlc291cmNlRXJyb3IuZmFpbGluZ1VSTCgpLCByZXNvdXJjZUVycm9yLmxvY2Fs aXplZERlc2NyaXB0aW9uKCkpKTsKK30KKworYm9vbCBkZWNvZGVSZXNvdXJjZUVycm9yKEFyZ3Vt ZW50RGVjb2RlciogZGVjb2RlciwgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYgcmVzb3VyY2VFcnJv cikKK3sKKyAgICBTdHJpbmcgZG9tYWluOworICAgIGludCBlcnJvckNvZGU7CisgICAgU3RyaW5n IGZhaWxpbmdVUkw7CisgICAgU3RyaW5nIGxvY2FsaXplZERlc2NyaXB0aW9uOworICAgIGlmICgh ZGVjb2Rlci0+ZGVjb2RlKENvcmVJUEM6Ok91dChkb21haW4sIGVycm9yQ29kZSwgZmFpbGluZ1VS TCwgbG9jYWxpemVkRGVzY3JpcHRpb24pKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJl c291cmNlRXJyb3IgPSBXZWJDb3JlOjpSZXNvdXJjZUVycm9yKGRvbWFpbiwgZXJyb3JDb2RlLCBm YWlsaW5nVVJMLCBsb2NhbGl6ZWREZXNjcmlwdGlvbik7CisgICAgcmV0dXJuIHRydWU7Cit9CisK IH0gLy8gbmFtZXNwYWNlIENvcmVJUEMK