57119 2011-03-25 13:39:07 -0700 Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll 2011-05-11 09:30:44 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sfalken webkit-unassigned aroben bweinstein oldest_to_newest 373703 0 sfalken 2011-03-25 13:39:07 -0700 Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll. This DLL links against a Firefox-specific library, and should be blacklisted, since this library won't be present in WebKit. 373704 1 sfalken 2011-03-25 13:39:48 -0700 Plug-in DLL name is: NPWPF.DLL. We should just blacklist by DLL name. 373705 2 sfalken 2011-03-25 13:42:06 -0700 <rdar://problem/9054148> 373714 3 86979 sfalken 2011-03-25 13:52:15 -0700 Created attachment 86979 Patch 373719 4 86979 bweinstein 2011-03-25 13:55:55 -0700 Comment on attachment 86979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86979&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=57119 Radar link? > Source/WebCore/plugins/win/PluginPackageWin.cpp:78 > + // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll It might be nice to say that this is a Mozilla only DLL. > Source/WebKit2/ChangeLog:7 > + Ditto about radar link. > Source/WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp:364 > + // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll Ditto about Mozilla-only DLL. 373720 5 sfalken 2011-03-25 14:05:39 -0700 Committed r81989: <http://trac.webkit.org/changeset/81989> 402042 6 aroben 2011-05-11 09:30:44 -0700 Looks like this patch wasn't quite right. See bug 60633. 86979 2011-03-25 13:52:15 -0700 2011-03-25 13:55:55 -0700 Patch bug-57119-20110325135144.patch text/plain 3029 sfalken SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxOTg4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjUgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNaWNyb3NvZnQgV2luZG93cyBQcmVzZW50YXRpb24gRm91 bmRhdGlvbiAoV1BGKSBwbHVnLWluIGNvbXBsYWlucyBhYm91dCBtaXNzaW5nIHhwY29tLmRsbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxMTkKKwor ICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblBhY2thZ2VXaW4uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGx1Z2luUGFja2FnZTo6aXNQbHVnaW5CbGFja2xpc3RlZCk6IEJsYWNrbGlzdCBucHdw Zi5kbGwuCisKIDIwMTEtMDMtMjUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBUcnkgdG8gZml4IHRoZSBjaHJvbWl1bSBtYWMgYnVpbGQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcAkocmV2aXNpb24g ODE4NzkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsOSBAQCBib29sIFBsdWdpblBhY2thZ2U6Omlz UGx1Z2luQmxhY2tsaXN0ZWQoCiAgICAgfSBlbHNlIGlmIChmaWxlTmFtZSgpID09ICJucG1vemF4 LmRsbCIpIHsKICAgICAgICAgLy8gQnVnIDE1MjE3OiBNb3ppbGxhIEFjdGl2ZVggY29udHJvbCBj b21wbGFpbnMgYWJvdXQgbWlzc2luZyB4cGNvbV9jb3JlLmRsbAogICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICB9IGVsc2UgaWYgKGZpbGVOYW1lKCkgPT0gIm5wd3BmLmRsbCIpIHsKKyAgICAgICAg Ly8gQnVnIDU3MTE5OiBNaWNyb3NvZnQgV2luZG93cyBQcmVzZW50YXRpb24gRm91bmRhdGlvbiAo V1BGKSBwbHVnLWluIGNvbXBsYWlucyBhYm91dCBtaXNzaW5nIHhwY29tLmRsbAorICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9IGVsc2UgaWYgKG5hbWUoKSA9PSAiWWFob28gQXBwbGljYXRpb24g U3RhdGUgUGx1Z2luIikgewogICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjY4NjAKICAgICAgICAgLy8gQnVnIGluIFlhaG9vIEFwcGxpY2F0aW9uIFN0 YXRlIHBsdWctaW4gZWFybGllciB0aGFuIDEuMC4wLjYgbGVhZHMgdG8gaGVhcCBjb3JydXB0aW9u LiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxOTg4KQorKysgU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjUgIFN0ZXZl IEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaWNyb3NvZnQgV2luZG93cyBQcmVzZW50YXRpb24g Rm91bmRhdGlvbiAoV1BGKSBwbHVnLWluIGNvbXBsYWlucyBhYm91dCBtaXNzaW5nIHhwY29tLmRs bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcxMTkK KworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL3dpbi9QbHVnaW5JbmZvU3RvcmVXaW4uY3Bw OgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5JbmZvU3RvcmU6OnNob3VsZFVzZVBsdWdpbik6IEJs YWNrbGlzdCBucHdwZi5kbGwuCisKIDIwMTEtMDMtMjUgIEplc3NpZSBCZXJsaW4gIDxqYmVybGlu QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvd2luL1BsdWdpbkluZm9TdG9yZVdpbi5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvd2luL1BsdWdp bkluZm9TdG9yZVdpbi5jcHAJKHJldmlzaW9uIDgxODc5KQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1BsdWdpbnMvd2luL1BsdWdpbkluZm9TdG9yZVdpbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM2MCw2ICszNjAsMTEgQEAgYm9vbCBQbHVnaW5JbmZvU3RvcmU6OnNob3VsZFVzZVBsdWdp bihjbwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCisgICAgaWYgKGVxdWFsSWdub3Jp bmdDYXNlKHBsdWdpbi5pbmZvLmZpbGUsICJucHdwZi5kbGwiKSkgeworICAgICAgICAvLyBCdWcg NTcxMTk6IE1pY3Jvc29mdCBXaW5kb3dzIFByZXNlbnRhdGlvbiBGb3VuZGF0aW9uIChXUEYpIHBs dWctaW4gY29tcGxhaW5zIGFib3V0IG1pc3NpbmcgeHBjb20uZGxsCisgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICB9CisKICAgICBpZiAocGx1Z2luLmluZm8ubmFtZSA9PSAiWWFob28gQXBwbGlj YXRpb24gU3RhdGUgUGx1Z2luIikgewogICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY4NjAKICAgICAgICAgLy8gQnVnIGluIFlhaG9vIEFwcGxpY2F0 aW9uIFN0YXRlIHBsdWctaW4gZWFybGllciB0aGFuIDEuMC4wLjYgbGVhZHMgdG8gaGVhcCBjb3Jy dXB0aW9uLgo=