57102 2011-03-25 07:07:20 -0700 [Qt] Get rid of the invalid string conversion with ::fromAscii() 2011-03-25 09:47:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED EasyFix, Qt, QtTriaged P2 Normal --- 1 benjamin benjamin abarth benjamin commit-queue eric kling webkit.review.bot oldest_to_newest 373486 0 benjamin 2011-03-25 07:07:20 -0700 QString/QChar::fromAscii() is almost never correct inside a library. This call use the default codec, not the ascii one. 373497 1 86936 benjamin 2011-03-25 07:37:28 -0700 Created attachment 86936 Patch Uploaded manually, webkit-patch exploded in one thousand sparkling pieces for some reason. 373501 2 86936 kling 2011-03-25 07:41:36 -0700 Comment on attachment 86936 Patch em=r 373512 3 86936 commit-queue 2011-03-25 08:02:53 -0700 Comment on attachment 86936 Patch Clearing flags on attachment: 86936 Committed r81961: <http://trac.webkit.org/changeset/81961> 373513 4 commit-queue 2011-03-25 08:02:58 -0700 All reviewed patches have been landed. Closing bug. 373564 5 webkit.review.bot 2011-03-25 09:47:59 -0700 http://trac.webkit.org/changeset/81961 might have broken Windows 7 Release (Tests) The following tests are not passing: http/tests/websocket/tests/frame-length-skip.html 86936 2011-03-25 07:37:28 -0700 2011-03-25 08:02:53 -0700 Patch 57102.diff text/plain 3618 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NWVjYWIwLi5kNmQ4YmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjUgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIEdldCByaWQgb2YgdGhlIGludmFsaWQgc3RyaW5nIGNvbnZlcnNpb24gd2l0aCA6OmZyb21B c2NpaSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzEwMgorCisgICAgICAgIFJlcGxhY2UgOjpmcm9tQXNjaWkoKSB3aXRoIDo6ZnJvbUxhdGluMSgp IHRvIG1ha2Ugc3VyZSB0aGUgY29kZWMgZG9lcyBub3QgZGVwZW5kIG9uIHRoZSB1c2VyIGNvZGUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpzZW5kUmVzcG9uc2VJ Zk5lZWRlZCk6CisgICAgICAgICogcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Y29va2llcyk6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVSZXF1ZXN0SGVh ZGVyRmllbGRWYWx1ZSk6CisKIDIwMTEtMDMtMTUgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5 SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmNwcAppbmRleCBjMmJmMTYzLi5lNzE3ZTU4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcApAQCAtMzgyLDcgKzM4Miw3IEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnNl bmRSZXNwb25zZUlmTmVlZGVkKCkKICAgICBpbnQgc3RhdHVzQ29kZSA9IG1fcmVwbHktPmF0dHJp YnV0ZShRTmV0d29ya1JlcXVlc3Q6Okh0dHBTdGF0dXNDb2RlQXR0cmlidXRlKS50b0ludCgpOwog CiAgICAgaWYgKHVybC5wcm90b2NvbEluSFRUUEZhbWlseSgpKSB7Ci0gICAgICAgIFN0cmluZyBz dWdnZXN0ZWRGaWxlbmFtZSA9IGZpbGVuYW1lRnJvbUhUVFBDb250ZW50RGlzcG9zaXRpb24oUVN0 cmluZzo6ZnJvbUFzY2lpKG1fcmVwbHktPnJhd0hlYWRlcigiQ29udGVudC1EaXNwb3NpdGlvbiIp KSk7CisgICAgICAgIFN0cmluZyBzdWdnZXN0ZWRGaWxlbmFtZSA9IGZpbGVuYW1lRnJvbUhUVFBD b250ZW50RGlzcG9zaXRpb24oUVN0cmluZzo6ZnJvbUxhdGluMShtX3JlcGx5LT5yYXdIZWFkZXIo IkNvbnRlbnQtRGlzcG9zaXRpb24iKSkpOwogCiAgICAgICAgIGlmICghc3VnZ2VzdGVkRmlsZW5h bWUuaXNFbXB0eSgpKQogICAgICAgICAgICAgcmVzcG9uc2Uuc2V0U3VnZ2VzdGVkRmlsZW5hbWUo c3VnZ2VzdGVkRmlsZW5hbWUpOwpAQCAtMzk0LDcgKzM5NCw3IEBAIHZvaWQgUU5ldHdvcmtSZXBs eUhhbmRsZXI6OnNlbmRSZXNwb25zZUlmTmVlZGVkKCkKIAogICAgICAgICAvLyBBZGQgcmVtYWlu aW5nIGhlYWRlcnMuCiAgICAgICAgIGZvcmVhY2ggKGNvbnN0IFFOZXR3b3JrUmVwbHk6OlJhd0hl YWRlclBhaXImIHBhaXIsIG1fcmVwbHktPnJhd0hlYWRlclBhaXJzKCkpCi0gICAgICAgICAgICBy ZXNwb25zZS5zZXRIVFRQSGVhZGVyRmllbGQoUVN0cmluZzo6ZnJvbUFzY2lpKHBhaXIuZmlyc3Qp LCBRU3RyaW5nOjpmcm9tQXNjaWkocGFpci5zZWNvbmQpKTsKKyAgICAgICAgICAgIHJlc3BvbnNl LnNldEhUVFBIZWFkZXJGaWVsZChRU3RyaW5nOjpmcm9tTGF0aW4xKHBhaXIuZmlyc3QpLCBRU3Ry aW5nOjpmcm9tTGF0aW4xKHBhaXIuc2Vjb25kKSk7CiAgICAgfQogCiAgICAgUVVybCByZWRpcmVj dGlvbiA9IG1fcmVwbHktPmF0dHJpYnV0ZShRTmV0d29ya1JlcXVlc3Q6OlJlZGlyZWN0aW9uVGFy Z2V0QXR0cmlidXRlKS50b1VybCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vcXQvQ29va2llSmFyUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2ll SmFyUXQuY3BwCmluZGV4IGRiNGE0MmEuLjNjNGNkNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3F0L0Nvb2tpZUphclF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTkxLDggKzkxLDcgQEAgU3RyaW5nIGNvb2tpZXMo Y29uc3QgRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBLVVJMJiB1cmwpCiAgICAgZm9yZWFjaCAo UU5ldHdvcmtDb29raWUgbmV0d29ya0Nvb2tpZSwgY29va2llcykgewogICAgICAgICBpZiAobmV0 d29ya0Nvb2tpZS5pc0h0dHBPbmx5KCkpCiAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg cmVzdWx0Q29va2llcy5hcHBlbmQoUVN0cmluZzo6ZnJvbUFzY2lpKAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBuZXR3b3JrQ29va2llLnRvUmF3Rm9ybShRTmV0d29ya0Nvb2tpZTo6TmFt ZUFuZFZhbHVlT25seSkuY29uc3REYXRhKCkpKTsKKyAgICAgICAgcmVzdWx0Q29va2llcy5hcHBl bmQoUVN0cmluZzo6ZnJvbUxhdGluMShuZXR3b3JrQ29va2llLnRvUmF3Rm9ybShRTmV0d29ya0Nv b2tpZTo6TmFtZUFuZFZhbHVlT25seSkuY29uc3REYXRhKCkpKTsKICAgICB9CiAKICAgICByZXR1 cm4gcmVzdWx0Q29va2llcy5qb2luKFFMYXRpbjFTdHJpbmcoIjsgIikpOwpAQCAtMTEwLDEwICsx MDksOCBAQCBTdHJpbmcgY29va2llUmVxdWVzdEhlYWRlckZpZWxkVmFsdWUoY29uc3QgRG9jdW1l bnQqIGRvY3VtZW50LCBjb25zdCBLVVJMICZ1cmwpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsK IAogICAgIFFTdHJpbmdMaXN0IHJlc3VsdENvb2tpZXM7Ci0gICAgZm9yZWFjaCAoUU5ldHdvcmtD b29raWUgbmV0d29ya0Nvb2tpZSwgY29va2llcykgewotICAgICAgICByZXN1bHRDb29raWVzLmFw cGVuZChRU3RyaW5nOjpmcm9tQXNjaWkoCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5l dHdvcmtDb29raWUudG9SYXdGb3JtKFFOZXR3b3JrQ29va2llOjpOYW1lQW5kVmFsdWVPbmx5KS5j b25zdERhdGEoKSkpOwotICAgIH0KKyAgICBmb3JlYWNoIChRTmV0d29ya0Nvb2tpZSBuZXR3b3Jr Q29va2llLCBjb29raWVzKQorICAgICAgICByZXN1bHRDb29raWVzLmFwcGVuZChRU3RyaW5nOjpm cm9tTGF0aW4xKG5ldHdvcmtDb29raWUudG9SYXdGb3JtKFFOZXR3b3JrQ29va2llOjpOYW1lQW5k VmFsdWVPbmx5KS5jb25zdERhdGEoKSkpOwogCiAgICAgcmV0dXJuIHJlc3VsdENvb2tpZXMuam9p bihRTGF0aW4xU3RyaW5nKCI7ICIpKTsKIH0K