57099 2011-03-25 06:23:32 -0700 Web Inspector: [Chromium] Clearing CPU profiles and heap snapshots doesn't release memory allocated for their native implementations 2011-03-28 05:26:36 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 373472 0 mnaganov 2011-03-25 06:23:32 -0700 For heap snapshots this means that page retains sufficient amount of memory after snapshots were cleared on Inspector's UI. 373475 1 86929 mnaganov 2011-03-25 06:26:28 -0700 Created attachment 86929 patch 374419 2 mnaganov 2011-03-28 05:26:36 -0700 Manually committed http://trac.webkit.org/changeset/82108 2011-03-28 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal. https://bugs.webkit.org/show_bug.cgi?id=57099 * bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot): * bindings/v8/ScriptHeapSnapshot.h: * bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::~ScriptProfile): * bindings/v8/ScriptProfile.h: * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): 86929 2011-03-25 06:26:28 -0700 2011-03-28 05:19:46 -0700 patch patch-57099 text/plain 3316 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NWVjYWIwLi4wMzdmOWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDMtMjUgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJJbnNw ZWN0b3I6IFtDaHJvbWl1bV0gRGVsZXRlIG5hdGl2ZSBDUFUgcHJvZmlsZXMgYW5kIGhlYXAgc25h cHNob3RzIG9uIGJpbmRpbmcgZGlzcG9zYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NzA5OQorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0 SGVhcFNuYXBzaG90LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEhlYXBTbmFwc2hvdDo6 flNjcmlwdEhlYXBTbmFwc2hvdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0SGVhcFNu YXBzaG90Lmg6CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JpcHRQcm9maWxlOjp+U2NyaXB0UHJvZmlsZSk6CisgICAgICAgICog YmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5oOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JQcm9maWxlckFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVy QWdlbnQ6OnJlc2V0U3RhdGUpOgorCiAyMDExLTAzLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEhlYXBTbmFwc2hv dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRIZWFwU25hcHNob3QuY3Bw CmluZGV4IDA5ZTFlNTQuLmQxMDU0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdEhlYXBTbmFwc2hvdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0SGVhcFNuYXBzaG90LmNwcApAQCAtNDAsNiArNDAsMTEgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCitTY3JpcHRIZWFwU25hcHNob3Q6On5TY3JpcHRIZWFwU25hcHNob3Qo KQoreworICAgIGNvbnN0X2Nhc3Q8djg6OkhlYXBTbmFwc2hvdCo+KG1fc25hcHNob3QpLT5EZWxl dGUoKTsKK30KKwogU3RyaW5nIFNjcmlwdEhlYXBTbmFwc2hvdDo6dGl0bGUoKSBjb25zdAogewog ICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdEhlYXBTbmFwc2hvdC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0SGVhcFNuYXBzaG90LmgKaW5kZXggNmNmZDc2ZC4uZmRkMDllMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0SGVhcFNuYXBzaG90LmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0SGVhcFNuYXBzaG90LmgKQEAgLTU0LDcg KzU0LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTY3Jp cHRIZWFwU25hcHNob3Qoc25hcHNob3QpKTsKICAgICB9Ci0gICAgdmlydHVhbCB+U2NyaXB0SGVh cFNuYXBzaG90KCkge30KKyAgICB2aXJ0dWFsIH5TY3JpcHRIZWFwU25hcHNob3QoKTsKIAogICAg IFN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAgIHVuc2lnbmVkIGludCB1aWQoKSBjb25zdDsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAKaW5kZXggYzVhNmRi Zi4uMmM5ZjBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 UHJvZmlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmls ZS5jcHAKQEAgLTM5LDYgKzM5LDExIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorU2NyaXB0 UHJvZmlsZTo6flNjcmlwdFByb2ZpbGUoKQoreworICAgIGNvbnN0X2Nhc3Q8djg6OkNwdVByb2Zp bGUqPihtX3Byb2ZpbGUpLT5EZWxldGUoKTsKK30KKwogU3RyaW5nIFNjcmlwdFByb2ZpbGU6OnRp dGxlKCkgY29uc3QKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmggYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmgKaW5kZXggMDE4MjY2OS4uZDgxOTZhNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaApAQCAtNDgsNyArNDgs NyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNjcmlwdFBy b2ZpbGUocHJvZmlsZSkpOwogICAgIH0KLSAgICB2aXJ0dWFsIH5TY3JpcHRQcm9maWxlKCkge30K KyAgICB2aXJ0dWFsIH5TY3JpcHRQcm9maWxlKCk7CiAKICAgICBTdHJpbmcgdGl0bGUoKSBjb25z dDsKICAgICB1bnNpZ25lZCBpbnQgdWlkKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKaW5kZXggMjZhZmM3My4uNjU0 NGZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2Zp bGVyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9m aWxlckFnZW50LmNwcApAQCAtMjUwLDYgKzI1MCw3IEBAIHZvaWQgSW5zcGVjdG9yUHJvZmlsZXJB Z2VudDo6cmVtb3ZlUHJvZmlsZShFcnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgdHlwZSwgdW5z CiAKIHZvaWQgSW5zcGVjdG9yUHJvZmlsZXJBZ2VudDo6cmVzZXRTdGF0ZSgpCiB7CisgICAgc3Rv cFVzZXJJbml0aWF0ZWRQcm9maWxpbmcoKTsKICAgICBtX3Byb2ZpbGVzLmNsZWFyKCk7CiAgICAg bV9zbmFwc2hvdHMuY2xlYXIoKTsKICAgICBtX2N1cnJlbnRVc2VySW5pdGlhdGVkUHJvZmlsZU51 bWJlciA9IDE7Cg==