57097 2011-03-25 05:54:28 -0700 [Chromium] Add CGBitmapContext.h include to WebViewImpl.cpp 2011-03-25 12:12:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 caryclark webkit-unassigned commit-queue oldest_to_newest 373463 0 caryclark 2011-03-25 05:54:28 -0700 In the Chrome tree, removing '#import ApplicationServices.h' from skia/ext/platform_device_mac.h avoids header conflicts, but causes WebKit/chromium/src/WebViewImpl.cpp to fail, since it refers to CGBitmapContextGetHeight(). Adding #include CGBitmapContext.h to WebViewImpl.cpp fixes this. 373506 1 86939 caryclark 2011-03-25 07:57:11 -0700 Created attachment 86939 patch to add include 373509 2 caryclark 2011-03-25 07:59:10 -0700 This patch is in support of http://codereview.chromium.org/6732027/ 373533 3 86939 dglazkov 2011-03-25 08:48:29 -0700 Comment on attachment 86939 patch to add include View in context: https://bugs.webkit.org/attachment.cgi?id=86939&action=review seems easy-peasy enough :) But the ChangeLog needs to tweakage. > Source/WebKit/chromium/ChangeLog:3 > + Reviewed by ? Please leave this line alone. It should say OOPS, that's being used by webkit-patch for landing. 373621 4 86962 caryclark 2011-03-25 11:26:24 -0700 Created attachment 86962 patch with correctly generated ChangeLog 373624 5 86962 dglazkov 2011-03-25 11:28:22 -0700 Comment on attachment 86962 patch with correctly generated ChangeLog great! Also useful is the --request-commit flag in the webkit-patch. It allows you to request the patch to be landed by a commit-queue. 373658 6 86962 commit-queue 2011-03-25 12:12:45 -0700 Comment on attachment 86962 patch with correctly generated ChangeLog Clearing flags on attachment: 86962 Committed r81979: <http://trac.webkit.org/changeset/81979> 373659 7 commit-queue 2011-03-25 12:12:50 -0700 All reviewed patches have been landed. Closing bug. 86939 2011-03-25 07:57:11 -0700 2011-03-25 11:26:24 -0700 patch to add include patch57097.txt text/plain 1046 caryclark SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTk2MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjUgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSA/CisKKyAgICAgICAgQWRkIENHQml0bWFwQ29udGV4dC5oIGluY2x1 ZGUgdG8gV2ViVmlld0ltcGwuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NzA5NworICAgICAgICAKKyAgICAgICAgTm8gdGVzdHMuIEV4cG9zZXMg bm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisgICAgICAgIAorICAgICAgICAqIHNyYy9XZWJWaWV3SW1w bC5jcHA6CisKIDIwMTEtMDMtMjUgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSb2xsIGZvcndhcmQgQ2hyb21pdW0gZGVwcyB0byByNzkzNzkgdG8g cGljayB1cCBWOCAzLjIuNC4yLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAkocmV2aXNpb24gODE5NjApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNiw2ICsxMjYsNyBAQAog I2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAogI2lmIFBMQVRGT1JNKENHKQorI2luY2x1ZGUgPENv cmVHcmFwaGljcy9DR0JpdG1hcENvbnRleHQuaD4KICNpbmNsdWRlIDxDb3JlR3JhcGhpY3MvQ0dD b250ZXh0Lmg+CiAjZW5kaWYKIAo= 86962 2011-03-25 11:26:24 -0700 2011-03-25 12:12:45 -0700 patch with correctly generated ChangeLog patch57097.txt text/plain 1006 caryclark SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTk3MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjUgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQ0dCaXRtYXBD b250ZXh0LmggaW5jbHVkZSB0byBXZWJWaWV3SW1wbC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MDk3CisgICAgICAgIAorICAgICAgICBObyB0 ZXN0cy4gRXhwb3NlcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHNyYy9XZWJW aWV3SW1wbC5jcHA6CisKIDIwMTEtMDMtMjUgIENoYW5nIFNodSAgPGNzaHVAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCkluZGV4OiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA4MTk2MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTI2LDYgKzEyNiw3IEBACiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiAjaWYgUExBVEZPUk0o Q0cpCisjaW5jbHVkZSA8Q29yZUdyYXBoaWNzL0NHQml0bWFwQ29udGV4dC5oPgogI2luY2x1ZGUg PENvcmVHcmFwaGljcy9DR0NvbnRleHQuaD4KICNlbmRpZgogCg==