57095 2011-03-25 05:39:40 -0700 [Qt] The keyboard shortcuts during fullscreen playback do not work. 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED Qt, QtTriaged P1 Major --- 1 menard menard abarth commit-queue eric webkit.review.bot oldest_to_newest 373452 0 menard 2011-03-25 05:39:40 -0700 Launch QtTestBrowser, go to tiny.cc/wkmedia. Play a video, enter fullscreen. Pressing esc does not quit the fullscreen mode, pressing space does nothing. But if you click and then use the shortcuts it works. 373453 1 86923 menard 2011-03-25 05:42:50 -0700 Created attachment 86923 Proposed patch. 373454 2 86924 menard 2011-03-25 05:44:12 -0700 Created attachment 86924 V2 with better changelog. 373456 3 86924 kling 2011-03-25 05:46:02 -0700 Comment on attachment 86924 V2 with better changelog. LGTM 373487 4 86924 commit-queue 2011-03-25 07:15:39 -0700 Comment on attachment 86924 V2 with better changelog. Clearing flags on attachment: 86924 Committed r81959: <http://trac.webkit.org/changeset/81959> 373488 5 commit-queue 2011-03-25 07:15:44 -0700 All reviewed patches have been landed. Closing bug. 373562 6 webkit.review.bot 2011-03-25 09:47:50 -0700 http://trac.webkit.org/changeset/81959 might have broken Windows 7 Release (Tests) The following tests are not passing: http/tests/websocket/tests/frame-length-skip.html 86923 2011-03-25 05:42:50 -0700 2011-03-25 05:44:12 -0700 Proposed patch. patch.diff text/plain 1229 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYzI2NzRjNC4uOGVlYjlkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMS0wMy0yNSAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIFRoZSBrZXlib2FyZCBzaG9ydGN1dHMgZHVyaW5nIGZ1bGxzY3JlZW4gcGxheWJh Y2sgZG8gbm90IHdvcmsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzA5NQorCisgICAgICAgIFdlIG5lZWQgdG8gZXhwbGljaXRlbHkgc2V0IHRoZSBm b2N1cyBvbiB0aGUgd2lkZ2V0IGluIG9yZGVyIGZvciBpdCB0byByZWNlaXZlIHRoZSBrZXlib2Fy ZCBldmVudHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GdWxsU2NyZWVuVmlkZW9XaWRn ZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnVsbFNjcmVlblZpZGVvV2lkZ2V0OjpzaG93KToK KwogMjAxMS0wMy0yMiAgQW5kcmV3IFdhc29uICA8cmVjdGFsb2dpY0ByZWN0YWxvZ2ljLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQb3VsYWluLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GdWxsU2NyZWVuVmlkZW9XaWRnZXQuY3BwIGIv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GdWxsU2NyZWVuVmlkZW9XaWRnZXQuY3Bw CmluZGV4IGE2OTk4ZTIuLmJiNWUyYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnVsbFNjcmVlblZpZGVvV2lkZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0Z1bGxTY3JlZW5WaWRlb1dpZGdldC5jcHAKQEAgLTY2LDYgKzY2 LDcgQEAgdm9pZCBGdWxsU2NyZWVuVmlkZW9XaWRnZXQ6OnNob3coUU1lZGlhUGxheWVyKiBwbGF5 ZXIpCiAgICAgc2V0TW91c2VUcmFja2luZyh0cnVlKTsKICAgICByYWlzZSgpOwogICAgIG1fbWVk aWFQbGF5ZXItPnNldFZpZGVvT3V0cHV0KHRoaXMpOworICAgIHNldEZvY3VzKCk7CiAgICAgZ3Jh Yk1vdXNlKCk7CiAgICAgaGlkZUN1cnNvcigpOwogfQo= 86924 2011-03-25 05:44:12 -0700 2011-03-25 07:15:39 -0700 V2 with better changelog. patch.diff text/plain 1222 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYzI2NzRjNC4uZjU1YjQzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMS0wMy0yNSAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIFRoZSBrZXlib2FyZCBzaG9ydGN1dHMgZHVyaW5nIGZ1bGxzY3JlZW4gcGxheWJh Y2sgZG8gbm90IHdvcmsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzA5NQorCisgICAgICAgIFdlIG5lZWQgdG8gZXhwbGljaXRlbHkgc2V0IHRoZSBm b2N1cyBvbiB0aGUgd2lkZ2V0IGluIG9yZGVyIHRvIHJlY2VpdmUgdGhlIGtleWJvYXJkIGV2ZW50 cy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Z1bGxTY3JlZW5WaWRlb1dpZGdldC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGdWxsU2NyZWVuVmlkZW9XaWRnZXQ6OnNob3cpOgorCiAyMDEx LTAzLTIyICBBbmRyZXcgV2Fzb24gIDxyZWN0YWxvZ2ljQHJlY3RhbG9naWMuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Z1bGxTY3JlZW5WaWRlb1dpZGdldC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Z1bGxTY3JlZW5WaWRlb1dpZGdldC5jcHAKaW5kZXgg YTY5OThlMi4uYmI1ZTJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9GdWxsU2NyZWVuVmlkZW9XaWRnZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnVsbFNjcmVlblZpZGVvV2lkZ2V0LmNwcApAQCAtNjYsNiArNjYsNyBAQCB2 b2lkIEZ1bGxTY3JlZW5WaWRlb1dpZGdldDo6c2hvdyhRTWVkaWFQbGF5ZXIqIHBsYXllcikKICAg ICBzZXRNb3VzZVRyYWNraW5nKHRydWUpOwogICAgIHJhaXNlKCk7CiAgICAgbV9tZWRpYVBsYXll ci0+c2V0VmlkZW9PdXRwdXQodGhpcyk7CisgICAgc2V0Rm9jdXMoKTsKICAgICBncmFiTW91c2Uo KTsKICAgICBoaWRlQ3Vyc29yKCk7CiB9Cg==