57091 2011-03-25 00:28:02 -0700 <keygen> does not support autofocus 2011-03-25 01:18:55 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 dominicc webkit-unassigned commit-queue oldest_to_newest 373379 0 dominicc 2011-03-25 00:28:02 -0700 The keygen element does not support the autofocus attribute. When a keygen element has the autofocus attribute, it does not automatically get focus. 373381 1 86905 dominicc 2011-03-25 00:31:12 -0700 Created attachment 86905 Patch 373383 2 86905 tkent 2011-03-25 00:44:06 -0700 Comment on attachment 86905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86905&action=review > LayoutTests/fast/forms/autofocus-keygen.html:16 > + shouldBe('focusedElement', 'document.querySelector("keygen")'); I think document.activeElement works instead of focusedElement. > LayoutTests/fast/forms/autofocus-keygen.html:23 > +successfullyParsed = true; > +</script> > +</head> > +<body onload="onLoad();"> This doesn't follow usual style of our layout tests. Please do: - remove layoutTestController.dumpAsText() in the second <script> - add window.jsTestisAsync = true in the second <script> - add finishJSTest() at the bottom of onLoad() - add <script> for js/resources/js-test-post.js at the bottom of <body> 373386 3 86907 dominicc 2011-03-25 00:52:50 -0700 Created attachment 86907 Patch 373387 4 86907 tkent 2011-03-25 00:55:10 -0700 Comment on attachment 86907 Patch ok 373392 5 86907 commit-queue 2011-03-25 01:18:50 -0700 Comment on attachment 86907 Patch Clearing flags on attachment: 86907 Committed r81947: <http://trac.webkit.org/changeset/81947> 373393 6 commit-queue 2011-03-25 01:18:55 -0700 All reviewed patches have been landed. Closing bug. 86905 2011-03-25 00:31:12 -0700 2011-03-25 00:52:45 -0700 Patch bug-57091-20110325163109.patch text/plain 3588 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjYjk0YTY4NmEwZTEzMjZhOTQ0MWRl MDFhOGZlYjRkNDlhZGViZWRhLi45ZTQ2N2VhZDUyYzc0YTY3YmI0NjQ3MmQyZjQzY2RhYjhiOGM4 YzNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjUgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRzIGEgcmVncmVzc2lvbiB0ZXN0IGZvciBrZXlnZW4gYXV0b2ZvY3Vz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwOTEK KworICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi5odG1sOiBBZGRlZC4K KwogMjAxMS0wMy0yNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIHNvbWUgZmxha3kgdGVzdHMgdG8gdGhlIG1hYy13azIgYW5kIHdpbi13azIgU2tpcHBlZCBm aWxlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2Vu LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjIzNTE5NWY1ZGQzZTE3ZDkwMjFiM2U0OTcwZWQzMGZl NzEwODE2YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2Zv Y3VzLWtleWdlbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACisKK1RoaXMgdGVzdHMgd2hl dGhlciB0aGUga2V5Z2VuIGVsZW1lbnQgc3VwcG9ydHMgdGhlIGF1dG9mb2N1cyBhdHRyaWJ1dGUu CisKK1BBU1MgZm9jdXNlZEVsZW1lbnQgaXMgZG9jdW1lbnQucXVlcnlTZWxlY3Rvcigia2V5Z2Vu IikKK1BBU1MgZG9jdW1lbnQucXVlcnlTZWxlY3Rvcigia2V5Z2VuIikuYXV0b2ZvY3VzIGlzIHRy dWUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2Vu Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1rZXlnZW4uaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5kN2ZkNzVkYTMyYjI2NjU2NmExN2UxYzI0YzUwZGI5YmQ1ZmI2MGQxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2VuLmh0bWwK QEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlw dCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0 PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisKK3ZhciBmb2N1c2VkRWxlbWVudDsKKworZnVuY3Rpb24gb25G b2N1cyhldmVudCkgeworICAgIGZvY3VzZWRFbGVtZW50ID0gZXZlbnQudGFyZ2V0OworfQorCitm dW5jdGlvbiBvbkxvYWQoKSB7CisgICAgc2hvdWxkQmUoJ2ZvY3VzZWRFbGVtZW50JywgJ2RvY3Vt ZW50LnF1ZXJ5U2VsZWN0b3IoImtleWdlbiIpJyk7CisgICAgc2hvdWxkQmUoJ2RvY3VtZW50LnF1 ZXJ5U2VsZWN0b3IoImtleWdlbiIpLmF1dG9mb2N1cycsICd0cnVlJyk7Cit9CisKK3N1Y2Nlc3Nm dWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ib25M b2FkKCk7Ij4KKzxrZXlnZW4gYXV0b2ZvY3VzIG9uZm9jdXM9Im9uRm9jdXMoZXZlbnQpOyI+Cis8 cHJlIGlkPSJjb25zb2xlIj4KK1RoaXMgdGVzdHMgd2hldGhlciB0aGUga2V5Z2VuIGVsZW1lbnQg c3VwcG9ydHMgdGhlIGF1dG9mb2N1cyBhdHRyaWJ1dGUuCisKKzwvcHJlPgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDg4NDliM2NiOTdiNmUyODU0NTQ0OTIyYmI2MjUwNTc2NmIwYzEy M2MuLmUwZGNhYjljYTZmMTIwOTU1YWVkYjMwYmE5MWRkZjA1ZDkwMjQ3MDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMy0yNSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2VzIGtleWdlbiBzdXBwb3J0IGF1dG9mb2N1cyBhdHRyaWJ1dGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzA5MQorCisgICAgICAgIFRl c3Q6IGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi5odG1sCisKKyAgICAgICAgKiBodG1sL0hU TUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1Db250 cm9sRWxlbWVudDo6YXR0YWNoKToKKwogMjAxMS0wMy0yNCAgRGltaXRyaSBHbGF6a292ICA8ZGds YXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXgg NGIzYzQ4YTk5NTI1NDcxMjMwYzIxNTEzNDlhMmEzOTRkYTU3MTZjOS4uZjMzYzViYTE3ZGEyZDc1 MzRmODA1NjJiOGM3OWQyZWNlYzc4ZGMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBIVE1MRm9y bUNvbnRyb2xFbGVtZW50OjphdHRhY2goKQogCiAgICAgaWYgKGF1dG9mb2N1cygpICYmIHJlbmRl cmVyKCkgJiYgIWRvY3VtZW50KCktPmlnbm9yZUF1dG9mb2N1cygpICYmICFpc1JlYWRPbmx5Rm9y bUNvbnRyb2woKSAmJgogICAgICAgICAgICAgKChoYXNUYWdOYW1lKGlucHV0VGFnKSAmJiAhaXNJ bnB1dFR5cGVIaWRkZW4pIHx8IGhhc1RhZ05hbWUoc2VsZWN0VGFnKSB8fAotICAgICAgICAgICAg ICBoYXNUYWdOYW1lKGJ1dHRvblRhZykgfHwgaGFzVGFnTmFtZSh0ZXh0YXJlYVRhZykpKQorICAg ICAgICAgICAgICBoYXNUYWdOYW1lKGtleWdlblRhZykgfHwgaGFzVGFnTmFtZShidXR0b25UYWcp IHx8IGhhc1RhZ05hbWUodGV4dGFyZWFUYWcpKSkKICAgICAgICAgIGZvY3VzKCk7CiB9CiAK 86907 2011-03-25 00:52:50 -0700 2011-03-25 01:18:50 -0700 Patch bug-57091-20110325165248.patch text/plain 3551 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjYjk0YTY4NmEwZTEzMjZhOTQ0MWRl MDFhOGZlYjRkNDlhZGViZWRhLi45ZTQ2N2VhZDUyYzc0YTY3YmI0NjQ3MmQyZjQzY2RhYjhiOGM4 YzNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMjUgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRzIGEgcmVncmVzc2lvbiB0ZXN0IGZvciBrZXlnZW4gYXV0b2ZvY3Vz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwOTEK KworICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi5odG1sOiBBZGRlZC4K KwogMjAxMS0wMy0yNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIHNvbWUgZmxha3kgdGVzdHMgdG8gdGhlIG1hYy13azIgYW5kIHdpbi13azIgU2tpcHBlZCBm aWxlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2Vu LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWtleWdlbi1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzE0Mzc0ZDBkYjgwMjlkMzc1NWNjYzhjNTljYzRiMmQ1 MjEwMGFkYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2Zv Y3VzLWtleWdlbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACisKK1RoaXMgdGVzdHMgd2hl dGhlciB0aGUga2V5Z2VuIGVsZW1lbnQgc3VwcG9ydHMgdGhlIGF1dG9mb2N1cyBhdHRyaWJ1dGUu CisKK1BBU1MgZG9jdW1lbnQuYWN0aXZlRWxlbWVudCBpcyBkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCJrZXlnZW4iKQorUEFTUyBkb2N1bWVudC5hY3RpdmVFbGVtZW50LmF1dG9mb2N1cyBpcyB0cnVl CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2VuLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1rZXlnZW4uaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4w OGIzNDY4Zjg5ZDA2MTY2MzIwMmI3OTBlY2E5ZjFiMTdlNTlmNDM5Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2VuLmh0bWwKQEAgLTAsMCAr MSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0Pgord2luZG93 LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlvbiBvbkxvYWQoKSB7CisgICAgc2hvdWxk QmUoJ2RvY3VtZW50LmFjdGl2ZUVsZW1lbnQnLCAnZG9jdW1lbnQucXVlcnlTZWxlY3Rvcigia2V5 Z2VuIiknKTsKKyAgICBzaG91bGRCZSgnZG9jdW1lbnQuYWN0aXZlRWxlbWVudC5hdXRvZm9jdXMn LCAndHJ1ZScpOworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCitzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9Im9uTG9hZCgpOyI+Cis8 a2V5Z2VuIGF1dG9mb2N1cz4KKzxwcmUgaWQ9ImNvbnNvbGUiPgorVGhpcyB0ZXN0cyB3aGV0aGVy IHRoZSBrZXlnZW4gZWxlbWVudCBzdXBwb3J0cyB0aGUgYXV0b2ZvY3VzIGF0dHJpYnV0ZS4KKwor PC9wcmU+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODg0OWIzY2I5N2I2ZTI4NTQ1 NDQ5MjJiYjYyNTA1NzY2YjBjMTIzYy4uZTBkY2FiOWNhNmYxMjA5NTVhZWRiMzBiYTkxZGRmMDVk OTAyNDcwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAzLTI1ICBEb21pbmlj IENvb25leSAgPGRvbWluaWNjQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZXMga2V5Z2VuIHN1cHBvcnQgYXV0b2ZvY3VzIGF0 dHJpYnV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU3MDkxCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9hdXRvZm9jdXMta2V5Z2VuLmh0bWwK KworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjphdHRhY2gpOgorCiAyMDExLTAzLTI0ICBE aW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRy b2xFbGVtZW50LmNwcAppbmRleCA0YjNjNDhhOTk1MjU0NzEyMzBjMjE1MTM0OWEyYTM5NGRhNTcx NmM5Li5mMzNjNWJhMTdkYTJkNzUzNGY4MDU2MmI4Yzc5ZDJlY2VjNzhkYzExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKQEAgLTE0MSw3ICsx NDEsNyBAQCB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmF0dGFjaCgpCiAKICAgICBpZiAo YXV0b2ZvY3VzKCkgJiYgcmVuZGVyZXIoKSAmJiAhZG9jdW1lbnQoKS0+aWdub3JlQXV0b2ZvY3Vz KCkgJiYgIWlzUmVhZE9ubHlGb3JtQ29udHJvbCgpICYmCiAgICAgICAgICAgICAoKGhhc1RhZ05h bWUoaW5wdXRUYWcpICYmICFpc0lucHV0VHlwZUhpZGRlbikgfHwgaGFzVGFnTmFtZShzZWxlY3RU YWcpIHx8Ci0gICAgICAgICAgICAgIGhhc1RhZ05hbWUoYnV0dG9uVGFnKSB8fCBoYXNUYWdOYW1l KHRleHRhcmVhVGFnKSkpCisgICAgICAgICAgICAgIGhhc1RhZ05hbWUoa2V5Z2VuVGFnKSB8fCBo YXNUYWdOYW1lKGJ1dHRvblRhZykgfHwgaGFzVGFnTmFtZSh0ZXh0YXJlYVRhZykpKQogICAgICAg ICAgZm9jdXMoKTsKIH0KIAo=