57073 2011-03-24 19:45:51 -0700 NamedNodeMaps created from Atomic Tokens use 4 MB on Membuster 2011-03-24 23:01:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 slewis webkit-unassigned slewis oldest_to_newest 373274 0 slewis 2011-03-24 19:45:51 -0700 The AtomicHTMLToken function reserved space for ten tokens in the attribute map which was rarely filled. Rework the function to reserve space for the number of attributes in the list. Seems slightly faster on the parser benchmarks. Saves 1.5 MB on Membuster. 373275 1 86872 slewis 2011-03-24 19:51:34 -0700 Created attachment 86872 patch 373284 2 86872 ggaren 2011-03-24 20:18:21 -0700 Comment on attachment 86872 patch r=me 373331 3 slewis 2011-03-24 23:01:10 -0700 committed http://trac.webkit.org/projects/webkit/changeset/81937 86872 2011-03-24 19:51:34 -0700 2011-03-24 20:18:21 -0700 patch AtomicHTMLAttributeChange text/plain 3910 slewis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxOTMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjQgIFN0ZXBoYW5p ZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU3MDczCisgICAgICAgIFJld29yayB0aGUgQXRvbWljSFRNTENvbnN0cnVjdG9yIHRvIHJl c2VydmUgc3BhY2UgZm9yIGF0dHJpYnV0ZXMgYmFzZWQgb24gdGhlIHNpemUgb2YgdGhlIGF0dHJp YnV0ZSBsaXN0LgorICAgICAgICBTYXZlcyAxLjUgTUIgb24gTWVtYnVzdGVyLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIHdhcyBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuICBD dXJyZW50IHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVG9rZW4uaDoK KyAgICAgICAgKFdlYkNvcmU6OkF0b21pY0hUTUxUb2tlbjo6QXRvbWljSFRNTFRva2VuKToKKyAg ICAgICAgKFdlYkNvcmU6OkF0b21pY0hUTUxUb2tlbjo6aW5pdGlhbGl6ZUF0dHJpYnV0ZXMpOgor CiAyMDExLTAzLTI0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MVG9rZW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MVG9rZW4uaAkocmV2aXNpb24gODE1NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MVG9rZW4uaAkod29ya2luZyBjb3B5KQpAQCAtMzk4LDI3ICszOTgsNyBA QCBwdWJsaWM6CiAgICAgICAgIGNhc2UgSFRNTFRva2VuOjpFbmRUYWc6IHsKICAgICAgICAgICAg IG1fc2VsZkNsb3NpbmcgPSB0b2tlbi5zZWxmQ2xvc2luZygpOwogICAgICAgICAgICAgbV9uYW1l ID0gQXRvbWljU3RyaW5nKHRva2VuLm5hbWUoKS5kYXRhKCksIHRva2VuLm5hbWUoKS5zaXplKCkp OwotICAgICAgICAgICAgY29uc3QgSFRNTFRva2VuOjpBdHRyaWJ1dGVMaXN0JiBhdHRyaWJ1dGVz ID0gdG9rZW4uYXR0cmlidXRlcygpOwotICAgICAgICAgICAgZm9yIChIVE1MVG9rZW46OkF0dHJp YnV0ZUxpc3Q6OmNvbnN0X2l0ZXJhdG9yIGl0ZXIgPSBhdHRyaWJ1dGVzLmJlZ2luKCk7Ci0gICAg ICAgICAgICAgICAgIGl0ZXIgIT0gYXR0cmlidXRlcy5lbmQoKTsgKytpdGVyKSB7Ci0gICAgICAg ICAgICAgICAgaWYgKCFpdGVyLT5tX25hbWUuaXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICAgICAg ICAgIFN0cmluZyBuYW1lKGl0ZXItPm1fbmFtZS5kYXRhKCksIGl0ZXItPm1fbmFtZS5zaXplKCkp OwotICAgICAgICAgICAgICAgICAgICBTdHJpbmcgdmFsdWUoaXRlci0+bV92YWx1ZS5kYXRhKCks IGl0ZXItPm1fdmFsdWUuc2l6ZSgpKTsKLSAgICAgICAgICAgICAgICAgICAgQVNTRVJUKGl0ZXIt Pm1fbmFtZVJhbmdlLm1fc3RhcnQpOwotICAgICAgICAgICAgICAgICAgICBBU1NFUlQoaXRlci0+ bV9uYW1lUmFuZ2UubV9lbmQpOwotICAgICAgICAgICAgICAgICAgICBBU1NFUlQoaXRlci0+bV92 YWx1ZVJhbmdlLm1fc3RhcnQpOwotICAgICAgICAgICAgICAgICAgICBBU1NFUlQoaXRlci0+bV92 YWx1ZVJhbmdlLm1fZW5kKTsKLSAgICAgICAgICAgICAgICAgICAgUmVmUHRyPEF0dHJpYnV0ZT4g bWFwcGVkQXR0cmlidXRlID0gQXR0cmlidXRlOjpjcmVhdGVNYXBwZWQobmFtZSwgdmFsdWUpOwot ICAgICAgICAgICAgICAgICAgICBpZiAoIW1fYXR0cmlidXRlcykgewotICAgICAgICAgICAgICAg ICAgICAgICAgbV9hdHRyaWJ1dGVzID0gTmFtZWROb2RlTWFwOjpjcmVhdGUoKTsKLSAgICAgICAg ICAgICAgICAgICAgICAgIC8vIFJlc2VydmluZyBjYXBhY2l0eSBoZXJlIGltcHJvdmVzIHRoZSBw YXJzZXIKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIGJlbmNobWFyay4gIEl0IG1pZ2h0IGJl IHdvcnRoIGV4cGVyaW1lbnRpbmcgd2l0aAotICAgICAgICAgICAgICAgICAgICAgICAgLy8gdGhl IGNvbnN0YW50IHRvIHNlZSB3aGVyZSB0aGUgb3B0aW1hbCBwb2ludCBpcy4KLSAgICAgICAgICAg ICAgICAgICAgICAgIG1fYXR0cmlidXRlcy0+cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eSgxMCk7Ci0g ICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAgICAgbV9hdHRyaWJ1dGVzLT5p bnNlcnRBdHRyaWJ1dGUobWFwcGVkQXR0cmlidXRlLnJlbGVhc2UoKSwgZmFsc2UpOwotICAgICAg ICAgICAgICAgIH0KLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGluaXRpYWxpemVBdHRyaWJ1 dGVzKHRva2VuLmF0dHJpYnV0ZXMoKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgICAgICBjYXNlIEhUTUxUb2tlbjo6Q29tbWVudDoKQEAgLTUxMyw2ICs0OTMsOCBAQCBwdWJs aWM6CiBwcml2YXRlOgogICAgIEhUTUxUb2tlbjo6VHlwZSBtX3R5cGU7CiAKKyAgICB2b2lkIGlu aXRpYWxpemVBdHRyaWJ1dGVzKGNvbnN0IEhUTUxUb2tlbjo6QXR0cmlidXRlTGlzdCYgYXR0cmli dXRlcyk7CisgICAgCiAgICAgYm9vbCB1c2VzTmFtZSgpIGNvbnN0CiAgICAgewogICAgICAgICBy ZXR1cm4gbV90eXBlID09IEhUTUxUb2tlbjo6U3RhcnRUYWcgfHwgbV90eXBlID09IEhUTUxUb2tl bjo6RW5kVGFnIHx8IG1fdHlwZSA9PSBIVE1MVG9rZW46OkRPQ1RZUEU7CkBAIC01NDgsNiArNTMw LDMwIEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPE5hbWVkTm9kZU1hcD4gbV9hdHRyaWJ1dGVzOwog fTsKIAoraW5saW5lIHZvaWQgQXRvbWljSFRNTFRva2VuOjppbml0aWFsaXplQXR0cmlidXRlcyhj b25zdCBIVE1MVG9rZW46OkF0dHJpYnV0ZUxpc3QmIGF0dHJpYnV0ZXMpCit7CisgICAgc2l6ZV90 IHNpemUgPSBhdHRyaWJ1dGVzLnNpemUoKTsKKyAgICBpZiAoIXNpemUpCisgICAgICAgIHJldHVy bjsKKworICAgIG1fYXR0cmlidXRlcyA9IE5hbWVkTm9kZU1hcDo6Y3JlYXRlKCk7CisgICAgbV9h dHRyaWJ1dGVzLT5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KHNpemUpOworICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgc2l6ZTsgKytpKSB7CisgICAgICAgIGNvbnN0IEhUTUxUb2tlbjo6QXR0cmli dXRlJiBhdHRyaWJ1dGUgPSBhdHRyaWJ1dGVzW2ldOworICAgICAgICBpZiAoYXR0cmlidXRlLm1f bmFtZS5pc0VtcHR5KCkpCisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICBBU1NFUlQo YXR0cmlidXRlLm1fbmFtZVJhbmdlLm1fc3RhcnQpOworICAgICAgICBBU1NFUlQoYXR0cmlidXRl Lm1fbmFtZVJhbmdlLm1fZW5kKTsKKyAgICAgICAgQVNTRVJUKGF0dHJpYnV0ZS5tX3ZhbHVlUmFu Z2UubV9zdGFydCk7CisgICAgICAgIEFTU0VSVChhdHRyaWJ1dGUubV92YWx1ZVJhbmdlLm1fZW5k KTsKKworICAgICAgICBTdHJpbmcgbmFtZShhdHRyaWJ1dGUubV9uYW1lLmRhdGEoKSwgYXR0cmli dXRlLm1fbmFtZS5zaXplKCkpOworICAgICAgICBTdHJpbmcgdmFsdWUoYXR0cmlidXRlLm1fdmFs dWUuZGF0YSgpLCBhdHRyaWJ1dGUubV92YWx1ZS5zaXplKCkpOworICAgICAgICBtX2F0dHJpYnV0 ZXMtPmluc2VydEF0dHJpYnV0ZShBdHRyaWJ1dGU6OmNyZWF0ZU1hcHBlZChuYW1lLCB2YWx1ZSks IGZhbHNlKTsKKyAgICB9Cit9CisKIH0KIAogI2VuZGlmCg==