57064 2011-03-24 16:39:32 -0700 WebFrame forward declares WebURLLoaderOptions as a class when it's a struct. 2011-04-06 10:38:31 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bbudge webkit-unassigned dimich eric levin scheib oldest_to_newest 373184 0 bbudge 2011-03-24 16:39:32 -0700 This causes a build error in Chromium code. 373188 1 86859 bbudge 2011-03-24 16:41:30 -0700 Created attachment 86859 Proposed Patch 373192 2 86859 bbudge 2011-03-24 16:44:38 -0700 Comment on attachment 86859 Proposed Patch Gah. I got confused by changes on my checkout. Never mind. 373195 3 86859 bbudge 2011-03-24 16:47:52 -0700 Comment on attachment 86859 Proposed Patch On second thought, this is needed. 373196 4 86860 bbudge 2011-03-24 16:49:32 -0700 Created attachment 86860 Proposed Patch On fourth thought, better make it right. 373210 5 86860 eric 2011-03-24 17:01:28 -0700 Comment on attachment 86860 Proposed Patch OK. 373211 6 eric 2011-03-24 17:02:22 -0700 It seems like we should catch this sort of thing with check-webkit-style. Probably by just deprecating "struct" from WebKit code. So rarely does a "struct" really want to be a struct and not just a class Foo { public: 373238 7 86860 dimich 2011-03-24 18:10:46 -0700 Comment on attachment 86860 Proposed Patch Clearing flags on attachment: 86860 Committed r81926: <http://trac.webkit.org/changeset/81926> 373239 8 dimich 2011-03-24 18:10:51 -0700 All reviewed patches have been landed. Closing bug. 380582 9 86859 eric 2011-04-06 10:38:31 -0700 Comment on attachment 86859 Proposed Patch Cleared review? from obsolete attachment 86859 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 86859 2011-03-24 16:41:30 -0700 2011-04-06 10:38:31 -0700 Proposed Patch webframe.txt text/plain 1109 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTkxNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjQgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBhIGZvcndh cmQgZGVjbGFyYXRpb24gb2YgV2ViVVJMTG9hZGVyT3B0aW9ucyB0byBzdHJ1Y3QgdG8gcHJldmVu dCBhIGJ1aWxkIGJyZWFrIGluIENocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwNjQKKworICAgICAgICBObyB0ZXN0cy4gRXhwb3NlcyBu byBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorCiAy MDExLTAzLTI0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg dGhlIGNocm9taXVtIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZS5oCShyZXZpc2lvbiA4MTkxNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDYgKzcxLDcgQEAgc3RydWN0IFdl YkZpbmRPcHRpb25zOwogc3RydWN0IFdlYlJlY3Q7CiBzdHJ1Y3QgV2ViU2NyaXB0U291cmNlOwog c3RydWN0IFdlYlNpemU7CitzdHJ1Y3QgV2ViVVJMTG9hZGVyT3B0aW9uczsKIHRlbXBsYXRlIDx0 eXBlbmFtZSBUPiBjbGFzcyBXZWJWZWN0b3I7CiAKIC8vIEZJWE1FKGphbSk6IHRha2UgdGhpcyBv dXQgb25jZSBDaHJvbWl1bSBoYXMgdGhpcwo= 86860 2011-03-24 16:49:32 -0700 2011-03-24 18:10:46 -0700 Proposed Patch webframe.txt text/plain 1299 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTkxNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjQgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBhIGZvcndh cmQgZGVjbGFyYXRpb24gb2YgV2ViVVJMTG9hZGVyT3B0aW9ucyB0byBzdHJ1Y3QgdG8gcHJldmVu dCBhIGJ1aWxkIGJyZWFrIGluIENocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTcwNjQKKworICAgICAgICBObyB0ZXN0cy4gRXhwb3NlcyBu byBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorCiAy MDExLTAzLTI0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg dGhlIGNocm9taXVtIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZS5oCShyZXZpc2lvbiA4MTkxNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDYgQEAgY2xhc3MgV2Vi U2VjdXJpdHlPcmlnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBjbGFzcyBX ZWJVUkxMb2FkZXI7Ci1jbGFzcyBXZWJVUkxMb2FkZXJPcHRpb25zOwogY2xhc3MgV2ViVVJMUmVx dWVzdDsKIGNsYXNzIFdlYlZpZXc7CiBzdHJ1Y3QgV2ViQ29uc29sZU1lc3NhZ2U7CkBAIC03MSw2 ICs3MCw3IEBAIHN0cnVjdCBXZWJGaW5kT3B0aW9uczsKIHN0cnVjdCBXZWJSZWN0Owogc3RydWN0 IFdlYlNjcmlwdFNvdXJjZTsKIHN0cnVjdCBXZWJTaXplOworc3RydWN0IFdlYlVSTExvYWRlck9w dGlvbnM7CiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gY2xhc3MgV2ViVmVjdG9yOwogCiAvLyBGSVhN RShqYW0pOiB0YWtlIHRoaXMgb3V0IG9uY2UgQ2hyb21pdW0gaGFzIHRoaXMK