57062 2011-03-24 15:52:32 -0700 [chromium] Remove deprecated overload of openFileSystem for workers 2011-03-25 12:29:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 adamk adamk commit-queue levin oldest_to_newest 373154 0 adamk 2011-03-24 15:52:32 -0700 [chromium] Remove deprecated overload of openFileSystem for workers 373155 1 86850 adamk 2011-03-24 15:53:05 -0700 Created attachment 86850 Patch 373187 2 86858 adamk 2011-03-24 16:41:05 -0700 Created attachment 86858 Patch 373233 3 adamk 2011-03-24 18:06:12 -0700 +levin, who's reviewed all my recent changes related to workers and filesystems. 373242 4 levin 2011-03-24 18:21:19 -0700 I wonder if we need to roll DEPS for this change to the version of chromium that no longer uses it. WebKit/chromium/DEPS 373554 5 adamk 2011-03-25 09:28:37 -0700 I'm about to submit the Chromium side of this change (http://codereview.chromium.org/6736012/), but this method is called only on the WebKit side, so the two changes can safely be landed in any order. Landing this one first simply means that the Chromium code will no longer be overriding this method, but providing its own of the same name. This happens to be simpler than usual in this case because the method has a default implementation in WebKit. Otherwise, ordering would be important. I've tested that this works as expected by building with "build-webkit --chromium". 373622 6 86858 commit-queue 2011-03-25 11:26:32 -0700 Comment on attachment 86858 Patch Clearing flags on attachment: 86858 Committed r81972: <http://trac.webkit.org/changeset/81972> 373623 7 commit-queue 2011-03-25 11:26:36 -0700 All reviewed patches have been landed. Closing bug. 373668 8 commit-queue 2011-03-25 12:29:43 -0700 The commit-queue encountered the following flaky tests while processing attachment 86858: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 86850 2011-03-24 15:53:05 -0700 2011-03-24 16:41:03 -0700 Patch bug-57062-20110324155304.patch text/plain 1776 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OGM3Y2Y5N2RjOWFiNDhiMDI2ODAyNTgwNTk1NDI2ZDQ0NzRkMjQ3NC4uYTBkNTJiNDIzYWJhMDNk Mzg2YTA0YjdiY2VkYzIzYWNmODNiM2FkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0wMy0yNCAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIFJlbW92ZSBkZXByZWNhdGVkIG92ZXJsb2FkIG9mIG9wZW5GaWxlU3lzdGVtIGZvciB3 b3JrZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzA2MgorCisgICAgICAgICogcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5oOgorCiAyMDEx LTAzLTI0ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5oIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKaW5kZXggYjk5ZDM5ZDQxYTJm ZTg2NzE4MGJmNjcwZWE2NzU5NzhiODM1MjJiMy4uNGNjYjYwMDRlMjFkZDZhMzNjZjE3MDU4M2Uw Y2NmYzAyNzhmMTRjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKQEAgLTg3LDE2ICs4Nyw3IEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIGJvb2wgYWxsb3dEYXRhYmFzZShXZWJGcmFtZSosIGNvbnN0IFdlYlN0cmluZyYg bmFtZSwgY29uc3QgV2ViU3RyaW5nJiBkaXNwbGF5TmFtZSwgdW5zaWduZWQgbG9uZyBlc3RpbWF0 ZWRTaXplKSA9IDA7CiAKICAgICAvLyBDYWxsZWQgb24gdGhlIG1haW4gd2Via2l0IHRocmVhZCBi ZWZvcmUgb3BlbmluZyBhIGZpbGUgc3lzdGVtLgotICAgIHZpcnR1YWwgdm9pZCBvcGVuRmlsZVN5 c3RlbShXZWJGaWxlU3lzdGVtOjpUeXBlLCBsb25nIGxvbmcgc2l6ZSwgYm9vbCBjcmVhdGUsIFdl YkZpbGVTeXN0ZW1DYWxsYmFja3MqKQotICAgIHsKLSAgICAgICAgV0VCS0lUX0FTU0VSVF9OT1Rf UkVBQ0hFRCgpOwotICAgIH0KLQotICAgIC8vIFRoaXMgd2lsbCBiZSByZW1vdmVkIG9uY2UgY2hh bmdlcyBpbiBjaHJvbWl1bSB1c2UgdGhlIG5ldyBtZXRob2QgYWJvdmUuCi0gICAgdmlydHVhbCB2 b2lkIG9wZW5GaWxlU3lzdGVtKFdlYkZpbGVTeXN0ZW06OlR5cGUsIGxvbmcgbG9uZyBzaXplLCBX ZWJGaWxlU3lzdGVtQ2FsbGJhY2tzKikKLSAgICB7Ci0gICAgICAgIFdFQktJVF9BU1NFUlRfTk9U X1JFQUNIRUQoKTsKLSAgICB9CisgICAgdmlydHVhbCB2b2lkIG9wZW5GaWxlU3lzdGVtKFdlYkZp bGVTeXN0ZW06OlR5cGUsIGxvbmcgbG9uZyBzaXplLCBib29sIGNyZWF0ZSwgV2ViRmlsZVN5c3Rl bUNhbGxiYWNrcyopID0gMDsKIAogcHJvdGVjdGVkOgogICAgIH5XZWJDb21tb25Xb3JrZXJDbGll bnQoKSB7IH0K 86858 2011-03-24 16:41:05 -0700 2011-03-25 11:26:32 -0700 Patch bug-57062-20110324164104.patch text/plain 1349 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OGM3Y2Y5N2RjOWFiNDhiMDI2ODAyNTgwNTk1NDI2ZDQ0NzRkMjQ3NC4uYTBkNTJiNDIzYWJhMDNk Mzg2YTA0YjdiY2VkYzIzYWNmODNiM2FkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0wMy0yNCAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIFJlbW92ZSBkZXByZWNhdGVkIG92ZXJsb2FkIG9mIG9wZW5GaWxlU3lzdGVtIGZvciB3 b3JrZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NzA2MgorCisgICAgICAgICogcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5oOgorCiAyMDEx LTAzLTI0ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5oIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKaW5kZXggYjk5ZDM5ZDQxYTJm ZTg2NzE4MGJmNjcwZWE2NzU5NzhiODM1MjJiMy4uOWYxMWFhMjVlMDU1MzcwMzQyNWYyOTE1ZmNk MWJhYzVlODc2MWQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgKQEAgLTkyLDEyICs5Miw2IEBAIHB1YmxpYzoKICAg ICAgICAgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KIAotICAgIC8vIFRoaXMg d2lsbCBiZSByZW1vdmVkIG9uY2UgY2hhbmdlcyBpbiBjaHJvbWl1bSB1c2UgdGhlIG5ldyBtZXRo b2QgYWJvdmUuCi0gICAgdmlydHVhbCB2b2lkIG9wZW5GaWxlU3lzdGVtKFdlYkZpbGVTeXN0ZW06 OlR5cGUsIGxvbmcgbG9uZyBzaXplLCBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzKikKLSAgICB7Ci0g ICAgICAgIFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICB9Ci0KIHByb3RlY3RlZDoK ICAgICB+V2ViQ29tbW9uV29ya2VyQ2xpZW50KCkgeyB9CiB9Owo=