57030 2011-03-24 09:55:54 -0700 REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message 2011-03-24 13:23:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r81782%20(9955)/http/tests/inspector/extensions-resources-redirect-crash-log.txt InRadar, LayoutTestFailure P2 Normal --- 1 aroben beidson andersca apavlov beidson bweinstein joepeck keishi loislo pfeldman pmuellr rik sam timothy yurys oldest_to_newest 372862 0 aroben 2011-03-24 09:55:54 -0700 http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's web process. We know this because the web process crashing then causes the UI process to crash (bug 57029). We don't know what's causing the web process to crash, though, because the UI process crash is masking it. 372866 1 aroben 2011-03-24 10:00:10 -0700 Ooh, I found a crash log from the web process. See the URL. 372870 2 aroben 2011-03-24 10:04:47 -0700 Looks like the first time this happened was in r81782, which seems like a related change. http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/9955 372871 3 aroben 2011-03-24 10:05:09 -0700 Added the test to the mac-wk2 Skipped file in r81874. 372878 4 aroben 2011-03-24 10:07:38 -0700 <rdar://problem/9182074> 373022 5 beidson 2011-03-24 13:08:18 -0700 Figured this out. A serious of events have to happen with both the network layer and the WebProcess -> UIProcess layer to reproduce this. There's probably no practical way to reproduce the exact conditions necessary in layout-test land, but we obviously already had coverage that caught this. In fact, the single test Adam deactivated isn't the only one that can cause this - I've seen it locally with other https tests (though less frequently) Patch is coming soon. 373036 6 86819 beidson 2011-03-24 13:17:20 -0700 Created attachment 86819 Fix WebCore and unskip the test 373042 7 beidson 2011-03-24 13:23:20 -0700 r81892 86819 2011-03-24 13:17:20 -0700 2011-03-24 13:21:04 -0700 Fix WebCore and unskip the test patch.txt text/plain 3648 beidson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxODkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDMtMjQgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NzAzMAorICAgICAgICBSRUdSRVNTSU9OIChyODE3ODIpOiBodHRwL3Rlc3RzL2luc3BlY3Rv ci9leHRlbnNpb25zLXJlc291cmNlcy1yZWRpcmVjdC5odG1sIHNvbWV0aW1lcyBjcmFzaGVzIFdl YktpdDIncyAKKyAgICAgICAgd2ViIHByb2Nlc3Mgd2hpbGUgaGFuZGxpbmcgYSBXZWJJY29uRGF0 YWJhc2VQcm94eTo6UmVjZWl2ZWRJY29uTG9hZERlY2lzaW9uIG1lc3NhZ2UKKworICAgICAgICBU aGUgY2FsbGJhY2sgb2JqZWN0cyBoYWQgc29tZSBib2d1cyBBU1NFUlRzIGFuZCBtaXNzZWQgYSBy ZWxldmFudCBudWxsIGNoZWNrLiBJZiBhIGNhbGxiYWNrIHdhcyB3YWl0aW5nIG9uCisgICAgICAg IGEgbWVzc2FnZSBiYWNrIGZyb20gdGhlIFVJUHJvY2VzcywgYnV0IHdhcyBpbnZhbGlkYXRlZCBm cm9tIHdpdGhpbiB0aGUgV2ViUHJvY2VzcyBpbiB0aGUgbWVhbnRpbWUsIGl0J3MKKyAgICAgICAg cGVyZmVjdGx5IHZhbGlkIHRvIGF0dGVtcHQgdG8gcGVyZm9ybUNhbGxiYWNrKCkgYWZ0ZXIgdGhl IGNhbGxiYWNrIGZ1bmN0aW9uIHBvaW50ZXIgaGFzIGJlZW4gY2xlYXJlZC4KKworICAgICAgICAq IGxvYWRlci9pY29uL0ljb25EYXRhYmFzZUJhc2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OkVudW1D YWxsYmFjazo6cGVyZm9ybUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkVudW1DYWxsYmFj azo6aW52YWxpZGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpFbnVtQ2FsbGJhY2s6OkVudW1DYWxs YmFjayk6CisgICAgICAgIChXZWJDb3JlOjpPYmplY3RDYWxsYmFjazo6cGVyZm9ybUNhbGxiYWNr KToKKyAgICAgICAgKFdlYkNvcmU6Ok9iamVjdENhbGxiYWNrOjppbnZhbGlkYXRlKToKKyAgICAg ICAgKFdlYkNvcmU6Ok9iamVjdENhbGxiYWNrOjpPYmplY3RDYWxsYmFjayk6CisKIDIwMTEtMDMt MjQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFz ZUJhc2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0 YWJhc2VCYXNlLmgJKHJldmlzaW9uIDgxODY4KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL2lj b24vSWNvbkRhdGFiYXNlQmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCwxNCArOTAsMTQgQEAg cHVibGljOgogCiAgICAgdm9pZCBwZXJmb3JtQ2FsbGJhY2soRW51bVR5cGUgcmVzdWx0KQogICAg IHsKLSAgICAgICAgQVNTRVJUKG1fY2FsbGJhY2spOworICAgICAgICBpZiAoIW1fY2FsbGJhY2sp CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIG1fY2FsbGJhY2socmVzdWx0LCBjb250ZXh0 KCkpOwogICAgICAgICBtX2NhbGxiYWNrID0gMDsKICAgICB9CiAgICAgCiAgICAgdm9pZCBpbnZh bGlkYXRlKCkKICAgICB7Ci0gICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKICAgICAgICAgbV9j YWxsYmFjayA9IDA7CiAgICAgfQogCkBAIC0xMDYsNiArMTA2LDcgQEAgcHJpdmF0ZToKICAgICAg ICAgOiBDYWxsYmFja0Jhc2UoY29udGV4dCkKICAgICAgICAgLCBtX2NhbGxiYWNrKGNhbGxiYWNr KQogICAgIHsKKyAgICAgICAgQVNTRVJUKG1fY2FsbGJhY2spOwogICAgIH0KIAogICAgIENhbGxi YWNrRnVuY3Rpb24gbV9jYWxsYmFjazsKQEAgLTEyOCwxNCArMTI5LDE0IEBAIHB1YmxpYzoKIAog ICAgIHZvaWQgcGVyZm9ybUNhbGxiYWNrKE9iamVjdFR5cGUgcmVzdWx0KQogICAgIHsKLSAgICAg ICAgQVNTRVJUKG1fY2FsbGJhY2spOworICAgICAgICBpZiAoIW1fY2FsbGJhY2spCisgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIG1fY2FsbGJhY2socmVzdWx0LCBjb250ZXh0KCkpOwogICAg ICAgICBtX2NhbGxiYWNrID0gMDsKICAgICB9CiAgICAgCiAgICAgdm9pZCBpbnZhbGlkYXRlKCkK ICAgICB7Ci0gICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKICAgICAgICAgbV9jYWxsYmFjayA9 IDA7CiAgICAgfQogCkBAIC0xNDQsNiArMTQ1LDcgQEAgcHJpdmF0ZToKICAgICAgICAgOiBDYWxs YmFja0Jhc2UoY29udGV4dCkKICAgICAgICAgLCBtX2NhbGxiYWNrKGNhbGxiYWNrKQogICAgIHsK KyAgICAgICAgQVNTRVJUKG1fY2FsbGJhY2spOwogICAgIH0KIAogICAgIENhbGxiYWNrRnVuY3Rp b24gbV9jYWxsYmFjazsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxODkwKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTEtMDMtMjQgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc29sdmluZyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTcwMzAsIHVuc2tpcCB0aGUgYnVzdGVkIHRlc3QuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQ6CisKIDIwMTEtMDMtMjQgIEFuZHkgRXN0ZXMg IDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAkocmV2aXNpb24gODE4OTApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAg LTIwMTcsOSArMjAxNyw2IEBAIHN0b3JhZ2UvZG9tc3RvcmFnZS9sb2NhbHN0b3JhZ2Uvc3RvcmFn ZXQKIGZhc3QvZm9ybXMvaW5wdXQtYXV0b2ZpbGxlZC5odG1sCiBmYXN0L2Zvcm1zL3Jlc2V0LWF1 dG9maWxsZWQuaHRtbAogCi0jIFNvbWV0aW1lcyBjcmFzaGVzIGh0dHA6Ly93ZWJraXQub3JnL2Iv NTcwMzAKLWh0dHAvdGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMtcmVzb3VyY2VzLXJlZGlyZWN0 Lmh0bWwKLQogIyMjIEVORCBPRiAoMikgQ2xhc3NpZmllZCBmYWlsdXJlcyB3aXRob3V0IGJ1ZyBy ZXBvcnRzICh5ZXQpCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAK