57025 2011-03-24 09:28:05 -0700 [GTK] [PATCH] Avoid critical warning when free-ing list of plugins 2011-03-25 03:33:42 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 plaes webkit-unassigned commit-queue mrobinson webkit.review.bot oldest_to_newest 372844 0 plaes 2011-03-24 09:28:05 -0700 Critical error is printed to console when there are no plugins present. This is because plugin list is stored inside GSList that is NULL by default (ie if no elements are present). But the function that free's the plugin list has g_return_if_fail(list) that emits the ciritical error when list is NULL. 372847 1 86782 plaes 2011-03-24 09:33:07 -0700 Created attachment 86782 plugins-critical-warning-fix.patch 372848 2 webkit.review.bot 2011-03-24 09:34:52 -0700 Attachment 86782 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebKit/gtk/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 372850 3 86783 plaes 2011-03-24 09:37:01 -0700 Created attachment 86783 plugins-critical-warning-fix.patch 373429 4 86783 commit-queue 2011-03-25 03:33:37 -0700 Comment on attachment 86783 plugins-critical-warning-fix.patch Clearing flags on attachment: 86783 Committed r81952: <http://trac.webkit.org/changeset/81952> 373430 5 commit-queue 2011-03-25 03:33:42 -0700 All reviewed patches have been landed. Closing bug. 86782 2011-03-24 09:33:07 -0700 2011-03-24 09:37:01 -0700 plugins-critical-warning-fix.patch 0001-2011-03-24-Priit-Laes-plaes-plaes.org.patch text/plain 1957 plaes RnJvbSAyMzZlNDA5OWY1MGVkNzU5MGQwMDhlNGQ1ODExZjFiMTFiNjgyMDNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFRo dSwgMjQgTWFyIDIwMTEgMTg6MjU6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDExLTAzLTI0 ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gW1BBVENIXSBBdm9pZCBjcml0aWNhbCB3YXJuaW5n IHdoZW4gZnJlZS1pbmcgbGlzdCBvZiBwbHVnaW5zCgkJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU3MDI1CgogICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbmRh dGFiYXNlLmNwcDoKICAgICAgICAod2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2VfcGx1Z2luc19s aXN0X2ZyZWUpOgoJCVVzZSByZWd1bGFyIGNoZWNrIGFuZCByZXR1cm4gaW5zdGVhZCBvZiBnX3Jl dHVybl9pZl9mYWlsLgotLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNwcCAgfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAx MyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBiZjFk MGYxLi5lN2MwYTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMt MjQgIFByaWl0IExhZXMgIDxwbGFlc0BwbGFlcy5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gW1BBVENIXSBBdm9pZCBjcml0aWNhbCB3 YXJuaW5nIHdoZW4gZnJlZS1pbmcgbGlzdCBvZiBwbHVnaW5zCisJCWh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzAyNQorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdl YnBsdWdpbmRhdGFiYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfcGx1Z2luX2RhdGFiYXNl X3BsdWdpbnNfbGlzdF9mcmVlKToKKwkJVXNlIHJlZ3VsYXIgY2hlY2sgYW5kIHJldHVybiBpbnN0 ZWFkIG9mIGdfcmV0dXJuX2lmX2ZhaWwuCisKIDIwMTEtMDMtMjMgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luZGF0YWJhc2Uu Y3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNw cAppbmRleCAyZDM2MTE1Li4xZWQ1MjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2VicGx1Z2luZGF0YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5kYXRhYmFzZS5jcHAKQEAgLTc0LDcgKzc0LDggQEAgc3Rh dGljIHZvaWQgd2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2VfaW5pdChXZWJLaXRXZWJQbHVnaW5E YXRhYmFzZSogZGF0YWJhc2UpCiAgKi8KIHZvaWQgd2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2Vf cGx1Z2luc19saXN0X2ZyZWUoR1NMaXN0KiBsaXN0KQogewotICAgIGdfcmV0dXJuX2lmX2ZhaWwo bGlzdCk7CisgICAgaWYgKCFsaXN0KQorICAgICAgICByZXR1cm47CiAKICAgICBmb3IgKEdTTGlz dCogcCA9IGxpc3Q7IHA7IHAgPSBwLT5uZXh0KQogICAgICAgICBnX29iamVjdF91bnJlZihwLT5k YXRhKTsKLS0gCjEuNy40LjEKCg== 86783 2011-03-24 09:37:01 -0700 2011-03-25 03:33:37 -0700 plugins-critical-warning-fix.patch 0001-2011-03-24-Priit-Laes-plaes-plaes.org.patch text/plain 1981 plaes RnJvbSAzYzZhOWQwMGFkMTdiODc0NzcxOGNkODYxNDJiZTMzMzQyZTAyMjY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFRo dSwgMjQgTWFyIDIwMTEgMTg6MjU6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDExLTAzLTI0 ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gW1BBVENIXSBBdm9pZCBjcml0aWNhbCB3YXJuaW5n IHdoZW4gZnJlZS1pbmcgbGlzdCBvZiBwbHVnaW5zCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MDI1CgogICAgICAgICogd2Via2l0L3dlYmtpdHdlYnBs dWdpbmRhdGFiYXNlLmNwcDoKICAgICAgICAod2Via2l0X3dlYl9wbHVnaW5fZGF0YWJhc2VfcGx1 Z2luc19saXN0X2ZyZWUpOgogICAgICAgIFVzZSByZWd1bGFyIGNoZWNrIGFuZCByZXR1cm4gaW5z dGVhZCBvZiBnX3JldHVybl9pZl9mYWlsLgotLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNwcCAgfCAgICAzICsrLQogMiBmaWxl cyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZwppbmRleCBiZjFkMGYxLi44N2RlNWE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDMtMjQgIFByaWl0IExhZXMgIDxwbGFlc0BwbGFlcy5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gW1BBVENIXSBBdm9p ZCBjcml0aWNhbCB3YXJuaW5nIHdoZW4gZnJlZS1pbmcgbGlzdCBvZiBwbHVnaW5zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NzAyNQorCisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdF93 ZWJfcGx1Z2luX2RhdGFiYXNlX3BsdWdpbnNfbGlzdF9mcmVlKToKKyAgICAgICAgVXNlIHJlZ3Vs YXIgY2hlY2sgYW5kIHJldHVybiBpbnN0ZWFkIG9mIGdfcmV0dXJuX2lmX2ZhaWwuCisKIDIwMTEt MDMtMjMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2VicGx1Z2luZGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnBsdWdpbmRhdGFiYXNlLmNwcAppbmRleCAyZDM2MTE1Li4xZWQ1MjA1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luZGF0YWJhc2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJwbHVnaW5kYXRhYmFzZS5j cHAKQEAgLTc0LDcgKzc0LDggQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9wbHVnaW5fZGF0YWJh c2VfaW5pdChXZWJLaXRXZWJQbHVnaW5EYXRhYmFzZSogZGF0YWJhc2UpCiAgKi8KIHZvaWQgd2Vi a2l0X3dlYl9wbHVnaW5fZGF0YWJhc2VfcGx1Z2luc19saXN0X2ZyZWUoR1NMaXN0KiBsaXN0KQog ewotICAgIGdfcmV0dXJuX2lmX2ZhaWwobGlzdCk7CisgICAgaWYgKCFsaXN0KQorICAgICAgICBy ZXR1cm47CiAKICAgICBmb3IgKEdTTGlzdCogcCA9IGxpc3Q7IHA7IHAgPSBwLT5uZXh0KQogICAg ICAgICBnX29iamVjdF91bnJlZihwLT5kYXRhKTsKLS0gCjEuNy40LjEKCg==