56978 2011-03-23 17:24:37 -0700 REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading() 2011-03-23 17:51:20 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P1 Normal --- 1 ap ap darin webkit-ews webkit.review.bot oldest_to_newest 372560 0 ap 2011-03-23 17:24:37 -0700 There are many crashes reported in WebKit2 with the following repetitive part: FrameLoader::recursiveCheckLoadComplete() FrameLoader::checkLoadComplete() FrameLoader::mainReceivedCompleteError() DocumentLoader::mainReceivedError() DocumentLoader::stopLoading() FrameLoader::checkLoadCompleteForThisFrame() /* provisional state */ Unfortunately, there are no steps to reproduce. <rdar://problem/9041670> 372561 1 ap 2011-03-23 17:29:06 -0700 Our best guess is that this is caused by the way plug-in loads are stopped - there are asynchronous messages sent, so DocumentLoader keeps thinking that it has plug-in loads unless it receives an IPC response, which it doesn't. But I couldn't make a test. 372564 2 86725 ap 2011-03-23 17:35:11 -0700 Created attachment 86725 proposed fix This passes regression tests. It's difficult to confidently say that there are no leaks, because loader and http regression tests leak a lot already. 372568 3 86726 ap 2011-03-23 17:43:19 -0700 Created attachment 86726 updated patch Oops, lost the condition rewrite somehow. 372570 4 86726 mjs 2011-03-23 17:44:27 -0700 Comment on attachment 86726 updated patch r=me 372571 5 webkit.review.bot 2011-03-23 17:44:57 -0700 Attachment 86726 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/FrameLoader.cpp:2401: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 372574 6 ap 2011-03-23 17:49:19 -0700 Committed <http://trac.webkit.org/changeset/81831> 372575 7 webkit-ews 2011-03-23 17:51:11 -0700 Attachment 86726 did not build on qt: Build output: http://queues.webkit.org/results/8236098 372576 8 ap 2011-03-23 17:51:20 -0700 Typo fix in <http://trac.webkit.org/changeset/81832>. 86725 2011-03-23 17:35:11 -0700 2011-03-23 17:43:19 -0700 proposed fix StopLoadingRecursion.txt text/plain 2323 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxODI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMjMgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogSW5maW5pdGUgcmVjdXJzaW9uIGluIHJl Y3Vyc2l2ZUNoZWNrTG9hZENvbXBsZXRlKCkvY2hlY2tMb2FkQ29tcGxldGVGb3JUaGlzRnJhbWUo KS9zdG9wTG9hZGluZygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01Njk3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTA0MTY3MD4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIGJlY2F1c2UgdGhlcmUgaXMgbm8ga25vd24gd2F5IHRvIHJlcHJvZHVj ZS4KKworICAgICAgICBSZW1vdmVkIHN0cmFuZ2UgY29kZSB0aGF0IHdhcyB0cnlpbmcgdG8gc3Rv cCBhIG5vbi1sb2FkaW5nIHByb3Zpc2lvbmFsIGRvY3VtZW50IGxvYWRlciBhbmQKKyAgICAgICAg ZXZlbiBpdHMgc3ViZnJhbWVzICg/ISkuIEFkZGVkIGFzc2VydGlvbnMgdG8gY2F0Y2ggaXQgaWYg d2UgY2FuIGFjdHVhbGx5IGJlIGxvYWRpbmcgaGVyZSBpbgorICAgICAgICBzb21lIHNlbnNlLgor ICAgICAgICBSZXdyb3RlIGEgY29uZGl0aW9uIGZvciBjbGFyaXR5IC0gc3RhcnRpbmcgd2l0aCBy NDMxNDgsIGl0IHdhcyBhY3RpbmcgYXMgYW4gb3Bwb3NpdGUgb2YgYQorICAgICAgICByZWN1cnNp b24gZ3VhcmQgKGJ1dCB0aGF0IGRpZG4ndCBjYXVzZSBpbW1lZGlhdGUgcHJvYmxlbXMgdGhlbiku CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOiAoV2ViQ29yZTo6RnJhbWVMb2Fk ZXI6OmNoZWNrTG9hZENvbXBsZXRlRm9yVGhpc0ZyYW1lKToKKwogMjAxMS0wMy0yMyAgTWFyayBS b3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDgxNjc3KQorKysgU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5 NiwxMSArMjM5NiwxMCBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZvclRo CiAgICAgICAgICAgICAgICAgbV9jbGllbnQtPmRpc3BhdGNoRGlkRmFpbFByb3Zpc2lvbmFsTG9h ZChlcnJvcik7CiAgICAgICAgICAgICAgICAgbV9kZWxlZ2F0ZUlzSGFuZGxpbmdQcm92aXNpb25h bExvYWRFcnJvciA9IGZhbHNlOwogCi0gICAgICAgICAgICAgICAgLy8gRklYTUU6IGNhbiBzdG9w cGluZyBsb2FkaW5nIGhlcmUgcG9zc2libHkgaGF2ZSBhbnkgZWZmZWN0LCBpZiBpc0xvYWRpbmcg aXMgZmFsc2UsCi0gICAgICAgICAgICAgICAgLy8gd2hpY2ggaXQgbXVzdCBiZSB0byBiZSBpbiB0 aGlzIGJyYW5jaCBvZiB0aGUgaWY/IEFuZCBpcyBpdCBPSyB0byBqdXN0IGRvIGEgZnVsbC1vbgot ICAgICAgICAgICAgICAgIC8vIHN0b3BBbGxMb2FkZXJzIGluc3RlYWQgb2Ygc3RvcExvYWRpbmdT dWJmcmFtZXM/Ci0gICAgICAgICAgICAgICAgc3RvcExvYWRpbmdTdWJmcmFtZXMoU2hvdWxkTm90 Q2xlYXJQcm92aXNpb25hbEl0ZW0pOwotICAgICAgICAgICAgICAgIHBkbC0+c3RvcExvYWRpbmco KTsKKyAgICAgICAgICAgICAgICBBU1NFUlQoIXBkbC0+aXNMb2FkaW5nKCkpOworICAgICAgICAg ICAgICAgIEFTU0VSVCghcGRsLT5pc0xvYWRpbmdNYWluUmVzb3VyY2UoKSk7CisgICAgICAgICAg ICAgICAgQVNTRVJUKCFwZGwtPmlzTG9hZGluZ1N1YnJlc291cmNlcygpKTsKKyAgICAgICAgICAg ICAgICBBU1NFUlQoIXBkbC0+aXNMb2FkaW5nUGx1Z0lucygpKTsKIAogICAgICAgICAgICAgICAg IC8vIElmIHdlJ3JlIGluIHRoZSBtaWRkbGUgb2YgbG9hZGluZyBtdWx0aXBhcnQgZGF0YSwgd2Ug bmVlZCB0byByZXN0b3JlIHRoZSBkb2N1bWVudCBsb2FkZXIuCiAgICAgICAgICAgICAgICAgaWYg KGlzUmVwbGFjaW5nKCkgJiYgIW1fZG9jdW1lbnRMb2FkZXIuZ2V0KCkpCg== 86726 2011-03-23 17:43:19 -0700 2011-03-23 17:44:27 -0700 updated patch StopLoadingRecursion.txt text/plain 2693 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxODI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDMtMjMgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogSW5maW5pdGUgcmVjdXJzaW9uIGluIHJl Y3Vyc2l2ZUNoZWNrTG9hZENvbXBsZXRlKCkvY2hlY2tMb2FkQ29tcGxldGVGb3JUaGlzRnJhbWUo KS9zdG9wTG9hZGluZygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01Njk3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTA0MTY3MD4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIGJlY2F1c2UgdGhlcmUgaXMgbm8ga25vd24gd2F5IHRvIHJlcHJvZHVj ZS4KKworICAgICAgICBSZW1vdmVkIHN0cmFuZ2UgY29kZSB0aGF0IHdhcyB0cnlpbmcgdG8gc3Rv cCBhIG5vbi1sb2FkaW5nIHByb3Zpc2lvbmFsIGRvY3VtZW50IGxvYWRlciBhbmQKKyAgICAgICAg ZXZlbiBpdHMgc3ViZnJhbWVzICg/ISkuIEFkZGVkIGFzc2VydGlvbnMgdG8gY2F0Y2ggaXQgaWYg d2UgY2FuIGFjdHVhbGx5IGJlIGxvYWRpbmcgaGVyZSBpbgorICAgICAgICBzb21lIHNlbnNlLgor ICAgICAgICBSZXdyb3RlIGEgY29uZGl0aW9uIGZvciBjbGFyaXR5IC0gc3RhcnRpbmcgd2l0aCBy NDMxNDgsIGl0IHdhcyBhY3RpbmcgYXMgYW4gb3Bwb3NpdGUgb2YgYQorICAgICAgICByZWN1cnNp b24gZ3VhcmQgKGJ1dCB0aGF0IGRpZG4ndCBjYXVzZSBpbW1lZGlhdGUgcHJvYmxlbXMgdGhlbiku CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOiAoV2ViQ29yZTo6RnJhbWVMb2Fk ZXI6OmNoZWNrTG9hZENvbXBsZXRlRm9yVGhpc0ZyYW1lKToKKwogMjAxMS0wMy0yMyAgTWFyayBS b3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDgxNjc3KQorKysgU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5 MSwxNiArMjM5MSwxNSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZvclRo CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBPbmx5IHJlc2V0IGlmIHdlIGFyZW4n dCBhbHJlYWR5IGdvaW5nIHRvIGEgbmV3IHByb3Zpc2lvbmFsIGl0ZW0uCiAgICAgICAgICAgICBi b29sIHNob3VsZFJlc2V0ID0gIWhpc3RvcnkoKS0+cHJvdmlzaW9uYWxJdGVtKCk7Ci0gICAgICAg ICAgICBpZiAoIShwZGwtPmlzTG9hZGluZ0luQVBJU2Vuc2UoKSAmJiAhcGRsLT5pc1N0b3BwaW5n KCkpKSB7CisgICAgICAgICAgICBpZiAoIXBkbC0+aXNMb2FkaW5nSW5BUElTZW5zZSgpIHx8IHBk bC0+aXNTdG9wcGluZygpKSkgewogICAgICAgICAgICAgICAgIG1fZGVsZWdhdGVJc0hhbmRsaW5n UHJvdmlzaW9uYWxMb2FkRXJyb3IgPSB0cnVlOwogICAgICAgICAgICAgICAgIG1fY2xpZW50LT5k aXNwYXRjaERpZEZhaWxQcm92aXNpb25hbExvYWQoZXJyb3IpOwogICAgICAgICAgICAgICAgIG1f ZGVsZWdhdGVJc0hhbmRsaW5nUHJvdmlzaW9uYWxMb2FkRXJyb3IgPSBmYWxzZTsKIAotICAgICAg ICAgICAgICAgIC8vIEZJWE1FOiBjYW4gc3RvcHBpbmcgbG9hZGluZyBoZXJlIHBvc3NpYmx5IGhh dmUgYW55IGVmZmVjdCwgaWYgaXNMb2FkaW5nIGlzIGZhbHNlLAotICAgICAgICAgICAgICAgIC8v IHdoaWNoIGl0IG11c3QgYmUgdG8gYmUgaW4gdGhpcyBicmFuY2ggb2YgdGhlIGlmPyBBbmQgaXMg aXQgT0sgdG8ganVzdCBkbyBhIGZ1bGwtb24KLSAgICAgICAgICAgICAgICAvLyBzdG9wQWxsTG9h ZGVycyBpbnN0ZWFkIG9mIHN0b3BMb2FkaW5nU3ViZnJhbWVzPwotICAgICAgICAgICAgICAgIHN0 b3BMb2FkaW5nU3ViZnJhbWVzKFNob3VsZE5vdENsZWFyUHJvdmlzaW9uYWxJdGVtKTsKLSAgICAg ICAgICAgICAgICBwZGwtPnN0b3BMb2FkaW5nKCk7CisgICAgICAgICAgICAgICAgQVNTRVJUKCFw ZGwtPmlzTG9hZGluZygpKTsKKyAgICAgICAgICAgICAgICBBU1NFUlQoIXBkbC0+aXNMb2FkaW5n TWFpblJlc291cmNlKCkpOworICAgICAgICAgICAgICAgIEFTU0VSVCghcGRsLT5pc0xvYWRpbmdT dWJyZXNvdXJjZXMoKSk7CisgICAgICAgICAgICAgICAgQVNTRVJUKCFwZGwtPmlzTG9hZGluZ1Bs dWdJbnMoKSk7CiAKICAgICAgICAgICAgICAgICAvLyBJZiB3ZSdyZSBpbiB0aGUgbWlkZGxlIG9m IGxvYWRpbmcgbXVsdGlwYXJ0IGRhdGEsIHdlIG5lZWQgdG8gcmVzdG9yZSB0aGUgZG9jdW1lbnQg bG9hZGVyLgogICAgICAgICAgICAgICAgIGlmIChpc1JlcGxhY2luZygpICYmICFtX2RvY3VtZW50 TG9hZGVyLmdldCgpKQo=