56974 2011-03-23 16:33:08 -0700 Services menu item to convert selected Simplified/Traditional Chinese Text is not working 2011-03-23 17:22:13 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica adele oldest_to_newest 372528 0 enrica 2011-03-23 16:33:08 -0700 Repro steps: 1. Launch Safari and navigate to http://www.mozilla.org/editor/midasdemo/ 2. Type "简体". 3. Control-click on the first character to bring up the context menu. 4. Choose "Convert Selected Simplified Chinese Text" Expected The character changes to 簡 Actual The character is unchanged. 372529 1 enrica 2011-03-23 16:33:42 -0700 I believe this regressed in http://trac.webkit.org/changeset/61794 where the readSelectionFromPasteboard method was removed from WebHTMLView. 372534 2 86719 enrica 2011-03-23 16:43:50 -0700 Created attachment 86719 Patch 372542 3 86719 ap 2011-03-23 16:53:45 -0700 Comment on attachment 86719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86719&action=review > Source/WebKit/mac/ChangeLog:11 > + This methos and writeSelectionToPasteboard are needed to support Mac OS X Typo: method. > Source/WebKit/mac/WebView/WebHTMLView.mm:931 > +- (BOOL)readSelectionFromPasteboard:(NSPasteboard *)pasteboard It would be good to add a comment explaining that this method is not unused (same for matching "write" one). 372543 4 ap 2011-03-23 16:54:31 -0700 <rdar://problem/8284642> 372558 5 enrica 2011-03-23 17:21:00 -0700 (In reply to comment #3) > (From update of attachment 86719 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86719&action=review > > > Source/WebKit/mac/ChangeLog:11 > > + This methos and writeSelectionToPasteboard are needed to support Mac OS X > > Typo: method. > > > Source/WebKit/mac/WebView/WebHTMLView.mm:931 > > +- (BOOL)readSelectionFromPasteboard:(NSPasteboard *)pasteboard > > It would be good to add a comment explaining that this method is not unused (same for matching "write" one). Done. Thanks for the review! 372559 6 enrica 2011-03-23 17:22:13 -0700 Committed http://trac.webkit.org/changeset/81827. 86719 2011-03-23 16:43:50 -0700 2011-03-23 16:53:45 -0700 Patch webkit1Services.txt text/plain 2973 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxODIxKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjMg IEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXJ2aWNlcyBtZW51IGl0ZW0gdG8gY29udmVy dCBzZWxlY3RlZCBTaW1wbGlmaWVkL1RyYWRpdGlvbmFsIENoaW5lc2UgVGV4dCBpcyBub3Qgd29y a2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2 OTc0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84Mjg0NjQyPgorCisgICAgICAgIFRoaXMgZml4 ZXMgYSByZWdyZXNzaW9uIGludHJvZHVjZWQgYnkgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvNjE3OTQKKyAgICAgICAgd2hlcmUgcmVhZFNlbGVjdGlvbkZyb21QYXN0ZWJvYXJkIHdh cyBhY2NpZGVudGFsbHkgcmVtb3ZlZC4KKyAgICAgICAgVGhpcyBtZXRob3MgYW5kIHdyaXRlU2Vs ZWN0aW9uVG9QYXN0ZWJvYXJkIGFyZSBuZWVkZWQgdG8gc3VwcG9ydCBNYWMgT1MgWAorICAgICAg ICBzZXJ2aWNlcy4KKyAgICAgICAgCisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToK KyAgICAgICAgKC1bV2ViSFRNTFZpZXcgX3Bhc3RlQXNQbGFpblRleHRXaXRoUGFzdGVib2FyZDpd KTogQWRkZWQuCisgICAgICAgICgtW1dlYkhUTUxWaWV3IHJlYWRTZWxlY3Rpb25Gcm9tUGFzdGVi b2FyZDpdKTogQWRkZWQuCisKIDIwMTEtMDMtMjIgIEFudG9uIEQnQXVyaWEgIDxhZGF1cmlhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRl eDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCShyZXZpc2lvbiA4MTcy MykKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHdvcmtpbmcg Y29weSkKQEAgLTM4Myw2ICszODMsNyBAQCAtIChCT09MKV9pbWFnZUV4aXN0c0F0UGF0aHM6KE5T QXJyYXkgKilwCiAtIChET01Eb2N1bWVudEZyYWdtZW50ICopX2RvY3VtZW50RnJhZ21lbnRGcm9t UGFzdGVib2FyZDooTlNQYXN0ZWJvYXJkICopcGFzdGVib2FyZCBpbkNvbnRleHQ6KERPTVJhbmdl ICopY29udGV4dCBhbGxvd1BsYWluVGV4dDooQk9PTClhbGxvd1BsYWluVGV4dDsKIC0gKE5TU3Ry aW5nICopX3BsYWluVGV4dEZyb21QYXN0ZWJvYXJkOihOU1Bhc3RlYm9hcmQgKilwYXN0ZWJvYXJk OwogLSAodm9pZClfcGFzdGVXaXRoUGFzdGVib2FyZDooTlNQYXN0ZWJvYXJkICopcGFzdGVib2Fy ZCBhbGxvd1BsYWluVGV4dDooQk9PTClhbGxvd1BsYWluVGV4dDsKKy0gKHZvaWQpX3Bhc3RlQXNQ bGFpblRleHRXaXRoUGFzdGVib2FyZDooTlNQYXN0ZWJvYXJkICopcGFzdGVib2FyZDsKIC0gKHZv aWQpX3JlbW92ZU1vdXNlTW92ZWRPYnNlcnZlclVuY29uZGl0aW9uYWxseTsKIC0gKHZvaWQpX3Jl bW92ZVN1cGVydmlld09ic2VydmVyczsKIC0gKHZvaWQpX3JlbW92ZVdpbmRvd09ic2VydmVyczsK QEAgLTkxNCw2ICs5MTUsMzEgQEAgLSAodm9pZClfcGFzdGVXaXRoUGFzdGVib2FyZDooTlNQYXN0 ZWJvYQogICAgIFt3ZWJWaWV3IHJlbGVhc2VdOwogfQogCistICh2b2lkKV9wYXN0ZUFzUGxhaW5U ZXh0V2l0aFBhc3RlYm9hcmQ6KE5TUGFzdGVib2FyZCAqKXBhc3RlYm9hcmQgCit7IAorICAgIFdl YlZpZXcgKndlYlZpZXcgPSBbW3NlbGYgX3dlYlZpZXddIHJldGFpbl07IAorICAgIFt3ZWJWaWV3 IF9zZXRJbnNlcnRpb25QYXN0ZWJvYXJkOnBhc3RlYm9hcmRdOyAKKworICAgIE5TU3RyaW5nICp0 ZXh0ID0gW3NlbGYgX3BsYWluVGV4dEZyb21QYXN0ZWJvYXJkOnBhc3RlYm9hcmRdOyAKKyAgICBp ZiAoW3NlbGYgX3Nob3VsZFJlcGxhY2VTZWxlY3Rpb25XaXRoVGV4dDp0ZXh0IGdpdmVuQWN0aW9u OldlYlZpZXdJbnNlcnRBY3Rpb25QYXN0ZWRdKSAKKyAgICAgICAgW1tzZWxmIF9mcmFtZV0gX3Jl cGxhY2VTZWxlY3Rpb25XaXRoVGV4dDp0ZXh0IHNlbGVjdFJlcGxhY2VtZW50Ok5PIHNtYXJ0UmVw bGFjZTpbc2VsZiBfY2FuU21hcnRSZXBsYWNlV2l0aFBhc3RlYm9hcmQ6cGFzdGVib2FyZF1dOyAK KworICAgIFt3ZWJWaWV3IF9zZXRJbnNlcnRpb25QYXN0ZWJvYXJkOm5pbF07IAorICAgIFt3ZWJW aWV3IHJlbGVhc2VdOworfQorCistIChCT09MKXJlYWRTZWxlY3Rpb25Gcm9tUGFzdGVib2FyZDoo TlNQYXN0ZWJvYXJkICopcGFzdGVib2FyZCAKK3sgCisgICAgRnJhbWUqIGNvcmVGcmFtZSA9IGNv cmUoW3NlbGYgX2ZyYW1lXSk7IAorICAgIGlmICghY29yZUZyYW1lKSAKKyAgICAgICAgcmV0dXJu IE5POyAKKyAgICBpZiAoY29yZUZyYW1lLT5zZWxlY3Rpb24oKS0+aXNDb250ZW50UmljaGx5RWRp dGFibGUoKSkgCisgICAgICAgIFtzZWxmIF9wYXN0ZVdpdGhQYXN0ZWJvYXJkOnBhc3RlYm9hcmQg YWxsb3dQbGFpblRleHQ6WUVTXTsgCisgICAgZWxzZSAKKyAgICAgICAgW3NlbGYgX3Bhc3RlQXNQ bGFpblRleHRXaXRoUGFzdGVib2FyZDpwYXN0ZWJvYXJkXTsgCisgICAgcmV0dXJuIFlFUzsgCit9 CisKIC0gKHZvaWQpX3JlbW92ZU1vdXNlTW92ZWRPYnNlcnZlclVuY29uZGl0aW9uYWxseQogewog ICAgIGlmICghX3ByaXZhdGUgfHwgIV9wcml2YXRlLT5vYnNlcnZpbmdNb3VzZU1vdmVkTm90aWZp Y2F0aW9ucykK