56944 2011-03-23 11:43:47 -0700 [Qt] "Unwavering" HTML5 game freezes the web page. 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED http://ippa.se/webgames/unwaivering/ Performance, Qt, QtTriaged P1 Normal --- 1 kling kling benjamin mdelaney7 oldest_to_newest 372300 0 kling 2011-03-23 11:43:47 -0700 When using the canvas getImageData() API on Qt's raster graphics system, each call causes a deep-copy of the underlying pixels. 372302 1 86656 kling 2011-03-23 11:46:18 -0700 Created attachment 86656 Proposed patch 372304 2 86656 kling 2011-03-23 11:47:01 -0700 Comment on attachment 86656 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=86656&action=review > Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:91 > + QPaintDevice* oldPaintDevice = m_pixmap.paintEngine()->paintDevice(); s/m_pixmap.paintEngine()/paintEngine/ 372306 3 86656 kenneth 2011-03-23 11:50:16 -0700 Comment on attachment 86656 Proposed patch Seems fine with me with your other fix 372309 4 86656 kenneth 2011-03-23 11:52:19 -0700 Comment on attachment 86656 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=86656&action=review >> Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:91 >> + QPaintDevice* oldPaintDevice = m_pixmap.paintEngine()->paintDevice(); > > s/m_pixmap.paintEngine()/paintEngine/ It is not really old thought :-) maybe currentPaintDevice? 372354 5 kling 2011-03-23 12:35:11 -0700 Committed r81793: <http://trac.webkit.org/changeset/81793> 86656 2011-03-23 11:46:18 -0700 2011-03-23 11:52:19 -0700 Proposed patch bug-56944.diff text/plain 3652 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MWFkZGY4Li4xNmRmN2Y3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDMtMjMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gIlVud2F2ZXJp bmciIEhUTUw1IGdhbWUgZnJlZXplcyB0aGUgd2ViIHBhZ2UuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njk0NAorCisgICAgICAgIEZvciBjYW52YXMn cyBnZXRJbWFnZURhdGEoKSBBUEksIHdlIGRvbid0IHdhbnQgdG8gbWFrZSBhIGRlZXAtY29weSBv ZgorICAgICAgICB0aGUgcGl4ZWxzLCB3aGljaCBpcyB0aGUgY2FzZSBvbiBRdCdzICJyYXN0ZXIi IGdyYXBoaWNzIHN5c3RlbS4KKworICAgICAgICBUbyB3b3JrIGFyb3VuZCB0aGlzLCB3ZSB0cmlj ayBRUGl4bWFwOjp0b0ltYWdlKCkgaW50byBnaXZpbmcgdXMgdGhlCisgICAgICAgIFFQaXhtYXAn cyBiYWNraW5nIFFJbWFnZSBieSB0ZW1wb3JhcmlseSBwb2ludGluZyB0aGUgcGFpbnQgZW5naW5l IHRvCisgICAgICAgIGEgbnVsbCBwYWludCBkZXZpY2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9xdC9JbWFnZUJ1ZmZlckRhdGEuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9xdC9JbWFnZUJ1ZmZlclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyRGF0 YTo6dG9RSW1hZ2UpOiBBZGRlZCwgcmV0dXJucyB0aGUKKyAgICAgICAgSW1hZ2VCdWZmZXJEYXRh IGFzIGEgUUltYWdlLCBhdm9pZGluZyBhIGJhY2tlbmQgZGVlcC1jb3B5IGlmIHBvc3NpYmxlLgor ICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnBsYXRmb3JtVHJhbnNmb3JtQ29sb3JTcGFj ZSk6CisgICAgICAgIChXZWJDb3JlOjpnZXRJbWFnZURhdGEpOgorCiAyMDExLTAzLTIyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9JbWFnZUJ1ZmZlckRhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0ltYWdlQnVmZmVyRGF0YS5oCmluZGV4IGFhMzIyNTMuLjYwMjE5N2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyRGF0 YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVy RGF0YS5oCkBAIC00Miw2ICs0Miw4IEBAIGNsYXNzIEltYWdlQnVmZmVyRGF0YSB7CiBwdWJsaWM6 CiAgICAgSW1hZ2VCdWZmZXJEYXRhKGNvbnN0IEludFNpemUmKTsKIAorICAgIFFJbWFnZSB0b1FJ bWFnZSgpIGNvbnN0OworCiAgICAgUVBpeG1hcCBtX3BpeG1hcDsKICAgICBPd25QdHI8UVBhaW50 ZXI+IG1fcGFpbnRlcjsKICAgICBSZWZQdHI8SW1hZ2U+IG1faW1hZ2U7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCmluZGV4 IGQyNjBiNTQuLjY3YjExMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCkBAIC04MCw2ICs4MCwyMSBAQCBJbWFnZUJ1 ZmZlckRhdGE6OkltYWdlQnVmZmVyRGF0YShjb25zdCBJbnRTaXplJiBzaXplKQogICAgIG1faW1h Z2UgPSBTdGlsbEltYWdlOjpjcmVhdGVGb3JSZW5kZXJpbmcoJm1fcGl4bWFwKTsKIH0KIAorUUlt YWdlIEltYWdlQnVmZmVyRGF0YTo6dG9RSW1hZ2UoKSBjb25zdAoreworICAgIFFQYWludEVuZ2lu ZSogcGFpbnRFbmdpbmUgPSBtX3BpeG1hcC5wYWludEVuZ2luZSgpOworICAgIGlmICghcGFpbnRF bmdpbmUgfHwgcGFpbnRFbmdpbmUtPnR5cGUoKSAhPSBRUGFpbnRFbmdpbmU6OlJhc3RlcikKKyAg ICAgICAgcmV0dXJuIG1fcGl4bWFwLnRvSW1hZ2UoKTsKKworICAgIC8vIFFSYXN0ZXJQaXhtYXBE YXRhOjp0b0ltYWdlKCkgd2lsbCBkZWVwLWNvcHkgdGhlIGJhY2tpbmcgUUltYWdlIGlmIHRoZXJl J3MgYW4gYWN0aXZlIFFQYWludGVyIG9uIGl0LgorICAgIC8vIEZvciBwZXJmb3JtYW5jZSByZWFz b25zLCB3ZSBkb24ndCB3YW50IHRoYXQgaGVyZSwgc28gd2UgdGVtcG9yYXJpbHkgcmVkaXJlY3Qg dGhlIHBhaW50IGVuZ2luZS4KKyAgICBRUGFpbnREZXZpY2UqIG9sZFBhaW50RGV2aWNlID0gbV9w aXhtYXAucGFpbnRFbmdpbmUoKS0+cGFpbnREZXZpY2UoKTsKKyAgICBwYWludEVuZ2luZS0+c2V0 UGFpbnREZXZpY2UoMCk7CisgICAgUUltYWdlIGltYWdlID0gbV9waXhtYXAudG9JbWFnZSgpOwor ICAgIHBhaW50RW5naW5lLT5zZXRQYWludERldmljZShvbGRQYWludERldmljZSk7CisgICAgcmV0 dXJuIGltYWdlOworfQorCiBJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIoY29uc3QgSW50U2l6ZSYg c2l6ZSwgQ29sb3JTcGFjZSwgUmVuZGVyaW5nTW9kZSwgYm9vbCYgc3VjY2VzcykKICAgICA6IG1f ZGF0YShzaXplKQogICAgICwgbV9zaXplKHNpemUpCkBAIC0xNTksNyArMTc0LDcgQEAgdm9pZCBJ bWFnZUJ1ZmZlcjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKGNvbnN0IFZlY3RvcjxpbnQ+ JiBsb29rVXBUYWJsZSkKICAgICBpZiAoaXNQYWludGluZykKICAgICAgICAgbV9kYXRhLm1fcGFp bnRlci0+ZW5kKCk7CiAKLSAgICBRSW1hZ2UgaW1hZ2UgPSBtX2RhdGEubV9waXhtYXAudG9JbWFn ZSgpLmNvbnZlcnRUb0Zvcm1hdChRSW1hZ2U6OkZvcm1hdF9BUkdCMzIpOworICAgIFFJbWFnZSBp bWFnZSA9IG1fZGF0YS50b1FJbWFnZSgpLmNvbnZlcnRUb0Zvcm1hdChRSW1hZ2U6OkZvcm1hdF9B UkdCMzIpOwogICAgIEFTU0VSVCghaW1hZ2UuaXNOdWxsKCkpOwogCiAgICAgdWNoYXIqIGJpdHMg PSBpbWFnZS5iaXRzKCk7CkBAIC0yMTQsNyArMjI5LDcgQEAgUGFzc1JlZlB0cjxCeXRlQXJyYXk+ IGdldEltYWdlRGF0YShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBJbWFnZUJ1ZmZlckRhdGEm IGkKICAgICBpbnQgbnVtUm93cyA9IGVuZHkgLSBvcmlnaW55OwogCiAgICAgLy8gTk9URTogRm9y IHVubXVsdGlwbGllZCBkYXRhLCB3ZSB1bmRvIHRoZSBwcmVtdWx0aXBsaWNhdGlvbiBiZWxvdy4K LSAgICBRSW1hZ2UgaW1hZ2UgPSBpbWFnZURhdGEubV9waXhtYXAudG9JbWFnZSgpLmNvbnZlcnRU b0Zvcm1hdChRSW1hZ2U6OkZvcm1hdF9BUkdCMzJfUHJlbXVsdGlwbGllZCk7CisgICAgUUltYWdl IGltYWdlID0gaW1hZ2VEYXRhLnRvUUltYWdlKCkuY29udmVydFRvRm9ybWF0KFFJbWFnZTo6Rm9y bWF0X0FSR0IzMl9QcmVtdWx0aXBsaWVkKTsKIAogICAgIEFTU0VSVCghaW1hZ2UuaXNOdWxsKCkp OwogCg==