56943 2011-03-23 11:41:04 -0700 CSS3 nth-child(n) selector fails 2011-05-01 10:08:43 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://tools.css3.info/selectors-test/test.html P2 Normal --- 1 ianet webkit-unassigned commit-queue eric lea yael oldest_to_newest 372297 0 86654 ianet 2011-03-23 11:41:04 -0700 Created attachment 86654 nth-child(n) test case The nth-child(n) CSS3 test fails although nth-child(1n) passes. See the attached test, the background for the 4 elements should be red. 372305 1 86658 ianet 2011-03-23 11:49:42 -0700 Created attachment 86658 Simpler test case Added a simpler test from Tab, text in the test should be green 378391 2 lea 2011-04-02 07:46:15 -0700 FWIW, here's another testcase: http://jsfiddle.net/leaverou/Cum32/ 395849 3 91811 yael 2011-04-30 21:03:05 -0700 Created attachment 91811 Patch. 395920 4 91811 eric 2011-05-01 09:44:55 -0700 Comment on attachment 91811 Patch. OK. 395921 5 eric 2011-05-01 09:45:30 -0700 The spec link in the ChangeLog or source would have been nice. :) Also generally our test cases use 4-space indent (like the rest of our code), but it's not a big deal. 395937 6 91811 commit-queue 2011-05-01 10:08:37 -0700 Comment on attachment 91811 Patch. Clearing flags on attachment: 91811 Committed r85416: <http://trac.webkit.org/changeset/85416> 395938 7 commit-queue 2011-05-01 10:08:43 -0700 All reviewed patches have been landed. Closing bug. 86654 2011-03-23 11:41:04 -0700 2011-03-23 11:49:42 -0700 nth-child(n) test case nth-child(n)-test.html text/html 533 ianet PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIgogICAiaHR0 cDovL3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+Cgo8aHRtbCBsYW5nPSJlbiI+Cgo8 aGVhZD4KCTxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1s OyBjaGFyc2V0PXV0Zi04Ij4KCTx0aXRsZT5udGgtY2hpbGQobikgVGVzdDwvdGl0bGU+Cgk8c3R5 bGUgdHlwZT0ndGV4dC9jc3MnPgoJCS5yZWQtbiA6bnRoLWNoaWxkKG4pIHsKCQkJYmFja2dyb3Vu ZC1jb2xvcjogI0YwMDsKCQl9Cgk8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9keT4KCTxkaXYgY2xhc3M9 J3JlZC1uJz4gCgkJPGRpdj5CYWNrZ3JvdW5kIHNob3VsZCBiZSByZWQ8L2Rpdj4gCgkJPGRpdj5C YWNrZ3JvdW5kIHNob3VsZCBiZSByZWQ8L2Rpdj4gCgkJPGRpdj5CYWNrZ3JvdW5kIHNob3VsZCBi ZSByZWQ8L2Rpdj4gCgkJPGRpdj5CYWNrZ3JvdW5kIHNob3VsZCBiZSByZWQ8L2Rpdj4gCgk8L2Rp dj4KPC9ib2R5PgoKPC9odG1sPgo= 86658 2011-03-23 11:49:42 -0700 2011-03-23 11:49:42 -0700 Simpler test case nth-child(n)-test2.html text/html 224 ianet PCFkb2N0eXBlIGh0bWw+CjxzdHlsZT4KcCB7IGNvbG9yOiByZWQ7IH0KcDpudGgtY2hpbGQobikg eyBjb2xvcjogZ3JlZW47IH0KPC9zdHlsZT4KPHA+VGVzdCBwYXNzZXMgb25seSBpZiB0aGlzIHRl eHQgaXMgZ3JlZW4uPC9wPgo8cD5UZXN0IHBhc3NlcyBvbmx5IGlmIHRoaXMgdGV4dCBpcyBncmVl bi48L3A+CjxwPlRlc3QgcGFzc2VzIG9ubHkgaWYgdGhpcyB0ZXh0IGlzIGdyZWVuLjwvcD4= 91811 2011-04-30 21:03:05 -0700 2011-05-01 10:08:37 -0700 Patch. 56943.patch text/plain 4076 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NDA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMzAgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTUzMgbnRoLWNoaWxkKG4pIHNlbGVjdG9yIGZhaWxzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njk0MworCisg ICAgICAgIFJlZ3Jlc3Npb24gZnJvbSByNzUxNTguCisgICAgICAgICJuIiBpcyBhIHZhbGlkIHBh cmFtZXRlciB0byBudGgoKSBhbmQgc2hvdWxkIGJlIGFsbG93ZWQuCisKKyAgICAgICAgVGVzdDog ZmFzdC9jc3MvbnRoLWNoaWxkLW4uaHRtbAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjppc1ZhbGlkTnRoVG9rZW4pOgorCiAyMDExLTA0LTMwICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZpZXdl ZDogaW5zcGVjdG9yIHRvb2xiYXIgdGl0bGVzIHdlcmUgMnB4IG9mZi4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCShyZXZpc2lvbiA4NTQwNCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NzcyLDggKzY3NzIsOCBAQCBTdHJpbmcg cXVvdGVDU1NVUkxJZk5lZWRlZChjb25zdCBTdHJpbmcmCiBib29sIGlzVmFsaWROdGhUb2tlbihj b25zdCBDU1NQYXJzZXJTdHJpbmcmIHRva2VuKQogewogICAgIC8vIFRoZSB0b2tlbml6ZXIgY2hl Y2tzIGZvciB0aGUgY29uc3RydWN0IG9mIGFuK2IuCi0gICAgLy8gbnRoIGNhbiBhbHNvIGFjY2Vw dCAib2RkIiBvciAiZXZlbiIgYnV0IHNob3VsZCBub3QgYWNjZXB0IGFueSBvdGhlciB0b2tlbi4K LSAgICByZXR1cm4gZXF1YWxJZ25vcmluZ0Nhc2UodG9rZW4sICJvZGQiKSB8fCBlcXVhbElnbm9y aW5nQ2FzZSh0b2tlbiwgImV2ZW4iKTsKKyAgICAvLyBudGggY2FuIGFsc28gYWNjZXB0ICJuIiwg Im9kZCIgb3IgImV2ZW4iIGJ1dCBzaG91bGQgbm90IGFjY2VwdCBhbnkgb3RoZXIgdG9rZW4uCisg ICAgcmV0dXJuIGVxdWFsSWdub3JpbmdDYXNlKHRva2VuLCAib2RkIikgfHwgZXF1YWxJZ25vcmlu Z0Nhc2UodG9rZW4sICJldmVuIikgfHwgZXF1YWxJZ25vcmluZ0Nhc2UodG9rZW4sICJuIik7CiB9 CiAKICNkZWZpbmUgWVlfREVDTCBpbnQgQ1NTUGFyc2VyOjpsZXgoKQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gODU0MDQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0wNC0zMCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ1NT MyBudGgtY2hpbGQobikgc2VsZWN0b3IgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU2OTQzCisKKyAgICAgICAgKiBmYXN0L2Nzcy9udGgtY2hp bGQtbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL250aC1jaGlsZC1u Lmh0bWw6IEFkZGVkLgorCiAyMDExLTA0LTMwICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNv bT4KIAogICAgICAgICBTa2lwIGFub3RoZXIgdGVzdCB0aGF0IHJlcXVpcmVzIGxheW91dFRlc3RD b250cm9sbGVyLnNldEFsd2F5c0FjY2VwdENvb2tpZXMgb24gbWFjLXdrMgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9jc3MvbnRoLWNoaWxkLW4tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGlsZC1uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGlsZC1uLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw1IEBACitUaGUgdGVzdCBwYXNzZXMgaWYgYWxsIERJVnMgYXJlIGdy ZWVuLgorCitESVYxCitESVYyCitQYXNzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9udGgt Y2hpbGQtbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL250aC1jaGls ZC1uLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9udGgtY2hpbGQt bi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDU3IEBACis8IURPQ1RZUEUgSFRNTCBQVUJM SUMgIi0vL1czQy8vRFREIEhUTUwgNC4wIFN0cmljdC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzx0 aXRsZT5DU1MgVGVzdDogOm50aC1jaGlsZChuKSBzZWxlY3RvcjwvdGl0bGU+Cis8c3R5bGUgdHlw ZT0idGV4dC9jc3MiPgorZGl2IGRpdjpudGgtY2hpbGQobikgeyBjb2xvcjogZ3JlZW47IH0KKzwv c3R5bGU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgd2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKQorPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keT4KKzxwPlRoZSB0ZXN0IHBhc3NlcyBpZiBhbGwgRElWcyBhcmUgZ3JlZW4uPC9wPgor PGRpdiBpZD0idGVzdCI+Cis8ZGl2PkRJVjE8L2Rpdj4KKzxkaXY+RElWMjwvZGl2PgorPC9kaXY+ Cis8ZGl2IGlkPSJ0ZXN0cmVzdWx0IiBzdHlsZT0iY29sb3I6IGJsdWUiPlJ1bm5pbmc8L2Rpdj4K KzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2Z1bmN0aW9uIEFycmF5Q29udGFpbnMo YXJyYXksIHZhbHVlLCBjaSkKK3sKKyAgY2kgPSBjaSA9PSB0cnVlID8gdHJ1ZSA6IGZhbHNlOwor ICBmb3IgKHZhciBpID0gMDsgaSA8IGFycmF5Lmxlbmd0aDsgaSsrKQorICB7CisgICAgaWYgKGNp ICYmIGFycmF5W2ldLnRvTG93ZXJDYXNlKCkgPT0gdmFsdWUudG9Mb3dlckNhc2UoKSkKKyAgICB7 CisgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgZWxzZSBpZiAoYXJyYXlbaV0gPT0gdmFs dWUpCisgICAgeworICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorICB9CisgIHJldHVybiBmYWxz ZTsKK30KKworZnVuY3Rpb24gVGVzdENhc2UoKQoreworICB0cnkKKyAgeworICAgIHZhciBncmVl blZhbHVlcyA9IG5ldyBBcnJheSgiZ3JlZW4iLCAiIzAwODAwMCIsICJyZ2IoMCwgMTI4LCAwKSIp OworCisgICAgdmFyIGVsZW0gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpOworICAg IHZhciB2YWwgPSBnZXRDb21wdXRlZFN0eWxlKGVsZW0uY2hpbGRyZW5bMF0sIG51bGwpLmdldFBy b3BlcnR5VmFsdWUoImNvbG9yIik7CisgICAgaWYgKEFycmF5Q29udGFpbnMoZ3JlZW5WYWx1ZXMs IHZhbCwgZmFsc2UpKQorICAgIHsKKyAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0 cmVzdWx0IikuaW5uZXJIVE1MID0gIlBhc3MiOworICAgICAgcmV0dXJuOworICAgIH0KKyAgfWNh dGNoKGUpe30KKyAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RyZXN1bHQiKS5pbm5lckhU TUwgPSAiRmFpbCI7Cit9CitUZXN0Q2FzZSgpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=