56923 2011-03-23 07:23:43 -0700 Regression: WebKit does not build with Python 3 following 56807 2011-03-24 07:15:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P5 Enhancement --- 56807 1 benjamin benjamin benjamin commit-queue eric oldest_to_newest 372130 0 benjamin 2011-03-23 07:23:43 -0700 The following broke the build because string.replace has been removed from Python 3. diff --git a/Source/WebCore/inspector/generate-inspector-idl b/Source/WebCore/inspector/generate-inspector-idl index 5712f40..c4b9c1b 100755 --- a/Source/WebCore/inspector/generate-inspector-idl +++ b/Source/WebCore/inspector/generate-inspector-idl @@ -41,6 +41,8 @@ input_path = sys.argv[3] input_file = open(input_path, "r") json_string = input_file.read() +json_string = string.replace(json_string, ": true", ": True") +json_string = string.replace(json_string, ": false", ": false") json_api = eval(json_string) output_file = open(output_path, "w") 372133 1 86615 benjamin 2011-03-23 07:32:24 -0700 Created attachment 86615 Patch 372747 2 86615 kling 2011-03-24 05:04:29 -0700 Comment on attachment 86615 Patch rs=me 372783 3 commit-queue 2011-03-24 06:45:09 -0700 The commit-queue encountered the following flaky tests while processing attachment 86615: http/tests/websocket/tests/workers/close-in-onmessage-crash.html bug 57011 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 372785 4 86615 commit-queue 2011-03-24 06:48:36 -0700 Comment on attachment 86615 Patch Clearing flags on attachment: 86615 Committed r81863: <http://trac.webkit.org/changeset/81863> 372786 5 commit-queue 2011-03-24 06:48:40 -0700 All reviewed patches have been landed. Closing bug. 372799 6 commit-queue 2011-03-24 07:15:03 -0700 The commit-queue encountered the following flaky tests while processing attachment 86615: java/lc3/JavaObject/JavaObjectToLong-004-n.html bug 57012 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 86615 2011-03-23 07:32:24 -0700 2011-03-24 06:48:36 -0700 Patch 56923.diff text/plain 1583 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDAzNTBjLi4zMjNlMzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDMtMjMgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWdyZXNzaW9uOiBXZWJLaXQgZG9lcyBub3QgYnVpbGQgd2l0aCBQeXRob24gMyBmb2xsb3dpbmcg NTY4MDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2 OTIzCisKKyAgICAgICAgVGhlIG1vZHVsZSBzdHJpbmcgZG9lcyBub3QgaGF2ZSB0aGUgZnVuY3Rp b24gcmVwbGFjZSBpbiBQeXRob24gMy4gVGhlIHN0ci5yZXBsYWNlIGZ1bmN0aW9uCisgICAgICAg IGNhbiBkbyB0aGUgc2FtZSBvcGVyYXRpb24gaW4gdGhpcyBjYXNlIGFuZCB3b3JrcyB3aXRoIHRo ZSB2ZXJzaW9ucyAyIGFuZCAzLgorCisgICAgICAgICogaW5zcGVjdG9yL2dlbmVyYXRlLWluc3Bl Y3Rvci1pZGw6CisKIDIwMTEtMDMtMjMgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZ2VuZXJhdGUtaW5zcGVjdG9yLWlkbCBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9nZW5lcmF0ZS1pbnNwZWN0b3ItaWRsCmluZGV4IGM0YjljMWIu LmI5NzU5NjMgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9nZW5lcmF0ZS1p bnNwZWN0b3ItaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9nZW5lcmF0ZS1pbnNw ZWN0b3ItaWRsCkBAIC0yOCw3ICsyOCw2IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGltcG9ydCBvcy5w YXRoCi1pbXBvcnQgc3RyaW5nCiBpbXBvcnQgc3lzCiAKIHByb2dyYW1fbmFtZSA9IG9zLnBhdGgu YmFzZW5hbWUoX19maWxlX18pCkBAIC00MSw4ICs0MCw4IEBAIGlucHV0X3BhdGggPSBzeXMuYXJn dlszXQogCiBpbnB1dF9maWxlID0gb3BlbihpbnB1dF9wYXRoLCAiciIpCiBqc29uX3N0cmluZyA9 IGlucHV0X2ZpbGUucmVhZCgpCi1qc29uX3N0cmluZyA9IHN0cmluZy5yZXBsYWNlKGpzb25fc3Ry aW5nLCAiOiB0cnVlIiwgIjogVHJ1ZSIpCi1qc29uX3N0cmluZyA9IHN0cmluZy5yZXBsYWNlKGpz b25fc3RyaW5nLCAiOiBmYWxzZSIsICI6IGZhbHNlIikKK2pzb25fc3RyaW5nID0ganNvbl9zdHJp bmcucmVwbGFjZSgiOiB0cnVlIiwgIjogVHJ1ZSIpCitqc29uX3N0cmluZyA9IGpzb25fc3RyaW5n LnJlcGxhY2UoIjogZmFsc2UiLCAiOiBmYWxzZSIpCiBqc29uX2FwaSA9IGV2YWwoanNvbl9zdHJp bmcpCiAKIG91dHB1dF9maWxlID0gb3BlbihvdXRwdXRfcGF0aCwgInciKQo=