<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>56920</bug_id>
          
          <creation_ts>2011-03-23 06:39:27 -0700</creation_ts>
          <short_desc>Web Inspector: use unsigned char instead of char when storing script source</short_desc>
          <delta_ts>2011-03-23 07:05:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Yury Semikhatsky">yurys</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>372115</commentid>
    <comment_count>0</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2011-03-23 06:39:27 -0700</bug_when>
    <thetext>Web Inspector: use unsigned char instead of char when storing script source since the constant is represented by hex values and may otherwise lead to compilation warnings on some platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>372116</commentid>
    <comment_count>1</comment_count>
      <attachid>86609</attachid>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2011-03-23 06:41:10 -0700</bug_when>
    <thetext>Created attachment 86609
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>372128</commentid>
    <comment_count>2</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2011-03-23 07:05:28 -0700</bug_when>
    <thetext>Committed r81773: &lt;http://trac.webkit.org/changeset/81773&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>86609</attachid>
            <date>2011-03-23 06:41:10 -0700</date>
            <delta_ts>2011-03-23 06:42:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-56920-20110323164107.patch</filename>
            <type>text/plain</type>
            <size>4665</size>
            <attacher name="Yury Semikhatsky">yurys</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODE3NzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNWY4MjQ1ZDllOWU1OTRm
NDBkOWQyMmNiMzIyZGU4YTA0MzUxMzEzLi5iOThjODBhMWY3YjA0N2Q4NWQyNzM2YjhlOTljNzZk
YjI1YjhlY2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMjMgIFl1cnkg
U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogdXNlIHVuc2lnbmVkIGNo
YXIgaW5zdGVhZCBvZiBjaGFyIHdoZW4gc3RvcmluZyBzY3JpcHQgc291cmNlCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjkyMAorCisgICAgICAgICog
YmluZGluZ3MvdjgvRGVidWdnZXJTY3JpcHQuanM6CisgICAgICAgICogYmluZGluZ3MvdjgvU2Ny
aXB0RGVidWdTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGVidWdTZXJ2ZXI6
OmVuc3VyZURlYnVnZ2VyU2NyaXB0Q29tcGlsZWQpOgorICAgICAgICAqIGluc3BlY3Rvci9Jbmpl
Y3RlZFNjcmlwdE1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5qZWN0ZWRTY3JpcHRN
YW5hZ2VyOjppbmplY3RlZFNjcmlwdFNvdXJjZSk6CisgICAgICAgICogaW5zcGVjdG9yL0luamVj
dGVkU2NyaXB0U291cmNlLmpzOiB3aGl0ZXNwYWNlIGNoYW5nZSB0byB0cmlnZ2VyIGNvbXBpbGF0
aW9uCisgICAgICAgICogaW5zcGVjdG9yL3h4ZC5wbDoKKyAgICAgICAgKiB4bWwvWE1MVmlld2Vy
LnhzbDoKKwogMjAxMS0wMy0yMyAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RlYnVnZ2VyU2NyaXB0LmpzIGIvU291cmNlL1dl
YkNvcmUvYmluZGluZ3MvdjgvRGVidWdnZXJTY3JpcHQuanMKaW5kZXggMGJlZDMzZDg3ZTZmZDQz
ZjRkZTJmZjU3NTY4Y2RmNTljMjRiYWJjNi4uZmU2ZThhYjZkOGIxYmVjZDk0OTE0YjhmOGU3ZTNl
NzRiYTlhMTNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRGVidWdn
ZXJTY3JpcHQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRGVidWdnZXJTY3Jp
cHQuanMKQEAgLTI2Miw1ICsyNjIsNCBAQCBEZWJ1Z2dlclNjcmlwdC5fZnJhbWVNaXJyb3JUb0pT
Q2FsbEZyYW1lID0gZnVuY3Rpb24oZnJhbWVNaXJyb3IsIGNhbGxlckZyYW1lKQogfQogCiByZXR1
cm4gRGVidWdnZXJTY3JpcHQ7Ci0KIH0pKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i
aW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n
cy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggMzQxMzQwYjg2ZGNkOWYwZjAyMjJjYjE2
Nzk3ZGVlN2RjZDFlNDQ3MC4uYTJjZjMwYTIwYzFhMTkyYmNiYmIxZTZlZTJlNzNiOGIxMzAwNmU4
NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2
ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVy
LmNwcApAQCAtNDUwLDcgKzQ1MCw3IEBAIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmVuc3VyZURl
YnVnZ2VyU2NyaXB0Q29tcGlsZWQoKQogICAgICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CiAg
ICAgICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gZGVidWdnZXJDb250ZXh0ID0gdjg6OkRlYnVn
OjpHZXREZWJ1Z0NvbnRleHQoKTsKICAgICAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRT
Y29wZShkZWJ1Z2dlckNvbnRleHQpOwotICAgICAgICBTdHJpbmcgZGVidWdnZXJTY3JpcHRTb3Vy
Y2UoRGVidWdnZXJTY3JpcHRTb3VyY2VfanMsIHNpemVvZihEZWJ1Z2dlclNjcmlwdFNvdXJjZV9q
cykpOworICAgICAgICBTdHJpbmcgZGVidWdnZXJTY3JpcHRTb3VyY2UocmVpbnRlcnByZXRfY2Fz
dDxjb25zdCBjaGFyKj4oRGVidWdnZXJTY3JpcHRTb3VyY2VfanMpLCBzaXplb2YoRGVidWdnZXJT
Y3JpcHRTb3VyY2VfanMpKTsKICAgICAgICAgbV9kZWJ1Z2dlclNjcmlwdC5zZXQodjg6OkhhbmRs
ZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2ODo6U2NyaXB0OjpDb21waWxlKHY4U3RyaW5nKGRlYnVnZ2Vy
U2NyaXB0U291cmNlKSktPlJ1bigpKSk7CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLmNwcAppbmRleCBjM2IxODAyM2M1NDk1
NGZmOTgyYWY1NWRmNDRmODBkNDYxNDg2YWZiLi41YzIxODAyMjkxOTkyMTk5ZmJlYzA4NWQ0MTY5
MWMwNjliYTc5ODY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0
ZWRTY3JpcHRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0
ZWRTY3JpcHRNYW5hZ2VyLmNwcApAQCAtMTAzLDcgKzEwMyw3IEBAIHZvaWQgSW5qZWN0ZWRTY3Jp
cHRNYW5hZ2VyOjpyZWxlYXNlT2JqZWN0R3JvdXAoY29uc3QgU3RyaW5nJiBvYmplY3RHcm91cCkK
IAogU3RyaW5nIEluamVjdGVkU2NyaXB0TWFuYWdlcjo6aW5qZWN0ZWRTY3JpcHRTb3VyY2UoKQog
ewotICAgIHJldHVybiBTdHJpbmcoSW5qZWN0ZWRTY3JpcHRTb3VyY2VfanMsIHNpemVvZihJbmpl
Y3RlZFNjcmlwdFNvdXJjZV9qcykpOworICAgIHJldHVybiBTdHJpbmcocmVpbnRlcnByZXRfY2Fz
dDxjb25zdCBjaGFyKj4oSW5qZWN0ZWRTY3JpcHRTb3VyY2VfanMpLCBzaXplb2YoSW5qZWN0ZWRT
Y3JpcHRTb3VyY2VfanMpKTsKIH0KIAogcGFpcjxsb25nLCBTY3JpcHRPYmplY3Q+IEluamVjdGVk
U2NyaXB0TWFuYWdlcjo6aW5qZWN0U2NyaXB0KGNvbnN0IFN0cmluZyYgc291cmNlLCBTY3JpcHRT
dGF0ZSogc2NyaXB0U3RhdGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv
SW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0
ZWRTY3JpcHRTb3VyY2UuanMKaW5kZXggOTY4YjUxNmIwZTYwZGNlN2E3NmI5YmIwNDQxNTBiYmRj
OGMyYzMzMC4uZjQ5OWExNzZkNDQ0NTJhNTljYTdlNWRiZjZhZmNjNTc4YTAwMGQzZCAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwpAQCAt
Njk4LDYgKzY5OCw1IEBAIENvbW1hbmRMaW5lQVBJSW1wbC5wcm90b3R5cGUgPSB7CiB9CiAKIGlu
amVjdGVkU2NyaXB0Ll9jb21tYW5kTGluZUFQSUltcGwgPSBuZXcgQ29tbWFuZExpbmVBUElJbXBs
KCk7Ci0KIHJldHVybiBpbmplY3RlZFNjcmlwdDsKIH0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9pbnNwZWN0b3IveHhkLnBsIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL3h4ZC5wbApp
bmRleCBkMjk0MTVhNmU0MDliYWViZWQ5ZGI5NWNlNjUwMmFlZjkzYzMwNDBhLi41ZWUwOGE1MmQ4
ZTY2Y2ZkYTNjMDgzZjdhZGIxNWY5NmMwOGE5YjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9pbnNwZWN0b3IveHhkLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci94eGQucGwK
QEAgLTQxLDUgKzQxLDUgQEAgY2xvc2UoJGlucHV0KTsKICR0ZXh0ID0gam9pbignLCAnLCBtYXAo
JzB4JyAuIHVucGFjaygiSCoiLCAkXyksIHNwbGl0KHVuZGVmLCAkdGV4dCkpKTsKIAogb3Blbigk
b3V0cHV0LCAnPicsICRvdXRwdXQpIG9yIGRpZSAiQ2FuJ3Qgb3BlbiBmaWxlIGZvciB3cml0ZTog
JG91dHB1dCAkISI7Ci1wcmludCAkb3V0cHV0ICJjb25zdCBjaGFyICR2YXJuYW1lXFtcXSA9IHtc
biR0ZXh0XG59O1xuIjsKK3ByaW50ICRvdXRwdXQgImNvbnN0IHVuc2lnbmVkIGNoYXIgJHZhcm5h
bWVcW1xdID0ge1xuJHRleHRcbn07XG4iOwogY2xvc2UoJG91dHB1dCk7CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS94bWwvWE1MVmlld2VyLnhzbCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxW
aWV3ZXIueHNsCmluZGV4IGNiNjY4NTgzMDgwNWM4NzVhMzBkZWI4ZTc2MTA1MDE4Mzk2YTcwMzIu
LjFiNjE2ZjJhMmJkM2QzYzMwMmZiMTkzNmNiOGEwYjA1MDQ2NDUzYWYgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3htbC9YTUxWaWV3ZXIueHNsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9Y
TUxWaWV3ZXIueHNsCkBAIC0zMzksNyArMzM5LDYgQEAKICAgICAgICAgICAgICAgICAgICAvLyBU
byBwcmV2ZW50IHNlbGVjdGlvbiBvbiBkb3VibGUgY2xpY2sKICAgICAgICAgICAgICAgICAgICBl
LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICAgICAgfQotCiAgICAgICAgICAgICA8L3hz
bDp0ZXh0PgogICAgICAgICA8L3NjcmlwdD4KICAgICA8L3hzbDp0ZW1wbGF0ZT4K
</data>
<flag name="review"
          id="78912"
          type_id="1"
          status="+"
          setter="pfeldman"
    />
          </attachment>
      

    </bug>

</bugzilla>