56890 2011-03-22 19:16:38 -0700 It is possible to calculate a NaN value for "value" in ScrollbarThemeMac::paint() 2011-03-22 20:16:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 371912 0 bdakin 2011-03-22 19:16:38 -0700 In ScrollbarThemeMac::paint() the following code can result in value being NaN, which is not great: else { // Within the bounds of the scrollable area. value = scrollbar->currentPos() / scrollbar->maximum(); } Patch forthcoming. <rdar://problem/9160621> 371913 1 86561 bdakin 2011-03-22 19:19:51 -0700 Created attachment 86561 Patch 371921 2 86561 sam 2011-03-22 19:43:42 -0700 Comment on attachment 86561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86561&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:445 > + if (max > 0) > + value = scrollbar->currentPos() / max; I think the whole word maximum here would be better. 371939 3 bdakin 2011-03-22 20:16:59 -0700 Fixed with revision 81745. Thanks, Sam! 86561 2011-03-22 19:19:51 -0700 2011-03-22 19:43:42 -0700 Patch for-review.txt text/plain 1527 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNzQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMjIgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU2ODkwIEl0IGlzIHBvc3NpYmxlIHRvIGNhbGN1bGF0ZSBhIAorICAgICAgICBOYU4g dmFsdWUgZm9yICJ2YWx1ZSIgaW4gU2Nyb2xsYmFyVGhlbWVNYWM6OnBhaW50KCkKKyAgICAgICAg LWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTE2MDYyMT4KKwor ICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjpwYWludCk6CisKIDIwMTEtMDMtMTcgIE9qYW4gVmFm YWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2 aXN0by4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1h Yy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFy VGhlbWVNYWMubW0JKHJldmlzaW9uIDgxNTk3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NDAsNyArNDQwLDEx IEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVNYWM6OnBhaW50KFNjcm9sbGJhcioKICAgICAgICAgb3Zl cmhhbmcgPSBzY3JvbGxiYXItPmN1cnJlbnRQb3MoKSArIHNjcm9sbGJhci0+dmlzaWJsZVNpemUo KSAtIHNjcm9sbGJhci0+dG90YWxTaXplKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gV2l0 aGluIHRoZSBib3VuZHMgb2YgdGhlIHNjcm9sbGFibGUgYXJlYS4KLSAgICAgICAgdmFsdWUgPSBz Y3JvbGxiYXItPmN1cnJlbnRQb3MoKSAvIHNjcm9sbGJhci0+bWF4aW11bSgpOworICAgICAgICBp bnQgbWF4ID0gc2Nyb2xsYmFyLT5tYXhpbXVtKCk7CisgICAgICAgIGlmIChtYXggPiAwKQorICAg ICAgICAgICAgdmFsdWUgPSBzY3JvbGxiYXItPmN1cnJlbnRQb3MoKSAvIG1heDsKKyAgICAgICAg ZWxzZQorICAgICAgICAgICAgdmFsdWUgPSAwOwogICAgIH0KIAogICAgIFNjcm9sbEFuaW1hdG9y TWFjKiBzY3JvbGxBbmltYXRvciA9IHN0YXRpY19jYXN0PFNjcm9sbEFuaW1hdG9yTWFjKj4oc2Ny b2xsYmFyLT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxBbmltYXRvcigpKTsK