56885 2011-03-22 17:23:05 -0700 WebFrame::createAssociatedURLLoader can't accept WebURLLoaderOptions 2011-03-24 16:56:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bbudge webkit-unassigned abarth ap commit-queue dimich eric levin webkit.review.bot oldest_to_newest 371855 0 bbudge 2011-03-22 17:23:05 -0700 WebFrame's createAssociatedURLLoader method takes no parameters, so the returned WebURLLoader can't be configured for CORS support. We should add an overload, or a parameter with a default value to the existing method declaration. 372212 1 86633 bbudge 2011-03-23 09:53:01 -0700 Created attachment 86633 Proposed Patch I had to add a createAssociatedURLLoader overload to WebFrame. Once this is landed, I can modify client code to use this new overload and remove the old one. 372268 2 86647 bbudge 2011-03-23 11:04:30 -0700 Created attachment 86647 Proposed Patch 372272 3 86647 darin 2011-03-23 11:06:52 -0700 Comment on attachment 86647 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86647&action=review > Source/WebKit/chromium/public/WebFrame.h:349 > + // TODO(bbudge) Remove this overload when clients have been changed to pass options. We don’t put our names in the code. And we use FIXME, not TODO. Please follow our usual style. 372273 4 86647 darin 2011-03-23 11:07:28 -0700 Comment on attachment 86647 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86647&action=review >> Source/WebKit/chromium/public/WebFrame.h:349 >> + // TODO(bbudge) Remove this overload when clients have been changed to pass options. > > We don’t put our names in the code. And we use FIXME, not TODO. Please follow our usual style. Except maybe the rules are different in the Chromium-specific code. 372275 5 86648 bbudge 2011-03-23 11:17:02 -0700 Created attachment 86648 Proposed Patch Ack. Still learning your ways. 372406 6 levin 2011-03-23 13:35:50 -0700 (In reply to comment #5) > Created an attachment (id=86648) [details] > Proposed Patch > > Ack. Still learning your ways. May I humbly suggest an appropriate penance would be to fix our style checking tool to catch this automatically? :) It shouldn't be too hard even if you don't know python. I'd be happy to give you pointers/help with doing this. (The code is in Tools/Scripts/webkitpy/style/checkers/cpp.py and I suspect we'd need code similar to where we check for 2 spaces after a period in comments -- as a note to myself that occurs where there is a comment " # Next, we check for proper spacing with respect to comments."). 372411 7 dimich 2011-03-23 13:48:00 -0700 It looks ok, but could you please add info or reference to other bugs here so it'd be clear in what context this change is made? Usually, if there is a big work item that is split into several small patches (like this one appears to be), there is an uber-bug that shortly describes the bigger change, and small bugs (one per patch) that link back to the uber-bug. This structure is useful when some time later another engineer tries to figure out what changes were made for what and how they are related. 372420 8 86648 dimich 2011-03-23 14:03:24 -0700 Comment on attachment 86648 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86648&action=review > Source/WebKit/chromium/public/WebFrame.h:355 > + virtual WebURLLoader* createAssociatedURLLoader(const WebURLLoaderOptions&) = 0; Nit: I understand you just adding a parameter to existing method, but it would be nice to understand why this "createFoo()" method returns a naked pointer instead PassXXXPtr? 372581 9 bbudge 2011-03-23 18:00:12 -0700 This work is needed to get the benefits of recent changes to AssociatedURLLoader which add support for CORS. https://bugs.webkit.org/show_bug.cgi?id=53925 This change allows clients to specify CORS options. 372594 10 86648 dimich 2011-03-23 18:24:27 -0700 Comment on attachment 86648 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86648&action=review Almost there. just a few tiny things. > Source/WebKit/chromium/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=56885 This ChangeLog is not informative. It is obvious that the patch adds a parameter. Good ChangeLog entry tells why (as you did in the bug itself). > Source/WebKit/chromium/public/WebFrame.h:350 > + virtual WebURLLoader* createAssociatedURLLoader() = 0; /FIXME/FIXME:/ > Source/WebKit/chromium/src/WebFrameImpl.cpp:1055 > +// FIXME Remove this overload when clients have been changed to pass options. /FIXME/FIXME:/ > Source/WebKit/chromium/src/WebFrameImpl.h:136 > + // FIXME Remove this overload when clients have been changed to pass options. /FIXME/FIXME:/ 372595 11 levin 2011-03-23 18:28:42 -0700 (In reply to comment #8) > (From update of attachment 86648 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86648&action=review > > > Source/WebKit/chromium/public/WebFrame.h:355 > > + virtual WebURLLoader* createAssociatedURLLoader(const WebURLLoaderOptions&) = 0; > > Nit: I understand you just adding a parameter to existing method, but it would be nice to understand why this "createFoo()" method returns a naked pointer instead PassXXXPtr? Plus it would be nice to understand this. 372961 12 86802 bbudge 2011-03-24 11:24:02 -0700 Created attachment 86802 Proposed Patch To answer Dmitri's question, this method returns a raw pointer because it is used in Chromium "glue" code that uses Chromium smart pointers rather than the WebKit ones. None of these files reference the wtf namespace. 373055 13 bbudge 2011-03-24 13:48:41 -0700 Thanks for the reviews and suggestions, Dmitry. 373156 14 86802 commit-queue 2011-03-24 15:54:21 -0700 Comment on attachment 86802 Proposed Patch Clearing flags on attachment: 86802 Committed r81913: <http://trac.webkit.org/changeset/81913> 373157 15 commit-queue 2011-03-24 15:54:26 -0700 All reviewed patches have been landed. Closing bug. 373162 16 webkit.review.bot 2011-03-24 16:08:26 -0700 http://trac.webkit.org/changeset/81913 might have broken Chromium Win Release 373200 17 bbudge 2011-03-24 16:56:08 -0700 I made another WebKit patch which fixes it. https://bugs.webkit.org/show_bug.cgi?id=57064 Otherwise, revert and I will redo it. 86633 2011-03-23 09:53:01 -0700 2011-03-23 09:53:50 -0700 Proposed Patch webframe.txt text/plain 3384 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTc3OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMjMgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkZyYW1lOjpjcmVh dGVBc3NvY2lhdGVkVVJMTG9hZGVyIGNhbid0IGFjY2VwdCBXZWJVUkxMb2FkZXJPcHRpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg4NQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhwb3NlcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRVUkxMb2Fk ZXIpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMS0wMy0yMyAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJh bWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFt ZS5oCShyZXZpc2lvbiA4MTczMikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTYyLDcgKzYyLDYgQEAgY2xhc3MgV2ViUmFuZ2U7 CiBjbGFzcyBXZWJTZWN1cml0eU9yaWdpbjsKIGNsYXNzIFdlYlN0cmluZzsKIGNsYXNzIFdlYlVS TDsKLWNsYXNzIFdlYlVSTExvYWRlcjsKIGNsYXNzIFdlYlVSTFJlcXVlc3Q7CiBjbGFzcyBXZWJW aWV3Owogc3RydWN0IFdlYkNvbnNvbGVNZXNzYWdlOwpAQCAtMzQ1LDEwICszNDQsMTMgQEAgcHVi bGljOgogICAgIC8vIERFUFJFQ0FURUQ6IFBsZWFzZSB1c2UgY3JlYXRlQXNzb2NpYXRlZFVSTExv YWRlciBpbnN0ZWFkLgogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChX ZWJVUkxSZXF1ZXN0JikgPSAwOwogCisgICAgLy8gVE9ETyhiYnVkZ2UpIFJlbW92ZSB0aGlzIG92 ZXJsb2FkIHdoZW4gdXBzdHJlYW0gY29kZSBoYXMgYmVlbiBjaGFuZ2VkIHRvIHBhc3Mgb3B0aW9u cy4KKyAgICB2aXJ0dWFsIFdlYlVSTExvYWRlciogY3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlcigp ID0gMDsKKwogICAgIC8vIFJldHVybnMgYSBXZWJVUkxMb2FkZXIgdGhhdCBpcyBhc3NvY2lhdGVk IHdpdGggdGhpcyBmcmFtZS4gIFRoZSBsb2FkZXIKICAgICAvLyB3aWxsLCBmb3IgZXhhbXBsZSwg YmUgY2FuY2VsbGVkIHdoZW4gV2ViRnJhbWU6OnN0b3BMb2FkaW5nIGlzIGNhbGxlZC4KICAgICAv LyBGSVhNRTogc3RvcExvYWRpbmcgZG9lcyBub3QgeWV0IGNhbmNlbCBhbiBhc3NvY2lhdGVkIGxv YWRlciEhCi0gICAgdmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRVUkxMb2Fk ZXIoKSA9IDA7CisgICAgdmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRVUkxM b2FkZXIoY29uc3QgV2ViVVJMTG9hZGVyT3B0aW9ucyYpID0gMDsKIAogICAgIC8vIENhbGxlZCBm cm9tIHdpdGhpbiBXZWJGcmFtZUNsaWVudDo6ZGlkUmVjZWl2ZURvY3VtZW50RGF0YSB0byBjb21t aXQKICAgICAvLyBkYXRhIGZvciB0aGUgZnJhbWUgdGhhdCB3aWxsIGJlIHVzZWQgdG8gY29uc3Ry dWN0IHRoZSBmcmFtZSdzCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFt ZUltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5jcHAJKHJldmlzaW9uIDgxNzMyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA1Nyw2ICsxMDU3LDExIEBA IFdlYlVSTExvYWRlciogV2ViRnJhbWVJbXBsOjpjcmVhdGVBc3NvY2kKICAgICByZXR1cm4gbmV3 IEFzc29jaWF0ZWRVUkxMb2FkZXIodGhpcyk7CiB9CiAKK1dlYlVSTExvYWRlciogV2ViRnJhbWVJ bXBsOjpjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKGNvbnN0IFdlYlVSTExvYWRlck9wdGlvbnMm IG9wdGlvbnMpCit7CisgICAgcmV0dXJuIG5ldyBBc3NvY2lhdGVkVVJMTG9hZGVyKHRoaXMsIG9w dGlvbnMpOworfQorCiB2b2lkIFdlYkZyYW1lSW1wbDo6Y29tbWl0RG9jdW1lbnREYXRhKGNvbnN0 IGNoYXIqIGRhdGEsIHNpemVfdCBsZW5ndGgpCiB7CiAgICAgbV9mcmFtZS0+bG9hZGVyKCktPmRv Y3VtZW50TG9hZGVyKCktPmNvbW1pdERhdGEoZGF0YSwgbGVuZ3RoKTsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCShyZXZpc2lvbiA4MTczMikKKysrIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMzQsNiArMTM0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRSZWZlcnJlckZv clJlcXVlc3QoV2ViVVJMUmVxdWVzdCYsIGNvbnN0IFdlYlVSTCYgcmVmZXJyZXIpOwogICAgIHZp cnR1YWwgdm9pZCBkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChXZWJVUkxSZXF1ZXN0Jik7CiAgICAg dmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIoKTsKKyAgICB2 aXJ0dWFsIFdlYlVSTExvYWRlciogY3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlcihjb25zdCBXZWJV UkxMb2FkZXJPcHRpb25zJik7CiAgICAgdmlydHVhbCB2b2lkIGNvbW1pdERvY3VtZW50RGF0YShj b25zdCBjaGFyKiBkYXRhLCBzaXplX3QgbGVuZ3RoKTsKICAgICB2aXJ0dWFsIHVuc2lnbmVkIHVu bG9hZExpc3RlbmVyQ291bnQoKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgaXNQcm9jZXNzaW5n VXNlckdlc3R1cmUoKSBjb25zdDsK 86647 2011-03-23 11:04:30 -0700 2011-03-23 11:17:02 -0700 Proposed Patch webframe.txt text/plain 3745 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTc3OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMjMgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkZyYW1lOjpjcmVh dGVBc3NvY2lhdGVkVVJMTG9hZGVyIGNhbid0IGFjY2VwdCBXZWJVUkxMb2FkZXJPcHRpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg4NQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhwb3NlcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRVUkxMb2Fk ZXIpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMS0wMy0yMyAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJh bWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFt ZS5oCShyZXZpc2lvbiA4MTczMikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAgY2xhc3MgV2ViU2VjdXJp dHlPcmlnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBjbGFzcyBXZWJVUkxM b2FkZXI7CitjbGFzcyBXZWJVUkxMb2FkZXJPcHRpb25zOwogY2xhc3MgV2ViVVJMUmVxdWVzdDsK IGNsYXNzIFdlYlZpZXc7CiBzdHJ1Y3QgV2ViQ29uc29sZU1lc3NhZ2U7CkBAIC0zNDUsMTAgKzM0 NiwxMyBAQCBwdWJsaWM6CiAgICAgLy8gREVQUkVDQVRFRDogUGxlYXNlIHVzZSBjcmVhdGVBc3Nv Y2lhdGVkVVJMTG9hZGVyIGluc3RlYWQuCiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoV2lsbFNl bmRSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSA9IDA7CiAKKyAgICAvLyBUT0RPKGJidWRnZSkgUmVt b3ZlIHRoaXMgb3ZlcmxvYWQgd2hlbiBjbGllbnRzIGhhdmUgYmVlbiBjaGFuZ2VkIHRvIHBhc3Mg b3B0aW9ucy4KKyAgICB2aXJ0dWFsIFdlYlVSTExvYWRlciogY3JlYXRlQXNzb2NpYXRlZFVSTExv YWRlcigpID0gMDsKKwogICAgIC8vIFJldHVybnMgYSBXZWJVUkxMb2FkZXIgdGhhdCBpcyBhc3Nv Y2lhdGVkIHdpdGggdGhpcyBmcmFtZS4gIFRoZSBsb2FkZXIKICAgICAvLyB3aWxsLCBmb3IgZXhh bXBsZSwgYmUgY2FuY2VsbGVkIHdoZW4gV2ViRnJhbWU6OnN0b3BMb2FkaW5nIGlzIGNhbGxlZC4K ICAgICAvLyBGSVhNRTogc3RvcExvYWRpbmcgZG9lcyBub3QgeWV0IGNhbmNlbCBhbiBhc3NvY2lh dGVkIGxvYWRlciEhCi0gICAgdmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRV UkxMb2FkZXIoKSA9IDA7CisgICAgdmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0 ZWRVUkxMb2FkZXIoY29uc3QgV2ViVVJMTG9hZGVyT3B0aW9ucyYpID0gMDsKIAogICAgIC8vIENh bGxlZCBmcm9tIHdpdGhpbiBXZWJGcmFtZUNsaWVudDo6ZGlkUmVjZWl2ZURvY3VtZW50RGF0YSB0 byBjb21taXQKICAgICAvLyBkYXRhIGZvciB0aGUgZnJhbWUgdGhhdCB3aWxsIGJlIHVzZWQgdG8g Y29uc3RydWN0IHRoZSBmcmFtZSdzCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDgxNzMyKQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA1MiwxMSArMTA1 MiwxNyBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlCiAgICAgICAg IDAsIDAsIHJlcXVlc3QudG9NdXRhYmxlUmVzb3VyY2VSZXF1ZXN0KCksIHJlc3BvbnNlKTsKIH0K IAorLy8gVE9ETyhiYnVkZ2UpIFJlbW92ZSB0aGlzIG92ZXJsb2FkIHdoZW4gY2xpZW50cyBoYXZl IGJlZW4gY2hhbmdlZCB0byBwYXNzIG9wdGlvbnMuCiBXZWJVUkxMb2FkZXIqIFdlYkZyYW1lSW1w bDo6Y3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlcigpCiB7CiAgICAgcmV0dXJuIG5ldyBBc3NvY2lh dGVkVVJMTG9hZGVyKHRoaXMpOwogfQogCitXZWJVUkxMb2FkZXIqIFdlYkZyYW1lSW1wbDo6Y3Jl YXRlQXNzb2NpYXRlZFVSTExvYWRlcihjb25zdCBXZWJVUkxMb2FkZXJPcHRpb25zJiBvcHRpb25z KQoreworICAgIHJldHVybiBuZXcgQXNzb2NpYXRlZFVSTExvYWRlcih0aGlzLCBvcHRpb25zKTsK K30KKwogdm9pZCBXZWJGcmFtZUltcGw6OmNvbW1pdERvY3VtZW50RGF0YShjb25zdCBjaGFyKiBk YXRhLCBzaXplX3QgbGVuZ3RoKQogewogICAgIG1fZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExv YWRlcigpLT5jb21taXREYXRhKGRhdGEsIGxlbmd0aCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAkocmV2aXNpb24gODE3MzIpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMTMzLDcg KzEzMyw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNWaWV3U291cmNlTW9kZUVuYWJs ZWQoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0UmVmZXJyZXJGb3JSZXF1ZXN0KFdlYlVS TFJlcXVlc3QmLCBjb25zdCBXZWJVUkwmIHJlZmVycmVyKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlz cGF0Y2hXaWxsU2VuZFJlcXVlc3QoV2ViVVJMUmVxdWVzdCYpOworICAgIC8vIFRPRE8oYmJ1ZGdl KSBSZW1vdmUgdGhpcyBvdmVybG9hZCB3aGVuIGNsaWVudHMgaGF2ZSBiZWVuIGNoYW5nZWQgdG8g cGFzcyBvcHRpb25zLgogICAgIHZpcnR1YWwgV2ViVVJMTG9hZGVyKiBjcmVhdGVBc3NvY2lhdGVk VVJMTG9hZGVyKCk7CisgICAgdmlydHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRV UkxMb2FkZXIoY29uc3QgV2ViVVJMTG9hZGVyT3B0aW9ucyYpOwogICAgIHZpcnR1YWwgdm9pZCBj b21taXREb2N1bWVudERhdGEoY29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCk7CiAgICAg dmlydHVhbCB1bnNpZ25lZCB1bmxvYWRMaXN0ZW5lckNvdW50KCkgY29uc3Q7CiAgICAgdmlydHVh bCBib29sIGlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkgY29uc3Q7Cg== 86648 2011-03-23 11:17:02 -0700 2011-03-24 11:24:02 -0700 Proposed Patch webframe.txt text/plain 3724 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTc3OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMjMgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkZyYW1lOjpjcmVh dGVBc3NvY2lhdGVkVVJMTG9hZGVyIGNhbid0IGFjY2VwdCBXZWJVUkxMb2FkZXJPcHRpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg4NQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhwb3NlcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRVUkxMb2Fk ZXIpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMS0wMy0yMyAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJh bWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFt ZS5oCShyZXZpc2lvbiA4MTczMikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAgY2xhc3MgV2ViU2VjdXJp dHlPcmlnaW47CiBjbGFzcyBXZWJTdHJpbmc7CiBjbGFzcyBXZWJVUkw7CiBjbGFzcyBXZWJVUkxM b2FkZXI7CitjbGFzcyBXZWJVUkxMb2FkZXJPcHRpb25zOwogY2xhc3MgV2ViVVJMUmVxdWVzdDsK IGNsYXNzIFdlYlZpZXc7CiBzdHJ1Y3QgV2ViQ29uc29sZU1lc3NhZ2U7CkBAIC0zNDUsMTAgKzM0 NiwxMyBAQCBwdWJsaWM6CiAgICAgLy8gREVQUkVDQVRFRDogUGxlYXNlIHVzZSBjcmVhdGVBc3Nv Y2lhdGVkVVJMTG9hZGVyIGluc3RlYWQuCiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoV2lsbFNl bmRSZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKSA9IDA7CiAKKyAgICAvLyBGSVhNRSBSZW1vdmUgdGhp cyBvdmVybG9hZCB3aGVuIGNsaWVudHMgaGF2ZSBiZWVuIGNoYW5nZWQgdG8gcGFzcyBvcHRpb25z LgorICAgIHZpcnR1YWwgV2ViVVJMTG9hZGVyKiBjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKCkg PSAwOworCiAgICAgLy8gUmV0dXJucyBhIFdlYlVSTExvYWRlciB0aGF0IGlzIGFzc29jaWF0ZWQg d2l0aCB0aGlzIGZyYW1lLiAgVGhlIGxvYWRlcgogICAgIC8vIHdpbGwsIGZvciBleGFtcGxlLCBi ZSBjYW5jZWxsZWQgd2hlbiBXZWJGcmFtZTo6c3RvcExvYWRpbmcgaXMgY2FsbGVkLgogICAgIC8v IEZJWE1FOiBzdG9wTG9hZGluZyBkb2VzIG5vdCB5ZXQgY2FuY2VsIGFuIGFzc29jaWF0ZWQgbG9h ZGVyISEKLSAgICB2aXJ0dWFsIFdlYlVSTExvYWRlciogY3JlYXRlQXNzb2NpYXRlZFVSTExvYWRl cigpID0gMDsKKyAgICB2aXJ0dWFsIFdlYlVSTExvYWRlciogY3JlYXRlQXNzb2NpYXRlZFVSTExv YWRlcihjb25zdCBXZWJVUkxMb2FkZXJPcHRpb25zJikgPSAwOwogCiAgICAgLy8gQ2FsbGVkIGZy b20gd2l0aGluIFdlYkZyYW1lQ2xpZW50OjpkaWRSZWNlaXZlRG9jdW1lbnREYXRhIHRvIGNvbW1p dAogICAgIC8vIGRhdGEgZm9yIHRoZSBmcmFtZSB0aGF0IHdpbGwgYmUgdXNlZCB0byBjb25zdHJ1 Y3QgdGhlIGZyYW1lJ3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJh bWVJbXBsLmNwcAkocmV2aXNpb24gODE3MzIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUyLDExICsxMDUyLDE3IEBA IHZvaWQgV2ViRnJhbWVJbXBsOjpkaXNwYXRjaFdpbGxTZW5kUmVxdWUKICAgICAgICAgMCwgMCwg cmVxdWVzdC50b011dGFibGVSZXNvdXJjZVJlcXVlc3QoKSwgcmVzcG9uc2UpOwogfQogCisvLyBG SVhNRSBSZW1vdmUgdGhpcyBvdmVybG9hZCB3aGVuIGNsaWVudHMgaGF2ZSBiZWVuIGNoYW5nZWQg dG8gcGFzcyBvcHRpb25zLgogV2ViVVJMTG9hZGVyKiBXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29j aWF0ZWRVUkxMb2FkZXIoKQogewogICAgIHJldHVybiBuZXcgQXNzb2NpYXRlZFVSTExvYWRlcih0 aGlzKTsKIH0KIAorV2ViVVJMTG9hZGVyKiBXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRV UkxMb2FkZXIoY29uc3QgV2ViVVJMTG9hZGVyT3B0aW9ucyYgb3B0aW9ucykKK3sKKyAgICByZXR1 cm4gbmV3IEFzc29jaWF0ZWRVUkxMb2FkZXIodGhpcywgb3B0aW9ucyk7Cit9CisKIHZvaWQgV2Vi RnJhbWVJbXBsOjpjb21taXREb2N1bWVudERhdGEoY29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxl bmd0aCkKIHsKICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+Y29tbWl0 RGF0YShkYXRhLCBsZW5ndGgpOwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RnJhbWVJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RnJhbWVJbXBsLmgJKHJldmlzaW9uIDgxNzMyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTEzMyw3ICsxMzMsOSBAQCBwdWJs aWM6CiAgICAgdmlydHVhbCBib29sIGlzVmlld1NvdXJjZU1vZGVFbmFibGVkKCkgY29uc3Q7CiAg ICAgdmlydHVhbCB2b2lkIHNldFJlZmVycmVyRm9yUmVxdWVzdChXZWJVUkxSZXF1ZXN0JiwgY29u c3QgV2ViVVJMJiByZWZlcnJlcik7CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoV2lsbFNlbmRS ZXF1ZXN0KFdlYlVSTFJlcXVlc3QmKTsKKyAgICAvLyBGSVhNRSBSZW1vdmUgdGhpcyBvdmVybG9h ZCB3aGVuIGNsaWVudHMgaGF2ZSBiZWVuIGNoYW5nZWQgdG8gcGFzcyBvcHRpb25zLgogICAgIHZp cnR1YWwgV2ViVVJMTG9hZGVyKiBjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKCk7CisgICAgdmly dHVhbCBXZWJVUkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIoY29uc3QgV2ViVVJM TG9hZGVyT3B0aW9ucyYpOwogICAgIHZpcnR1YWwgdm9pZCBjb21taXREb2N1bWVudERhdGEoY29u c3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCk7CiAgICAgdmlydHVhbCB1bnNpZ25lZCB1bmxv YWRMaXN0ZW5lckNvdW50KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzUHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlKCkgY29uc3Q7Cg== 86802 2011-03-24 11:24:02 -0700 2011-03-24 15:54:21 -0700 Proposed Patch webframe.txt text/plain 3821 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTg3NSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMjQgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBvdmVybG9h ZGVkIFdlYkZyYW1lOjpjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyIG1ldGhvZCB0aGF0IHRha2Vz IFdlYlVSTExvYWRlck9wdGlvbnMsIHNvIGNsaWVudHMgY2FuIHNwZWNpZnkgQ09SUyBvcHRpb25z IHRvIGFsbG93IGNyb3NzLW9yaWdpbiByZXF1ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODg1CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBF eHBvc2VzIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcHVibGljL1dlYkZyYW1l Lmg6CisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkZyYW1lSW1wbDo6Y3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlcik6CisgICAgICAgICogc3JjL1dl YkZyYW1lSW1wbC5oOgorCiAyMDExLTAzLTI0ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAkocmV2aXNpb24gODE3MzIp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCSh3b3JraW5nIGNv cHkpCkBAIC02Myw2ICs2Myw3IEBAIGNsYXNzIFdlYlNlY3VyaXR5T3JpZ2luOwogY2xhc3MgV2Vi U3RyaW5nOwogY2xhc3MgV2ViVVJMOwogY2xhc3MgV2ViVVJMTG9hZGVyOworY2xhc3MgV2ViVVJM TG9hZGVyT3B0aW9uczsKIGNsYXNzIFdlYlVSTFJlcXVlc3Q7CiBjbGFzcyBXZWJWaWV3Owogc3Ry dWN0IFdlYkNvbnNvbGVNZXNzYWdlOwpAQCAtMzQ1LDEwICszNDYsMTMgQEAgcHVibGljOgogICAg IC8vIERFUFJFQ0FURUQ6IFBsZWFzZSB1c2UgY3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlciBpbnN0 ZWFkLgogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChXZWJVUkxSZXF1 ZXN0JikgPSAwOwogCisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG92ZXJsb2FkIHdoZW4gY2xp ZW50cyBoYXZlIGJlZW4gY2hhbmdlZCB0byBwYXNzIG9wdGlvbnMuCisgICAgdmlydHVhbCBXZWJV UkxMb2FkZXIqIGNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIoKSA9IDA7CisKICAgICAvLyBSZXR1 cm5zIGEgV2ViVVJMTG9hZGVyIHRoYXQgaXMgYXNzb2NpYXRlZCB3aXRoIHRoaXMgZnJhbWUuICBU aGUgbG9hZGVyCiAgICAgLy8gd2lsbCwgZm9yIGV4YW1wbGUsIGJlIGNhbmNlbGxlZCB3aGVuIFdl YkZyYW1lOjpzdG9wTG9hZGluZyBpcyBjYWxsZWQuCiAgICAgLy8gRklYTUU6IHN0b3BMb2FkaW5n IGRvZXMgbm90IHlldCBjYW5jZWwgYW4gYXNzb2NpYXRlZCBsb2FkZXIhIQotICAgIHZpcnR1YWwg V2ViVVJMTG9hZGVyKiBjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKCkgPSAwOworICAgIHZpcnR1 YWwgV2ViVVJMTG9hZGVyKiBjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKGNvbnN0IFdlYlVSTExv YWRlck9wdGlvbnMmKSA9IDA7CiAKICAgICAvLyBDYWxsZWQgZnJvbSB3aXRoaW4gV2ViRnJhbWVD bGllbnQ6OmRpZFJlY2VpdmVEb2N1bWVudERhdGEgdG8gY29tbWl0CiAgICAgLy8gZGF0YSBmb3Ig dGhlIGZyYW1lIHRoYXQgd2lsbCBiZSB1c2VkIHRvIGNvbnN0cnVjdCB0aGUgZnJhbWUncwpJbmRl eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lv biA4MTczMikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwNTIsMTEgKzEwNTIsMTcgQEAgdm9pZCBXZWJGcmFtZUltcGw6 OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZQogICAgICAgICAwLCAwLCByZXF1ZXN0LnRvTXV0YWJsZVJl c291cmNlUmVxdWVzdCgpLCByZXNwb25zZSk7CiB9CiAKKy8vIEZJWE1FOiBSZW1vdmUgdGhpcyBv dmVybG9hZCB3aGVuIGNsaWVudHMgaGF2ZSBiZWVuIGNoYW5nZWQgdG8gcGFzcyBvcHRpb25zLgog V2ViVVJMTG9hZGVyKiBXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIoKQog ewogICAgIHJldHVybiBuZXcgQXNzb2NpYXRlZFVSTExvYWRlcih0aGlzKTsKIH0KIAorV2ViVVJM TG9hZGVyKiBXZWJGcmFtZUltcGw6OmNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIoY29uc3QgV2Vi VVJMTG9hZGVyT3B0aW9ucyYgb3B0aW9ucykKK3sKKyAgICByZXR1cm4gbmV3IEFzc29jaWF0ZWRV UkxMb2FkZXIodGhpcywgb3B0aW9ucyk7Cit9CisKIHZvaWQgV2ViRnJhbWVJbXBsOjpjb21taXRE b2N1bWVudERhdGEoY29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCkKIHsKICAgICBtX2Zy YW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+Y29tbWl0RGF0YShkYXRhLCBsZW5ndGgp OwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHJldmlz aW9uIDgxNzMyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEzMyw3ICsxMzMsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBi b29sIGlzVmlld1NvdXJjZU1vZGVFbmFibGVkKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHNl dFJlZmVycmVyRm9yUmVxdWVzdChXZWJVUkxSZXF1ZXN0JiwgY29uc3QgV2ViVVJMJiByZWZlcnJl cik7CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KFdlYlVSTFJlcXVl c3QmKTsKKyAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgb3ZlcmxvYWQgd2hlbiBjbGllbnRzIGhh dmUgYmVlbiBjaGFuZ2VkIHRvIHBhc3Mgb3B0aW9ucy4KICAgICB2aXJ0dWFsIFdlYlVSTExvYWRl ciogY3JlYXRlQXNzb2NpYXRlZFVSTExvYWRlcigpOworICAgIHZpcnR1YWwgV2ViVVJMTG9hZGVy KiBjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKGNvbnN0IFdlYlVSTExvYWRlck9wdGlvbnMmKTsK ICAgICB2aXJ0dWFsIHZvaWQgY29tbWl0RG9jdW1lbnREYXRhKGNvbnN0IGNoYXIqIGRhdGEsIHNp emVfdCBsZW5ndGgpOwogICAgIHZpcnR1YWwgdW5zaWduZWQgdW5sb2FkTGlzdGVuZXJDb3VudCgp IGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSgpIGNvbnN0 Owo=