56884 2011-03-22 17:21:30 -0700 Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory 2011-03-23 18:13:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adamk adamk commit-queue dpranke levin michaeln mihaip oldest_to_newest 371851 0 adamk 2011-03-22 17:21:30 -0700 Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory 371856 1 86550 adamk 2011-03-22 17:23:17 -0700 Created attachment 86550 Patch 371860 2 86550 mihaip 2011-03-22 17:28:34 -0700 Comment on attachment 86550 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86550&action=review > Tools/ChangeLog:9 > + referencing js-test-resources from a layout test over HTTP. I'm not entirely sure I understand the use-case here, but if you'd like to remap what directories are available at what location when using new-run-webkit-tests's HTTP server, you can use aliases the way http://trac.webkit.org/changeset/79630 works (see the Tools/Scripts changes). 371863 3 86550 adamk 2011-03-22 17:33:07 -0700 Comment on attachment 86550 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86550&action=review >> Tools/ChangeLog:9 >> + referencing js-test-resources from a layout test over HTTP. > > I'm not entirely sure I understand the use-case here, but if you'd like to remap what directories are available at what location when using new-run-webkit-tests's HTTP server, you can use aliases the way http://trac.webkit.org/changeset/79630 works (see the Tools/Scripts changes). So, the remapping I want is already there (/js-test-resources -> fast/js/resources), the trick is that these tests are running in Chromium's ui_tests against a limited set of LayoutTests under chrome/test/data/layout_tests. But port.layout_tests_dir() returns third_party/WebKit/LayoutTests, which on many folks' checkouts (including the try bots) is empty. See http://codereview.chromium.org/6727001/diff/2005/chrome/test/ui/ui_test.cc for how I plan to use this flag. 372591 4 86550 commit-queue 2011-03-23 18:13:54 -0700 Comment on attachment 86550 Patch Clearing flags on attachment: 86550 Committed r81834: <http://trac.webkit.org/changeset/81834> 372592 5 commit-queue 2011-03-23 18:13:59 -0700 All reviewed patches have been landed. Closing bug. 86550 2011-03-22 17:23:17 -0700 2011-03-23 18:13:54 -0700 Patch bug-56884-20110322172316.patch text/plain 3972 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogODE3MDgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYzg5ODcwZjgyZWY3NWRlMjI3ZjBjYTI5MTMzZjI2Y2I4 MzNjYjViLi5jNjAxNmQwZTkwYTczMGYzOTAyZmRlNWI2ZGUzODUwN2QxNjA2Mzk1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjIgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIG9wdGlvbiB0 byBuZXctcnVuLXdlYmtpdC1odHRwZCB0byBhbGxvdyBvdmVycmlkaW5nIHRoZSBsb2NhdGlvbiBv ZiBMYXlvdXRUZXN0cyBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2ODg0CisKKyAgICAgICAgVGhpcyBvcHRpb24gd2lsbCBiZSB1dGls aXplZCBieSBDaHJvbWl1bSdzIHVpX3Rlc3RzIHRvIGFsbG93CisgICAgICAgIHJlZmVyZW5jaW5n IGpzLXRlc3QtcmVzb3VyY2VzIGZyb20gYSBsYXlvdXQgdGVzdCBvdmVyIEhUVFAuCisKKyAgICAg ICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBkOgorICAgICAgICBBZGRlZCAtLWxheW91 dF90ZXN0c19kaXIgb3B0aW9uLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHk6CisgICAgICAgIFBsdW1iZWQgdGhyb3VnaCBhcyBsYXlv dXRfdGVzdHNfZGlyIHBhcmFtLgorCiAyMDExLTAzLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTY3ODE+IEFkZCAt LWRzeW0gc3dpdGNoIHRvIGVuYWJsZSBkc3ltIGdlbmVyYXRpb24gd2hlbiBidWlsZGluZyB3aXRo IFhjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBkIGIv VG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC1odHRwZAppbmRleCBmNmVjMTY0ODI4MTZkMTNi MzI3NzUwMmJkMmIzODA3NzZjYjgyYjQzLi40MTIyOTkzYzQ2NjRjZmY3NzQwNWE2ZDNhMzlkOWM5 MWVhNWNiZDE0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBk CisrKyBiL1Rvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtaHR0cGQKQEAgLTY1LDcgKzY1LDgg QEAgZGVmIHJ1bihvcHRpb25zKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB0ZW1wZmlsZS5nZXR0ZW1wZGlyKCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcG9ydD1vcHRpb25zLnBvcnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcm9vdD1vcHRpb25zLnJvb3QsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcnVuX2JhY2tncm91bmQ9b3B0aW9ucy5ydW5fYmFja2dyb3VuZCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBydW5fYmFja2dyb3VuZD1vcHRpb25zLnJ1bl9iYWNr Z3JvdW5kLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxheW91dF90ZXN0 c19kaXI9b3B0aW9ucy5sYXlvdXRfdGVzdHNfZGlyKQogICAgICAgICBpZiBvcHRpb25zLnNlcnZl ciA9PSAnc3RhcnQnOgogICAgICAgICAgICAgaHR0cGQuc3RhcnQoKQogICAgICAgICBlbHNlOgpA QCAtODUsNiArODYsOSBAQCBkZWYgbWFpbigpOgogICAgIG9wdGlvbl9wYXJzZXIuYWRkX29wdGlv bignLS1ydW5fYmFja2dyb3VuZCcsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCiAgICAgICAgIGRlc3Q9 InJ1bl9iYWNrZ3JvdW5kIiwKICAgICAgICAgaGVscD0nUnVuIG9uIGJhY2tncm91bmQgKGZvciBy dW5uaW5nIGFzIFVJIHRlc3QpJykKKyAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy0tbGF5 b3V0X3Rlc3RzX2RpcicsCisgICAgICAgIGRlc3Q9ImxheW91dF90ZXN0c19kaXIiLAorICAgICAg ICBoZWxwPSdBYnNvbHV0ZSBwYXRoIHRvIExheW91dFRlc3RzIHJvb3QnKQogICAgIG9wdGlvbnMs IGFyZ3MgPSBvcHRpb25fcGFyc2VyLnBhcnNlX2FyZ3MoKQogCiAgICAgIyBGSVhNRTogTWFrZSB0 aGlzIHdvcmsgd2l0aCBvdGhlciBwb3J0cyBhcyB3ZWxsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHkKaW5kZXggNzUy YjA5OWMzN2NlNzQxOTliODkyMGNiN2VjMjliYWNjMTE4Y2IzOC4uMTc1M2FlZTcxZDJlYWJkNmQw MGQyNGI0NDA3YWRjYjg4ZGEyZmQ2MSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5CkBAIC01NSw3ICs1NSw3IEBA IGNsYXNzIEh0dHBkTm90U3RhcnRlZChFeGNlcHRpb24pOgogY2xhc3MgTGlnaHR0cGQoaHR0cF9z ZXJ2ZXJfYmFzZS5IdHRwU2VydmVyQmFzZSk6CiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgcG9y dF9vYmosIG91dHB1dF9kaXIsIGJhY2tncm91bmQ9RmFsc2UsIHBvcnQ9Tm9uZSwKLSAgICAgICAg ICAgICAgICAgcm9vdD1Ob25lLCBydW5fYmFja2dyb3VuZD1Ob25lKToKKyAgICAgICAgICAgICAg ICAgcm9vdD1Ob25lLCBydW5fYmFja2dyb3VuZD1Ob25lLCBsYXlvdXRfdGVzdHNfZGlyPU5vbmUp OgogICAgICAgICAiIiJBcmdzOgogICAgICAgICAgIG91dHB1dF9kaXI6IHRoZSBhYnNvbHV0ZSBw YXRoIHRvIHRoZSBsYXlvdXQgdGVzdCByZXN1bHQgZGlyZWN0b3J5CiAgICAgICAgICIiIgpAQCAt NjYsMTYgKzY2LDIxIEBAIGNsYXNzIExpZ2h0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZl ckJhc2UpOgogICAgICAgICBzZWxmLl9wb3J0ID0gcG9ydAogICAgICAgICBzZWxmLl9yb290ID0g cm9vdAogICAgICAgICBzZWxmLl9ydW5fYmFja2dyb3VuZCA9IHJ1bl9iYWNrZ3JvdW5kCisgICAg ICAgIHNlbGYuX2xheW91dF90ZXN0c19kaXIgPSBsYXlvdXRfdGVzdHNfZGlyCisKICAgICAgICAg aWYgc2VsZi5fcG9ydDoKICAgICAgICAgICAgIHNlbGYuX3BvcnQgPSBpbnQoc2VsZi5fcG9ydCkK IAorICAgICAgICBpZiBub3Qgc2VsZi5fbGF5b3V0X3Rlc3RzX2RpcjoKKyAgICAgICAgICAgIHNl bGYuX2xheW91dF90ZXN0c19kaXIgPSBzZWxmLl9wb3J0X29iai5sYXlvdXRfdGVzdHNfZGlyKCkK KwogICAgICAgICB0cnk6CiAgICAgICAgICAgICBzZWxmLl93ZWJraXRfdGVzdHMgPSBvcy5wYXRo LmpvaW4oCi0gICAgICAgICAgICAgICAgc2VsZi5fcG9ydF9vYmoubGF5b3V0X3Rlc3RzX2Rpcigp LCAnaHR0cCcsICd0ZXN0cycpCisgICAgICAgICAgICAgICAgc2VsZi5fbGF5b3V0X3Rlc3RzX2Rp ciwgJ2h0dHAnLCAndGVzdHMnKQogICAgICAgICAgICAgc2VsZi5fanNfdGVzdF9yZXNvdXJjZSA9 IG9zLnBhdGguam9pbigKLSAgICAgICAgICAgICAgICBzZWxmLl9wb3J0X29iai5sYXlvdXRfdGVz dHNfZGlyKCksICdmYXN0JywgJ2pzJywgJ3Jlc291cmNlcycpCisgICAgICAgICAgICAgICAgc2Vs Zi5fbGF5b3V0X3Rlc3RzX2RpciwgJ2Zhc3QnLCAnanMnLCAncmVzb3VyY2VzJykKICAgICAgICAg ICAgIHNlbGYuX21lZGlhX3Jlc291cmNlID0gb3MucGF0aC5qb2luKAotICAgICAgICAgICAgICAg IHNlbGYuX3BvcnRfb2JqLmxheW91dF90ZXN0c19kaXIoKSwgJ21lZGlhJykKKyAgICAgICAgICAg ICAgICBzZWxmLl9sYXlvdXRfdGVzdHNfZGlyLCAnbWVkaWEnKQogCiAgICAgICAgIGV4Y2VwdDoK ICAgICAgICAgICAgIHNlbGYuX3dlYmtpdF90ZXN0cyA9IE5vbmUK