56882 2011-03-22 16:59:58 -0700 Add API to retrieve the audio hardware sample-rate 2011-03-23 14:38:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned kbr tony oldest_to_newest 371825 0 crogers 2011-03-22 16:59:58 -0700 Add API to retrieve the audio hardware sample-rate 371831 1 86546 crogers 2011-03-22 17:02:11 -0700 Created attachment 86546 Patch 371841 2 86546 kbr 2011-03-22 17:07:34 -0700 Comment on attachment 86546 Patch Looks fine to me; do you want to commit the Chromium side first? 371845 3 crogers 2011-03-22 17:09:22 -0700 Thanks, Ken, yes I will have to. Here's that CL: http://codereview.chromium.org/6721015/ 372379 4 crogers 2011-03-23 13:04:50 -0700 Committed r81797: <http://trac.webkit.org/changeset/81797> 372436 5 tony 2011-03-23 14:21:00 -0700 I'm getting a compilation error in Chromium with this change: content/renderer/renderer_webkitclient_impl.cc: In member function ‘virtual WebKit::WebAudioDevice* RendererWebKitClientImpl::createAudioDevice(size_t, unsigned int, double, WebKit::WebAudioDevice::RenderCallback*)’: content/renderer/renderer_webkitclient_impl.cc:553: error: cannot allocate an object of abstract type ‘RendererWebAudioDeviceImpl’ ./content/renderer/renderer_webaudiodevice_impl.h:16: note: because the following virtual functions are pure within ‘RendererWebAudioDeviceImpl’: ./third_party/WebKit/Source/WebKit/chromium/public/WebAudioDevice.h:51: note: virtual double WebKit::WebAudioDevice::sampleRate() It looks like renderer_webaudiodevice_impl.* needs to declare sampleRate()? 372440 6 crogers 2011-03-23 14:28:31 -0700 Tony, sorry about that. I'll land a temporary fix on the chromium-side... 372443 7 crogers 2011-03-23 14:38:38 -0700 I have a patch about ready to land: http://codereview.chromium.org/6733006/ 86546 2011-03-22 17:02:11 -0700 2011-03-22 17:07:34 -0700 Patch bug-56882-20110322170210.patch text/plain 2411 crogers SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MTcyMykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDMtMjIgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRvIHJl dHJpZXZlIHRoZSBhdWRpbyBoYXJkd2FyZSBzYW1wbGUtcmF0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY4ODIKKworICAgICAgICAqIHB1YmxpYy9X ZWJBdWRpb0RldmljZS5oOgorICAgICAgICAqIHB1YmxpYy9XZWJLaXRDbGllbnQuaDoKKyAgICAg ICAgKFdlYktpdDo6V2ViS2l0Q2xpZW50OjphdWRpb0hhcmR3YXJlU2FtcGxlUmF0ZSk6CisgICAg ICAgICogc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBdWRpb0Rlc3RpbmF0aW9uOjpoYXJkd2FyZVNhbXBsZVJhdGUpOgorCiAyMDExLTAzLTIyICBK YXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXZpZCBMZXZpbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkF1 ZGlvRGV2aWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViQXVkaW9EZXZpY2UuaAkocmV2aXNpb24gODE3MDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJBdWRpb0RldmljZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3 IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzdGFydCgpID0gMDsKICAgICB2aXJ0dWFs IHZvaWQgc3RvcCgpID0gMDsKKyAgICB2aXJ0dWFsIGRvdWJsZSBzYW1wbGVSYXRlKCkgPSAwOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJLaXRDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAkocmV2aXNpb24gODE3MDApCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjg2 LDYgKzI4Niw3IEBAIHB1YmxpYzoKIAogICAgIC8vIEF1ZGlvIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKKyAgICB2aXJ0dWFs IGRvdWJsZSBhdWRpb0hhcmR3YXJlU2FtcGxlUmF0ZSgpIHsgcmV0dXJuIDA7IH0KICAgICB2aXJ0 dWFsIFdlYkF1ZGlvRGV2aWNlKiBjcmVhdGVBdWRpb0RldmljZShzaXplX3QgYnVmZmVyU2l6ZSwg dW5zaWduZWQgbnVtYmVyT2ZDaGFubmVscywgZG91YmxlIHNhbXBsZVJhdGUsIFdlYkF1ZGlvRGV2 aWNlOjpSZW5kZXJDYWxsYmFjayopIHsgcmV0dXJuIDA7IH0KIAogICAgIC8vIEZpbGVTeXN0ZW0g LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0aW5hdGlvbkNocm9t aXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9BdWRpb0Rl c3RpbmF0aW9uQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA4MTcwMCkKKysrIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTk4LDggKzk4LDcgQEAgdm9pZCBBdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW06OnN0b3AoKQog CiBkb3VibGUgQXVkaW9EZXN0aW5hdGlvbjo6aGFyZHdhcmVTYW1wbGVSYXRlKCkKIHsKLSAgICAv LyBGSVhNRTogaW1wbGVtZW50IHRoaXMgcHJvcGVybHkgZm9yIENocm9taXVtLgotICAgIHJldHVy biA0NDEwMC4wOworICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+YXVkaW9IYXJkd2FyZVNhbXBs ZVJhdGUoKTsKIH0KIAogLy8gUHVsbHMgb24gb3VyIHByb3ZpZGVyIHRvIGdldCB0aGUgcmVuZGVy ZWQgYXVkaW8gc3RyZWFtLgo=