56875 2011-03-22 15:53:20 -0700 [chromium] Remove identity from dragTargetDragEnter() function signature 2011-04-12 01:05:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 57303 58303 1 noel.gordon noel.gordon commit-queue ojan tony oldest_to_newest 371751 0 noel.gordon 2011-03-22 15:53:20 -0700 Requires a 3-sided patch. 1) create a new function signature in WebKit, await roll. 2) chromium patch to update call sites to use the new function signature. 3) remove old signature from WebKit. 371854 1 86549 noel.gordon 2011-03-22 17:22:38 -0700 Created attachment 86549 Patch - provide a new function signature, await roll. 371898 2 86549 commit-queue 2011-03-22 18:45:49 -0700 Comment on attachment 86549 Patch - provide a new function signature, await roll. Clearing flags on attachment: 86549 Committed r81743: <http://trac.webkit.org/changeset/81743> 371899 3 commit-queue 2011-03-22 18:45:53 -0700 All reviewed patches have been landed. Closing bug. 86549 2011-03-22 17:22:38 -0700 2011-03-22 18:45:49 -0700 Patch - provide a new function signature, await roll. new-drag-target-function-signature.diff text/plain 3219 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggY2FlN2UyMC4uZjA5NTUyNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMy0yMiAgTm9lbCBHb3Jk b24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgaWRlbnRpdHkgZnJvbSBkcmFn VGFyZ2V0RHJhZ0VudGVyKCkgZnVuY3Rpb24gc2lnbmF0dXJlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg3NQorCisgICAgICAgIEZpcnN0IHBhcnQg b2YgMy1zaWRlZCBwYXRjaC4gIEFkZCBuZXcgZnVuY3Rpb24gc2lnbmF0dXJlIHNhbnMgaWRlbnRp dHkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAgICAqIHNyYy9XZWJWaWV3 SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpkcmFnVGFyZ2V0RHJhZ0Vu dGVyKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0wMy0yMiAgSmF5IENp dmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJW aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggNjM4 MThhZS4uMWM0MmQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaApA QCAtMjMyLDYgKzIzMiwxMCBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnN0IFdlYkRyYWdEYXRhJiwg aW50IGlkZW50aXR5LCAvLyBGSVhNRTogcmVtb3ZlIGlkZW50aXR5IGZyb20gdGhpcyBmdW5jdGlv biBzaWduYXR1cmUuCiAgICAgICAgIGNvbnN0IFdlYlBvaW50JiBjbGllbnRQb2ludCwgY29uc3Qg V2ViUG9pbnQmIHNjcmVlblBvaW50LAogICAgICAgICBXZWJEcmFnT3BlcmF0aW9uc01hc2sgb3Bl cmF0aW9uc0FsbG93ZWQpID0gMDsKKyAgICB2aXJ0dWFsIFdlYkRyYWdPcGVyYXRpb24gZHJhZ1Rh cmdldERyYWdFbnRlcigKKyAgICAgICAgY29uc3QgV2ViRHJhZ0RhdGEmLAorICAgICAgICBjb25z dCBXZWJQb2ludCYgY2xpZW50UG9pbnQsIGNvbnN0IFdlYlBvaW50JiBzY3JlZW5Qb2ludCwKKyAg ICAgICAgV2ViRHJhZ09wZXJhdGlvbnNNYXNrIG9wZXJhdGlvbnNBbGxvd2VkKSA9IDA7CiAgICAg dmlydHVhbCBXZWJEcmFnT3BlcmF0aW9uIGRyYWdUYXJnZXREcmFnT3ZlcigKICAgICAgICAgY29u c3QgV2ViUG9pbnQmIGNsaWVudFBvaW50LCBjb25zdCBXZWJQb2ludCYgc2NyZWVuUG9pbnQsCiAg ICAgICAgIFdlYkRyYWdPcGVyYXRpb25zTWFzayBvcGVyYXRpb25zQWxsb3dlZCkgPSAwOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDBiMjc4YWQuLjE1 ZDVhZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAg LTE3ODksNiArMTc4OSwyMCBAQCBXZWJEcmFnT3BlcmF0aW9uIFdlYlZpZXdJbXBsOjpkcmFnVGFy Z2V0RHJhZ0VudGVyKAogICAgIHJldHVybiBkcmFnVGFyZ2V0RHJhZ0VudGVyT3JPdmVyKGNsaWVu dFBvaW50LCBzY3JlZW5Qb2ludCwgRHJhZ0VudGVyKTsKIH0KIAorV2ViRHJhZ09wZXJhdGlvbiBX ZWJWaWV3SW1wbDo6ZHJhZ1RhcmdldERyYWdFbnRlcigKKyAgICBjb25zdCBXZWJEcmFnRGF0YSYg d2ViRHJhZ0RhdGEsCisgICAgY29uc3QgV2ViUG9pbnQmIGNsaWVudFBvaW50LAorICAgIGNvbnN0 IFdlYlBvaW50JiBzY3JlZW5Qb2ludCwKKyAgICBXZWJEcmFnT3BlcmF0aW9uc01hc2sgb3BlcmF0 aW9uc0FsbG93ZWQpCit7CisgICAgQVNTRVJUKCFtX2N1cnJlbnREcmFnRGF0YS5nZXQoKSk7CisK KyAgICBtX2N1cnJlbnREcmFnRGF0YSA9IHdlYkRyYWdEYXRhOworICAgIG1fb3BlcmF0aW9uc0Fs bG93ZWQgPSBvcGVyYXRpb25zQWxsb3dlZDsKKworICAgIHJldHVybiBkcmFnVGFyZ2V0RHJhZ0Vu dGVyT3JPdmVyKGNsaWVudFBvaW50LCBzY3JlZW5Qb2ludCwgRHJhZ0VudGVyKTsKK30KKwogV2Vi RHJhZ09wZXJhdGlvbiBXZWJWaWV3SW1wbDo6ZHJhZ1RhcmdldERyYWdPdmVyKAogICAgIGNvbnN0 IFdlYlBvaW50JiBjbGllbnRQb2ludCwKICAgICBjb25zdCBXZWJQb2ludCYgc2NyZWVuUG9pbnQs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAppbmRleCA4NmRjNzQ0Li41 ZGRhNGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTE1 OCw2ICsxNTgsMTEgQEAgcHVibGljOgogICAgICAgICBjb25zdCBXZWJQb2ludCYgY2xpZW50UG9p bnQsCiAgICAgICAgIGNvbnN0IFdlYlBvaW50JiBzY3JlZW5Qb2ludCwKICAgICAgICAgV2ViRHJh Z09wZXJhdGlvbnNNYXNrIG9wZXJhdGlvbnNBbGxvd2VkKTsKKyAgICB2aXJ0dWFsIFdlYkRyYWdP cGVyYXRpb24gZHJhZ1RhcmdldERyYWdFbnRlcigKKyAgICAgICAgY29uc3QgV2ViRHJhZ0RhdGEm LAorICAgICAgICBjb25zdCBXZWJQb2ludCYgY2xpZW50UG9pbnQsCisgICAgICAgIGNvbnN0IFdl YlBvaW50JiBzY3JlZW5Qb2ludCwKKyAgICAgICAgV2ViRHJhZ09wZXJhdGlvbnNNYXNrIG9wZXJh dGlvbnNBbGxvd2VkKTsKICAgICB2aXJ0dWFsIFdlYkRyYWdPcGVyYXRpb24gZHJhZ1RhcmdldERy YWdPdmVyKAogICAgICAgICBjb25zdCBXZWJQb2ludCYgY2xpZW50UG9pbnQsCiAgICAgICAgIGNv bnN0IFdlYlBvaW50JiBzY3JlZW5Qb2ludCwK