56866 2011-03-22 14:54:52 -0700 [GTK] Force DumpRenderTree to use 96 DPI 2011-03-26 12:51:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 57068 1 mrobinson webkit-unassigned abarth alex eric webkit.review.bot xan.lopez oldest_to_newest 371680 0 mrobinson 2011-03-22 14:54:52 -0700 Forcing DumpRenderTree to use 96 DPI will fix a few issues: 1. Allow for consistent runs across different systems. Depending on when font sizes were calculated in DRT runs, the DPI was different. 2. Fix the size of the menu list arrow in DRT results. The default GTK+ font size was specified in terms of 72 DPI, which resulted in large sized arrows. 3. Allow the DumpRenderTree (WebKit1) to share more DRT results with the WebKitTestRunner (WebKit2), which uses pixel font sizes and 92 DPI always. 373599 1 86958 mrobinson 2011-03-25 10:52:16 -0700 Created attachment 86958 Patch 373609 2 mrobinson 2011-03-25 11:05:19 -0700 This patch does not include the many pixel and expected results changes. Essentially any test with a menu list will change. I plan to generate those after landing both this patch and https://bugs.webkit.org/show_bug.cgi?id=57068 to avoid churn. 373613 3 86958 mrobinson 2011-03-25 11:14:48 -0700 Comment on attachment 86958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86958&action=review > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:427 > + "default-font-size", 12, > + "default-monospace-font-size", 10, I will leave a comment here when landing that says something like this: // WebGTK+ accepts font sizes in points, so these match other platforms' DRTs for 96 DPI. 373618 4 86958 xan.lopez 2011-03-25 11:18:55 -0700 Comment on attachment 86958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86958&action=review OK. > Tools/ChangeLog:14 > + (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new font size. s/font size/DPI/ > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:141 > + "gtk-xft-dpi", 98304, // This is 96 * 1024 or 96 DPI according to the GTK+ docs. wat. 373931 5 mrobinson 2011-03-26 11:52:29 -0700 Committed r82033: <http://trac.webkit.org/changeset/82033> 373956 6 webkit.review.bot 2011-03-26 12:51:32 -0700 http://trac.webkit.org/changeset/82033 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/forms/input-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-layer.html fast/forms/input-appearance-spinbutton-visibility.html fast/harness/override-preferences-2.html 86958 2011-03-25 10:52:16 -0700 2011-03-26 11:59:10 -0700 Patch bug-56866-20110325105216.patch text/plain 2976 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODE3ODUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZTJlODI3YjJiYTFkYTc3YmM3OGI0ZDYxNjc3OTM0NGU2 ZTVmMzEyLi5jNzMwYjMzZDZmOGEyMDJmZTAzMjlhOGFjOGJhOGU3MDlhZjNlMjczIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjMgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZv cmNlIER1bXBSZW5kZXJUcmVlIHRvIHVzZSA5NiBEUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODY2CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQg R1RLKyBpcyBzZXQgdG8gdXNlIDk2IERQSSB3aGVuIHJ1bm5pbmcgdGVzdHMuIFRoaXMgZW5zdXJl cworICAgICAgICBicm9hZGVyIGNvbXBhdGliaWxpdHkgd2l0aCBXZWJLaXQyIGFuZCBtYWtlcyBz ZXR0aW5nIGZvbnQgc2l6ZXMgbW9yZSBzdHJhaWdodGZvcndhcmQuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdGlhbGl6ZUd0 a0ZvbnRTZXR0aW5ncyk6IFNldCB0aGUgc2NyZWVuIHJlc29sdXRpb24gYW5kIEdUSysgeGZ0IHBy b3BlcnR5IHRvIDk2IERQSS4KKyAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1 ZXMpOlJlbW92ZSB0aGUgY2FsbCB3aGljaCByZXBlYXRlZGx5IHNldCB0aGUgR0RLIHNjcmVlbiBy ZXNvbHV0aW9uLgorICAgICAgICAoc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRTdGF0ZVZhbHVlc0Zv clRlc3RpbmcpOiBVcGRhdGUgdGhlIGZvbnQgc2l6ZXMgdG8gcmVmbGVjdCB0aGUgbmV3IGZvbnQg c2l6ZS4KKwogMjAxMS0wMy0yMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggY2NmMjk1ZjQ2NjRkZWFhMzhjMGNj OGFmNGJlNjE2OGQ2NTc1YjQ3Ni4uYTcxMzBhZjI4Mzg3YmM2NmRjZDQ5OWMyNzg1YTE2NWUzODFm MTk0OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVl LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBA IC0xMzcsOSArMTM3LDEzIEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVHdGtGb250U2V0dGluZ3Mo Y29uc3QgY2hhciogdGVzdFVSTCkKICAgICBHdGtTZXR0aW5ncyogc2V0dGluZ3MgPSBndGtfc2V0 dGluZ3NfZ2V0X2RlZmF1bHQoKTsKICAgICBpZiAoIXNldHRpbmdzKQogICAgICAgICByZXR1cm47 Ci0gICAgZ19vYmplY3Rfc2V0KHNldHRpbmdzLCAiZ3RrLXhmdC1hbnRpYWxpYXMiLCAxLAorICAg IGdfb2JqZWN0X3NldChzZXR0aW5ncywKKyAgICAgICAgICAgICAgICAgImd0ay14ZnQtZHBpIiwg OTgzMDQsIC8vIFRoaXMgaXMgOTYgKiAxMDI0IG9yIDk2IERQSSBhY2NvcmRpbmcgdG8gdGhlIEdU SysgZG9jcy4KKyAgICAgICAgICAgICAgICAgImd0ay14ZnQtYW50aWFsaWFzIiwgMSwKICAgICAg ICAgICAgICAgICAgImd0ay14ZnQtaGludGluZyIsIDAsCi0gICAgICAgICAgICAgICAgICJndGst Zm9udC1uYW1lIiwgIkxpYmVyYXRpb24gU2FucyAxNiIsIE5VTEwpOworICAgICAgICAgICAgICAg ICAiZ3RrLWZvbnQtbmFtZSIsICJMaWJlcmF0aW9uIFNhbnMgMTIiLAorICAgICAgICAgICAgICAg ICBOVUxMKTsKKyAgICBnZGtfc2NyZWVuX3NldF9yZXNvbHV0aW9uKGdka19zY3JlZW5fZ2V0X2Rl ZmF1bHQoKSwgOTYuMCk7CiAKICAgICAvLyBPbmUgdGVzdCBuZWVkcyBzdWJwaXhlbCBhbnRpLWFs aWFzaW5nIHR1cm5lZCBvbiwgYnV0IGdlbmVyYWxseSB3ZQogICAgIC8vIHdhbnQgYWxsIHRleHQg aW4gb3RoZXIgdGVzdHMgdG8gdXNlIHRvIGdyYXlzY2FsZSBhbnRpLWFsaWFzaW5nLgpAQCAtNDE5 LDggKzQyMyw4IEBAIHN0YXRpYyB2b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMo KQogICAgICAgICAgICAgICAgICAic2Fucy1zZXJpZi1mb250LWZhbWlseSIsICJIZWx2ZXRpY2Ei LAogICAgICAgICAgICAgICAgICAiY3Vyc2l2ZS1mb250LWZhbWlseSIsICJjdXJzaXZlIiwKICAg ICAgICAgICAgICAgICAgImZhbnRhc3ktZm9udC1mYW1pbHkiLCAiZmFudGFzeSIsCi0gICAgICAg ICAgICAgICAgICJkZWZhdWx0LWZvbnQtc2l6ZSIsIDE2LAotICAgICAgICAgICAgICAgICAiZGVm YXVsdC1tb25vc3BhY2UtZm9udC1zaXplIiwgMTMsCisgICAgICAgICAgICAgICAgICJkZWZhdWx0 LWZvbnQtc2l6ZSIsIDEyLAorICAgICAgICAgICAgICAgICAiZGVmYXVsdC1tb25vc3BhY2UtZm9u dC1zaXplIiwgMTAsCiAgICAgICAgICAgICAgICAgICJtaW5pbXVtLWZvbnQtc2l6ZSIsIDAsCiAg ICAgICAgICAgICAgICAgICJlbmFibGUtY2FyZXQtYnJvd3NpbmciLCBGQUxTRSwKICAgICAgICAg ICAgICAgICAgImVuYWJsZS1wYWdlLWNhY2hlIiwgRkFMU0UsCkBAIC01ODMsOCArNTg3LDYgQEAg dm9pZCBkdW1wKCkKIAogc3RhdGljIHZvaWQgc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRTdGF0ZVZh bHVlc0ZvclRlc3RpbmcoKQogewotICAgIGdka19zY3JlZW5fc2V0X3Jlc29sdXRpb24oZ2RrX3Nj cmVlbl9nZXRfZGVmYXVsdCgpLCA3Mi4wKTsKLQogICAgIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3Rl bnRWYWx1ZXMoKTsKIAogICAgIC8qIERpc2FibGUgdGhlIGRlZmF1bHQgYXV0aCBkaWFsb2cgZm9y IHRlc3RpbmcgKi8K