56865 2011-03-22 14:53:13 -0700 Webkit warning: converting to 'unsigned int' from 'double' 2011-03-23 14:05:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Other RESOLVED FIXED P3 Normal --- 1 george.guo george.guo commit-queue george.guo laszlo.gombos oldest_to_newest 371678 0 george.guo 2011-03-22 14:53:13 -0700 When I tried to compile webkit on RedHat Linux with this following command: Tools/Scripts/build-webkit --qt –debug I got the following error ../../Source/JavaScriptCore/profiler -I../../../Source/JavaScriptCore/runtime -I../../../Source/JavaScriptCore/wtf -I../../../Source/JavaScriptCore/wtf/gobject -I/nokia/bs_nmp/groups/s40_builds/naguo/webkit2/trunk/Source/JavaScriptCore/wtf/symbian -I../../../Source/JavaScriptCore/wtf/unicode -I../../../Source/JavaScriptCore/yarr -I../../../Source/JavaScriptCore/API -I../../../Source/JavaScriptCore/ForwardingHeaders -Igenerated -I../../../Source -I../include/QtWebKit -I../include -I. -I../../../Source/JavaScriptCore -I. -o obj/debug/TimeoutChecker.o ../../../Source/JavaScriptCore/runtime/TimeoutChecker.cpp cc1plus: warnings being treated as errors ../../../Source/JavaScriptCore/runtime/TimeoutChecker.cpp: In function 'unsigned int JSC::getCPUTime()': ../../../Source/JavaScriptCore/runtime/TimeoutChecker.cpp:104: warning: converting to 'unsigned int' from 'double' make[1]: *** [obj/debug/TimeoutChecker.o] Error 1 371712 1 laszlo.gombos 2011-03-22 15:27:41 -0700 This is not just for Qt, removing the Qt prefix. 371869 2 86553 george.guo 2011-03-22 17:44:12 -0700 Created attachment 86553 A explicit cast in C++ style for review 371894 3 86553 darin 2011-03-22 18:33:18 -0700 Comment on attachment 86553 A explicit cast in C++ style for review This casts to unsigned before multiplying by 1000, so now the function will only return multiples of 1000! 372124 4 86611 george.guo 2011-03-23 06:55:32 -0700 Created attachment 86611 This patch resolves the issue pointed out by Adler during the review 372174 5 86611 darin 2011-03-23 09:00:05 -0700 Comment on attachment 86611 This patch resolves the issue pointed out by Adler during the review View in context: https://bugs.webkit.org/attachment.cgi?id=86611&action=review > Source/JavaScriptCore/runtime/TimeoutChecker.cpp:104 > + return static_cast<unsigned> ((currentTime() - firstTime) * 1000); There’s an extra space here after the "<". This is not the normal way we format. I’m also concerned. We have many places where we assign from double to an integer. Is this really the only failure in WebKit of this type? 372271 6 george.guo 2011-03-23 11:06:04 -0700 ok, preparing a new patch to get rid of the extra space. Yes, with the build it did pass the build after this change. 372422 7 86611 commit-queue 2011-03-23 14:05:29 -0700 Comment on attachment 86611 This patch resolves the issue pointed out by Adler during the review Clearing flags on attachment: 86611 Committed r81803: <http://trac.webkit.org/changeset/81803> 372423 8 commit-queue 2011-03-23 14:05:34 -0700 All reviewed patches have been landed. Closing bug. 86553 2011-03-22 17:44:12 -0700 2011-03-22 18:33:18 -0700 A explicit cast in C++ style for review bug56865.patch text/plain 1218 george.guo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODE3MDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDMtMjIgIEdlb3JnZSBHdW8gIDxHZW9yZ2UuR3VvQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJraXQgd2FybmluZzog Y29udmVydGluZyB0byAndW5zaWduZWQgaW50JyBmcm9tICdkb3VibGUnCisKKyAgICAgICAgV2l0 aCAtV2VyciBlbmFibGluZywgdGhpcyBjYXVzZSB0aGUgYnVpbGQgZmFpbHVyZSBvbiBSZWRIYXQu IEFkZCAKKyAgICAgICAgYW4gZXhwbGljaXQgY2FzdCBoZWxwcy4gIAorCisgICAgICAgICogcnVu dGltZS9UaW1lb3V0Q2hlY2tlci5jcHA6CisgICAgICAgIChKU0M6OmdldENQVVRpbWUpOgorCiAy MDExLTAzLTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv VGltZW91dENoZWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1RpbWVvdXRDaGVja2VyLmNwcAkocmV2aXNpb24gODEzODYpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwMSw3ICsxMDEsNyBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGdldENQVVRpbWUoKQogCiAg ICAgLy8gdXNlIGEgcmVsYXRpdmUgdGltZSBmcm9tIGZpcnN0IGNhbGwgaW4gb3JkZXIgdG8gYXZv aWQgYW4gb3ZlcmZsb3cKICAgICBzdGF0aWMgZG91YmxlIGZpcnN0VGltZSA9IGN1cnJlbnRUaW1l KCk7Ci0gICAgcmV0dXJuIChjdXJyZW50VGltZSgpIC0gZmlyc3RUaW1lKSAqIDEwMDA7CisgICAg cmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPiAoY3VycmVudFRpbWUoKSAtIGZpcnN0VGltZSkg KiAxMDAwOwogI2VuZGlmCiB9CiAK 86611 2011-03-23 06:55:32 -0700 2011-03-23 14:05:29 -0700 This patch resolves the issue pointed out by Adler during the review bug56865-1.patch text/plain 1229 george.guo SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDgxNzcx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMt MjMgIEdlb3JnZSBHdW8gIDxHZW9yZ2UuR3VvQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJraXQgd2FybmluZzogY29udmVydGlu ZyB0byAndW5zaWduZWQgaW50JyBmcm9tICdkb3VibGUnCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njg2NQorCisgICAgICAgIFdpdGggLVdlcnIgZW5h YmxlZCwgdGhpcyBjYXVzZSB0aGUgYnVpbGQgZmFpbHVyZSBvbiBSZWRIYXQgTGludXguIAorICAg ICAgICBBZGQgYSBjYXN0IGhlbHBlZC4gIAorCisgICAgICAgICogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwOgorICAgICAgICAoSlNDOjpnZXRDUFVUaW1l KToKKwogMjAxMS0wMy0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1RpbWVvdXRDaGVja2VyLmNwcAkocmV2aXNpb24gODEzODYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEwMSw3ICsxMDEsNyBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGdldENQVVRp bWUoKQogCiAgICAgLy8gdXNlIGEgcmVsYXRpdmUgdGltZSBmcm9tIGZpcnN0IGNhbGwgaW4gb3Jk ZXIgdG8gYXZvaWQgYW4gb3ZlcmZsb3cKICAgICBzdGF0aWMgZG91YmxlIGZpcnN0VGltZSA9IGN1 cnJlbnRUaW1lKCk7Ci0gICAgcmV0dXJuIChjdXJyZW50VGltZSgpIC0gZmlyc3RUaW1lKSAqIDEw MDA7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPiAoKGN1cnJlbnRUaW1lKCkgLSBm aXJzdFRpbWUpICogMTAwMCk7CiAjZW5kaWYKIH0KIAo=