56854 2011-03-22 12:02:44 -0700 computation in InlineTextBox::positionForOffset() might be wrong. 2025-06-29 13:56:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 xji webkit-unassigned ahmad.saleem792 enrica mitz simon.fraser zalan oldest_to_newest 371539 0 xji 2011-03-22 12:02:44 -0700 Following line inside "float InlineTextBox::positionForOffset(int offset) const" might be wrong: // FIXME: Do we need to add rightBearing here? return f.selectionRectForText(TextRun(text->text()->characters() + m_start, m_len, textRenderer()->allowTabs(), textPos(), m_expansion, trailingExpansionBehavior(), !isLeftToRightDirection(), m_dirOverride), IntPoint(logicalLeft(), 0), 0, from, to).maxX(); convert "logicalLeft()" to "int" in "IntPoint(logicalLeft(), 0)" should not be done. For example, <textarea id="textarea_rtl_no_wrap" style="padding:0; margin:0; white-space:nowrap; width: 100px; font: 8px" dir="rtl">דגלחכ גדכ לחידגכ יחעדד</textarea> the width of the text is 120, the logicalLeft() is -19.775, which is round to -19. Then, the positionForOffset(0) will be "120 - 19 = 101" which is greater than the textarea width: 100px. 379952 1 88331 xji 2011-04-05 16:15:39 -0700 Created attachment 88331 patch w/ layout test Dan, Enrica, Could you please help on verifying the layout test result on editing/selection/mixed-editability-10.html and platform/mac/editing/input/caret-primary-bidi.html? I tried moving caret in caret-primary-bidi.html, and I did not see any where that the caret becomes invisible. Seems the result is acceptable. But I am not sure on mixed-editability-10.html. The result changed for the first <div> with one regression and one progression. 379991 2 xji 2011-04-05 17:28:32 -0700 The patch is not completed. It breaks mixed-editability-10.html in the sense that when clicking left of the span, the caret overlaps with the span, the caret should be placed before the span. The code in the patch itself seems reasonable. But there are probably some other code pieces that do float/int conversion or float rounding or other float hacking that need to be taken care of. 380199 3 88331 rniwa 2011-04-06 01:05:49 -0700 Comment on attachment 88331 patch w/ layout test View in context: https://bugs.webkit.org/attachment.cgi?id=88331&action=review > LayoutTests/platform/mac/editing/input/caret-primary-bidi-expected.txt:3 > -0: 124,508,0,28 > +0: 125,508,0,28 > 1: 21,564,0,28 > 2: 36,564,0,28 These output makes no sense to me. We should come up with a better output here. 1953496 4 ahmad.saleem792 2023-05-07 03:58:48 -0700 @Alan - I looked into it and it seems that it is in IFC part and I am sure that you might have already fixed it and improved it. Anything to do it? https://searchfox.org/wubkat/source/Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp#93 2126586 5 ahmad.saleem792 2025-06-29 08:42:02 -0700 (In reply to Ahmad Saleem from comment #4) > @Alan - I looked into it and it seems that it is in IFC part and I am sure > that you might have already fixed it and improved it. > > > Anything to do it? > > https://searchfox.org/wubkat/source/Source/WebCore/layout/integration/inline/ > InlineIteratorTextBox.cpp#93 Code is now deleted - https://commits.webkit.org/244347@main and can't find reference of this comment in IFC. 88331 2011-04-05 16:15:39 -0700 2011-04-06 01:05:49 -0700 patch w/ layout test 56854.v1 text/plain 5748 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyOTk3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMDUgIFhpYW9tZWkg SmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvbXB1dGF0aW9uIGluIElubGluZVRleHRCb3g6OnBvc2l0aW9uRm9y T2Zmc2V0KCkgbWlnaHQgYmUgd3JvbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01Njg1NAorCisgICAgICAgICogcmVuZGVyaW5nL0lubGluZVRleHRC b3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lVGV4dEJveDo6cG9zaXRpb25Gb3JPZmZz ZXQpOiBEbyBub3QgY2FzdCBsb2dpY2FsTGVmdCgpIHRvCisgICAgICAgICJpbnQiLCBwYXNzaW5n IEZsb2F0UG9pbnQgdG8gRm9udDo6c2VsZWN0aW9uUmVjdEZvclRleHQoKS4KKwogMjAxMS0wNC0w NSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9Jbmxp bmVUZXh0Qm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5s aW5lVGV4dEJveC5jcHAJKHJldmlzaW9uIDgyOTQ3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0lubGluZVRleHRCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQzLDcgKzEyNDMsNyBA QCBmbG9hdCBJbmxpbmVUZXh0Qm94Ojpwb3NpdGlvbkZvck9mZnNldChpCiAgICAgaW50IHRvID0g IWlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSA/IG1fbGVuIDogb2Zmc2V0IC0gbV9zdGFydDsKICAg ICAvLyBGSVhNRTogRG8gd2UgbmVlZCB0byBhZGQgcmlnaHRCZWFyaW5nIGhlcmU/CiAgICAgcmV0 dXJuIGYuc2VsZWN0aW9uUmVjdEZvclRleHQoVGV4dFJ1bih0ZXh0LT50ZXh0KCktPmNoYXJhY3Rl cnMoKSArIG1fc3RhcnQsIG1fbGVuLCB0ZXh0UmVuZGVyZXIoKS0+YWxsb3dUYWJzKCksIHRleHRQ b3MoKSwgbV9leHBhbnNpb24sIGV4cGFuc2lvbkJlaGF2aW9yKCksICFpc0xlZnRUb1JpZ2h0RGly ZWN0aW9uKCksIG1fZGlyT3ZlcnJpZGUpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEludFBvaW50KGxvZ2ljYWxMZWZ0KCksIDApLCAwLCBmcm9tLCB0bykubWF4WCgpOworICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQobG9naWNhbExlZnQoKSwg MCksIDAsIGZyb20sIHRvKS5tYXhYKCk7CiB9CiAKIGJvb2wgSW5saW5lVGV4dEJveDo6Y29udGFp bnNDYXJldE9mZnNldChpbnQgb2Zmc2V0KSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODI5OTcp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAxMS0wNC0wNSAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcHV0YXRpb24gaW4gSW5s aW5lVGV4dEJveDo6cG9zaXRpb25Gb3JPZmZzZXQoKSBtaWdodCBiZSB3cm9uZy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODU0CisKKyAgICAgICAg KiBlZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1lZGl0YWJpbGl0eS0xMC1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvY2FyZXQtcHJpbWFyeS1iaWRpLWV4 cGVjdGVkLnR4dDoKKwogMjAxMS0wNC0wNSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIDMgdGVzdHMgZmFpbCBvbiBhcHBsZS1tYWNwcm8tNiAoZHVlIHRvIGRp ZmZlcmVudCBKUyBNSU1FIHR5cGUpIGJ1dCBub3QgYW55IG90aGVyIExlb3BhcmQKSW5kZXg6IExh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5LTEwLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1l ZGl0YWJpbGl0eS0xMC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDgyOTQ3KQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMTAtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0xNSw4ICsxNSw4IEBAIEhlbGxvIFdvcmxkCiAjNiBub24gZWRpdGFi bGUgRElWIGVsZW1lbnQgd2l0aCBhbiBlZGl0YWJsZSBlbXB0eSBzcGFuIGVsZW1lbnQKIAogSGVs bG86wqAKLUFuY2hvciAoW29iamVjdCBIVE1MRGl2RWxlbWVudF0sIDAgY2FyZXRbNDAsNTQwXSBy ZWZwb3M9NDApIGlzIGNvcnJlY3QuCi1BbmNob3IgKFtvYmplY3QgSFRNTERpdkVsZW1lbnRdLCAz IGNhcmV0Wzc1LDU0MF0gcmVmcG9zPTc2KSBpcyBpbmNvcnJlY3QuCitBbmNob3IgKFtvYmplY3Qg SFRNTERpdkVsZW1lbnRdLCAwIGNhcmV0WzQxLDU0MF0gcmVmcG9zPTQwKSBpcyBpbmNvcnJlY3Qu CitBbmNob3IgKFtvYmplY3QgSFRNTERpdkVsZW1lbnRdLCAzIGNhcmV0Wzc2LDU0MF0gcmVmcG9z PTc2KSBpcyBjb3JyZWN0LgogQW5jaG9yIChbb2JqZWN0IEhUTUxEaXZFbGVtZW50XSwgMSBjYXJl dFs0Myw0NzJdIHJlZnBvcz00MykgaXMgY29ycmVjdC4KIEFuY2hvciAoW29iamVjdCBIVE1MRGl2 RWxlbWVudF0sIDAgY2FyZXRbOCw0NzJdIHJlZnBvcz04KSBpcyBjb3JyZWN0LgogQW5jaG9yIChb b2JqZWN0IEhUTUxEaXZFbGVtZW50XSwgMCBjYXJldFs3Myw0MDRdIHJlZnBvcz03MykgaXMgY29y cmVjdC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L2NhcmV0 LXByaW1hcnktYmlkaS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQvY2FyZXQtcHJpbWFyeS1iaWRpLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gODI5NDcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1 dC9jYXJldC1wcmltYXJ5LWJpZGktZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDY2 ICsxLDY2IEBACi0wOiAxMjQsNTA4LDAsMjgKKzA6IDEyNSw1MDgsMCwyOAogMTogMjEsNTY0LDAs MjgKIDI6IDM2LDU2NCwwLDI4Ci0zOiA0OCw1NjQsMSwyOAotNDogMTU0LDU2NCwwLDI4Ci01OiAx NDAsNTY0LDAsMjgKKzM6IDQ5LDU2NCwwLDI4Cis0OiAxNTUsNTY0LDAsMjgKKzU6IDE0MSw1NjQs MCwyOAogNjogODUsNTY0LDAsMjgKIDc6IDEwMCw1NjQsMCwyOAogODogMTE1LDU2NCwwLDI4CiA5 OiAxMzEsNTY0LDAsMjgKLTEwOiA3Myw1NjQsMCwyOAotMTE6IDU2LDU2NCwwLDI4Ci0xMjogMTY5 LDU2NCwxLDI4CisxMDogNzQsNTY0LDAsMjgKKzExOiA1Nyw1NjQsMCwyOAorMTI6IDE3MCw1NjQs MCwyOAogMTM6IDE4NSw1NjQsMCwyOAogMTQ6IDE5OCw1NjQsMCwyOAogMTU6IDIwNyw1NjQsMCwy OAogMTY6IDgsNTM2LDAsMjgKIDE3OiAxMTQsNTM2LDAsMjgKIDE4OiAxMDAsNTM2LDAsMjgKLTE5 OiA0NCw1MzYsMCwyOAotMjA6IDU5LDUzNiwwLDI4Ci0yMTogNzQsNTM2LDAsMjgKLTIyOiA5MCw1 MzYsMCwyOAorMTk6IDQ1LDUzNiwwLDI4CisyMDogNjAsNTM2LDAsMjgKKzIxOiA3NSw1MzYsMCwy OAorMjI6IDkxLDUzNiwwLDI4CiAyMzogMzMsNTM2LDAsMjgKIDI0OiAxNiw1MzYsMCwyOAogMjU6 IDEyOSw1MzYsMCwyOAogMjY6IDgsNTA4LDAsMjgKLTI3OiAxNDgsNTA4LDAsMjgKLTI4OiAxMzQs NTA4LDAsMjgKLTI5OiAxMjQsNTA4LDAsMjgKKzI3OiAxNDksNTA4LDAsMjgKKzI4OiAxMzUsNTA4 LDAsMjgKKzI5OiAxMjUsNTA4LDAsMjgKIDMwOiAzMyw1MDgsMCwyOAogMzE6IDE2LDUwOCwwLDI4 Ci0zMjogMTYzLDUwOCwwLDI4CiszMjogMTY0LDUwOCwwLDI4CiAzMzogOCw0NzgsMCwyOAogMzQ6 IDMyLDQ3OCwwLDI4CiAzNTogMTgsNDc4LDAsMjgKIDM2OiA0Nyw0NzgsMCwyOAogMzc6IDYwLDQ3 OCwwLDI4CiAzODogNzUsNDc4LDAsMjgKLTM5OiA4Nyw0NzgsMSwyOAotNDA6IDExMiw0NzgsMCwy OAotNDE6IDk1LDQ3OCwwLDI4Ci00MjogMTI0LDQ3OCwwLDI4CiszOTogODgsNDc4LDAsMjgKKzQw OiAxMTMsNDc4LDAsMjgKKzQxOiA5Niw0NzgsMCwyOAorNDI6IDEyNSw0NzgsMCwyOAogNDM6IDc5 MSw0NTAsMCwyOAogNDQ6IDc2NCw0NTAsMCwyOAogNDU6IDc3OSw0NTAsMCwyOAogNDY6IDc1MSw0 NTAsMCwyOAogNDc6IDczNiw0NTAsMCwyOAogNDg6IDcyMiw0NTAsMCwyOAotNDk6IDcxMiw0NTAs MCwyOAotNTA6IDY4MSw0NTAsMCwyOAotNTE6IDY5Niw0NTAsMCwyOAotNTI6IDY2Niw0NTAsMCwy OAotNTM6IDY1NCw0NTAsMCwyOAotNTQ6IDYzNyw0NTAsMCwyOAotNTU6IDYyOSw0NTAsMCwyOAor NDk6IDcxMiw0NTAsMSwyOAorNTA6IDY4Miw0NTAsMCwyOAorNTE6IDY5Nyw0NTAsMCwyOAorNTI6 IDY2Nyw0NTAsMCwyOAorNTM6IDY1NSw0NTAsMCwyOAorNTQ6IDYzOCw0NTAsMCwyOAorNTU6IDYy OSw0NTAsMSwyOAogNTY6IDYwNyw0NTAsMCwyOAogNTc6IDYyMCw0NTAsMCwyOAogNTg6IDU5Miw0 NTAsMCwyOAogNTk6IDc5MSw0MjIsMCwyOAotNjA6IDc3Niw0MjIsMCwyOAotNjE6IDc2Miw0MjIs MCwyOAotNjI6IDc1Miw0MjIsMSwyOAorNjA6IDc3Nyw0MjIsMCwyOAorNjE6IDc2Myw0MjIsMCwy OAorNjI6IDc1Myw0MjIsMCwyOAogNjM6IDcyMiw0MjIsMCwyOAogNjQ6IDczNyw0MjIsMCwyOAog NjU6IDcwNyw0MjIsMCwyOApAQCAtNjgsMjAgKzY4LDIwIEBACiA2NzogNjc4LDQyMiwwLDI4CiA2 ODogNjcwLDQyMiwwLDI4CiA2OTogNzkxLDM5NCwwLDI4Ci03MDogNzc2LDM5NCwwLDI4Ci03MTog NzYyLDM5NCwwLDI4Ci03MjogNzUyLDM5NCwwLDI4Ci03MzogNjYwLDM5NCwwLDI4Ci03NDogNjQz LDM5NCwwLDI4Ci03NTogNjM1LDM5NCwwLDI4Cis3MDogNzc3LDM5NCwwLDI4Cis3MTogNzYzLDM5 NCwwLDI4Cis3MjogNzUzLDM5NCwwLDI4Cis3MzogNjYxLDM5NCwwLDI4Cis3NDogNjQ0LDM5NCww LDI4Cis3NTogNjM2LDM5NCwwLDI4CiA3NjogNzkxLDM2NCwwLDI4CiA3NzogNzY0LDM2NCwwLDI4 CiA3ODogNzc5LDM2NCwwLDI4CiA3OTogNzUxLDM2NCwwLDI4CiA4MDogNzM2LDM2NCwwLDI4CiA4 MTogNzIyLDM2NCwwLDI4Ci04MjogNzExLDM2NCwxLDI4Ci04MzogNjg5LDM2NCwwLDI4Ci04NDog NzAyLDM2NCwwLDI4Ci04NTogNjc0LDM2NCwwLDI4Cis4MjogNzEyLDM2NCwwLDI4Cis4MzogNjkw LDM2NCwwLDI4Cis4NDogNzAzLDM2NCwwLDI4Cis4NTogNjc1LDM2NCwwLDI4CiAK