56847 2011-03-22 11:17:45 -0700 WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling) 2011-04-06 17:53:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam adele oldest_to_newest 371497 0 sam 2011-03-22 11:17:45 -0700 WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling) 371499 1 86482 sam 2011-03-22 11:19:19 -0700 Created attachment 86482 Patch 371503 2 86482 aroben 2011-03-22 11:24:44 -0700 Comment on attachment 86482 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86482&action=review > Source/WebKit2/Shared/mac/WebEventFactory.mm:45 > + if (!pressedMouseButtons) > + return WebMouseEvent::NoButton; > + if (pressedMouseButtons == 1 << 0) > + return WebMouseEvent::LeftButton; > + if (pressedMouseButtons == 1 << 1) > + return WebMouseEvent::RightButton; Surprising that there aren't constants for these! 381012 3 adele 2011-04-06 17:53:07 -0700 Fixed in r81679. 86482 2011-03-22 11:19:19 -0700 2011-03-22 11:24:43 -0700 Patch bug-56847-20110322111919.patch text/plain 2053 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjc4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjIgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXQyOiBDYW5ub3QgbWFrZSBhIHNlbGVjdGlvbiBwYXN0IHRoZSBl bmQgb2YgdGhlIHZpc2libGUgcGFnZSAobm8gYXV0b3Njcm9sbGluZykKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODQ3CisKKyAgICAgICAgKiBTaGFy ZWQvbWFjL1dlYkV2ZW50RmFjdG9yeS5tbToKKyAgICAgICAgKFdlYktpdDo6Y3VycmVudE1vdXNl QnV0dG9uKToKKyAgICAgICAgKFdlYktpdDo6bW91c2VCdXR0b25Gb3JFdmVudCk6CisgICAgICAg IEFkZCBtb3VzZSBidXR0b24gZm9yIG1vdXNlRW50ZXIvRXhpdCBldmVudHMuIFtOU0V2ZW50IGJ1 dHRvbk51bWJlcl0gZG9lc24ndCBzZWVtIHRvIGdpdmUgdGhlIHJpZ2h0IHJlc3VsdAorICAgICAg ICBmb3IgdGhlc2UgZXZlbnRzLCBidXQgZ2V0dGluZyB0aGUgY3VycmVudE1vdXNlQnV0dG9uIGRv ZXMgd29yay4KKwogMjAxMS0wMy0yMSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IE1hYyByZWxlYXNlIGJ1aWxkcyBhZnRlciBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3ODMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCShyZXZpc2lvbiA4MTYwMSkKKysrIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0z NCw2ICszNCwxOCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktp dCB7CiAKK3N0YXRpYyBXZWJNb3VzZUV2ZW50OjpCdXR0b24gY3VycmVudE1vdXNlQnV0dG9uKCkK K3sKKyAgICBOU1VJbnRlZ2VyIHByZXNzZWRNb3VzZUJ1dHRvbnMgPSBbTlNFdmVudCBwcmVzc2Vk TW91c2VCdXR0b25zXTsKKyAgICBpZiAoIXByZXNzZWRNb3VzZUJ1dHRvbnMpCisgICAgICAgIHJl dHVybiBXZWJNb3VzZUV2ZW50OjpOb0J1dHRvbjsKKyAgICBpZiAocHJlc3NlZE1vdXNlQnV0dG9u cyA9PSAxIDw8IDApCisgICAgICAgIHJldHVybiBXZWJNb3VzZUV2ZW50OjpMZWZ0QnV0dG9uOwor ICAgIGlmIChwcmVzc2VkTW91c2VCdXR0b25zID09IDEgPDwgMSkKKyAgICAgICAgcmV0dXJuIFdl Yk1vdXNlRXZlbnQ6OlJpZ2h0QnV0dG9uOworICAgIHJldHVybiBXZWJNb3VzZUV2ZW50OjpNaWRk bGVCdXR0b247Cit9CisKIHN0YXRpYyBXZWJNb3VzZUV2ZW50OjpCdXR0b24gbW91c2VCdXR0b25G b3JFdmVudChOU0V2ZW50ICpldmVudCkKIHsKICAgICBzd2l0Y2ggKFtldmVudCB0eXBlXSkgewpA QCAtNDksNiArNjEsOSBAQCBzdGF0aWMgV2ViTW91c2VFdmVudDo6QnV0dG9uIG1vdXNlQnV0dG9u CiAgICAgICAgIGNhc2UgTlNPdGhlck1vdXNlVXA6CiAgICAgICAgIGNhc2UgTlNPdGhlck1vdXNl RHJhZ2dlZDoKICAgICAgICAgICAgIHJldHVybiBXZWJNb3VzZUV2ZW50OjpNaWRkbGVCdXR0b247 CisgICAgICAgIGNhc2UgTlNNb3VzZUVudGVyZWQ6CisgICAgICAgIGNhc2UgTlNNb3VzZUV4aXRl ZDoKKyAgICAgICAgICAgIHJldHVybiBjdXJyZW50TW91c2VCdXR0b24oKTsKICAgICAgICAgZGVm YXVsdDoKICAgICAgICAgICAgIHJldHVybiBXZWJNb3VzZUV2ZW50OjpOb0J1dHRvbjsKICAgICB9 Cg==