56837 2011-03-22 09:28:22 -0700 Allow WebMediaPlayerClient to call playbackStatechanged in MediaPlayer 2011-03-24 19:09:26 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned commit-queue jamesr qinmin scherkus oldest_to_newest 371420 0 qinmin 2011-03-22 09:28:22 -0700 Once we start playing a media url in WebMediaPlayerImpl, m_paused in HTMLMediaElement will always set to true, even if the whole stream has been consumed by the pipeline. This CL allows the WebMediaPlayerClient to inform MediaPlayer that playstate has changed (e.g., pipeline crashed due to some errors and the WebMediaPlayerImpl is in state "paused") 371434 1 86466 qinmin 2011-03-22 10:01:54 -0700 Created attachment 86466 Patch 373062 2 86466 scherkus 2011-03-24 13:56:39 -0700 Comment on attachment 86466 Patch Looks good to me. 373071 3 jamesr 2011-03-24 14:02:43 -0700 Can you make a test? 373076 4 86466 jamesr 2011-03-24 14:06:15 -0700 Comment on attachment 86466 Patch OK 373169 5 86852 qinmin 2011-03-24 16:16:13 -0700 Created attachment 86852 Patch 373263 6 commit-queue 2011-03-24 19:05:50 -0700 The commit-queue encountered the following flaky tests while processing attachment 86852: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 373265 7 86852 commit-queue 2011-03-24 19:09:22 -0700 Comment on attachment 86852 Patch Clearing flags on attachment: 86852 Committed r81930: <http://trac.webkit.org/changeset/81930> 373266 8 commit-queue 2011-03-24 19:09:26 -0700 All reviewed patches have been landed. Closing bug. 86466 2011-03-22 10:01:54 -0700 2011-03-24 16:16:10 -0700 Patch bug-56837-20110322100153.patch text/plain 2726 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogODE2MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZjFmMDEzOWZjMmEzMDU1ZWE1NGI2YzBjM2ExYzhjMGE4NmE1NzE4YS4uNWY5YWY4MTkwYzY2MDY3 NDY5N2ZkYjE5OGE2M2FhYWIwMWM4ZDhjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wMy0yMiAgTWluIFFpbiAgPHFpbm1pbkBnb29nbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IFdl Yk1lZGlhUGxheWVyQ2xpZW50IHRvIG5vdGlmeSBNZWRpYVBsYXllciB0aGF0IHRoZSBwbGF5YmFj ayBzdGF0ZSBoYXMgY2hhbmdlZAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjgzNworCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyQ2xp ZW50Lmg6CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6cGxheWJhY2tTdGF0ZUNoYW5n ZWQpOgorICAgICAgICAqIHNyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaDoKKwogMjAxMS0w My0yMSAgUm9iZXJ0IEtyb2VnZXIgIDxyamtyb2VnZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oCmluZGV4IDdlNWRkNjhjOTE2ODE2NGFk NmVjY2I2MTJmZTMxY2YyOGUwYTcyMWUuLjVmNjA4NzBkYzE1MGY3ZjAzNmMwMDlmYjczYWUyNGVk ZjQxZTJiN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1l ZGlhUGxheWVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi TWVkaWFQbGF5ZXJDbGllbnQuaApAQCAtNDksNiArNDksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIHNpemVDaGFuZ2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzYXdVbnN1cHBvcnRl ZFRyYWNrcygpID0gMDsKICAgICB2aXJ0dWFsIGZsb2F0IHZvbHVtZSgpIGNvbnN0ID0gMDsKKyAg ICB2aXJ0dWFsIHZvaWQgcGxheWJhY2tTdGF0ZUNoYW5nZWQoKSA9IDA7CiAKIHByb3RlY3RlZDoK ICAgICB+V2ViTWVkaWFQbGF5ZXJDbGllbnQoKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCmluZGV4IGExYjQy OGNiOTM2ZTE0ZjljMjZlNjFlYTFiY2FmM2Q5ZTZjMzUzMjIuLmFiZTljYmYxMzA1MDAxMGMxMjcz MzhhNGM4MjhkMDA2OWNhYzBkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcApAQCAtMTgzLDYgKzE4MywxMiBA QCBmbG9hdCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OnZvbHVtZSgpIGNvbnN0CiAgICAgcmV0 dXJuIDAuMGY7CiB9CiAKK3ZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpwbGF5YmFja1N0 YXRlQ2hhbmdlZCgpCit7CisgICAgQVNTRVJUKG1fbWVkaWFQbGF5ZXIpOworICAgIG1fbWVkaWFQ bGF5ZXItPnBsYXliYWNrU3RhdGVDaGFuZ2VkKCk7Cit9CisKIC8vIE1lZGlhUGxheWVyUHJpdmF0 ZUludGVyZmFjZSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAKIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpsb2FkKGNvbnN0IFN0cmluZyYg dXJsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5 ZXJDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXll ckNsaWVudEltcGwuaAppbmRleCA1ZDQ0NjI2OTMxZGE4MzNmMTdjOTMzNDcwNmY2Yzc4ZTVlMDU0 NmQ2Li4yMjAzMGIzNDA2ODBlZjE3MjY5ODNiMWI5YWI0YjEyZWRlYzA0NTUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwu aApAQCAtNzYsNiArNzYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNpemVDaGFuZ2Vk KCk7CiAgICAgdmlydHVhbCB2b2lkIHNhd1Vuc3VwcG9ydGVkVHJhY2tzKCk7CiAgICAgdmlydHVh bCBmbG9hdCB2b2x1bWUoKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgcGxheWJhY2tTdGF0ZUNo YW5nZWQoKTsKIAogICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSBtZXRob2RzOgog ICAgIHZpcnR1YWwgdm9pZCBsb2FkKGNvbnN0IFdURjo6U3RyaW5nJiB1cmwpOwo= 86852 2011-03-24 16:16:13 -0700 2011-03-24 19:09:22 -0700 Patch bug-56837-20110324161612.patch text/plain 2726 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogODE2MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZjFmMDEzOWZjMmEzMDU1ZWE1NGI2YzBjM2ExYzhjMGE4NmE1NzE4YS4uMDU2OTczOTQ0NTIzM2Y4 NWFlYmMxZDQyMjUyYzYxZDcyNzY2NWJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wMy0yMiAgTWluIFFpbiAgPHFpbm1pbkBnb29nbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAgIEFsbG93IFdl Yk1lZGlhUGxheWVyQ2xpZW50IHRvIG5vdGlmeSBNZWRpYVBsYXllciB0aGF0IHRoZSBwbGF5YmFj ayBzdGF0ZSBoYXMgY2hhbmdlZAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjgzNworCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyQ2xp ZW50Lmg6CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6cGxheWJhY2tTdGF0ZUNoYW5n ZWQpOgorICAgICAgICAqIHNyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaDoKKwogMjAxMS0w My0yMSAgUm9iZXJ0IEtyb2VnZXIgIDxyamtyb2VnZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oCmluZGV4IDdlNWRkNjhjOTE2ODE2NGFk NmVjY2I2MTJmZTMxY2YyOGUwYTcyMWUuLjVmNjA4NzBkYzE1MGY3ZjAzNmMwMDlmYjczYWUyNGVk ZjQxZTJiN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1l ZGlhUGxheWVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi TWVkaWFQbGF5ZXJDbGllbnQuaApAQCAtNDksNiArNDksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIHNpemVDaGFuZ2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzYXdVbnN1cHBvcnRl ZFRyYWNrcygpID0gMDsKICAgICB2aXJ0dWFsIGZsb2F0IHZvbHVtZSgpIGNvbnN0ID0gMDsKKyAg ICB2aXJ0dWFsIHZvaWQgcGxheWJhY2tTdGF0ZUNoYW5nZWQoKSA9IDA7CiAKIHByb3RlY3RlZDoK ICAgICB+V2ViTWVkaWFQbGF5ZXJDbGllbnQoKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCmluZGV4IGExYjQy OGNiOTM2ZTE0ZjljMjZlNjFlYTFiY2FmM2Q5ZTZjMzUzMjIuLmFiZTljYmYxMzA1MDAxMGMxMjcz MzhhNGM4MjhkMDA2OWNhYzBkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcApAQCAtMTgzLDYgKzE4MywxMiBA QCBmbG9hdCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OnZvbHVtZSgpIGNvbnN0CiAgICAgcmV0 dXJuIDAuMGY7CiB9CiAKK3ZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpwbGF5YmFja1N0 YXRlQ2hhbmdlZCgpCit7CisgICAgQVNTRVJUKG1fbWVkaWFQbGF5ZXIpOworICAgIG1fbWVkaWFQ bGF5ZXItPnBsYXliYWNrU3RhdGVDaGFuZ2VkKCk7Cit9CisKIC8vIE1lZGlhUGxheWVyUHJpdmF0 ZUludGVyZmFjZSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAKIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpsb2FkKGNvbnN0IFN0cmluZyYg dXJsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5 ZXJDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXll ckNsaWVudEltcGwuaAppbmRleCA1ZDQ0NjI2OTMxZGE4MzNmMTdjOTMzNDcwNmY2Yzc4ZTVlMDU0 NmQ2Li4yMjAzMGIzNDA2ODBlZjE3MjY5ODNiMWI5YWI0YjEyZWRlYzA0NTUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwu aApAQCAtNzYsNiArNzYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNpemVDaGFuZ2Vk KCk7CiAgICAgdmlydHVhbCB2b2lkIHNhd1Vuc3VwcG9ydGVkVHJhY2tzKCk7CiAgICAgdmlydHVh bCBmbG9hdCB2b2x1bWUoKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgcGxheWJhY2tTdGF0ZUNo YW5nZWQoKTsKIAogICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSBtZXRob2RzOgog ICAgIHZpcnR1YWwgdm9pZCBsb2FkKGNvbnN0IFdURjo6U3RyaW5nJiB1cmwpOwo=