56821 2011-03-22 02:41:42 -0700 [EFL] Functions without parameters take (void) instead of () 2011-03-22 08:37:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 g.czajkowski webkit-unassigned abarth commit-queue eric gyuyoung.kim kenneth leandro l.slachciak lucas.de.marchi ryuan.choi tkent tonikitoo webkit.review.bot oldest_to_newest 371306 0 g.czajkowski 2011-03-22 02:41:42 -0700 Some of functions without parameters in WebKit-EFL take () or (void) in declaration/definition. I suggest to use (void) for the ones. 371310 1 86449 g.czajkowski 2011-03-22 02:49:35 -0700 Created attachment 86449 patch 371311 2 gyuyoung.kim 2011-03-22 02:53:18 -0700 LGTM. 371335 3 86449 commit-queue 2011-03-22 05:22:19 -0700 Comment on attachment 86449 patch Clearing flags on attachment: 86449 Committed r81658: <http://trac.webkit.org/changeset/81658> 371336 4 commit-queue 2011-03-22 05:22:24 -0700 All reviewed patches have been landed. Closing bug. 371397 5 webkit.review.bot 2011-03-22 08:37:08 -0700 http://trac.webkit.org/changeset/81658 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html inspector/protocol/database-agent.html 86449 2011-03-22 02:49:35 -0700 2011-03-22 05:22:19 -0700 patch add_void_to_function_without_parameters.patch text/plain 6859 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1YmUxNmQ5Li5iMWJlMDdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMjIgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIHZvaWQgdG8gZnVuY3Rpb24gd2l0aG91dCBwYXJhbWV0ZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjgyMQorCisgICAg ICAgICogZXdrL2V3a19jb29raWVzLmNwcDoKKyAgICAgICAgKGV3a19jb29raWVzX2NsZWFyKToK KyAgICAgICAgKGV3a19jb29raWVzX3BvbGljeV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfY29v a2llcy5oOgorICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAqIGV3ay9ld2tf c2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0 X3F1b3RhX2dldCk6CisgICAgICAgIChld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfZ2V0 KToKKyAgICAgICAgKGV3a19zZXR0aW5nc19wcm94eV91cmlfZ2V0KToKKyAgICAgICAgKGV3a19z ZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdlbnRfZ2V0KToKKyAgICAgICAgKiBld2svZXdrX3NldHRp bmdzLmg6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2Rw aV9nZXQpOgorCiAyMDExLTAzLTE3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19jb29raWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf Y29va2llcy5jcHAKaW5kZXggNzU1ODE1NC4uMDQ4ODg2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19jb29raWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX2Nvb2tpZXMuY3BwCkBAIC03Niw3ICs3Niw3IEBAIEVBUEkgRWluYV9Cb29sIGV3a19jb29r aWVzX2ZpbGVfc2V0KGNvbnN0IGNoYXIgKmZpbGVuYW1lKQogLyoqCiAgKiBDbGVhcnMgYWxsIHRo ZSBjb29raWVzIGZyb20gdGhlIGNvb2tpZSBqYXIuCiAgKi8KLUVBUEkgdm9pZCBld2tfY29va2ll c19jbGVhcigpCitFQVBJIHZvaWQgZXdrX2Nvb2tpZXNfY2xlYXIodm9pZCkKIHsKICNpZiBVU0Uo U09VUCkKICAgICBHU0xpc3QqIGw7CkBAIC0yMDcsNyArMjA3LDcgQEAgRUFQSSB2b2lkIGV3a19j b29raWVzX3BvbGljeV9zZXQoRXdrX0Nvb2tpZV9Qb2xpY3kgcCkKICAqIEByZXR1cm4gdGhlIGN1 cnJlbnQgYWNjZXB0YW5jZSBwb2xpY3kKICAqIEBzZWUgRXdrX0Nvb2tpZV9Qb2xpY3kKICAqLwot RUFQSSBFd2tfQ29va2llX1BvbGljeSBld2tfY29va2llc19wb2xpY3lfZ2V0KCkKK0VBUEkgRXdr X0Nvb2tpZV9Qb2xpY3kgZXdrX2Nvb2tpZXNfcG9saWN5X2dldCh2b2lkKQogewogICAgIEV3a19D b29raWVfUG9saWN5IGV3a19wb2xpY3kgPSBFV0tfQ09PS0lFX0pBUl9BQ0NFUFRfQUxXQVlTOwog I2lmIFVTRShTT1VQKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb29r aWVzLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuaAppbmRleCAxOWVhYzBm Li5lYzBlODRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuaApAQCAtNzYsMTIgKzc2 LDEyIEBAIHR5cGVkZWYgZW51bSBfRXdrX0Nvb2tpZV9Qb2xpY3kgRXdrX0Nvb2tpZV9Qb2xpY3k7 CiAvKioqKioqKioqKioqKioqKioqKioqKioqKiogRXhwb3J0ZWQgZnVuY3Rpb25zICoqKioqKioq KioqKioqKioqKioqKioqLwogCiBFQVBJIEVpbmFfQm9vbCAgICAgICAgICBld2tfY29va2llc19m aWxlX3NldChjb25zdCBjaGFyICpmaWxlbmFtZSk7Ci1FQVBJIHZvaWQgICAgICAgICAgICAgICBl d2tfY29va2llc19jbGVhcigpOwotRUFQSSBFaW5hX0xpc3QqICAgICAgICAgZXdrX2Nvb2tpZXNf Z2V0X2FsbCgpOworRUFQSSB2b2lkICAgICAgICAgICAgICAgZXdrX2Nvb2tpZXNfY2xlYXIodm9p ZCk7CitFQVBJIEVpbmFfTGlzdCogICAgICAgICBld2tfY29va2llc19nZXRfYWxsKHZvaWQpOwog RUFQSSB2b2lkICAgICAgICAgICAgICAgZXdrX2Nvb2tpZXNfY29va2llX2RlbChFd2tfQ29va2ll ICpjb29raWUpOwogRUFQSSB2b2lkICAgICAgICAgICAgICAgZXdrX2Nvb2tpZXNfY29va2llX2Zy ZWUoRXdrX0Nvb2tpZSAqY29va2llKTsKIEVBUEkgdm9pZCAgICAgICAgICAgICAgIGV3a19jb29r aWVzX3BvbGljeV9zZXQoRXdrX0Nvb2tpZV9Qb2xpY3kgcCk7Ci1FQVBJIEV3a19Db29raWVfUG9s aWN5ICBld2tfY29va2llc19wb2xpY3lfZ2V0KCk7CitFQVBJIEV3a19Db29raWVfUG9saWN5ICBl d2tfY29va2llc19wb2xpY3lfZ2V0KHZvaWQpOwogCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXggNTk1YmQ1Zi4uMTE0YzM5ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTEwNiw3ICsxMDYsNyBAQCB2b2lkIGV3a192 aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfc2V0KEV2YXNfT2JqZWN0ICpvLCBjb25zdCBXZWJDb3Jl OjpWaWV3cG9ydEFyZwogCiB2b2lkIGV3a192aWV3X2Rvd25sb2FkX3JlcXVlc3QoRXZhc19PYmpl Y3QgKm8sIEV3a19Eb3dubG9hZCAqZG93bmxvYWQpOwogCi1pbnQgZXdrX3ZpZXdfZHBpX2dldCgp OworaW50IGV3a192aWV3X2RwaV9nZXQodm9pZCk7CiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRT KQogdm9pZCBld2tfdmlld19uZWVkX3RvdWNoX2V2ZW50c19zZXQoRXZhc19PYmplY3QqLCBib29s IG5lZWRlZCk7CkBAIC0xNjUsNyArMTY1LDcgQEAgdm9pZCBld2tfdmlld19jb250ZW50c19zaXpl X2NoYW5nZWQoRXZhc19PYmplY3QgKm8sIEV2YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKTsKIAog V2ViQ29yZTo6RmxvYXRSZWN0IGV3a192aWV3X3BhZ2VfcmVjdF9nZXQoRXZhc19PYmplY3QgKm8p OwogCi1jb25zdCBjaGFyKiBld2tfc2V0dGluZ3NfZGVmYXVsdF91c2VyX2FnZW50X2dldCgpOwor Y29uc3QgY2hhciogZXdrX3NldHRpbmdzX2RlZmF1bHRfdXNlcl9hZ2VudF9nZXQodm9pZCk7CiAK ICNpZmRlZiBfX2NwbHVzcGx1cwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3Bw CmluZGV4IDNhZTUwM2EuLmQ4YzdlMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGlu Z3MuY3BwCkBAIC04Nyw3ICs4Nyw3IEBAIHN0YXRpYyBXVEY6OlN0cmluZyBfZXdrX3NldHRpbmdz X3dlYmtpdF9vc192ZXJzaW9uX2dldCgpCiAgKgogICogQHJldHVybiB0aGUgY3VycmVudCBkZWZh dWx0IGRhdGFiYXNlIHF1b3RhIGluIGJ5dGVzCiAgKi8KLXVpbnQ2NF90IGV3a19zZXR0aW5nc193 ZWJfZGF0YWJhc2VfZGVmYXVsdF9xdW90YV9nZXQoKQordWludDY0X3QgZXdrX3NldHRpbmdzX3dl Yl9kYXRhYmFzZV9kZWZhdWx0X3F1b3RhX2dldCh2b2lkKQogewogICAgIHJldHVybiBfZXdrX2Rl ZmF1bHRfd2ViX2RhdGFiYXNlX3F1b3RhOwogfQpAQCAtMTIwLDcgKzEyMCw3IEBAIHZvaWQgZXdr X3NldHRpbmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldChjb25zdCBjaGFyICpwYXRoKQogICoKICAq IEByZXR1cm4gZGF0YWJhc2UgcGF0aCBvciBAYyAwIGlmIG5vbmUgb3Igd2ViIGRhdGFiYXNlIGlz IG5vdCBzdXBwb3J0ZWQKICAqLwotY29uc3QgY2hhciAqZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFz ZV9wYXRoX2dldCgpCitjb25zdCBjaGFyICpld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhf Z2V0KHZvaWQpCiB7CiAjaWYgRU5BQkxFKERBVEFCQVNFKQogICAgIHJldHVybiBfZXdrX2RlZmF1 bHRfd2ViX2RhdGFiYXNlX3BhdGg7CkBAIC0zMDYsNyArMzA2LDcgQEAgdm9pZCBld2tfc2V0dGlu Z3NfcHJveHlfdXJpX3NldChjb25zdCBjaGFyKiBwcm94eSkKICAqCiAgKiBAcmV0dXJuIGN1cnJl bnQgcHJveHkgVVJJIG9yIEBjIDAgaWYgaXQncyBub3Qgc2V0CiAgKi8KLWNvbnN0IGNoYXIqIGV3 a19zZXR0aW5nc19wcm94eV91cmlfZ2V0KCkKK2NvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19wcm94 eV91cmlfZ2V0KHZvaWQpCiB7CiAjaWYgVVNFKFNPVVApCiAgICAgU291cFVSSSogdXJpOwpAQCAt MzMyLDcgKzMzMiw3IEBAIGNvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19wcm94eV91cmlfZ2V0KCkK ICAqCiAgKiBAcmV0dXJuIGEgcG9pbnRlciB0byBhbiBlaW5hX3N0cmluZ3NoYXJlIGNvbnRhaW5p bmcgdGhlIHVzZXIgYWdlbnQgc3RyaW5nCiAgKi8KLWNvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19k ZWZhdWx0X3VzZXJfYWdlbnRfZ2V0KCkKK2NvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19kZWZhdWx0 X3VzZXJfYWdlbnRfZ2V0KHZvaWQpCiB7CiAgICAgV1RGOjpTdHJpbmcgdWFfdmVyc2lvbiA9IG1h a2VTdHJpbmcoU3RyaW5nOjpudW1iZXIoV0VCS0lUX1VTRVJfQUdFTlRfTUFKT1JfVkVSU0lPTiks ICcuJywgU3RyaW5nOjpudW1iZXIoV0VCS0lUX1VTRVJfQUdFTlRfTUlOT1JfVkVSU0lPTiksICcr Jyk7CiAgICAgV1RGOjpTdHJpbmcgc3RhdGljX3VhID0gbWFrZVN0cmluZygiTW96aWxsYS81LjAg KCIsIF9ld2tfc2V0dGluZ3Nfd2Via2l0X3BsYXRmb3JtX2dldCgpLCAiOyAiLCBfZXdrX3NldHRp bmdzX3dlYmtpdF9vc192ZXJzaW9uX2dldCgpLCAiKSBBcHBsZVdlYktpdC8iLCB1YV92ZXJzaW9u KSArIG1ha2VTdHJpbmcoIiAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNpb24vNS4wIFNhZmFyaS8i LCB1YV92ZXJzaW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0 dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAppbmRleCBiNzQ5 OGIyLi4zZTVjYTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRp bmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCkBAIC0zNyw5 ICszNyw5IEBAIGV4dGVybiAiQyIgewogICogQGJyaWVmIEdlbmVyYWwgcHVycG9zZSBzZXR0aW5n cywgbm90IHRpZWQgdG8gYW55IHZpZXcgb2JqZWN0LgogICovCiAKLUVBUEkgdWludDY0X3QgICAg ICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX2RlZmF1bHRfcXVvdGFfZ2V0KCk7CitFQVBJ IHVpbnQ2NF90ICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1b3Rh X2dldCh2b2lkKTsKIEVBUEkgdm9pZCAgICAgICAgICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFi YXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIgKnBhdGgpOwotRUFQSSBjb25zdCBjaGFyICAgICAgKmV3 a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9nZXQoKTsKK0VBUEkgY29uc3QgY2hhciAgICAg ICpld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfZ2V0KHZvaWQpOwogCiBFQVBJIEVpbmFf Qm9vbCAgICAgICAgZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfcGF0aF9zZXQoY29uc3QgY2hh ciAqcGF0aCk7CiBFQVBJIGNvbnN0IGNoYXIgICAgICAqZXdrX3NldHRpbmdzX2ljb25fZGF0YWJh c2VfcGF0aF9nZXQodm9pZCk7CkBAIC01Miw3ICs1Miw3IEBAIEVBUEkgRWluYV9Cb29sICAgICAg ICBld2tfc2V0dGluZ3NfY2FjaGVfZGlyZWN0b3J5X3BhdGhfc2V0KGNvbnN0IGNoYXIgKnBhdGgp OwogRUFQSSBjb25zdCBjaGFyICAgICAgKmV3a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0 aF9nZXQodm9pZCk7CiAKIEVBUEkgdm9pZCAgICAgICAgICAgICBld2tfc2V0dGluZ3NfcHJveHlf dXJpX3NldChjb25zdCBjaGFyKiBwcm94eSk7Ci1FQVBJIGNvbnN0IGNoYXIqICAgICAgZXdrX3Nl dHRpbmdzX3Byb3h5X3VyaV9nZXQoKTsKK0VBUEkgY29uc3QgY2hhciogICAgICBld2tfc2V0dGlu Z3NfcHJveHlfdXJpX2dldCh2b2lkKTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBkOGM2ODhkLi44YTNiMDRkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKQEAgLTQ0ODcsNyArNDQ4Nyw3IEBAIFdlYkNvcmU6OkZsb2F0UmVj dCBld2tfdmlld19wYWdlX3JlY3RfZ2V0KEV2YXNfT2JqZWN0ICpvKQogICoKICAqIEByZXR1cm4g ZGV2aWNlJ3MgZHBpIHZhbHVlLgogICovCi1pbnQgZXdrX3ZpZXdfZHBpX2dldCgpCitpbnQgZXdr X3ZpZXdfZHBpX2dldCh2b2lkKQogewogI2lmZGVmIEhBVkVfRUNPUkVfWAogICAgICByZXR1cm4g ZWNvcmVfeF9kcGlfZ2V0KCk7Cg==