56819 2011-03-22 02:24:55 -0700 [EFL] Change return values with better one in ewk_setting's functions 2011-03-22 11:39:43 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim abarth commit-queue eric kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 371299 0 gyuyoung.kim 2011-03-22 02:24:55 -0700 In ewk_settings_cache_directory_path_set_xxx, they return false value when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX. 371303 1 86447 gyuyoung.kim 2011-03-22 02:33:03 -0700 Created attachment 86447 Proposed Patch 371304 2 webkit.review.bot 2011-03-22 02:35:12 -0700 Attachment 86447 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_settings.cpp:382: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 371305 3 86448 gyuyoung.kim 2011-03-22 02:40:14 -0700 Created attachment 86448 Proposed Patch Fix style error. 371399 4 86448 tonikitoo 2011-03-22 08:39:18 -0700 Comment on attachment 86448 Proposed Patch rs=me 371405 5 86448 commit-queue 2011-03-22 09:03:59 -0700 Comment on attachment 86448 Proposed Patch Clearing flags on attachment: 86448 Committed r81670: <http://trac.webkit.org/changeset/81670> 371406 6 commit-queue 2011-03-22 09:04:05 -0700 All reviewed patches have been landed. Closing bug. 371513 7 webkit.review.bot 2011-03-22 11:39:43 -0700 http://trac.webkit.org/changeset/81670 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html 86447 2011-03-22 02:33:03 -0700 2011-03-22 02:40:14 -0700 Proposed Patch patch-wrong-false.patch text/plain 1514 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1YmUxNmQ5Li5hYzA0NTE0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBDaGFuZ2UgcmV0dXJuIHZhbHVlcyB3aXRoIGJldHRlciBvbmUgaW4gZXdrX3Nl dHRpbmcncyBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU2ODE5CisKKyAgICAgICAgSW4gZXdrX3NldHRpbmdzX2NhY2hlX2RpcmVjdG9y eV9wYXRoX3NldF94eHgsIHRoZXkgcmV0dXJuIGZhbHNlIHZhbHVlCisgICAgICAgIHdoZW4gc291 cCBpcyBkaXNhYmxlZC4gSXQgaXMgYmV0dGVyIHRvIHVzZSBFSU5BX1NBRkVUWV9PTl9UUlVFX1JF VFVSTl9YWFguCisKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3 a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0aF9zZXQpOgorICAgICAgICAoZXdrX3NldHRp bmdzX2NhY2hlX2RpcmVjdG9yeV9wYXRoX2dldCk6CisKIDIwMTEtMDMtMTcgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IDNhZTUwM2EuLmJiYmE3 YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC0zNjEsNyArMzYx LDcgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0aF9zZXQoY29u c3QgY2hhciAqcGF0aCkKICAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZfZXdrX2Nh Y2hlX2RpcmVjdG9yeV9wYXRoLCBwYXRoKTsKICAgICByZXR1cm4gRUlOQV9UUlVFOwogI2Vsc2UK LSAgICByZXR1cm4gRUlOQV9GQUxTRTsKKyAgICBFSU5BX1NBRkVUWV9PTl9UUlVFX1JFVFVSTl9W QUwoMSwgRUlOQV9GQUxTRSk7CiAjZW5kaWYKIH0KIApAQCAtMzc5LDYgKzM3OSw2IEBAIGNvbnN0 IGNoYXIgKmV3a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0aF9nZXQoKQogI2lmIEVOQUJM RShPRkZMSU5FX1dFQl9BUFBMSUNBVElPTlMpCiAgICAgcmV0dXJuIF9ld2tfY2FjaGVfZGlyZWN0 b3J5X3BhdGg7CiAjZWxzZQotICAgIHJldHVybiAwOworICAgIEVJTkFfU0FGRVRZX09OX1RSVUVf UkVUVVJOX1ZBTCgxLCBOVUxMKTsKICNlbmRpZgogfQo= 86448 2011-03-22 02:40:14 -0700 2011-03-22 09:03:59 -0700 Proposed Patch patch-wrong-false.patch text/plain 1847 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1YmUxNmQ5Li5lODgwYzhiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBDaGFuZ2UgcmV0dXJuIHZhbHVlcyB3aXRoIGJldHRlciBvbmUgaW4gZXdrX3Nl dHRpbmcncyBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU2ODE5CisKKyAgICAgICAgSW4gZXdrX3NldHRpbmdzX2NhY2hlX2RpcmVjdG9y eV9wYXRoX3NldF94eHgsIHRoZXkgcmV0dXJuIGZhbHNlIHZhbHVlCisgICAgICAgIHdoZW4gc291 cCBpcyBkaXNhYmxlZC4gSXQgaXMgYmV0dGVyIHRvIHVzZSBFSU5BX1NBRkVUWV9PTl9UUlVFX1JF VFVSTl9YWFguCisKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3 a19zZXR0aW5nc19wcm94eV91cmlfZ2V0KToKKyAgICAgICAgKGV3a19zZXR0aW5nc19jYWNoZV9k aXJlY3RvcnlfcGF0aF9zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdzX2NhY2hlX2RpcmVjdG9y eV9wYXRoX2dldCk6CisKIDIwMTEtMDMtMTcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IDNhZTUwM2EuLmI0YmFkOGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC0zMjEsNyArMzIxLDcgQEAgY29uc3QgY2hhciog ZXdrX3NldHRpbmdzX3Byb3h5X3VyaV9nZXQoKQogICAgIFdURjo6U3RyaW5nIHByb3h5ID0gc291 cF91cmlfdG9fc3RyaW5nKHVyaSwgRUlOQV9GQUxTRSk7CiAgICAgcmV0dXJuIGVpbmFfc3RyaW5n c2hhcmVfYWRkKHByb3h5LnV0ZjgoKS5kYXRhKCkpOwogI2VsaWYgVVNFKENVUkwpCi0gICAgRUlO QV9TQUZFVFlfT05fVFJVRV9SRVRVUk5fVkFMKDEsIE5VTEwpOworICAgIEVJTkFfU0FGRVRZX09O X1RSVUVfUkVUVVJOX1ZBTCgxLCAwKTsKICNlbmRpZgogfQogCkBAIC0zNjEsNyArMzYxLDcgQEAg RWluYV9Cb29sIGV3a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0aF9zZXQoY29uc3QgY2hh ciAqcGF0aCkKICAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZfZXdrX2NhY2hlX2Rp cmVjdG9yeV9wYXRoLCBwYXRoKTsKICAgICByZXR1cm4gRUlOQV9UUlVFOwogI2Vsc2UKLSAgICBy ZXR1cm4gRUlOQV9GQUxTRTsKKyAgICBFSU5BX1NBRkVUWV9PTl9UUlVFX1JFVFVSTl9WQUwoMSwg RUlOQV9GQUxTRSk7CiAjZW5kaWYKIH0KIApAQCAtMzc5LDYgKzM3OSw2IEBAIGNvbnN0IGNoYXIg KmV3a19zZXR0aW5nc19jYWNoZV9kaXJlY3RvcnlfcGF0aF9nZXQoKQogI2lmIEVOQUJMRShPRkZM SU5FX1dFQl9BUFBMSUNBVElPTlMpCiAgICAgcmV0dXJuIF9ld2tfY2FjaGVfZGlyZWN0b3J5X3Bh dGg7CiAjZWxzZQotICAgIHJldHVybiAwOworICAgIEVJTkFfU0FGRVRZX09OX1RSVUVfUkVUVVJO X1ZBTCgxLCAwKTsKICNlbmRpZgogfQo=