5681 2005-11-09 08:24:17 -0800 font family management can be faster by avoiding NSString/autorelease 2005-11-29 09:22:07 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin oldest_to_newest 23856 0 darin 2005-11-09 08:24:17 -0800 23857 1 4644 darin 2005-11-09 08:25:02 -0800 Created attachment 4644 use CFString instead of NSString for a small speedup 23888 2 4644 eric 2005-11-09 12:18:22 -0800 Comment on attachment 4644 use CFString instead of NSString for a small speedup Looks fine. 4644 2005-11-09 08:25:02 -0800 2005-11-09 12:18:22 -0800 use CFString instead of NSString for a small speedup FontFamilyAutoreleasePatch.txt text/plain 3108 darin SW5kZXg6IFdlYkNvcmUva3dxL0tXUUZvbnRGYW1pbHkuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv Y3ZzL3Jvb3QvV2ViQ29yZS9rd3EvS1dRRm9udEZhbWlseS5oLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjYKZGlmZiAtcCAtdSAtcjEuNiBXZWJDb3JlL2t3cS9LV1FGb250RmFtaWx5LmgKLS0tIFdl YkNvcmUva3dxL0tXUUZvbnRGYW1pbHkuaAkzIE9jdCAyMDA1IDIxOjEzOjAzIC0wMDAwCTEuNgor KysgV2ViQ29yZS9rd3EvS1dRRm9udEZhbWlseS5oCTI1IE9jdCAyMDA1IDE1OjI5OjE4IC0wMDAw CkBAIC02OSw3ICs2OSw3IEBAIHByaXZhdGU6CiAgICAgRE9NOjpBdG9taWNTdHJpbmcgX2ZhbWls eTsKICAgICBLV1FGb250RmFtaWx5ICpfbmV4dDsKICAgICBpbnQgX3JlZkNudDsKLSAgICBtdXRh YmxlIE5TU3RyaW5nICpfTlNGYW1pbHk7CisgICAgbXV0YWJsZSBDRlN0cmluZ1JlZiBfQ0ZGYW1p bHk7CiB9OwogCiAKSW5kZXg6IFdlYkNvcmUva3dxL0tXUUZvbnRGYW1pbHkubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva3dxL0tXUUZvbnRGYW1pbHkubW0sdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNgpkaWZmIC1wIC11IC1yMS42IFdlYkNvcmUva3dxL0tXUUZvbnRG YW1pbHkubW0KLS0tIFdlYkNvcmUva3dxL0tXUUZvbnRGYW1pbHkubW0JMyBPY3QgMjAwNSAyMTox MzowMyAtMDAwMAkxLjYKKysrIFdlYkNvcmUva3dxL0tXUUZvbnRGYW1pbHkubW0JMjUgT2N0IDIw MDUgMTU6Mjk6MTggLTAwMDAKQEAgLTMzLDcgKzMzLDcgQEAgdXNpbmcgRE9NOjpET01TdHJpbmdJ bXBsOwogS1dRRm9udEZhbWlseTo6S1dRRm9udEZhbWlseSgpCiAgICAgOiBfbmV4dCgwKQogICAg ICwgX3JlZkNudCgwKQotICAgICwgX05TRmFtaWx5KDApCisgICAgLCBfQ0ZGYW1pbHkoMCkKIHsK IH0KIApAQCAtNDEsNyArNDEsNyBAQCBLV1FGb250RmFtaWx5OjpLV1FGb250RmFtaWx5KGNvbnN0 IEtXUUZvCiAgICAgOiBfZmFtaWx5KG90aGVyLl9mYW1pbHkpCiAgICAgLCBfbmV4dChvdGhlci5f bmV4dCkKICAgICAsIF9yZWZDbnQoMCkKLSAgICAsIF9OU0ZhbWlseShvdGhlci5fTlNGYW1pbHkp CisgICAgLCBfQ0ZGYW1pbHkob3RoZXIuX0NGRmFtaWx5KQogewogICAgIGlmIChfbmV4dCkKICAg ICAgICAgX25leHQtPnJlZigpOwpAQCAtNTUsNyArNTUsNyBAQCBLV1FGb250RmFtaWx5JiBLV1FG b250RmFtaWx5OjpvcGVyYXRvcj0oCiAgICAgICAgIF9uZXh0LT5kZXJlZigpOwogICAgIF9mYW1p bHkgPSBvdGhlci5fZmFtaWx5OwogICAgIF9uZXh0ID0gb3RoZXIuX25leHQ7Ci0gICAgX05TRmFt aWx5ID0gb3RoZXIuX05TRmFtaWx5OworICAgIF9DRkZhbWlseSA9IG90aGVyLl9DRkZhbWlseTsK ICAgICByZXR1cm4gKnRoaXM7CiB9CiAKQEAgLTc0LDI5ICs3NCwzMCBAQCBjb25zdCBDRkRpY3Rp b25hcnlLZXlDYWxsQmFja3MgQ0ZEaWN0aW9uCiAKIE5TU3RyaW5nICpLV1FGb250RmFtaWx5Ojpn ZXROU0ZhbWlseSgpIGNvbnN0CiB7Ci0gICAgaWYgKCFfTlNGYW1pbHkpIHsKKyAgICBpZiAoIV9D RkZhbWlseSkgewogICAgICAgICBpZiAoX2ZhbWlseS5pc0VtcHR5KCkpCi0gICAgICAgICAgICBf TlNGYW1pbHkgPSBAIiI7CisgICAgICAgICAgICBfQ0ZGYW1pbHkgPSBDRlNUUigiIik7CiAgICAg ICAgIGVsc2UgewogICAgICAgICAgICAgLy8gVXNlIGFuIGltbXV0YWJsZSBjb3B5IG9mIHRoZSBu YW1lLCBidXQga2VlcCBhIHNldCBvZgogICAgICAgICAgICAgLy8gYWxsIGZhbWlseSBuYW1lcyBz byB3ZSBkb24ndCBlbmQgdXAgd2l0aCB0b28gbWFueSBvYmplY3RzLgogICAgICAgICAgICAgc3Rh dGljIENGTXV0YWJsZURpY3Rpb25hcnlSZWYgZmFtaWxpZXM7CiAgICAgICAgICAgICBpZiAoZmFt aWxpZXMgPT0gTlVMTCkKICAgICAgICAgICAgICAgICBmYW1pbGllcyA9IENGRGljdGlvbmFyeUNy ZWF0ZU11dGFibGUoTlVMTCwgMCwgJkNGRGljdGlvbmFyeUZhbWlseUtleUNhbGxCYWNrcywgJmtD RlR5cGVEaWN0aW9uYXJ5VmFsdWVDYWxsQmFja3MpOwotICAgICAgICAgICAgX05TRmFtaWx5ID0g KE5TU3RyaW5nICopQ0ZEaWN0aW9uYXJ5R2V0VmFsdWUoZmFtaWxpZXMsIF9mYW1pbHkuaW1wbCgp KTsKLSAgICAgICAgICAgIGlmICghX05TRmFtaWx5KSB7Ci0gICAgICAgICAgICAgICAgX05TRmFt aWx5ID0gW05TU3RyaW5nIHN0cmluZ1dpdGhDaGFyYWN0ZXJzOihjb25zdCB1bmljaGFyICopX2Zh bWlseS51bmljb2RlKCkgbGVuZ3RoOl9mYW1pbHkubGVuZ3RoKCldOwotICAgICAgICAgICAgICAg IENGRGljdGlvbmFyeVNldFZhbHVlKGZhbWlsaWVzLCBfZmFtaWx5LmltcGwoKSwgX05TRmFtaWx5 KTsKKyAgICAgICAgICAgIF9DRkZhbWlseSA9IChDRlN0cmluZ1JlZilDRkRpY3Rpb25hcnlHZXRW YWx1ZShmYW1pbGllcywgX2ZhbWlseS5pbXBsKCkpOworICAgICAgICAgICAgaWYgKCFfQ0ZGYW1p bHkpIHsKKyAgICAgICAgICAgICAgICBfQ0ZGYW1pbHkgPSBDRlN0cmluZ0NyZWF0ZVdpdGhDaGFy YWN0ZXJzKDAsIChjb25zdCBVbmlDaGFyICopX2ZhbWlseS51bmljb2RlKCksIF9mYW1pbHkubGVu Z3RoKCkpOworICAgICAgICAgICAgICAgIENGRGljdGlvbmFyeVNldFZhbHVlKGZhbWlsaWVzLCBf ZmFtaWx5LmltcGwoKSwgX0NGRmFtaWx5KTsKKyAgICAgICAgICAgICAgICBDRlJlbGVhc2UoX0NG RmFtaWx5KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KLSAgICByZXR1cm4gX05T RmFtaWx5OworICAgIHJldHVybiAoTlNTdHJpbmcgKilfQ0ZGYW1pbHk7CiB9CiAKIHZvaWQgS1dR Rm9udEZhbWlseTo6c2V0RmFtaWx5KGNvbnN0IEF0b21pY1N0cmluZyAmZmFtaWx5KQogewogICAg IF9mYW1pbHkgPSBmYW1pbHk7Ci0gICAgX05TRmFtaWx5ID0gbmlsOworICAgIF9DRkZhbWlseSA9 IDA7CiB9CiAKIGJvb2wgS1dRRm9udEZhbWlseTo6b3BlcmF0b3I9PShjb25zdCBLV1FGb250RmFt aWx5ICZjb21wYXJlRm9udEZhbWlseSkgY29uc3QK