56801 2011-03-21 22:17:42 -0700 REGRESSION(r81597): Change results in lots of unexpected flaky on the dashboard. (Requested by pfeldman on #webkit). 2011-03-21 22:30:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 56760 1 webkit.review.bot webkit.review.bot dpranke mihaip ojan pfeldman tony oldest_to_newest 371205 0 webkit.review.bot 2011-03-21 22:17:42 -0700 http://trac.webkit.org/changeset/81597 broke the build: Change results in lots of unexpected flaky on the dashboard. (Requested by pfeldman on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 371206 1 86420 webkit.review.bot 2011-03-21 22:18:12 -0700 Created attachment 86420 ROLLOUT of r81597 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 371207 2 86420 pfeldman 2011-03-21 22:21:43 -0700 Comment on attachment 86420 ROLLOUT of r81597 Clearing flags on attachment: 86420 Committed r81645: <http://trac.webkit.org/changeset/81645> 371208 3 pfeldman 2011-03-21 22:21:50 -0700 All reviewed patches have been landed. Closing bug. 371213 4 dpranke 2011-03-21 22:27:30 -0700 If this test made a bunch of tests become suddenly flaky, then that means that they were sensitive to the order they were being run in. I think the right thing to do is probably to mark them as flaky in the expectations and then fix them, rather than roll this out. (Of course, you've already rolled this out, so I suppose I mean that we should re-land this and then triage and mark as flaky ...). There isn't really any good way to figure out what the flakiness will be without landing this and getting some runs in. Thoughts? 371216 5 dpranke 2011-03-21 22:30:05 -0700 Per comment on bug 56760, Mihai suggests that this change actually made the http tests run backwards on the chromium linux bots. That would be an actual bad thing deserving of roll-out, rather than just flakiness. 86420 2011-03-21 22:18:12 -0700 2011-03-21 22:21:43 -0700 ROLLOUT of r81597 bug-56801-20110322051614.patch text/plain 4350 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODE2NDQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkYmY5YWNlMzg4YjllMDJiM2RjOTJkZTY4YmY0OTYwZjY0 MTJlZjFlLi5iMTUzYmQ4ZDIyZDg3NWU0OGFmMTYyOGY1YTg0YTRjOTJhNDYxYTRjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDMtMjEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4MTU5Ny4KKyAgICAgICAgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvODE1OTcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2ODAxCisKKyAgICAgICAgQ2hhbmdlIHJlc3Vs dHMgaW4gbG90cyBvZiB1bmV4cGVjdGVkIGZsYWt5IG9uIHRoZSBkYXNoYm9hcmQuCisgICAgICAg IChSZXF1ZXN0ZWQgYnkgcGZlbGRtYW4gb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3J1bm5lci5weToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0 dGVzdC5weToKKwogMjAxMS0wMy0yMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIEZpeCBmYWlsaW5nIHRlc3RzIG9uIHRoZSBXZWJLaXQyIGJvdHMuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0 X3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9w YWNrYWdlL3Rlc3RfcnVubmVyLnB5CmluZGV4IDU2MzkwMDhjNGU0ZTFiOGNiMDM5YmYwNWZlNmU3 NWZkYzA0YzQ5YWMuLjA4NTlmNjhlZTZhZmIyOTYyMjRjZDhmMzA1NjQxMmJiZjJmYjZhZTMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5CkBAIC00OTgsNiArNDk4LDcgQEAgY2xh c3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICAjIEtlZXAgdGhlIHRlc3RzIGluIGFscGhh YmV0aWNhbCBvcmRlci4KICAgICAgICAgICAgICAgICAjIEZJWE1FOiBSZW1vdmUgb25jZSB0ZXN0 cyBhcmUgZml4ZWQgc28gdGhleSBjYW4gYmUgcnVuIGluIGFueQogICAgICAgICAgICAgICAgICMg b3JkZXIuCisgICAgICAgICAgICAgICAgdGVzdF9saXN0LnJldmVyc2UoKQogICAgICAgICAgICAg ICAgIHRlc3RfbGlzdF90dXBsZSA9IChkaXJlY3RvcnksIHRlc3RfbGlzdCkKICAgICAgICAgICAg ICAgICB0ZXN0X2xpc3RzLmFwcGVuZCh0ZXN0X2xpc3RfdHVwbGUpCiAgICAgICAgICAgICB0ZXN0 X2xpc3RzLnNvcnQobGFtYmRhIGEsIGI6IGNtcChsZW4oYlsxXSksIGxlbihhWzFdKSkpCkBAIC01 MDYsNiArNTA3LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgIyBidXQgZWFjaCBodHRw IHRlc3QgdGFrZXMgYSB2ZXJ5IGxvbmcgdGltZSB0byBydW4sIHNvIHNvcnRpbmcgYnkgdGhlCiAg ICAgICAgICMgbnVtYmVyIG9mIHRlc3RzIGRvZXNuJ3QgYWNjdXJhdGVseSBjYXB0dXJlIGhvdyBs b25nIHRoZXkgdGFrZSB0byBydW4uCiAgICAgICAgIGlmIHRlc3RzX3RvX2h0dHBfbG9jazoKKyAg ICAgICAgICAgIHRlc3RzX3RvX2h0dHBfbG9jay5yZXZlcnNlKCkKICAgICAgICAgICAgIHRlc3Rf bGlzdHMuaW5zZXJ0KDAsICgidGVzdHNfdG9faHR0cF9sb2NrIiwgdGVzdHNfdG9faHR0cF9sb2Nr KSkKIAogICAgICAgICByZXR1cm4gdGVzdF9saXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CmluZGV4IDZkYWQzMzI1MTU5NTNiMDIxMmU4 ZWM2NWRkZDY3YjY2MWUzYmY4NmIuLjRhZWI4YmJlYjY5MTRhMmFiMGVhYzRjOGJjZDc2YWExMmY0 YWM4OWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvdGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3Rlc3QucHkKQEAgLTEyOCw3ICsxMjgsNiBAQCBkZWYgdW5pdF90ZXN0X2xpc3QoKToKICAgICAg ICAgICAgICAgYWN0dWFsX2NoZWNrc3VtPSd0ZXh0LWltYWdlLWNoZWNrc3VtX2ZhaWwtY2hlY2tz dW0nKQogICAgIHRlc3RzLmFkZCgnZmFpbHVyZXMvdW5leHBlY3RlZC90aW1lb3V0Lmh0bWwnLCB0 aW1lb3V0PVRydWUpCiAgICAgdGVzdHMuYWRkKCdodHRwL3Rlc3RzL3Bhc3Nlcy90ZXh0Lmh0bWwn KQotICAgIHRlc3RzLmFkZCgnaHR0cC90ZXN0cy9wYXNzZXMvaW1hZ2UuaHRtbCcpCiAgICAgdGVz dHMuYWRkKCdodHRwL3Rlc3RzL3NzbC90ZXh0Lmh0bWwnKQogICAgIHRlc3RzLmFkZCgncGFzc2Vz L2Vycm9yLmh0bWwnLCBlcnJvcj0nc3R1ZmYgZ29pbmcgdG8gc3RkZXJyJykKICAgICB0ZXN0cy5h ZGQoJ3Bhc3Nlcy9pbWFnZS5odG1sJykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5Cmlu ZGV4IGZmYjliYWY5YmE2MGY2NjI0Njc3OGQ2OTIwNjg5ZTU5MDExOTY4MDUuLmY3NTNmMjMxZGU2 Y2JkYzJjZmJhZjNkNzk0OWRmYTI2MjlmZTJlMDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0 dGVzdC5weQpAQCAtNDcwLDIyICs0NzAsNiBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0 Q2FzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0ZXN0c19p bmNsdWRlZD1UcnVlKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVzZXIub3BlbmVkX3VybHMs IFsnL3RtcC9mb28vcmVzdWx0cy5odG1sJ10pCiAKLSAgICBkZWYgdGVzdF9ydW5fb3JkZXIoc2Vs Zik6Ci0gICAgICAgICMgVGhpcyB0ZXN0cyB0aGF0IHdlIHJ1biB0aGUgdGVzdHMgaW4gYXNjZW5k aW5nIGFscGhhYmV0aWNhbCBvcmRlcgotICAgICAgICAjIHBlciBkaXJlY3RvcnkuIFdlIGhhdmUg dG8gY2hlY2sgYm90aCB0aGUgaW5saW5lIGFuZCB0aHJlYWRlZCBwYXRocwotICAgICAgICAjIGFz IHdlbGwgYXMgaHR0cCB0ZXN0cywgd2hpY2ggYXJlIHNoYXJkZWQgc2VwYXJhdGVseS4KLSAgICAg ICAgdGVzdHNfcnVuID0gZ2V0X3Rlc3RzX3J1bihbJ3Bhc3NlcyddLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHRlc3RzX2luY2x1ZGVkPVRydWUsIGZsYXR0ZW5fYmF0Y2hlcz1U cnVlKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscyh0ZXN0c19ydW4sIHNvcnRlZCh0ZXN0c19y dW4pKQotCi0gICAgICAgIHRlc3RzX3J1biA9IGdldF90ZXN0c19ydW4oWyctLXdvcmtlci1tb2Rl bCcsICd0aHJlYWRzJywgJ3Bhc3NlcyddLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHRlc3RzX2luY2x1ZGVkPVRydWUsIGZsYXR0ZW5fYmF0Y2hlcz1UcnVlKQotICAgICAgICBz ZWxmLmFzc2VydEVxdWFscyh0ZXN0c19ydW4sIHNvcnRlZCh0ZXN0c19ydW4pKQotCi0gICAgICAg IHRlc3RzX3J1biA9IGdldF90ZXN0c19ydW4oWyctLXdvcmtlci1tb2RlbCcsICdpbmxpbmUnLCAn aHR0cC90ZXN0cy9wYXNzZXMnXSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0 ZXN0c19pbmNsdWRlZD1UcnVlLCBmbGF0dGVuX2JhdGNoZXM9VHJ1ZSkKLSAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHModGVzdHNfcnVuLCBzb3J0ZWQodGVzdHNfcnVuKSkKLQogICAgIGRlZiB0ZXN0 X3RvbGVyYW5jZShzZWxmKToKICAgICAgICAgY2xhc3MgSW1hZ2VEaWZmVGVzdFBvcnQoVGVzdFBv cnQpOgogICAgICAgICAgICAgZGVmIGRpZmZfaW1hZ2Uoc2VsZiwgZXhwZWN0ZWRfY29udGVudHMs IGFjdHVhbF9jb250ZW50cywK