5680 2005-11-09 08:21:38 -0800 containsOnlyWhitespace does not need to be a virtual function 2019-02-06 09:04:14 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin cdumez oldest_to_newest 23854 0 darin 2005-11-09 08:21:38 -0800 23855 1 4643 darin 2005-11-09 08:22:10 -0800 Created attachment 4643 remove virtual containsOnlyWhitespace from DOM::NodeImpl 23889 2 4643 eric 2005-11-09 12:20:40 -0800 Comment on attachment 4643 remove virtual containsOnlyWhitespace from DOM::NodeImpl This part of your patch is not safe: + !curr->element() || !static_cast<TextImpl *>(curr->element())- It may be possible for things other than TextNodes to create RenderText objects (at least in an SVG-enabled world). 23891 3 4643 darin 2005-11-09 13:41:07 -0800 Comment on attachment 4643 remove virtual containsOnlyWhitespace from DOM::NodeImpl Good point. I thought there was a check of isTextNode on that line. I'll fix it. 26152 4 5145 darin 2005-12-18 15:00:18 -0800 Created attachment 5145 adds call to isTextNode missing from earlier patch 26155 5 5145 ggaren 2005-12-18 15:15:55 -0800 Comment on attachment 5145 adds call to isTextNode missing from earlier patch r=me 1503128 6 lforschler 2019-02-06 09:04:14 -0800 Mass moving XML DOM bugs to the "DOM" Component. 4643 2005-11-09 08:22:10 -0800 2005-12-18 15:00:18 -0800 remove virtual containsOnlyWhitespace from DOM::NodeImpl NonVirtualContainsOnlyWhitespacePatch.txt text/plain 2941 darin SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJh bWVzLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44MgpkaWZmIC1wIC11IC1yMS44MiBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcAotLS0gV2ViQ29yZS9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjUgT2N0IDIwMDUgMDM6NDU6MzEgLTAwMDAJMS44 MgorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjUgT2N0IDIw MDUgMTU6Mjk6MTEgLTAwMDAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJodG1sL2h0bWx0 b2tlbml6ZXIuaCIKICNpbmNsdWRlICJ4bWwvZG9tMl9ldmVudHNpbXBsLmgiCiAjaW5jbHVkZSAi eG1sL2RvbV9kb2NpbXBsLmgiCisjaW5jbHVkZSAieG1sL2RvbV90ZXh0aW1wbC5oIgogI2luY2x1 ZGUgInhtbC9FdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAia2h0bWx2aWV3LmgiCiAjaW5jbHVkZSAi a2h0bWxfcGFydC5oIgpAQCAtOTE5LDcgKzkyMCw3IEBAIHZvaWQgUmVuZGVyUGFydE9iamVjdDo6 dXBkYXRlV2lkZ2V0KCkKICAgICAgIG1faGFzRmFsbGJhY2tDb250ZW50ID0gZmFsc2U7CiAgICAg ICBmb3IgKE5vZGVJbXBsICpjaGlsZCA9IG8tPmZpcnN0Q2hpbGQoKTsgY2hpbGQgJiYgIW1faGFz RmFsbGJhY2tDb250ZW50OyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAg ICAgaWYgKCghY2hpbGQtPmlzVGV4dE5vZGUoKSAmJiAhY2hpbGQtPmhhc1RhZ05hbWUoZW1iZWRU YWcpICYmICFjaGlsZC0+aGFzVGFnTmFtZShwYXJhbVRhZykpIHx8IC8vIERpc2NvdW50IDxlbWJl ZD4gYW5kIDxwYXJhbT4KLSAgICAgICAgICAgICAgKGNoaWxkLT5pc1RleHROb2RlKCkgJiYgIWNo aWxkLT5jb250YWluc09ubHlXaGl0ZXNwYWNlKCkpKQorICAgICAgICAgICAgICAoY2hpbGQtPmlz VGV4dE5vZGUoKSAmJiAhc3RhdGljX2Nhc3Q8VGV4dEltcGwgKj4oY2hpbGQpLT5jb250YWluc09u bHlXaGl0ZXNwYWNlKCkpKQogICAgICAgICAgICAgICBtX2hhc0ZhbGxiYWNrQ29udGVudCA9IHRy dWU7CiAgICAgICB9CiAgICAgICBib29sIHN1Y2Nlc3MgPSBwYXJ0LT5yZXF1ZXN0T2JqZWN0KCB0 aGlzLCB1cmwsIHNlcnZpY2VUeXBlLCBwYXJhbU5hbWVzLCBwYXJhbVZhbHVlcyApOwpJbmRleDog V2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2xpbmUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfbGluZS5jcHAsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuNTUKZGlmZiAtcCAtdSAtcjEuNTUgV2ViQ29yZS9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2xpbmUuY3BwCi0tLSBXZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5k ZXJfbGluZS5jcHAJMTggT2N0IDIwMDUgMDM6MTU6MzEgLTAwMDAJMS41NQorKysgV2ViQ29yZS9r aHRtbC9yZW5kZXJpbmcvcmVuZGVyX2xpbmUuY3BwCTI1IE9jdCAyMDA1IDE1OjI5OjEyIC0wMDAw CkBAIC05MTcsNyArOTE3LDcgQEAgc3RhdGljIGJvb2wgc2hvdWxkRHJhd0RlY29yYXRpb24oUmVu ZGVyTwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAoY3Vy ci0+aXNUZXh0KCkgJiYgIWN1cnItPmlzQlIoKSAmJiAoY3Vyci0+c3R5bGUoKS0+d2hpdGVTcGFj ZSgpID09IFBSRSB8fAotICAgICAgICAgICAgICAgICAhY3Vyci0+ZWxlbWVudCgpIHx8ICFjdXJy LT5lbGVtZW50KCktPmNvbnRhaW5zT25seVdoaXRlc3BhY2UoKSkpIHsKKyAgICAgICAgICAgICAg ICAgIWN1cnItPmVsZW1lbnQoKSB8fCAhc3RhdGljX2Nhc3Q8VGV4dEltcGwgKj4oY3Vyci0+ZWxl bWVudCgpKS0+Y29udGFpbnNPbmx5V2hpdGVzcGFjZSgpKSkgewogICAgICAgICAgICAgc2hvdWxk RHJhdyA9IHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQkKSW5kZXg6IFdlYkNv cmUva2h0bWwveG1sL2RvbV9ub2RlaW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9v dC9XZWJDb3JlL2todG1sL3htbC9kb21fbm9kZWltcGwuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4xMDcKZGlmZiAtcCAtdSAtcjEuMTA3IFdlYkNvcmUva2h0bWwveG1sL2RvbV9ub2RlaW1wbC5o Ci0tLSBXZWJDb3JlL2todG1sL3htbC9kb21fbm9kZWltcGwuaAkyNSBPY3QgMjAwNSAwMDowNzo0 NyAtMDAwMAkxLjEwNworKysgV2ViQ29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmgJMjUgT2N0 IDIwMDUgMTU6Mjk6MTggLTAwMDAKQEAgLTEyOSw4ICsxMjksNiBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCBib29sIGlzTWFsZm9ybWVkKCkgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIHZv aWQgc2V0TWFsZm9ybWVkKGJvb2wgbWFsZm9ybWVkKSB7fTsKICAgICAKLSAgICB2aXJ0dWFsIGJv b2wgY29udGFpbnNPbmx5V2hpdGVzcGFjZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAg CiAgICAgLy8gaGVscGVyIGZ1bmN0aW9ucyBub3QgYmVpbmcgcGFydCBvZiB0aGUgRE9NCiAgICAg Ly8gQXR0ZW50aW9uOiB0aGV5IGFzc3VtZSB0aGF0IHRoZSBjYWxsZXIgZGlkIHRoZSBjb25zaXN0 ZW5jeSBjaGVja2luZyEKICAgICB2b2lkIHNldFByZXZpb3VzU2libGluZyhOb2RlSW1wbCAqcHJl dmlvdXMpIHsgbV9wcmV2aW91cyA9IHByZXZpb3VzOyB9Cg== 5145 2005-12-18 15:00:18 -0800 2005-12-18 15:15:55 -0800 adds call to isTextNode missing from earlier patch NonVirtualContainsOnlyWhitespacePatch.txt text/plain 2974 darin SW5kZXg6IFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9mcmFtZXMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJh bWVzLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44MgpkaWZmIC1wIC11IC1yMS44MiBXZWJD b3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfZnJhbWVzLmNwcAotLS0gV2ViQ29yZS9raHRtbC9y ZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjUgT2N0IDIwMDUgMDM6NDU6MzEgLTAwMDAJMS44 MgorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ZyYW1lcy5jcHAJMjUgT2N0IDIw MDUgMTU6Mjk6MTEgLTAwMDAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJodG1sL2h0bWx0 b2tlbml6ZXIuaCIKICNpbmNsdWRlICJ4bWwvZG9tMl9ldmVudHNpbXBsLmgiCiAjaW5jbHVkZSAi eG1sL2RvbV9kb2NpbXBsLmgiCisjaW5jbHVkZSAieG1sL2RvbV90ZXh0aW1wbC5oIgogI2luY2x1 ZGUgInhtbC9FdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAia2h0bWx2aWV3LmgiCiAjaW5jbHVkZSAi a2h0bWxfcGFydC5oIgpAQCAtOTE5LDcgKzkyMCw3IEBAIHZvaWQgUmVuZGVyUGFydE9iamVjdDo6 dXBkYXRlV2lkZ2V0KCkKICAgICAgIG1faGFzRmFsbGJhY2tDb250ZW50ID0gZmFsc2U7CiAgICAg ICBmb3IgKE5vZGVJbXBsICpjaGlsZCA9IG8tPmZpcnN0Q2hpbGQoKTsgY2hpbGQgJiYgIW1faGFz RmFsbGJhY2tDb250ZW50OyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAg ICAgaWYgKCghY2hpbGQtPmlzVGV4dE5vZGUoKSAmJiAhY2hpbGQtPmhhc1RhZ05hbWUoZW1iZWRU YWcpICYmICFjaGlsZC0+aGFzVGFnTmFtZShwYXJhbVRhZykpIHx8IC8vIERpc2NvdW50IDxlbWJl ZD4gYW5kIDxwYXJhbT4KLSAgICAgICAgICAgICAgKGNoaWxkLT5pc1RleHROb2RlKCkgJiYgIWNo aWxkLT5jb250YWluc09ubHlXaGl0ZXNwYWNlKCkpKQorICAgICAgICAgICAgICAoY2hpbGQtPmlz VGV4dE5vZGUoKSAmJiAhc3RhdGljX2Nhc3Q8VGV4dEltcGwqPihjaGlsZCktPmNvbnRhaW5zT25s eVdoaXRlc3BhY2UoKSkpCiAgICAgICAgICAgICAgIG1faGFzRmFsbGJhY2tDb250ZW50ID0gdHJ1 ZTsKICAgICAgIH0KICAgICAgIGJvb2wgc3VjY2VzcyA9IHBhcnQtPnJlcXVlc3RPYmplY3QoIHRo aXMsIHVybCwgc2VydmljZVR5cGUsIHBhcmFtTmFtZXMsIHBhcmFtVmFsdWVzICk7CkluZGV4OiBX ZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfbGluZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9saW5lLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS41NQpkaWZmIC1wIC11IC1yMS41NSBXZWJDb3JlL2todG1sL3Jl bmRlcmluZy9yZW5kZXJfbGluZS5jcHAKLS0tIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRl cl9saW5lLmNwcAkxOCBPY3QgMjAwNSAwMzoxNTozMSAtMDAwMAkxLjU1CisrKyBXZWJDb3JlL2to dG1sL3JlbmRlcmluZy9yZW5kZXJfbGluZS5jcHAJMjUgT2N0IDIwMDUgMTU6Mjk6MTIgLTAwMDAK QEAgLTkxNyw3ICs5MTcsNyBAQCBzdGF0aWMgYm9vbCBzaG91bGREcmF3RGVjb3JhdGlvbihSZW5k ZXJPCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBlbHNlIGlmIChjdXJy LT5pc1RleHQoKSAmJiAhY3Vyci0+aXNCUigpICYmIChjdXJyLT5zdHlsZSgpLT53aGl0ZVNwYWNl KCkgPT0gUFJFIHx8Ci0gICAgICAgICAgICAgICAgICFjdXJyLT5lbGVtZW50KCkgfHwgIWN1cnIt PmVsZW1lbnQoKS0+Y29udGFpbnNPbmx5V2hpdGVzcGFjZSgpKSkgeworICAgICAgICAgICAgICAg ICAhY3Vyci0+ZWxlbWVudCgpIHx8ICEoY3Vyci0+ZWxlbWVudCgpLT5pc1RleHROb2RlKCkgJiYg c3RhdGljX2Nhc3Q8VGV4dEltcGwqPihjdXJyLT5lbGVtZW50KCkpLT5jb250YWluc09ubHlXaGl0 ZXNwYWNlKCkpKSkgewogICAgICAgICAgICAgc2hvdWxkRHJhdyA9IHRydWU7CiAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgfQkKSW5kZXg6IFdlYkNvcmUva2h0bWwveG1sL2RvbV9ub2RlaW1w bC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3htbC9kb21f bm9kZWltcGwuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMDcKZGlmZiAtcCAtdSAtcjEuMTA3 IFdlYkNvcmUva2h0bWwveG1sL2RvbV9ub2RlaW1wbC5oCi0tLSBXZWJDb3JlL2todG1sL3htbC9k b21fbm9kZWltcGwuaAkyNSBPY3QgMjAwNSAwMDowNzo0NyAtMDAwMAkxLjEwNworKysgV2ViQ29y ZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmgJMjUgT2N0IDIwMDUgMTU6Mjk6MTggLTAwMDAKQEAg LTEyOSw4ICsxMjksNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGlzTWFsZm9ybWVkKCkg eyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0TWFsZm9ybWVkKGJvb2wgbWFs Zm9ybWVkKSB7fTsKICAgICAKLSAgICB2aXJ0dWFsIGJvb2wgY29udGFpbnNPbmx5V2hpdGVzcGFj ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgCiAgICAgLy8gaGVscGVyIGZ1bmN0aW9u cyBub3QgYmVpbmcgcGFydCBvZiB0aGUgRE9NCiAgICAgLy8gQXR0ZW50aW9uOiB0aGV5IGFzc3Vt ZSB0aGF0IHRoZSBjYWxsZXIgZGlkIHRoZSBjb25zaXN0ZW5jeSBjaGVja2luZyEKICAgICB2b2lk IHNldFByZXZpb3VzU2libGluZyhOb2RlSW1wbCAqcHJldmlvdXMpIHsgbV9wcmV2aW91cyA9IHBy ZXZpb3VzOyB9Cg==