56798 2011-03-21 19:45:17 -0700 add autorelease pools to WebKit2 control flow 2011-03-22 22:05:21 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 slewis webkit-unassigned ggaren webkit.review.bot oldest_to_newest 371158 0 slewis 2011-03-21 19:45:17 -0700 wrap autorelease pools around calls that can have pathological memory growth on Membuster 371200 1 86418 slewis 2011-03-21 22:10:35 -0700 Created attachment 86418 patch 371201 2 webkit.review.bot 2011-03-21 22:13:36 -0700 Attachment 86418 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/mac/RunLoopMac.mm:36: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:37: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:38: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:106: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/Platform/mac/RunLoopMac.mm:107: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 371872 3 86418 simon.fraser 2011-03-22 17:47:42 -0700 Comment on attachment 86418 patch r=me minus the tabs. 371962 4 ggaren 2011-03-22 22:05:21 -0700 http://trac.webkit.org/changeset/81734 86418 2011-03-21 22:10:35 -0700 2011-03-22 17:47:42 -0700 patch AddAutoreleasePools text/plain 3009 slewis SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjM2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMjEgIFN0ZXBoYW5p ZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU2Nzk4CisgICAgICAgIFdyYXAgYXV0b3JlbGVhc2UgcG9vbHMgYXJvdW5kIGNhbGxzIHRo YXQgY2FuIGhhdmUgcGF0aG9sb2dpY2FsIG1lbW9yeSBncm93dGggb24gTWVtYnVzdGVyLgorCisg ICAgICAgICogUGxhdGZvcm0vbWFjL1J1bkxvb3BNYWMubW06CisgICAgICAgIChSdW5Mb29wOjpw ZXJmb3JtV29yayk6CisgICAgICAgIChSdW5Mb29wOjpUaW1lckJhc2U6OnRpbWVyRmlyZWQpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5tbToKKyAg ICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlSG9zdE1hYzo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2Vz UnVuTG9vcE9ic2VydmVyQ2FsbGJhY2spOgorCiAyMDExLTAzLTIxICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggTWFjIHJlbGVhc2UgYnVpbGRzIGFmdGVy IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Njc4MwpJbmRleDogU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1J1bkxvb3BNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1J1bkxvb3BNYWMubW0JKHJldmlzaW9uIDgxNTQ3KQor KysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1J1bkxvb3BNYWMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTMwLDcgKzMwLDE0IEBACiAKIHZvaWQgUnVuTG9vcDo6cGVyZm9ybVdvcmsodm9pZCog Y29udGV4dCkKIHsKLSAgICBzdGF0aWNfY2FzdDxSdW5Mb29wKj4oY29udGV4dCktPnBlcmZvcm1X b3JrKCk7CisgICAgLy8gV3JhcCBtYWluIHRocmVhZCBpbiBhbiBBdXRvcmVsZWFzZSBwb29sLiAg U2VuZGluZyBtZXNzYWdlcyBjYW4gY2FsbCAKKyAgICAvLyBpbnRvIG9iamMgY29kZSBhbmQgYWNj dW11bGF0ZSBtZW1vcnkuICAKKyAgICBpZiAoY3VycmVudCgpID09IG1haW4oKSkgeworICAgIAlO U0F1dG9yZWxlYXNlUG9vbCAqcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRd OworICAgIAlzdGF0aWNfY2FzdDxSdW5Mb29wKj4oY29udGV4dCktPnBlcmZvcm1Xb3JrKCk7Cisg ICAgCVtwb29sIGRyYWluXTsKKyAgICB9IGVsc2UKKyAgICAgICAgc3RhdGljX2Nhc3Q8UnVuTG9v cCo+KGNvbnRleHQpLT5wZXJmb3JtV29yaygpOwogfQogCiBSdW5Mb29wOjpSdW5Mb29wKCkKQEAg LTkxLDcgKzk4LDE1IEBAIHZvaWQgUnVuTG9vcDo6d2FrZVVwKCkKIHZvaWQgUnVuTG9vcDo6VGlt ZXJCYXNlOjp0aW1lckZpcmVkKENGUnVuTG9vcFRpbWVyUmVmLCB2b2lkKiBjb250ZXh0KQogewog ICAgIFRpbWVyQmFzZSogdGltZXIgPSBzdGF0aWNfY2FzdDxUaW1lckJhc2UqPihjb250ZXh0KTsK LSAgICB0aW1lci0+ZmlyZWQoKTsKKyAgICAKKyAgICAvLyBXcmFwIG1haW4gdGhyZWFkIGluIGFu IEF1dG9yZWxlYXNlIHBvb2wuICBUaGUgdGltZXIgY2FuIGNhbGwgCisgICAgLy8gaW50byBvYmpj IGNvZGUgYW5kIGFjY3VtdWxhdGUgbWVtb3J5IG91dHNpZGUgb2YgdGhlIG1haW4gZXZlbnQgbG9v cC4KKyAgICBpZiAoY3VycmVudCgpID09IG1haW4oKSkgeworICAgICAgICBOU0F1dG9yZWxlYXNl UG9vbCAqcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOyAKKyAgICAJdGlt ZXItPmZpcmVkKCk7CisgICAgCVtwb29sIGRyYWluXTsKKyAgICB9IGVsc2UKKyAgICAgICAgdGlt ZXItPmZpcmVkKCk7CiB9CiAKIFJ1bkxvb3A6OlRpbWVyQmFzZTo6VGltZXJCYXNlKFJ1bkxvb3Aq IHJ1bkxvb3ApCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0xh eWVyVHJlZUhvc3RNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9MYXllclRyZWVIb3N0TWFjLm1tCShyZXZpc2lvbiA4MTU0NykKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5tbQko d29ya2luZyBjb3B5KQpAQCAtMjM5LDcgKzIzOSwxMCBAQCBib29sIExheWVyVHJlZUhvc3RNYWM6 OnNob3dSZXBhaW50Q291bnRlCiAKIHZvaWQgTGF5ZXJUcmVlSG9zdE1hYzo6Zmx1c2hQZW5kaW5n TGF5ZXJDaGFuZ2VzUnVuTG9vcE9ic2VydmVyQ2FsbGJhY2soQ0ZSdW5Mb29wT2JzZXJ2ZXJSZWYs IENGUnVuTG9vcEFjdGl2aXR5LCB2b2lkKiBjb250ZXh0KQogeworICAgIC8vIFRoaXMgZ2V0cyBj YWxsZWQgb3V0c2lkZSBvZiB0aGUgbm9ybWFsIGV2ZW50IGxvb3Agc28gd3JhcCBpbiBhbiBhdXRv cmVsZWFzZSBwb29sCisgICAgTlNBdXRvcmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVh c2VQb29sIGFsbG9jXSBpbml0XTsKICAgICBzdGF0aWNfY2FzdDxMYXllclRyZWVIb3N0TWFjKj4o Y29udGV4dCktPmZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlc1J1bkxvb3BPYnNlcnZlckNhbGxiYWNr KCk7CisgICAgW3Bvb2wgZHJhaW5dOwogfQogCiB2b2lkIExheWVyVHJlZUhvc3RNYWM6OmZsdXNo UGVuZGluZ0xheWVyQ2hhbmdlc1J1bkxvb3BPYnNlcnZlckNhbGxiYWNrKCkK