56787 2011-03-21 17:28:08 -0700 Expose "webkitIndexedDB" to Workers 2012-01-05 14:02:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED DUPLICATE 73609 P2 Normal --- 57789 1 dgrogan dgrogan atwilson bugmail buildbot dimich gustavo.noronha gustavo jorlow jsbell levin priyajeet.hora webkit-ews xan.lopez oldest_to_newest 371056 0 dgrogan 2011-03-21 17:28:08 -0700 Expose "webkitIndexedDB" to Workers 371063 1 86394 dgrogan 2011-03-21 17:35:47 -0700 Created attachment 86394 Patch 371065 2 dgrogan 2011-03-21 17:39:37 -0700 This isn't ready for actual review. I'm tearing my hair out trying to figure out why these WorkerContext changes don't make webkitIndexedDB available in a worker. Do you know what I'm missing? Do I need to add some stuff to the bindings generator? 371068 3 86394 jorlow 2011-03-21 17:43:07 -0700 Comment on attachment 86394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86394&action=review > LayoutTests/storage/indexeddb/basics-workers.js:11 > + shouldBeTrue("'webkitIndexedDB' in window"); I don't get it...you set window = self above (in some cases)...? What exactly is this testing? > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) what about the above test? Eventually, all indexedDB tests shoudl run against workers and the main window. It's OK to just do a few for now tho. > Source/WebCore/workers/WorkerContext.h:206 > + extra new line > Source/WebCore/workers/WorkerContext.idl:139 > + extra newline 371069 4 jorlow 2011-03-21 17:44:08 -0700 I'm not sure. cc'ing others who can maybe help Btw, you'll need to add some stuff to the idl about static tables or something like that IIRC. 371070 5 jorlow 2011-03-21 17:45:27 -0700 Also, note that you'll need to land code to make the IndexedDBDispatcher (and maybe other things? not positive) thread-safe before landing this so that we don't break isolates. 371071 6 webkit-ews 2011-03-21 17:45:41 -0700 Attachment 86394 did not build on qt: Build output: http://queues.webkit.org/results/8221096 371074 7 levin 2011-03-21 17:48:21 -0700 Make sure to add " NoStaticTables" to the idl that you are exposing. (Search for where it is used in other places.) Your syntax for EnabledAtRuntime appears to be incorrect. (Look for where it is used in other places.) When you get it correct, you'll actually need to do work to expose turn on the flag. (Search for what other places do for their flag). 371081 8 buildbot 2011-03-21 17:54:06 -0700 Attachment 86394 did not build on win: Build output: http://queues.webkit.org/results/8221100 371089 9 levin 2011-03-21 18:02:09 -0700 (In reply to comment #7) > Your syntax for EnabledAtRuntime appears to be incorrect. (Look for where it is used in other places.) Drew pointed out that this part of my comment was incorrect. :) But the key is to understand this flag. 371122 10 atwilson 2011-03-21 18:19:04 -0700 I would strongly recommend looking at the generated code for this attribute and then maybe step through the code in a debugger - apologies if you've already done this, but pretty much any time I've run into issues with creating new JS bindings (and I *always* run into issues) I have to actually step through the bindings code to figure it out. I was mentioning to Dave that the bindings code is like 90% boilerplate, but small problems with the boilerplate result in really difficult to diagnose problems. 374867 11 gustavo.noronha 2011-03-28 16:11:01 -0700 Attachment 86394 did not build on gtk: Build output: http://queues.webkit.org/results/8276377 530609 12 dgrogan 2012-01-05 14:02:34 -0800 *** This bug has been marked as a duplicate of bug 73609 *** 86394 2011-03-21 17:35:47 -0700 2011-03-21 17:43:26 -0700 Patch bug-56787-20110321173545.patch text/plain 4841 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogODE1MjcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL2Jhc2ljcy13b3JrZXJzLmpzIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRl eGVkZGIvYmFzaWNzLXdvcmtlcnMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmM2OThjNTEyODJkODM5ZDRkY2Iy YmY4MzEzYjBmYmQ3NWQzMWFiZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL2Jhc2ljcy13b3JrZXJzLmpzCkBAIC0wLDAgKzEsMTggQEAKK2lmICh0aGlz LmltcG9ydFNjcmlwdHMpIHsKKyAgICBpbXBvcnRTY3JpcHRzKCdyZXNvdXJjZXMvZnMtd29ya2Vy LWNvbW1vbi5qcycpOworICAgIGltcG9ydFNjcmlwdHMoJ3Jlc291cmNlcy9zaGFyZWQuanMnKTsK KyAgICB3aW5kb3cgPSBzZWxmOworfQorCitkZXNjcmlwdGlvbigiVGVzdCBpbmRleGVkZGIgYmFz aWNzIGluIGEgd29ya2VyIik7CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHNob3VsZEJlVHJ1 ZSgiJ3dlYmtpdEluZGV4ZWREQicgaW4gd2luZG93Iik7CisgICAgc2hvdWxkQmVUcnVlKCIncmVx dWVzdEZpbGVTeXN0ZW0nIGluIHNlbGYiKTsgLy8gc3VjY2VlZHMKKyAgICBzaG91bGRCZVRydWUo Iid3ZWJraXRJbmRleGVkREInIGluIHNlbGYiKTsgLy8gZmFpbHMKKworICAgIGZpbmlzaEpTVGVz dCgpOworICAgIHJldHVybjsKK30KK3Rlc3QoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYjQwNjMzN2QzNzNj NTM5OWU2NzM3MTNhYWJiNTZiNzBkN2ExMmE0Li5kMWI0NGQxZjhhMmFhZTIyYmM1MDA2OTM5MmQ5 ZjMyNmY4MzAwMmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjEgIERh dmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSB3ZWJraXRJbmRleGVkREIgdG8gV29y a2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3 ODcKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHdvcmtlcnMv V29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0Ojp3ZWJr aXRJbmRleGVkREIpOgorICAgICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5oOgorICAgICAg ICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5pZGw6CisKIDIwMTEtMDMtMTggIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNwcAppbmRleCBhY2Y3ZjA0NmQ3 NTM3NjFhMTExZmI4YjM4ZDI1Mjc0MjNhYTlmNTEyLi4zNTEwZjQ0ZTcyNDM3YmM4NzFiMmYyNmRm YjRiMjVhYzM5ZTg5YjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ckNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5j cHAKQEAgLTc4LDYgKzc4LDggQEAKICNpbmNsdWRlICJTeW5jQ2FsbGJhY2tIZWxwZXIuaCIKICNl bmRpZgogCisjaW5jbHVkZSAiSURCRmFjdG9yeS5oIgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IGNsYXNzIENsb3NlV29ya2VyQ29udGV4dFRhc2sgOiBwdWJsaWMgU2NyaXB0RXhlY3V0aW9uQ29u dGV4dDo6VGFzayB7CkBAIC00MjcsNiArNDI5LDEwIEBAIHZvaWQgV29ya2VyQ29udGV4dDo6bm90 aWZ5T2JzZXJ2ZXJzT2ZTdG9wKCkKICAgICAgICAgaXRlciA9IG1fd29ya2VyT2JzZXJ2ZXJzLmJl Z2luKCk7CiAgICAgfQogfQorSURCRmFjdG9yeSogV29ya2VyQ29udGV4dDo6d2Via2l0SW5kZXhl ZERCKCkgY29uc3QKK3sKKyAgICByZXR1cm4gMDsKK30KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaCBi L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCmluZGV4IDJlODAyZjI1NTI0 ZDE2NDU4NmIxZGEwYjZhMGNiMzk3M2I2YWQzNmQuLjU0YWUxMTkxYmE0M2MwODk2YjRhMTNhMjA2 MzEzNWZkOTQyZGNkODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy Q29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5oCkBA IC01Miw2ICs1Miw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBEYXRhYmFzZVN5 bmM7CiAgICAgY2xhc3MgRXJyb3JDYWxsYmFjazsKICAgICBjbGFzcyBGaWxlU3lzdGVtQ2FsbGJh Y2s7CisgICAgY2xhc3MgSURCRmFjdG9yeTsKICAgICBjbGFzcyBOb3RpZmljYXRpb25DZW50ZXI7 CiAgICAgY2xhc3MgU2NoZWR1bGVkQWN0aW9uOwogICAgIGNsYXNzIFdvcmtlckxvY2F0aW9uOwpA QCAtMTU4LDYgKzE1OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCByZWdp c3Rlck9ic2VydmVyKE9ic2VydmVyKik7CiAgICAgICAgIHZvaWQgdW5yZWdpc3Rlck9ic2VydmVy KE9ic2VydmVyKik7CiAgICAgICAgIHZvaWQgbm90aWZ5T2JzZXJ2ZXJzT2ZTdG9wKCk7CisjaWYg RU5BQkxFKElOREVYRURfREFUQUJBU0UpCisgICAgICAgIElEQkZhY3RvcnkqIHdlYmtpdEluZGV4 ZWREQigpIGNvbnN0OworI2VuZGlmCiAKICAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIFdvcmtlckNv bnRleHQoY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYsIFdvcmtlclRocmVhZCopOwpAQCAtMTk2 LDYgKzIwMCwxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEV2ZW50VGFyZ2V0RGF0 YSBtX2V2ZW50VGFyZ2V0RGF0YTsKIAogICAgICAgICBIYXNoU2V0PE9ic2VydmVyKj4gbV93b3Jr ZXJPYnNlcnZlcnM7CisjaWYgRU5BQkxFKElOREVYRURfREFUQUJBU0UpCisgICAgICAgIG11dGFi bGUgUmVmUHRyPElEQkZhY3Rvcnk+IG1faWRiRmFjdG9yeTsKKyNlbmRpZgorCisKICAgICB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL1dvcmtlckNvbnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250 ZXh0LmlkbAppbmRleCAxNzkyMjFlZDRlYjczMDdjM2Q4NTNiMzRkM2U5ZTVjOGNmOWQ3ZDkyLi4y M2QxNTY3MDliYmZmMjY3YzllMTcyOWU0ZmFhMzA4NzU0M2U4N2Q4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwKQEAgLTEyMiw2ICsxMjIsMjIgQEAgbW9kdWxlIHRo cmVhZHMgewogICAgICAgICBhdHRyaWJ1dGUgSW50MzJBcnJheUNvbnN0cnVjdG9yIEludDMyQXJy YXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgogICAgICAgICBhdHRyaWJ1dGUgVWludDMy QXJyYXlDb25zdHJ1Y3RvciBVaW50MzJBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9y CiAgICAgICAgIGF0dHJpYnV0ZSBGbG9hdDMyQXJyYXlDb25zdHJ1Y3RvciBGbG9hdDMyQXJyYXk7 IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgorCisjaWYgZGVmaW5lZChFTkFCTEVfSU5ERVhF RF9EQVRBQkFTRSkgJiYgRU5BQkxFX0lOREVYRURfREFUQUJBU0UKKyAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIFtFbmFibGVkQXRSdW50aW1lXSBJREJGYWN0b3J5IHdlYmtpdEluZGV4ZWREQjsK KworICAgICAgICBhdHRyaWJ1dGUgW0VuYWJsZWRBdFJ1bnRpbWVdIElEQkN1cnNvckNvbnN0cnVj dG9yIHdlYmtpdElEQkN1cnNvcjsKKyAgICAgICAgYXR0cmlidXRlIFtFbmFibGVkQXRSdW50aW1l XSBJREJEYXRhYmFzZUNvbnN0cnVjdG9yIHdlYmtpdElEQkRhdGFiYXNlOworICAgICAgICBhdHRy aWJ1dGUgW0VuYWJsZWRBdFJ1bnRpbWVdIElEQkRhdGFiYXNlRXJyb3JDb25zdHJ1Y3RvciB3ZWJr aXRJREJEYXRhYmFzZUVycm9yOworICAgICAgICBhdHRyaWJ1dGUgW0VuYWJsZWRBdFJ1bnRpbWVd IElEQkRhdGFiYXNlRXhjZXB0aW9uQ29uc3RydWN0b3Igd2Via2l0SURCRGF0YWJhc2VFeGNlcHRp b247CisgICAgICAgIGF0dHJpYnV0ZSBbRW5hYmxlZEF0UnVudGltZV0gSURCRmFjdG9yeUNvbnN0 cnVjdG9yIHdlYmtpdElEQkZhY3Rvcnk7CisgICAgICAgIGF0dHJpYnV0ZSBbRW5hYmxlZEF0UnVu dGltZV0gSURCSW5kZXhDb25zdHJ1Y3RvciB3ZWJraXRJREJJbmRleDsKKyAgICAgICAgYXR0cmli dXRlIFtFbmFibGVkQXRSdW50aW1lXSBJREJLZXlSYW5nZUNvbnN0cnVjdG9yIHdlYmtpdElEQktl eVJhbmdlOworICAgICAgICBhdHRyaWJ1dGUgW0VuYWJsZWRBdFJ1bnRpbWVdIElEQk9iamVjdFN0 b3JlQ29uc3RydWN0b3Igd2Via2l0SURCT2JqZWN0U3RvcmU7CisgICAgICAgIGF0dHJpYnV0ZSBb RW5hYmxlZEF0UnVudGltZV0gSURCUmVxdWVzdENvbnN0cnVjdG9yIHdlYmtpdElEQlJlcXVlc3Q7 CisgICAgICAgIGF0dHJpYnV0ZSBbRW5hYmxlZEF0UnVudGltZV0gSURCVHJhbnNhY3Rpb25Db25z dHJ1Y3RvciB3ZWJraXRJREJUcmFuc2FjdGlvbjsKKworI2VuZGlmCiAgICAgfTsKIAogfQo=