56782 2011-03-21 16:55:02 -0700 REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key 2011-03-21 18:06:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap abarth eric webkit.review.bot oldest_to_newest 371022 0 ap 2011-03-21 16:55:02 -0700 Steps to reproduce: 1. Open a new WebKit2 window. 2. Click in content to focus. 3. Press Cmd+[, or Esc, or some other command key. Results: both web and UI process taking a lot of CPU time, bouncing the key event back and forth. <rdar://problem/9151993> 371033 1 86390 ap 2011-03-21 17:05:49 -0700 Created attachment 86390 proposed fix I can't say that I really deeply understand this code, but the fix seems to be straightforward. 371038 2 86390 darin 2011-03-21 17:08:06 -0700 Comment on attachment 86390 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=86390&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:1739 > +- (void)_resendEvent:(NSEvent *)event I like the name _resetKeyDownEvent slightly better. 371042 3 ap 2011-03-21 17:12:31 -0700 Committed <http://trac.webkit.org/changeset/81622>. 371099 4 webkit.review.bot 2011-03-21 18:06:14 -0700 http://trac.webkit.org/changeset/81622 might have broken Qt Linux Release The following tests are not passing: css2.1/t09-c5526c-display-00-e.html 86390 2011-03-21 17:05:49 -0700 2011-03-21 17:08:06 -0700 proposed fix ResendEvent.txt text/plain 5663 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjE5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMjEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjgxMjY5KTogV2ViS2l0MiBnZXRzIGlu dG8gYW4gaW5maW5pdGUgcmVjdXJzaW9uIGFmdGVyIGFuIHVuaGFuZGxlZCBjb21tYW5kIGtleQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY3ODIKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkxNTE5OTM+CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L21hYy9QYWdlQ2xpZW50SW1wbC5tbTogKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmRvbmVXaXRo S2V5RXZlbnQpOgorICAgICAgICBGYWN0b3JlZCBvdXQgY29kZSBmb3IgcmVzZW5kaW5nIGFuIGV2 ZW50IGFuZCBtb3ZlZCBpdCB0byBXS1ZpZXcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBwZXJmb3JtS2V5RXF1aXZhbGVudDpdKTog RG9uJ3QgemVybyBvdXQgX2tleURvd25FdmVudEJlaW5nUmVzZW50LCBpdCdzIGVhc2llcgorICAg ICAgICB0byBqdXN0IGRvIHRoYXQgaW4gX3Jlc2VuZEV2ZW50Oi4KKyAgICAgICAgKC1bV0tWaWV3 IGtleURvd246XSk6IERpdHRvLgorICAgICAgICAoLVtXS1ZpZXcgX3Jlc2VuZEV2ZW50Ol0pOiBN b3ZlZCBmcm9tIFBhZ2VDbGllbnRJbXBsLm1tLiBBZGRlZCBhbiBhc3NlcnRpb24gdGhhdCB3ZSBh cmUKKyAgICAgICAgbm90IGFscmVhZHkgcmVzZW5kaW5nIGFuIGV2ZW50IC0gaXQgd291bGQgYmUg dG9vIGNvbmZ1c2luZyBpZiB3ZSBldmVyIGhhZCB0byBkbyB0aGF0LCBidXQKKyAgICAgICAgbG9v a3MgbGlrZSB0aGlzIG5ldmVyIGhhcHBlbnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXdJbnRlcm5hbC5oOiBFeHBvc2VkIF9yZXNlbmRFdmVudC4KKwogMjAxMS0wMy0yMSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9Q YWdlQ2xpZW50SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQkocmV2aXNpb24gODE1ODgpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQkod29ya2luZyBjb3B5KQpA QCAtNDgsNyArNDgsNiBAQAogCiBAaW50ZXJmYWNlIE5TQXBwbGljYXRpb24gKFdlYk5TQXBwbGlj YXRpb25EZXRhaWxzKQogLSAoTlNDdXJzb3IgKilfY3Vyc29yUmVjdEN1cnNvcjsKLS0gKHZvaWQp X3NldEN1cnJlbnRFdmVudDooTlNFdmVudCAqKWV2ZW50OwogQGVuZAogCiB1c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKQEAgLTMyOSwxMSArMzI4LDggQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6ZG9u ZVdpdGhLZXlFdmVudChjbwogICAgICAgICByZXR1cm47CiAgICAgaWYgKHdhc0V2ZW50SGFuZGxl ZCkKICAgICAgICAgW05TQ3Vyc29yIHNldEhpZGRlblVudGlsTW91c2VNb3ZlczpZRVNdOwotICAg IGVsc2UgewotICAgICAgICBbbV93a1ZpZXcgX3NldEV2ZW50QmVpbmdSZXNlbnQ6bmF0aXZlRXZl bnRdOwotICAgICAgICBbTlNBcHAgX3NldEN1cnJlbnRFdmVudDpuYXRpdmVFdmVudF07Ci0gICAg ICAgIFtOU0FwcCBzZW5kRXZlbnQ6bmF0aXZlRXZlbnRdOwotICAgIH0KKyAgICBlbHNlCisgICAg ICAgIFttX3drVmlldyBfcmVzZW5kRXZlbnQ6bmF0aXZlRXZlbnRdOwogfQogCiBQYXNzUmVmUHRy PFdlYlBvcHVwTWVudVByb3h5PiBQYWdlQ2xpZW50SW1wbDo6Y3JlYXRlUG9wdXBNZW51UHJveHko V2ViUGFnZVByb3h5KiBwYWdlKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbQkocmV2aXNpb24gODE1ODgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTcxLDExICs3MSwxMiBAQAog Ly8gRklYTUUgKFdlYktpdDIpIDxyZGFyOi8vcHJvYmxlbS84NzI4ODYwPiBXZWJLaXQyIG5lZWRz IHRvIGJlIGxvY2FsaXplZAogI2RlZmluZSBVSV9TVFJJTkcoX19zdHIsIF9fZGVzYykgW05TU3Ry aW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOl9fc3RyXQogCi1AaW50ZXJmYWNlIE5TQXBwbGljYXRp b24gKERldGFpbHMpCitAaW50ZXJmYWNlIE5TQXBwbGljYXRpb24gKFdlYk5TQXBwbGljYXRpb25E ZXRhaWxzKQogLSAodm9pZClzcGVha1N0cmluZzooTlNTdHJpbmcgKilzdHJpbmc7CistICh2b2lk KV9zZXRDdXJyZW50RXZlbnQ6KE5TRXZlbnQgKilldmVudDsKIEBlbmQKIAotQGludGVyZmFjZSBO U1dpbmRvdyAoRGV0YWlscykKK0BpbnRlcmZhY2UgTlNXaW5kb3cgKFdlYk5TV2luZG93RGV0YWls cykKIC0gKE5TUmVjdClfZ3Jvd0JveFJlY3Q7CiAtIChpZClfZ3Jvd0JveE93bmVyOwogLSAodm9p ZClfc2V0U2hvd09wYXF1ZUdyb3dCb3hGb3JPd25lcjooaWQpb3duZXI7CkBAIC0xMjcsNyArMTI4 LDcgQEAgQGludGVyZmFjZSBXS1ZpZXdEYXRhIDogTlNPYmplY3QgewogICAgIC8vIFdlIGtlZXAg aGVyZSB0aGUgZXZlbnQgd2hlbiByZXNlbmRpbmcgaXQgdG8KICAgICAvLyB0aGUgYXBwbGljYXRp b24gdG8gZGlzdGluZ3Vpc2ggdGhlIGNhc2Ugb2YgYSBuZXcgZXZlbnQgZnJvbSBvbmUgCiAgICAg Ly8gdGhhdCBoYXMgYmVlbiBhbHJlYWR5IHNlbnQgdG8gV2ViQ29yZS4KLSAgICBOU0V2ZW50ICpf a2V5RG93bkV2ZW50QmVpbmdSZXNlbnQ7CisgICAgUmV0YWluUHRyPE5TRXZlbnQ+IF9rZXlEb3du RXZlbnRCZWluZ1Jlc2VudDsKICAgICBib29sIF9pc0luSW50ZXJwcmV0S2V5RXZlbnRzOwogICAg IFZlY3RvcjxLZXlwcmVzc0NvbW1hbmQ+IF9jb21tYW5kc0xpc3Q7CiAKQEAgLTExMDQsOSArMTEw NSw2IEBAIC0gKEJPT0wpcGVyZm9ybUtleUVxdWl2YWxlbnQ6KE5TRXZlbnQgKikKICAgICAvLyBC dXQgZG9uJ3QgZG8gaXQgaWYgd2UgaGF2ZSBhbHJlYWR5IGhhbmRsZWQgdGhlIGV2ZW50LgogICAg IC8vIFByZXNzaW5nIEVzYyByZXN1bHRzIGluIGEgZmFrZSBldmVudCBiZWluZyBzZW50IC0gZG9u J3QgcGFzcyBpdCB0byBXZWJDb3JlLgogICAgIGlmICghZXZlbnRXYXNTZW50VG9XZWJDb3JlICYm IGV2ZW50ID09IFtOU0FwcCBjdXJyZW50RXZlbnRdICYmIHNlbGYgPT0gW1tzZWxmIHdpbmRvd10g Zmlyc3RSZXNwb25kZXJdKSB7Ci0gICAgICAgIFtfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVz ZW50IHJlbGVhc2VdOwotICAgICAgICBfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50ID0g bmlsOwotICAgICAgICAKICAgICAgICAgX2RhdGEtPl9wYWdlLT5oYW5kbGVLZXlib2FyZEV2ZW50 KE5hdGl2ZVdlYktleWJvYXJkRXZlbnQoZXZlbnQsIHNlbGYpKTsKICAgICAgICAgcmV0dXJuIFlF UzsKICAgICB9CkBAIC0xMTM5LDggKzExMzcsNiBAQCAtICh2b2lkKWtleURvd246KE5TRXZlbnQg Kil0aGVFdmVudAogICAgIC8vIHRoZXJlIGlzIG5vIHJhbmdlIHNlbGVjdGlvbikuCiAgICAgLy8g SWYgdGhpcyBpcyB0aGUgY2FzZSB3ZSBzaG91bGQgaWdub3JlIHRoZSBrZXkgZG93bi4KICAgICBp ZiAoX2RhdGEtPl9rZXlEb3duRXZlbnRCZWluZ1Jlc2VudCA9PSB0aGVFdmVudCkgewotICAgICAg ICBbX2RhdGEtPl9rZXlEb3duRXZlbnRCZWluZ1Jlc2VudCByZWxlYXNlXTsKLSAgICAgICAgX2Rh dGEtPl9rZXlEb3duRXZlbnRCZWluZ1Jlc2VudCA9IG5pbDsKICAgICAgICAgW3N1cGVyIGtleURv d246dGhlRXZlbnRdOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtMTc0MCw5ICsxNzM2LDE0 IEBAIC0gKHZvaWQpX3NldFVzZXJJbnRlcmZhY2VJdGVtU3RhdGU6KE5TU3QKICAgICB9CiB9CiAK LS0gKHZvaWQpX3NldEV2ZW50QmVpbmdSZXNlbnQ6KE5TRXZlbnQgKilldmVudAorLSAodm9pZClf cmVzZW5kRXZlbnQ6KE5TRXZlbnQgKilldmVudAogewotICAgIF9kYXRhLT5fa2V5RG93bkV2ZW50 QmVpbmdSZXNlbnQgPSBbZXZlbnQgcmV0YWluXTsKKyAgICBBU1NFUlQoIV9kYXRhLT5fa2V5RG93 bkV2ZW50QmVpbmdSZXNlbnQpOworICAgIF9kYXRhLT5fa2V5RG93bkV2ZW50QmVpbmdSZXNlbnQg PSBldmVudDsKKyAgICBbTlNBcHAgX3NldEN1cnJlbnRFdmVudDpldmVudF07CisgICAgW05TQXBw IHNlbmRFdmVudDpldmVudF07CisKKyAgICBfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50 ID0gbnVsbHB0cjsKIH0KIAogLSAoVmVjdG9yPEtleXByZXNzQ29tbWFuZD4mKV9pbnRlcmNlcHRL ZXlFdmVudDooTlNFdmVudCAqKXRoZUV2ZW50IApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCShyZXZpc2lvbiA4MTU4OCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmgJKHdvcmtp bmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgQGludGVyZmFjZSBXS1ZpZXcgKEludGVybmFsKQog LSAodm9pZClfc2V0VXNlckludGVyZmFjZUl0ZW1TdGF0ZTooTlNTdHJpbmcgKiljb21tYW5kTmFt ZSBlbmFibGVkOihCT09MKWlzRW5hYmxlZCBzdGF0ZTooaW50KW5ld1N0YXRlOwogLSAoVmVjdG9y PFdlYkNvcmU6OktleXByZXNzQ29tbWFuZD4mKV9pbnRlcmNlcHRLZXlFdmVudDooTlNFdmVudCAq KXRoZUV2ZW50OwogLSAodm9pZClfZ2V0VGV4dElucHV0U3RhdGU6KHVuc2lnbmVkKXN0YXJ0IHNl bGVjdGlvbkVuZDoodW5zaWduZWQpZW5kIHVuZGVybGluZXM6KFZlY3RvcjxXZWJDb3JlOjpDb21w b3NpdGlvblVuZGVybGluZT4mKWxpbmVzOwotLSAodm9pZClfc2V0RXZlbnRCZWluZ1Jlc2VudDoo TlNFdmVudCAqKWV2ZW50OworLSAodm9pZClfcmVzZW5kRXZlbnQ6KE5TRXZlbnQgKilldmVudDsK IC0gKE5TUmVjdClfY29udmVydFRvRGV2aWNlU3BhY2U6KE5TUmVjdClyZWN0OwogLSAoTlNSZWN0 KV9jb252ZXJ0VG9Vc2VyU3BhY2U6KE5TUmVjdClyZWN0OwogLSAodm9pZClfc2V0RmluZEluZGlj YXRvcjooUGFzc1JlZlB0cjxXZWJLaXQ6OkZpbmRJbmRpY2F0b3I+KWZpbmRJbmRpY2F0b3IgZmFk ZU91dDooQk9PTClmYWRlT3V0Owo=