56764 2011-03-21 12:56:57 -0700 QT plug-in loads controller at top of movie not bottom 2011-03-21 13:03:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 370844 0 andersca 2011-03-21 12:56:57 -0700 QT plug-in loads controller at top of movie not bottom 370846 1 86355 andersca 2011-03-21 12:59:18 -0700 Created attachment 86355 Patch 370852 2 86355 sam 2011-03-21 13:02:23 -0700 Comment on attachment 86355 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86355&action=review Otherwise, r=me. > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:234 > + RetainPtr<CALayer> realPluginLayer(AdoptNS, reinterpret_cast<CALayer *>(value)); This adoption seems wrong. 370853 3 andersca 2011-03-21 13:03:56 -0700 Committed r81604: <http://trac.webkit.org/changeset/81604> 86355 2011-03-21 12:59:18 -0700 2011-03-21 13:02:23 -0700 Patch bug-56764-20110321125916.patch text/plain 2068 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNjAxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMjEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBRVCBwbHVnLWluIGxvYWRzIGNvbnRyb2xsZXIgYXQgdG9w IG9mIG1vdmllIG5vdCBib3R0b20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU2NzY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTc5MDM3PgorCisg ICAgICAgIENyZWF0ZSBhIGxheWVyIHdpdGggZ2VvbWV0cnlGbGlwcGVkIHNldCBhbmQgYWRkIHRo ZSBwbHVnLWluIGxheWVyIGFzIGEgc3VibGF5ZXIsCisgICAgICAgIG1hdGNoaW5nIFdlYktpdDEu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1 Z2luTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1Qb3N0 SW5pdGlhbGl6ZSk6CisKIDIwMTEtMDMtMjEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1Z2luTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9tYWMvTmV0c2NhcGVQbHVnaW5NYWMubW0JKHJldmlzaW9uIDgxNTkxKQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMjMwLDcgKzIzMCwxNyBAQCBib29sIE5ldHNjYXBlUGx1Z2lu OjpwbGF0Zm9ybVBvc3RJbml0aWFsCiAgICAgICAgIC8vIEdldCB0aGUgQ29yZSBBbmltYXRpb24g bGF5ZXIuCiAgICAgICAgIGlmIChOUFBfR2V0VmFsdWUoTlBQVnBsdWdpbkNvcmVBbmltYXRpb25M YXllciwgJnZhbHVlKSA9PSBOUEVSUl9OT19FUlJPUiAmJiB2YWx1ZSkgewogICAgICAgICAgICAg QVNTRVJUKCFtX3BsdWdpbkxheWVyKTsKLSAgICAgICAgICAgIG1fcGx1Z2luTGF5ZXIgPSByZWlu dGVycHJldF9jYXN0PENBTGF5ZXIgKj4odmFsdWUpOworCisgICAgICAgICAgICBSZXRhaW5QdHI8 Q0FMYXllcj4gcmVhbFBsdWdpbkxheWVyKEFkb3B0TlMsIHJlaW50ZXJwcmV0X2Nhc3Q8Q0FMYXll ciAqPih2YWx1ZSkpOworCisgICAgICAgICAgICAvLyBDcmVhdGUgYSBsYXllciB3aXRoIGZsaXBw ZWQgZ2VvbWV0cnkgYW5kIGFkZCB0aGUgcmVhbCBwbHVnLWluIGxheWVyIGFzIGEgc3VibGF5ZXIK KyAgICAgICAgICAgIC8vIHNvIHRoZSBjb29yZGluYXRlIHN5c3RlbSB3aWxsIG1hdGNoIHRoZSBl dmVudCBjb29yZGluYXRlIHN5c3RlbS4KKyAgICAgICAgICAgIG1fcGx1Z2luTGF5ZXIuYWRvcHRO UyhbW0NBTGF5ZXIgYWxsb2NdIGluaXRdKTsKKyAgICAgICAgICAgIFttX3BsdWdpbkxheWVyLmdl dCgpIHNldEJvdW5kczpbcmVhbFBsdWdpbkxheWVyLmdldCgpIGJvdW5kc11dOworICAgICAgICAg ICAgW21fcGx1Z2luTGF5ZXIuZ2V0KCkgc2V0R2VvbWV0cnlGbGlwcGVkOllFU107CisKKyAgICAg ICAgICAgIFtyZWFsUGx1Z2luTGF5ZXIuZ2V0KCkgc2V0QXV0b3Jlc2l6aW5nTWFzazprQ0FMYXll cldpZHRoU2l6YWJsZSB8IGtDQUxheWVySGVpZ2h0U2l6YWJsZV07CisgICAgICAgICAgICBbbV9w bHVnaW5MYXllci5nZXQoKSBhZGRTdWJsYXllcjpyZWFsUGx1Z2luTGF5ZXIuZ2V0KCldOwogICAg ICAgICB9CiAgICAgfQogCg==