56761 2011-03-21 11:40:29 -0700 KeyboardEvent keyIdentifier is not propagated to plugins by Chromium 2013-04-11 13:30:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 0 wez webkit-unassigned levin morrita schenney oldest_to_newest 370502 0 wez 2011-03-21 11:40:29 -0700 Overview: DOM KeyboardEvents reach plug-ins in Chromium via the WebPluginContainerImpl, which converts them to Chromium's WebKeyboardEvent. The conversion process doesn't currently propagate the keyIdentifier field (presumably because that is never currently passed to plug-ins). Steps to Reproduce: Try to use the keyIdentifier field of the WebKeyboardEvent from plug-in code. Actual Results: The keyIdentifier string will be empty. Expected Results: The keyIdentifier field should contain a character key-value (e.g. U+0041) or key function name (e.g. "Shift"). Build Date & Platform: Build 2011-03-21 on Linux w/ Chromium development build. 372129 1 86613 wez 2011-03-23 07:14:29 -0700 Created attachment 86613 Patch 384368 2 morrita 2011-04-12 14:17:02 -0700 Looks no harm. This patch would be safe to r+ for any reviewers ;-) 384412 3 86613 levin 2011-04-12 15:03:45 -0700 Comment on attachment 86613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86613&action=review > Source/WebKit/chromium/src/WebInputEventConversion.cpp:339 > + sizeof(keyIdentifier) - 1); I dislike strncpy. It does weird things. (Why fill in all those 0's?) What about memcpy? memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), std::min(sizeof(keyIdentifier) - 1, event.keyIdentifier().ascii().length()); keyIdentifier[event.keyIdentifier().ascii().length()] = '\0'; (Of course, you may want to put event.keyIdentifier().ascii() in a local and possible length as well, so I guess that makes it slightly longer.) What do you think? 384414 4 levin 2011-04-12 15:05:32 -0700 fwiw, I tried to find a function in webkit that did this but failed. 393083 5 86613 ojan 2011-04-26 16:54:06 -0700 Comment on attachment 86613 Patch r- per David's last comment. 874107 6 schenney 2013-04-11 13:30:23 -0700 https://code.google.com/p/chromium/issues/detail?id=230550 86613 2011-03-23 07:14:29 -0700 2011-04-26 16:54:06 -0700 Patch bug-56761-20110323141427.patch text/plain 1680 wez U3VidmVyc2lvbiBSZXZpc2lvbjogODE2NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MWQ1OGFmNGY1MDNkMTRmZWRkNzMyNTY2MThjNjk4NTkxNWM5YjM3ZC4uYWEzNjEzNTNkNzA4YTZl MDVjNjRjZjI1OGMwMjdjMzY4MTBkYmZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMy0yMyAgV2V6ICA8d2V6QGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgNTY3NjE6IEtl eWJvYXJkRXZlbnQga2V5SWRlbnRpZmllciBpcyBub3QgcHJvcGFnYXRlZCB0byBwbHVnaW5zIGJ5 IENocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTY3NjEKKworICAgICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYktleWJvYXJkRXZlbnRCdWlsZGVyOjpXZWJLZXlib2FyZEV2ZW50 QnVpbGRlcik6CisgICAgICAgIFByb3BhZ2F0ZSB0aGUga2V5SWRlbnRpZmllciBmcm9tIERPTSBL ZXlib2FyZEV2ZW50IHRvIFdlYktleWJvYXJkRXZlbnQuCisKIDIwMTEtMDMtMjEgIEFkYW0gS2xl aW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2 aW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50 Q29udmVyc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50 Q29udmVyc2lvbi5jcHAKaW5kZXggMjRlZWI4ODViMGYyODBjNmMyMDlkZjFmMjIwZDhjMmYzNDM2 ODNjZi4uMDVhMTZkMTgyZTliM2JkZWMyMWE4ZjMyOTk4NmFiN2YzNmZiMWJiMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9u LmNwcApAQCAtMzM0LDYgKzMzNCwxMSBAQCBXZWJLZXlib2FyZEV2ZW50QnVpbGRlcjo6V2ViS2V5 Ym9hcmRFdmVudEJ1aWxkZXIoY29uc3QgS2V5Ym9hcmRFdmVudCYgZXZlbnQpCiAgICAgdGltZVN0 YW1wU2Vjb25kcyA9IGV2ZW50LnRpbWVTdGFtcCgpICogMS4wZS0zOwogICAgIHdpbmRvd3NLZXlD b2RlID0gZXZlbnQua2V5Q29kZSgpOwogCisgICAgLy8gUHVsbCB0aGUgRE9NLUxldmVsLTMga2V5 ICJpZGVudGlmaWVyIiBvdXQKKyAgICBzdHJuY3B5KGtleUlkZW50aWZpZXIsIGV2ZW50LmtleUlk ZW50aWZpZXIoKS5hc2NpaSgpLmRhdGEoKSwKKyAgICAgICAgICAgIHNpemVvZihrZXlJZGVudGlm aWVyKSAtIDEpOworICAgIGtleUlkZW50aWZpZXJbc2l6ZW9mKGtleUlkZW50aWZpZXIpIC0gMV0g PSAnXDAnOworCiAgICAgLy8gVGhlIHBsYXRmb3JtIGtleWV2ZW50IGRvZXMgbm90IGV4aXN0IGlm IHRoZSBldmVudCB3YXMgY3JlYXRlZCB1c2luZwogICAgIC8vIGluaXRLZXlib2FyZEV2ZW50Lgog ICAgIGlmICghZXZlbnQua2V5RXZlbnQoKSkK