56728 2011-03-20 19:17:17 -0700 [CMAKE] Add exception handling when PORT was missing. 2011-03-21 20:22:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit commit-queue gyuyoung.kim kenneth leandro lucas.de.marchi paroga tonikitoo oldest_to_newest 370258 0 ryuan.choi 2011-03-20 19:17:17 -0700 When using cmake build system, user should choose proper port between Efl or WinCE (now). I believe that cmake system should notify what user should do when PORT was missed. 370260 1 86290 ryuan.choi 2011-03-20 19:24:11 -0700 Created attachment 86290 Patch 370911 2 86290 lucas.de.marchi 2011-03-21 14:40:11 -0700 Comment on attachment 86290 Patch LGTM 371010 3 86290 tonikitoo 2011-03-21 16:42:21 -0700 Comment on attachment 86290 Patch rs=me 371164 4 86290 commit-queue 2011-03-21 20:15:59 -0700 Comment on attachment 86290 Patch Clearing flags on attachment: 86290 Committed r81638: <http://trac.webkit.org/changeset/81638> 371165 5 commit-queue 2011-03-21 20:16:05 -0700 All reviewed patches have been landed. Closing bug. 371170 6 commit-queue 2011-03-21 20:22:49 -0700 The commit-queue encountered the following flaky tests while processing attachment 86290: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 86290 2011-03-20 19:24:11 -0700 2011-03-21 20:15:59 -0700 Patch bug-56728-20110321112408.patch text/plain 1445 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDgxNTY3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMt MjAgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gQWRkIGV4Y2VwdGlvbiBo YW5kbGluZyB3aGVuIFBPUlQgd2FzIG1pc3NpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjcyOAorCisgICAgICAgICogU291cmNlL0NNYWtlTGlz dHMudHh0OgorCiAyMDExLTAzLTEwICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxvc3RhcGVua28u dmlhdGNoZXNsYXZAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhc3psbyBHb21i b3MuCkluZGV4OiBTb3VyY2UvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0NN YWtlTGlzdHMudHh0CShyZXZpc2lvbiA4MTU2NykKKysrIFNvdXJjZS9DTWFrZUxpc3RzLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMjMsOCArMjMsMTMgQEAgSU5DTFVERShXZWJLaXRGZWF0dXJlcykK ICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgRGV0ZXJtaW5lIHdoaWNoIHBvcnQgd2lsbCBiZSBi dWlsdAogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQotU0VUKEFMTF9QT1JUUyBFZmwpCi1PUFRJT04o UE9SVCAiY2hvb3NlIHdoaWNoIFdlYktpdCBwb3J0IHRvIGJ1aWxkIChvbmUgb2YgJHtBTExfUE9S VFN9KSIgIk5PUE9SVCIpCitTRVQoQUxMX1BPUlRTIEVmbCBXaW5DRSkKK1NFVChQT1JUICJOT1BP UlQiIENBQ0hFIFNUUklORyAiY2hvb3NlIHdoaWNoIFdlYktpdCBwb3J0IHRvIGJ1aWxkIChvbmUg b2YgJHtBTExfUE9SVFN9KSIpCisKK0xJU1QoRklORCBBTExfUE9SVFMgJHtQT1JUfSBSRVQpCitJ RiAoJHtSRVR9IEVRVUFMIC0xKQorICAgIE1FU1NBR0UoRkFUQUxfRVJST1IgIlBsZWFzZSBjaG9v c2Ugd2hpY2ggV2ViS2l0IHBvcnQgdG8gYnVpbGQgKG9uZSBvZiAke0FMTF9QT1JUU30pIikKK0VO RElGICgpCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgRmluZCBjb21tb24gcGFja2FnZXMg KHVzZWQgYnkgYWxsIHBvcnRzKQo=