56698 2011-03-18 17:52:00 -0700 [GTK] Simplify GObjectEventListener 2011-03-19 12:57:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned abarth eric webkit.review.bot xan.lopez oldest_to_newest 370046 0 xan.lopez 2011-03-18 17:52:00 -0700 There's really no need to have a special member variable for DOMWindow, since it's also an EventTarget. 370048 1 86249 xan.lopez 2011-03-18 17:54:41 -0700 Created attachment 86249 Patch 370086 2 86249 mrobinson 2011-03-18 20:04:14 -0700 Comment on attachment 86249 Patch Nice cleanup! 370127 3 86249 xan.lopez 2011-03-19 07:25:25 -0700 Comment on attachment 86249 Patch Clearing flags on attachment: 86249 Committed r81550: <http://trac.webkit.org/changeset/81550> 370128 4 xan.lopez 2011-03-19 07:25:32 -0700 All reviewed patches have been landed. Closing bug. 370154 5 webkit.review.bot 2011-03-19 12:57:16 -0700 http://trac.webkit.org/changeset/81550 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/workers/storage/multiple-databases-garbage-collection.html fast/workers/storage/open-database-inputs-sync.html storage/multiple-databases-garbage-collection.html storage/open-database-creation-callback-isolated-world.html storage/open-database-creation-callback.html storage/quota-tracking.html storage/statement-error-callback-isolated-world.html storage/statement-success-callback-isolated-world.html storage/transaction-callback-isolated-world.html storage/transaction-error-callback-isolated-world.html storage/transaction-success-callback-isolated-world.html 86249 2011-03-18 17:54:41 -0700 2011-03-19 07:25:25 -0700 Patch bug-56698-20110319015433.patch text/plain 7178 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogODE1MzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNjJjYjQ3Y2YwOTAxNDg2 MDI2N2IyOTQ2OTNjNGE5MjllY2VlNjNlLi40MzljZmRlZDg1MWQ1YTNiMGM4OWM3NjEwMjg0ZTBj NDliMjY2ZTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMTggIFhhbiBM b3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtHVEtdIFNpbXBsaWZ5IEdPYmplY3RFdmVudExpc3RlbmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjY5OAorCisg ICAgICAgIEdldCByaWQgb2Ygc3BlY2lhbCBjYXNlIGZvciBET01XaW5kb3csIHNpbmNlIGl0J3Mg YWxzbyBhbgorICAgICAgICBFdmVudFRhcmdldC4KKworICAgICAgICAqIGJpbmRpbmdzL2dvYmpl Y3QvR09iamVjdEV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R09iamVjdEV2 ZW50TGlzdGVuZXI6OkdPYmplY3RFdmVudExpc3RlbmVyKTogcmVtb3ZlCisgICAgICAgIERPTVdp bmRvdyBzcGVjaWFsIGNhc2luZy4KKyAgICAgICAgKFdlYkNvcmU6OkdPYmplY3RFdmVudExpc3Rl bmVyOjp+R09iamVjdEV2ZW50TGlzdGVuZXIpOiBkaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkdP YmplY3RFdmVudExpc3RlbmVyOjpnb2JqZWN0RGVzdHJveWVkKToKKyAgICAgICAgKiBiaW5kaW5n cy9nb2JqZWN0L0dPYmplY3RFdmVudExpc3RlbmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpHT2Jq ZWN0RXZlbnRMaXN0ZW5lcjo6YWRkRXZlbnRMaXN0ZW5lcik6IGRpdHRvLgorICAgICAgICAoV2Vi Q29yZTo6R09iamVjdEV2ZW50TGlzdGVuZXI6OnJlbW92ZUV2ZW50TGlzdGVuZXIpOiBkaXR0by4K KwogMjAxMS0wMy0xNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9nb2JqZWN0L0dPYmplY3RFdmVudExpc3RlbmVyLmNwcAppbmRleCA2ZDQ3ODAwYjI4 NGNlOWU3NDFjNzdhYzllYjRkZDk3NzFhY2E4MjJjLi42MjExZTdkMjU2MmMyYWJiYjQ1NmMzOWRh ZjM3NmQyNDk2ZmMxODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2Jq ZWN0L0dPYmplY3RFdmVudExpc3RlbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9nb2JqZWN0L0dPYmplY3RFdmVudExpc3RlbmVyLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0g KiAgQ29weXJpZ2h0IChDKSAyMDEwIElnYWxpYSBTLkwuCisgKiAgQ29weXJpZ2h0IChDKSAyMDEw LCAyMDExIElnYWxpYSBTLkwuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCkBAIC0zMSw0MiArMzEsMzUg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB0eXBlZGVmIHZvaWQgKCpHT2JqZWN0RXZlbnRMaXN0 ZW5lckNhbGxiYWNrKShHT2JqZWN0KiwgV2ViS2l0RE9NRXZlbnQqLCB2b2lkKik7CiAKLUdPYmpl Y3RFdmVudExpc3RlbmVyOjpHT2JqZWN0RXZlbnRMaXN0ZW5lcihHT2JqZWN0KiBvYmplY3QsIERP TVdpbmRvdyogd2luZG93LCBFdmVudFRhcmdldCogdGFyZ2V0LCBjb25zdCBjaGFyKiBkb21FdmVu dE5hbWUsIEdDYWxsYmFjayBoYW5kbGVyLCBib29sIGNhcHR1cmUsIHZvaWQqIHVzZXJEYXRhKQor R09iamVjdEV2ZW50TGlzdGVuZXI6OkdPYmplY3RFdmVudExpc3RlbmVyKEdPYmplY3QqIG9iamVj dCwgRXZlbnRUYXJnZXQqIHRhcmdldCwgY29uc3QgY2hhciogZG9tRXZlbnROYW1lLCBHQ2FsbGJh Y2sgaGFuZGxlciwgYm9vbCBjYXB0dXJlLCB2b2lkKiB1c2VyRGF0YSkKICAgICA6IEV2ZW50TGlz dGVuZXIoR09iamVjdEV2ZW50TGlzdGVuZXJUeXBlKQogICAgICwgbV9vYmplY3Qob2JqZWN0KQog ICAgICwgbV9jb3JlVGFyZ2V0KHRhcmdldCkKLSAgICAsIG1fY29yZVdpbmRvdyh3aW5kb3cpCiAg ICAgLCBtX2RvbUV2ZW50TmFtZShkb21FdmVudE5hbWUpCiAgICAgLCBtX2hhbmRsZXIoaGFuZGxl cikKICAgICAsIG1fY2FwdHVyZShjYXB0dXJlKQogICAgICwgbV91c2VyRGF0YSh1c2VyRGF0YSkK IHsKLSAgICBBU1NFUlQoIW1fY29yZVdpbmRvdyB8fCAhbV9jb3JlVGFyZ2V0KTsKLQorICAgIEFT U0VSVChtX2NvcmVUYXJnZXQpOwogICAgIGdfb2JqZWN0X3dlYWtfcmVmKG9iamVjdCwgcmVpbnRl cnByZXRfY2FzdDxHV2Vha05vdGlmeT4oR09iamVjdEV2ZW50TGlzdGVuZXI6OmdvYmplY3REZXN0 cm95ZWRDYWxsYmFjayksIHRoaXMpOwogfQogCiBHT2JqZWN0RXZlbnRMaXN0ZW5lcjo6fkdPYmpl Y3RFdmVudExpc3RlbmVyKCkKIHsKLSAgICBpZiAoIW1fY29yZVdpbmRvdyAmJiAhbV9jb3JlVGFy Z2V0KQorICAgIGlmICghbV9jb3JlVGFyZ2V0KQogICAgICAgICByZXR1cm47CiAgICAgZ19vYmpl Y3Rfd2Vha191bnJlZihtX29iamVjdCwgcmVpbnRlcnByZXRfY2FzdDxHV2Vha05vdGlmeT4oR09i amVjdEV2ZW50TGlzdGVuZXI6OmdvYmplY3REZXN0cm95ZWRDYWxsYmFjayksIHRoaXMpOwogfQog CiB2b2lkIEdPYmplY3RFdmVudExpc3RlbmVyOjpnb2JqZWN0RGVzdHJveWVkKCkKIHsKLSAgICBB U1NFUlQoIW1fY29yZVdpbmRvdyB8fCAhbV9jb3JlVGFyZ2V0KTsKLQotICAgIC8vIFdlIG11c3Qg c2V0IG1fY29yZVdpbmRvdyBhbmQgbV9jb3JlVGFyZ2V0IHRvIG51bGwsIGJlY2F1c2UgcmVtb3Zl RXZlbnRMaXN0ZW5lciBtYXkgY2FsbCB0aGUKLSAgICAvLyBkZXN0cnVjdG9yIGFzIGEgc2lkZSBl ZmZlY3QgYW5kIHdlIG11c3QgYmUgaW4gdGhlIHByb3BlciBzdGF0ZSB0byBwcmV2ZW50IGdfb2Jq ZWN0X3dlYWtfdW5yZWYuCi0gICAgaWYgKERPTVdpbmRvdyogd2luZG93ID0gbV9jb3JlV2luZG93 KSB7Ci0gICAgICAgIG1fY29yZVdpbmRvdyA9IDA7Ci0gICAgICAgIHdpbmRvdy0+cmVtb3ZlRXZl bnRMaXN0ZW5lcihtX2RvbUV2ZW50TmFtZS5kYXRhKCksIHRoaXMsIG1fY2FwdHVyZSk7Ci0gICAg ICAgIHJldHVybjsKLSAgICB9CisgICAgQVNTRVJUKG1fY29yZVRhcmdldCk7CiAKKyAgICAvLyBX ZSBtdXN0IHNldCBtX2NvcmVUYXJnZXQgdG8gbnVsbCwgYmVjYXVzZSByZW1vdmVFdmVudExpc3Rl bmVyCisgICAgLy8gbWF5IGNhbGwgdGhlIGRlc3RydWN0b3IgYXMgYSBzaWRlIGVmZmVjdCBhbmQg d2UgbXVzdCBiZSBpbiB0aGUKKyAgICAvLyBwcm9wZXIgc3RhdGUgdG8gcHJldmVudCBnX29iamVj dF93ZWFrX3VucmVmLgogICAgIEV2ZW50VGFyZ2V0KiB0YXJnZXQgPSBtX2NvcmVUYXJnZXQ7Ci0g ICAgbV9jb3JlVGFyZ2V0ID0gMDsgLy8gU2VlIGFib3ZlLgorICAgIG1fY29yZVRhcmdldCA9IDA7 CiAgICAgdGFyZ2V0LT5yZW1vdmVFdmVudExpc3RlbmVyKG1fZG9tRXZlbnROYW1lLmRhdGEoKSwg dGhpcywgbV9jYXB0dXJlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5lci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5lci5oCmluZGV4IDk4YjgwOGQyODIwZDY1YTU3 OTRjYWQxM2I5NTRhMTkwZjM5NTVhNGYuLjZjODU3MDFjOGNjMGU5YjExNWViZWJhYWRlNzQxZWNi ZjFhZmM0YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvR09i amVjdEV2ZW50TGlzdGVuZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0 L0dPYmplY3RFdmVudExpc3RlbmVyLmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogIENvcHlyaWdo dCAoQykgMjAxMCBJZ2FsaWEgUy5MLgorICogIENvcHlyaWdodCAoQykgMjAxMCwgMjAxMSBJZ2Fs aWEgUy5MLgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiBy ZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0 aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtMTksNyArMTksNiBAQAogI2lmbmRlZiBH T2JqZWN0RXZlbnRMaXN0ZW5lcl9oCiAjZGVmaW5lIEdPYmplY3RFdmVudExpc3RlbmVyX2gKIAot I2luY2x1ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkV2ZW50TGlzdGVuZXIuaCIKICNpbmNs dWRlICJFdmVudFRhcmdldC5oIgogCkBAIC0zNCwyNyArMzMsMTUgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogY2xhc3MgR09iamVjdEV2ZW50TGlzdGVuZXIgOiBwdWJsaWMgRXZlbnRMaXN0ZW5lciB7 CiBwdWJsaWM6CiAKLSAgICBzdGF0aWMgYm9vbCBhZGRFdmVudExpc3RlbmVyKEdPYmplY3QqIG9i amVjdCwgRE9NV2luZG93KiB3aW5kb3csIGNvbnN0IGNoYXIqIGRvbUV2ZW50TmFtZSwgR0NhbGxi YWNrIGhhbmRsZXIsIGJvb2wgdXNlQ2FwdHVyZSwgdm9pZCogdXNlckRhdGEpCi0gICAgewotICAg ICAgICBSZWZQdHI8R09iamVjdEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyKGFkb3B0UmVmKG5ldyBH T2JqZWN0RXZlbnRMaXN0ZW5lcihvYmplY3QsIHdpbmRvdywgMCwgZG9tRXZlbnROYW1lLCBoYW5k bGVyLCB1c2VDYXB0dXJlLCB1c2VyRGF0YSkpKTsKLSAgICAgICAgcmV0dXJuIHdpbmRvdy0+YWRk RXZlbnRMaXN0ZW5lcihkb21FdmVudE5hbWUsIGxpc3RlbmVyLnJlbGVhc2UoKSwgdXNlQ2FwdHVy ZSk7Ci0gICAgfQotCiAgICAgc3RhdGljIGJvb2wgYWRkRXZlbnRMaXN0ZW5lcihHT2JqZWN0KiBv YmplY3QsIEV2ZW50VGFyZ2V0KiB0YXJnZXQsIGNvbnN0IGNoYXIqIGRvbUV2ZW50TmFtZSwgR0Nh bGxiYWNrIGhhbmRsZXIsIGJvb2wgdXNlQ2FwdHVyZSwgdm9pZCogdXNlckRhdGEpCiAgICAgewot ICAgICAgICBSZWZQdHI8R09iamVjdEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyKGFkb3B0UmVmKG5l dyBHT2JqZWN0RXZlbnRMaXN0ZW5lcihvYmplY3QsIDAsIHRhcmdldCwgZG9tRXZlbnROYW1lLCBo YW5kbGVyLCB1c2VDYXB0dXJlLCB1c2VyRGF0YSkpKTsKKyAgICAgICAgUmVmUHRyPEdPYmplY3RF dmVudExpc3RlbmVyPiBsaXN0ZW5lcihhZG9wdFJlZihuZXcgR09iamVjdEV2ZW50TGlzdGVuZXIo b2JqZWN0LCB0YXJnZXQsIGRvbUV2ZW50TmFtZSwgaGFuZGxlciwgdXNlQ2FwdHVyZSwgdXNlckRh dGEpKSk7CiAgICAgICAgIHJldHVybiB0YXJnZXQtPmFkZEV2ZW50TGlzdGVuZXIoZG9tRXZlbnRO YW1lLCBsaXN0ZW5lci5yZWxlYXNlKCksIHVzZUNhcHR1cmUpOwogICAgIH0KIAotICAgIHN0YXRp YyBib29sIHJlbW92ZUV2ZW50TGlzdGVuZXIoR09iamVjdCogb2JqZWN0LCBET01XaW5kb3cqIHdp bmRvdywgY29uc3QgY2hhciogZG9tRXZlbnROYW1lLCBHQ2FsbGJhY2sgaGFuZGxlciwgYm9vbCB1 c2VDYXB0dXJlKQotICAgIHsKLSAgICAgICAgR09iamVjdEV2ZW50TGlzdGVuZXIga2V5KG9iamVj dCwgd2luZG93LCAwLCBkb21FdmVudE5hbWUsIGhhbmRsZXIsIHVzZUNhcHR1cmUsIDApOwotICAg ICAgICByZXR1cm4gd2luZG93LT5yZW1vdmVFdmVudExpc3RlbmVyKGRvbUV2ZW50TmFtZSwgJmtl eSwgdXNlQ2FwdHVyZSk7Ci0gICAgfQotCiAgICAgc3RhdGljIGJvb2wgcmVtb3ZlRXZlbnRMaXN0 ZW5lcihHT2JqZWN0KiBvYmplY3QsIEV2ZW50VGFyZ2V0KiB0YXJnZXQsIGNvbnN0IGNoYXIqIGRv bUV2ZW50TmFtZSwgR0NhbGxiYWNrIGhhbmRsZXIsIGJvb2wgdXNlQ2FwdHVyZSkKICAgICB7Ci0g ICAgICAgIEdPYmplY3RFdmVudExpc3RlbmVyIGtleShvYmplY3QsIDAsIHRhcmdldCwgZG9tRXZl bnROYW1lLCBoYW5kbGVyLCB1c2VDYXB0dXJlLCAwKTsKKyAgICAgICAgR09iamVjdEV2ZW50TGlz dGVuZXIga2V5KG9iamVjdCwgdGFyZ2V0LCBkb21FdmVudE5hbWUsIGhhbmRsZXIsIHVzZUNhcHR1 cmUsIDApOwogICAgICAgICByZXR1cm4gdGFyZ2V0LT5yZW1vdmVFdmVudExpc3RlbmVyKGRvbUV2 ZW50TmFtZSwgJmtleSwgdXNlQ2FwdHVyZSk7CiAgICAgfQogCkBAIC03Myw3ICs2MCw3IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgb3BlcmF0b3I9PShjb25zdCBFdmVudExpc3RlbmVyJiBv dGhlcik7CiAKIHByaXZhdGU6Ci0gICAgR09iamVjdEV2ZW50TGlzdGVuZXIoR09iamVjdCosIERP TVdpbmRvdyosIEV2ZW50VGFyZ2V0KiwgY29uc3QgY2hhciogZG9tRXZlbnROYW1lLCBHQ2FsbGJh Y2sgaGFuZGxlciwgYm9vbCBjYXB0dXJlLCB2b2lkKiB1c2VyRGF0YSk7CisgICAgR09iamVjdEV2 ZW50TGlzdGVuZXIoR09iamVjdCosIEV2ZW50VGFyZ2V0KiwgY29uc3QgY2hhciogZG9tRXZlbnRO YW1lLCBHQ2FsbGJhY2sgaGFuZGxlciwgYm9vbCBjYXB0dXJlLCB2b2lkKiB1c2VyRGF0YSk7CiAg ICAgfkdPYmplY3RFdmVudExpc3RlbmVyKCk7CiAgICAgdm9pZCBnb2JqZWN0RGVzdHJveWVkKCk7 CiAKQEAgLTgxLDEwICs2OCw5IEBAIHByaXZhdGU6CiAKICAgICBHT2JqZWN0KiBtX29iamVjdDsK IAotICAgIC8vIFdlIGRvIG5vdCBuZWVkIHRvIGtlZXAgYSByZWZlcmVuY2UgdG8gdGhlc2UgV2Vi Q29yZSBvYmplY3RzLCBiZWNhdXNlCi0gICAgLy8gd2Ugb25seSB1c2UgdGhlbSB3aGVuIHRoZSBH T2JqZWN0IGFuZCB0aHVzIHRoZSBXZWJDb3JlIG9iamVjdCBpcyBhbGl2ZS4KKyAgICAvLyBXZSBk byBub3QgbmVlZCB0byBrZWVwIGEgcmVmZXJlbmNlIHRvIHRoZSBtX2NvcmVUYXJnZXQsIGJlY2F1 c2UKKyAgICAvLyB3ZSBvbmx5IHVzZSBpdCB3aGVuIHRoZSBHT2JqZWN0IGFuZCB0aHVzIHRoZSBt X2NvcmVUYXJnZXQgb2JqZWN0IGlzIGFsaXZlLgogICAgIEV2ZW50VGFyZ2V0KiBtX2NvcmVUYXJn ZXQ7Ci0gICAgRE9NV2luZG93KiBtX2NvcmVXaW5kb3c7CiAgICAgQ1N0cmluZyBtX2RvbUV2ZW50 TmFtZTsKICAgICBHQ2FsbGJhY2sgbV9oYW5kbGVyOwogICAgIGJvb2wgbV9jYXB0dXJlOwo=