56688 2011-03-18 15:09:25 -0700 Fix clang static analyzer warning in WebCoreViewFactory.m 2011-03-18 20:59:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer andersca oldest_to_newest 369935 0 86220 ddkilzer 2011-03-18 15:09:25 -0700 Created attachment 86220 Patch Reviewed by NOBODY (OOPS!). Fixes the following static analyzer warning: Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]' return self; ^ * page/mac/WebCoreViewFactory.m: (-[WebCoreViewFactory init]): Assign the result of [super init] to self. --- 2 files changed, 17 insertions(+), 1 deletions(-) 370090 1 ddkilzer 2011-03-18 20:59:23 -0700 Committed r81546: <http://trac.webkit.org/changeset/81546> 86220 2011-03-18 15:09:25 -0700 2011-03-18 15:32:07 -0700 Patch 20110318150924.patch text/plain 1416 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODEzODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZDNlOGE2NDAzY2I1OGUx NDgxMGE3OThlOTQ0MTQ4YTJkODMxZWEyLi5kMWNlMDczNzlkNGU1MWFlMThmNWY0ZjgwNjgyNWY0 ZWRiYjFkMWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMTggIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY2xhbmcgc3RhdGlj IGFuYWx5emVyIHdhcm5pbmcgaW4gV2ViQ29yZVZpZXdGYWN0b3J5Lm0KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0aGUgZm9sbG93aW5nIHN0 YXRpYyBhbmFseXplciB3YXJuaW5nOgorCisgICAgICAgICAgICBTb3VyY2UvV2ViQ29yZS9wYWdl L21hYy9XZWJDb3JlVmlld0ZhY3RvcnkubTo0NTo1OiB3YXJuaW5nOiBSZXR1cm5pbmcgJ3NlbGYn IHdoaWxlIGl0IGlzIG5vdCBzZXQgdG8gdGhlIHJlc3VsdCBvZiAnWyhzdXBlciBvciBzZWxmKSBp bml0Li4uXScKKyAgICAgICAgICAgICAgICAgcmV0dXJuIHNlbGY7CisgICAgICAgICAgICAgICAg IF4KKworICAgICAgICAqIHBhZ2UvbWFjL1dlYkNvcmVWaWV3RmFjdG9yeS5tOgorICAgICAgICAo LVtXZWJDb3JlVmlld0ZhY3RvcnkgaW5pdF0pOiBBc3NpZ24gdGhlIHJlc3VsdCBvZiBbc3VwZXIg aW5pdF0KKyAgICAgICAgdG8gc2VsZi4KKwogMjAxMS0wMy0xNyAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbiBhbmQg RW5yaWNhIENhc3VjY2kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9XZWJD b3JlVmlld0ZhY3RvcnkubSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1dlYkNvcmVWaWV3RmFj dG9yeS5tCmluZGV4IDUzOTg5ODk2NTI3MjdiZGE5ZTJhMmRlN2M5OTM0OTY1YzQ1MTllNDQuLjE3 YTdhMjk0NmRhZTIzOTY1YjYxMWE3Mjc3NGM1NjI4NTcwNWI0ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvbWFjL1dlYkNvcmVWaWV3RmFjdG9yeS5tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvbWFjL1dlYkNvcmVWaWV3RmFjdG9yeS5tCkBAIC0zNyw3ICszNyw3IEBAICsgKFdl YkNvcmVWaWV3RmFjdG9yeSAqKXNoYXJlZEZhY3RvcnkKIAogLSBpbml0CiB7Ci0gICAgW3N1cGVy IGluaXRdOworICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07CiAgICAgCiAgICAgQVNTRVJUKCFzaGFy ZWRGYWN0b3J5KTsKICAgICBzaGFyZWRGYWN0b3J5ID0gW3NlbGYgcmV0YWluXTsK